Commit Graph

1840 Commits

Author SHA1 Message Date
vocx-fc
d38390db1e Draft: update unit test for new gui_trackers module 2020-03-23 12:14:33 +01:00
vocx-fc
478510d20e Draft: Snapper class with new gui_trackers module
Also change the imports in `DraftFillet.py`
and `DraftEdit.py` so the trackers are found.
2020-03-23 12:14:33 +01:00
vocx-fc
419431559a Draft: move DraftTrackers to another module.
Properly import the tracker classes. Avoid star imports,
and use the classes prefixed with the name of the module.
The BIM Workbench also has to be updated to use the new
module.
```
import draftguitools.gui_trackers as DraftTrackers
```
2020-03-23 12:14:33 +01:00
vocx-fc
6a92cb968d Draft: update unit test for gui_snapper 2020-03-20 08:11:04 -03:00
vocx-fc
580270ce4a Draft: move DraftSnap to another module
And do not load the `Snapper` in `DraftGui`.
The Snapper should be initialized by the module
that imports `DraftGui`, most probably `DraftTools`
or even by the `InitGui` of the workbench.
2020-03-20 08:11:04 -03:00
vocx-fc
6b87a416fd Draft: properly import the Snapper class
Avoid star imports, and prepend the module name,
`DraftSnap.Snapper()`.
2020-03-20 08:11:04 -03:00
vocx-fc
3ac2e079bc Draft: move snap commands to an individual module
This way we remove lines from `DraftTools.py`
and we can more easily identify where the snapping
commands are defined.
2020-03-20 08:11:04 -03:00
UR-0
03b652930c DRAFT: import DXF version R12 minimalistic file with legacy importer 2020-03-19 12:21:39 -03:00
vocx-fc
f73de9912c Draft, Arch: coding conventions for the workbench 2020-03-19 12:20:03 -03:00
vocx-fc
e836811e3c Draft: improve the README files with links 2020-03-19 12:11:16 -03:00
vocx-fc
33092ce82c Draft: recompute before using radial dimension in the unit test
This solves a small bug in the radial dimension
unit test introduced in 7917b82c09, where a circle shape
is used before it is recomputed.

```
drafttests/test_creation.DraftCreation.test_dimension_radial
```
2020-03-19 12:10:56 -03:00
triplus
946fd7352b Draft - enable toggle grid command in edit mode
Some people would like to have more control over draft grid visibility  while in Sketcher edit mode.  Hence this PR enables the usage of Draft ToggleGrid  command in Sketcher edit mode.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=34&t=43265&start=20#p374747
2020-03-12 09:26:48 -03:00
vocx-fc
81d7267e72 Draft: add new viewprovider icon for radius dimension
If it is a linear dimension show the older icon;
if it is a radius or diameter dimension show a new icon.

These three modes use the same Proxy class
and the same viewprovider class. Depending on the linked geometry
one icon or the other will be shown.
2020-03-12 09:12:11 -03:00
vocx-fc
dce7f63c02 Draft: add new viewprovider icons for specific objects
When there are many Draft objects in the tree view
the icon can be used to tell different objects apart quickly.
One icon is used for objects that are "straight lines",
whose Proxy is of type `Line`, `Wire` or `Polyline`; another icon
for "regular geometrical" shapes of type `Rectangle` or `Polygon`;
and another icon for "curved" objects of type `Circle`,
`Ellipse`, `BSpline`, `BezCurve`, or `Fillet`.

Other objects use the older default icon.
2020-03-12 09:12:11 -03:00
carlopav
8f2cd4526e [Draft] Remove AddPoint and DelPoint commands from UI
[Draft] Edit: Remove Bezcurve interface from Edit Ui


[Draft] Edit: cleanup


small improvement to tooltip
2020-03-12 09:11:34 -03:00
carlopav
6d2c8b5df3 [Draft] Uniform length and xyz inputfield behaviour
Single returnPressed to accept point if cursor is parallel to xyz axis for bot setfocus on x and on length inputfields.
[Draft] Edit_updated tooltip


[Draft] DraftGui Further cleanup and bugfix
2020-03-12 09:11:34 -03:00
carlopav
4396b40fec [Draft] DraftGui and DraftEdit Cleanup to remove AddPoint & DelPoint
Lines to be deleted in DraftGui in the future, are now commented.
2020-03-12 09:11:34 -03:00
carlopav
786eac8c01 [Draft] DraftGui Bugfix on selecting inputfields
https://forum.freecadweb.org/viewtopic.php?f=23&t=43145&p=367517#p367517
2020-03-12 09:11:34 -03:00
vocx-fc
7a622e7021 Draft: implement unit test for angular dimension
Previously the `makeAngularDimension` function produced
error messages in the report view due to internal rounding
of `App::PropertyAngles`.
This was fixed in `Base::Quantity`, which now supports
Python's `__round__` function.
2020-03-12 09:06:11 -03:00
vocx-fc
07a0bdcabe Draft: implement unit test for radial dimension 2020-03-12 09:06:11 -03:00
vocx-fc
8c08fb27fb Draft: cleanup of unit tests code 2020-03-12 09:06:11 -03:00
vocx-fc
9c6162f88c Draft: unit test for arc by 3 points 2020-03-12 09:06:11 -03:00
vocx-fc
85bce262b4 Draft: add script to produce a test file as example
The test script can be run by the program's executable
or run as a macro.
```
freecad draft_test_objects.py
```

It can also be used as a Python module within the program
to create a test file on demand.
```
import drafttests.draft_test_objects as dt
dt.create_test_file()
```

The produced test file will be added in a different commit
once this commit is merged.
The idea is to have a test file created by a certain
stable version of the master branch. Then as the code
continues to change and grow, this file can be opened
with future versions of the program to test for compatibility
and regressions.
2020-03-12 09:06:11 -03:00
Syres916
eebb73cfd2 [Draft] Orthoarray Task Panel Fix Z interval 2020-03-06 18:05:14 -03:00
luz.paz
c8cb520887 [skip ci] fix follow-up typos 2020-03-06 14:50:35 +01:00
luz.paz
ebe194a9e9 Fix typos
Found via  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
Yorik van Havre
8933e8ed38 Merged latest translations from crowdin 2020-03-05 11:58:03 -03:00
vocx-fc
9d887131af Draft: Draft_Arc_3Points using the new arc function
Instead of creating the arc directly in the GuiCommand
it calls the new `make_arc_3point` function.
2020-03-05 09:03:02 -03:00
vocx-fc
da7e484c30 Draft: arc by 3 points function
Previously, the arc was entirely created in the GuiCommand
definition. The code to create only the arc is placed inside
a module so that the function can be used in scripting
from the terminal, without a graphical interface.
2020-03-05 09:03:02 -03:00
vocx-fc
b25ca7194c Draft: lowercase use_link option for arrays
Inside the class `_DraftLink` the `onDocumentRestored` function
tests for the existence of the old attribute `useLink`. If it is
present, it uses it to define the new variable name `use_link`.
This is done use Python naming conventions.
The old `useLink` is deleted so it is not longer saved
together with the object when the document is saved.
2020-03-04 09:58:56 -03:00
carlopav
cfb176e08c [Draft] Edit bugfix: closed wire check for point lying in the face plane
https://forum.freecadweb.org/viewtopic.php?f=23&t=43414&p=372524#p372524
2020-03-03 21:27:31 +01:00
vocx-fc
549ca9205b Draft: new Draft_OrthoArray command
It replaces the older `Draft_Array` command, and provides
a task panel to select the properties, similar to the
`Draft_PolarArray` and `Draft_CircularArray` commands.

It can also create `App::Links` directly from this task
panel, so it also replaces the `Draft_LinkArray`
introduced by the LinkMerge.
2020-03-03 21:27:31 +01:00
Syres916
3ae13a012a [Draft] Change boolean If statement 2020-03-02 12:08:53 -03:00
Syres916
e26f306895 [Draft] WireToBSpline Fix makeWire Placement
See discussion https://forum.freecadweb.org/viewtopic.php?f=23&t=43184
2020-03-02 12:08:53 -03:00
Syres916
4242afb8b4 [Draft] WireToBSpline Fix Placement of makeWire
See Discussion https://forum.freecadweb.org/viewtopic.php?f=23&t=43184
2020-03-02 12:08:53 -03:00
vocx-fc
624139743f Draft: upgrade patterns to PlainSVG and 96dpi 2020-03-02 11:50:49 -03:00
vocx-fc
8334c5659e Draft: ugrade icons to PlainSVG and 96dpi 2020-03-02 11:50:49 -03:00
vocx-fc
9667bb957a Draft: translate functions with the context set to Draft 2020-03-02 11:45:27 -03:00
vocx-fc
adfc58580d Draft, Arch: group the array tools 2020-03-02 11:41:22 -03:00
vocx-fc
b6791b5571 Draft: angle dimension icon saved as plain SVG
As discussed in the previous request, the icon
is saved as Plain SVG, meaning that Inkscape-specific tags
are removed. This is better for compatibility purposes
for use with other SVG editors and viewers.
2020-02-15 19:33:23 +01:00
vocx-fc
4c8bef7c91 Draft: new view provider icon for the angle dimension
The linear and radial dimensions use the same Proxy class,
but the angular dimension uses a different Proxy class.
To recognize quickly in the tree view the different
types of dimensions, we provide a new icon.

The icon is inspired on the `Draft_Dimension.svg` and
`TechDraw_AngleDimensions.svg` icons.
2020-02-15 13:07:38 +01:00
paullee0
f77a6949c9 [ArchWall, DraftGeomUtils] fix bug: ArchWall with Offset Attribute set and based on Sketch fails at some cases
DraftGeomUtils.offsetWire() supports ArchWall Offset setting inherently now.

Discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=42933
2020-02-10 11:19:47 +01:00
carlopav
b44031df60 [Draft] Move and rotate bugfix to handle App::DocumentGroup
Bugfix, ref https://forum.freecadweb.org/viewtopic.php?f=23&t=43061
2020-02-10 11:16:34 +01:00
vocx-fc
6a66044c21 Draft: override text in dimension only when GUI is up 2020-02-10 11:14:01 +01:00
vocx-fc
107a945ccc Draft: standardized module to build messages 2020-02-10 11:12:45 +01:00
vocx-fc
fd533c74ba Draft: disable the excessive output in the ToDo class 2020-02-10 11:09:10 +01:00
vocx-fc
ccebb92258 Draft: added init_tools to create the toolbars 2020-02-10 11:02:28 +01:00
vocx-fc
a083fea057 Draft: explicitly import modules in the initialization
Also other small fixes: cleanup for getting the icon
of the workbench; we don't need to test for PySide because
it should already exist as part of the system
for the entire interface to work; cleanup of the printing
functions.
2020-02-10 11:02:28 +01:00
donovaly
24ec114cb8 remove program-specific SVG namespaces
while fixing a SVG export issue for techDraw I noticed that some SVG files have program-dependent (and thus not clean) code in it. These are traces of the programs Sodipodi and Inkscape, like e.g. this line:
inkscape:export-filename="/home/yorik/PartDesign_Groove.png

This is unnecessary and FC should not use program-dependent code in the SVG but use instead plain SVG strictly following the SVG specification.

This PR transforms the few affected SVGs to a plain version.
2020-02-07 07:34:49 -05:00
vocx-fc
5e253f6310 Draft: add README files to explain the new structure 2020-02-05 10:59:28 +01:00