Commit Graph

38 Commits

Author SHA1 Message Date
Russell Johnson
4c1951aedc Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
luz paz
60c055e62d Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
Russell Johnson
cf23bc6892 Path: Implement backwards compatibility
Source modules are replaced with pass-through code to send pre-existing profile-based operations to new unified `Profile` operation.
Path: Set line endings to Unix style
2020-05-10 18:19:42 -05:00
Russell Johnson
27c4db9a34 Path: Consolidate Contour, ProfileFaces, and ProfileEdges
No geometry selection defaults to Contour operation.
Path: Add new unified `Profile` operation modules
2020-05-10 18:19:42 -05:00
Russell Johnson
c5e577be89 Path: Initiate unification of ProfileFaces and ProfileEdges operations
ProfileFaces now accepts and processes faces and edges.
Full functionality is maintained (so far as tested) with respect to original operations.
2020-05-10 18:19:42 -05:00
Eric Trombly
24e681c63b add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
Russell Johnson
b05361a163 Path: Apply rotation improvement to B(y) rotations 2020-03-26 10:43:32 -05:00
Russell Johnson
988038c5d2 Path: Remove unnecessary comments
PathAreaOp
PathProfileFaces
2020-03-26 10:43:32 -05:00
Russell Johnson
4145e287c0 Path: Improve 4th-axis rotation analysis and application
Fix incorrect depth calculations for envelopes.
Added solid-based model orientation check developed in PathProfileEdges open edges upgrade.
Clean-up some blank indentations.
Down-grade some messaging levels.
Add a few debug comments.
2020-03-26 10:43:32 -05:00
Russell Johnson
2dc4496e9a Fix failed Job creation due EnableRotation property error
PathAreaOp:   Add SetupProperties() function
PathPocketBase:   Modify SetupProperties() function to include return from same in PathAreaOp.
PathPocketShape:  remove blank indents
PathProfileBase:  Modify SetupProperties() function to include return from same in PathAreaOp.
PathProfileFaces:  fix `EnableRotation` issue
2020-03-21 11:05:46 -05:00
Patrick Felixberger
61d578bb61 Code clean up 2020-03-16 18:30:30 +01:00
Russell Johnson
8e9d704556 4th-axis fixes and improvements
Fix rotational orientation of pockets.  Need to apply same fix to ProfileFaces.
Fix final depth issue based upon error in rotational orientation fixed here.
Add property, `LimitDepthToFace` to facilitate easier pockets and face profiling on rotational-enabled operations.
Hide rotational support properties when operations do not use rotation.
Remove unnecessary property, `B_AxisErrorOverride`, and delete dead code that used it.
2020-03-14 11:36:21 -05:00
Patrick Felixberger
a08ca59766 Fixed broken final depth calculation for rotational axis in pocket, profile and drill; Added EnableRotation to GUI; Fix some weird gcode generation 2020-03-11 21:16:21 +01:00
Markus Lampert
81bbb0066d Removed dead code for debugging shortcut warnings. 2020-01-03 23:13:55 -08:00
Russell Johnson
940f3b300a ProfileFaces: fix "HandleMultipleFeatures" set to individually
Summary condition produced error and no paths; corrected subshape passed to getEnvelope().
Removed unnecessary comments.
Simplified debug level setting.
2019-07-25 14:54:22 -05:00
Markus Lampert
7b7c27ed9b Addressed pylint warnings for PathProfileFaces 2019-07-01 15:32:54 -07:00
Markus Lampert
0a900b3276 addressing pylint warnings for PathProfile family 2019-07-01 15:32:54 -07:00
Russell Johnson
dd6a6597e9 ProfileFaces: Fix obj.processPerimeter feature (#2306)
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368
if obj.processPerimeter: `else` block re-configured to read new property, `HandleMultipleFeatures`
Removed some excess comments
2019-06-30 09:31:30 -05:00
sliptonic
617c619d2f remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
Russell Johnson
37336d5701 Fix functionality of manual override of Final Depth
manual Final Depth settings were limited to values greater than the base face for the Op. Manual settings of Final Depth may now proceed below the face (Outside profile ops)
2019-06-20 00:02:14 -05:00
sliptonic
082c1e71f1 Path: PEP8 and Proxy changes. 2019-06-17 09:17:38 -05:00
Russell Johnson
183228cc25 Misc. fixes
Clean up code, improve comments, improve user feedback.
Improve temp clone management.
Correct depth issue with self.finDep
Add comment descriptions for new methods
Clean up comments and contribution information
Initiate recognition of type()==SurfaceOfExtrusion
Adopt standard PathGeom.isRoughly() and .Tolerance rather than idependent precision settings
2019-06-13 10:55:32 -05:00
Russell Johnson
73e00617d1 Fixes for depths and AttemptInverseAngle
Depth correction to obj.FinalDepth.Value in single feature operations
Fix AttemptInverseAngle to be uni-directional
Clean up debug and other user provided feedback
2019-06-13 10:55:31 -05:00
Russell Johnson
a7202f151f Improve code structure; correct 4th-axis depth issues 2019-06-13 10:55:30 -05:00
Russell Johnson
1f3b3ad4e4 Integration of 4th-axis feature to PathProfileFaces
4th-axis integration should not affect current feature set
2019-06-13 10:55:29 -05:00
luz.paz
ec12ffae0c Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
Markus Lampert
5acf7c771f Fixed ProfileFaces for multiple base models. 2018-09-11 07:24:39 +02:00
Markus Lampert
0b1ae8c5e5 Fixed merge issues 2018-09-11 07:24:35 +02:00
Markus Lampert
256d42e2de Fixed unit tests to support multiple base models. 2018-09-11 07:24:31 +02:00
Markus Lampert
4dcf6b88a3 Added operation setting support to profile ops. 2018-09-02 00:32:22 -07:00
Markus Lampert
353ec4a646 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
9cd8ac46f7 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
Markus Lampert
e2824a777a Fixed retraction of tool when profiling multiple holes. 2017-08-22 10:16:58 -03:00
Markus Lampert
684b4f6e7e Added doc strings to operations. 2017-08-22 10:16:58 -03:00
Markus Lampert
62c9bcc39a Added support for baseobject into PathOp, used by almost all ops anyway. 2017-08-22 10:16:58 -03:00
Markus Lampert
f4c20e7c61 Moved base functionality into PathOp and renamed AreaOp interface to areaOp... 2017-08-22 10:16:58 -03:00
Markus Lampert
54ca9a446d Extracted common profile functionality into base class. 2017-08-22 10:16:57 -03:00
Markus Lampert
6f334e84a5 Renamed PathProfile to PathProfileFaces for consistency; moved common depth calculation for ops with BaseGeometry into PathAreaOp. 2017-08-22 10:16:57 -03:00