Commit Graph

136 Commits

Author SHA1 Message Date
Benjamin Nauck
d525b29fa5 [Spreadsheet] Remove alias from dynamic properties on removeRows/Columns
When removing a row in a spreadsheet which has an assigned alias, the
alias will not be removed from the list of dynamic properties.

This makes it impossible to create a new alias which uses the same name
even if the original was removed (using removeRows/removeColumns)

Fixes #4492
2021-01-04 22:10:58 +01:00
luz paz
5bd5f3a963 Spreadsheet: Fix header uniformity + trailing whitespace
[skip ci]
2020-11-27 19:39:06 +01:00
luz paz
44636aca2f Spreadsheet: Make all file headers uniform [skip-ci] 2020-11-03 14:52:53 +01:00
Cheuksan Wang
0aa759b5c5 Move the aliases before other content of cells
When a user performs insert rows, remove rows, insert columns, or
remove rows, we need to move multiple cells as a batch. The cells are
moved sequentially. For each cell, its dependent alias positions are
looked up and dependencies are added.  However, those cells with
aliases may be moved later in the batch. Thus the earlier dependencies
become wrong. This commit fixes this bug by moving all the aliases
before moving the cells. Unit tests are added to for this bug.

fixes issue #4429
2020-09-13 11:58:54 +02:00
wmayer
dff82ea08a PVS: V506 Pointer to local variable '_value' is stored outside the scope of this variable. Such a pointer will become invalid. 2020-07-18 10:59:28 +02:00
wmayer
811efa6107 PVS: V690 The copy constructor is declared as private in the 'PropertySheet' class, but the default copy assignment operator will still be generated by compiler. It is dangerous to use such a class. 2020-07-18 10:59:28 +02:00
wmayer
f3b460e42e boost: fix for boost < 1.60 2020-06-15 19:38:39 +02:00
wmayer
4ec45b545e boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated 2020-06-12 17:51:33 +02:00
wmayer
5e9869aaef Spreadsheet: [skip ci] add generated Imp files to repository to avoid possible build failures 2020-04-16 12:24:38 +02:00
luz.paz
2ed5786d07 [skip-ci] Various typo fixes
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-07 18:17:03 +02:00
wmayer
ec8b1bc072 [skip ci] use QLocale class consistently to make it possible to change it application-wide 2020-03-26 16:37:45 +01:00
wmayer
7fe10182a9 [skip ci] fix header uniformity
Set a real email address for headers in inspection and surface module
2019-12-21 16:12:54 +01:00
luz.paz
1bc33025d6 LGTM: various fixes for using string operator instead of numeric 2019-10-25 10:33:12 -03:00
Zheng, Lei
41387fd991 App: fix dynamic property undo/redo
Instead of enforce property type match when undo/redo, modify various
property Paste() to make it type safe.
2019-10-07 17:24:31 +02:00
Zheng, Lei
976952db63 Spreadsheet: improve cyclic dependency exception handling 2019-10-07 17:24:30 +02:00
wandererfan
bed78b0b7b [SS]Fix Integer Formatted Value 2019-10-01 20:34:11 -04:00
Zheng, Lei
a1417c5ffa App: extend Expression syntax
* Support sub-object reference syntax using the following syntax,
    Part.<<Box.>>.Placement
  or, with sub-object label referencing
    Part.<<$Cube.>>.Placement

* Extend indexing support, including range based indexing, e.g.
    A1[B2+1][C3][D4:-1]

* Add new constants, None, True, true, False, false.
2019-09-28 15:31:24 +02:00
Zheng, Lei
ea7eee8061 Expression: split Expression.h to ExpressionParser.h
Split Expression details into a separate header to reduce recompilation
time on changes.
2019-09-28 15:30:41 +02:00
Zheng, Lei
d141975701 App: use Python number protocol in Expression
This adds support to do mul/div with matrix and vector, as well as
Python formated string with operator %.
2019-09-28 15:30:34 +02:00
wandererfan
019198a30c [TD][SS]Fix 4131 SS formatting in TD View 2019-09-20 12:56:26 -04:00
wmayer
a247b7e6a5 force strict ISO C++ (-Wpedantic)
for Drawing, Image, Inspection, Mesh, MeshPart, Part, Path, Points, Raytracing, ReverseEngineering, Spreadsheet, Start, Surface, Web

TODO: fix several -Woverflow in area
2019-09-18 11:32:42 +02:00
wmayer
3759b83b7c Fix clang compiler warnings:
+ fix -Winconsistent-missing-override
2019-08-17 19:53:21 +02:00
luz.paz
039d6eac01 Fix typos in various src/Mod directories 2019-08-17 15:32:49 +02:00
Zheng, Lei
e911b69769 Spreadsheet changes
Various changes to support in-place editing, and more.
2019-08-17 15:15:47 +02:00
Zheng, Lei
34ed8a8e00 Spreadsheet: convert PropertySheet to link type property
PropertySheet is changed to derive from PropertyExpressionContainer,
which makes it a link type property that is capable of external linking.
It now relies on the unified link property API to manage object
depenency, and tracking of object life time, relabeling, etc.

This patch also includes various fix and improvement of Spreadsheet,
such as improved recompute efficiency, correct handling of document
label change, etc.
2019-08-17 14:52:09 +02:00
luz.paz
9453e68e23 Misc. source comment typo and whitespace fixes
Found via codespell
2019-06-16 20:47:07 +02:00
DeepSOIC
28cbe2bd89 Spreadsheet: fix #3474 cross-CS drag-drop issue 2019-01-20 00:45:49 +01:00
wmayer
c9b4f4ba67 fix possible crash in PropertySheet when removing dependencies 2019-01-17 18:33:06 +01:00
wmayer
fc16bcbfca Replace Base::Exception with appropriate subclass 2018-11-14 18:02:49 +01:00
wmayer
f898eafd64 move from deprecated boost.signals to boost.signals2 library 2018-10-30 19:09:03 +01:00
wmayer
7b86681678 fixes 0003638: Importing CSV-files produces an empty spreadsheet without the data 2018-10-18 23:32:32 +02:00
wmayer
c6745d1b5b fixes 0003610: App::PropertyFloatList not updating in Spreadsheet 2018-10-13 14:02:03 +02:00
wmayer
a2d44d2642 fixes 0003521: Import of csv file into Spreadsheet does not work if the path contains non ASCII characters 2018-09-24 22:16:48 +02:00
luz.paz
b214f606c4 Misc. typo and whitespace fixes
ref: https://forum.freecadweb.org/viewtopic.php?f=3&t=30988#p256964
along with other misc. fixes
2018-09-19 17:26:03 +02:00
wmayer
0b86312714 CMP0050: make Spreadsheet module aware of cmake policy 2018-08-20 15:14:05 +02:00
Markus Lampert
0b40519f3f Changed all catch types to references for polymorphic exceptions. 2018-08-08 15:45:30 +02:00
Eivind Kvedalen
5d2a889a80 Fixed issue #3506: Certain alias names with a number at the end caused exceptions when deleting cells in a spreadsheet. 2018-08-01 19:23:16 -03:00
Eivind Kvedalen
d2f9ab6a11 Spreadsheet: Fixed issue #3361. 2018-07-31 16:11:37 -03:00
Eivind Kvedalen
13da3dd830 Revert "fixes #0003361: Spreadsheet: Inserting Row Cause Crash - FC Daily v0.17"
This reverts commit f485a0786f.
2018-07-31 16:11:37 -03:00
luz.paz
7a09a5774e More misc. typos 2018-05-19 12:17:52 -04:00
luz.paz
0dead11c3e Spreadsheet: typo fixes 2018-04-30 08:30:20 +02:00
looooo
1f121a17c4 py3: Spreadsheet use Unicode instead of bytes 2018-04-22 07:53:20 +02:00
wmayer
f485a0786f fixes #0003361: Spreadsheet: Inserting Row Cause Crash - FC Daily v0.17 2018-03-25 13:39:21 +02:00
luz.paz
a35dd3feea Typos
The stepcode typos aren't to be found upstream. Recomend we merge nonetheless.
2018-01-08 21:07:00 +01:00
Eivind Kvedalen
5fe7a9af71 Spreadsheet: Fix for issue #3225.
Done by adding a selector function to Document::renameObjectIdentifiers(...) to ensure
that the Spreadsheet document object is not rewritten twice.
2017-11-08 23:15:16 +01:00
luzpaz
ab8f8919b6 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
wmayer
a5bc70cca0 remove properties from transactions when being deleted 2017-08-28 21:20:17 +02:00
Eivind Kvedalen
338ca55622 Spreadsheet: Fixed issue #2894: Unit strings could be used as aliases. 2017-03-07 13:45:53 -03:00
hgutsche
942d30c057 Address is actually spelled with two "d" 2017-02-28 18:52:04 +01:00
hgutsche
63ccfdde82 fix typo and and add explanation for a cell address 2017-02-28 18:52:04 +01:00