Commit Graph

102 Commits

Author SHA1 Message Date
luzpaz
d5a313146f Fix various whitespace issues 2023-03-20 16:38:40 +01:00
Uwe
9007723331 [FEM] rewrite initial velocity constraint
- same as #8963 but for initial velocity

- add an example file that demonstrates the influence of the initial velocity
- some fine-tuning for the existing flow example
2023-03-20 04:58:24 +01:00
Uwe
06061e37dc [FEM] rewrite velocity constraint
- complete revision of the constraint.

This is a breaking change, meaning existing constraints won't work.

This is possible because since 2 days ago the whole flow equation did not work at all. Also the existing constraint implementation if buggy and cannot be used to do the Elmer tutorial. Also, the constraint is only used by Elmer and only be the flow equation.

Since nobody complained about the obvious wrong results, we can assume the flow equation was not yet in practical usage (and for FC 0.20 we known that it does not work at all, first with FC 0.20.1).

It is necessary since it must be possible to either input a velocity or an equation. With an equation, a velocity profile can be specified.

- update the flow examples accordingly:
-- simplify them since an initial and and output velocity is not necessary to specify
-- use a formula as input velocity for the non-turbulent example
2023-03-20 01:57:09 +01:00
Uwe
0e108cba4f [FEM] use unique result mesh name
- it is a long-standing bug that the name of the result mesh object is not unique. For example for a frequency analysis you get for every result the same object "ResultMesh". When now a "ResultMesh" object is deleted because one result mode object should be deleted, all result modes loose their mesh.
To fix this, use a unique name for the mesh object.
2023-03-16 06:19:10 +01:00
Uwe
4ecf74322c [FEM] better pipeline connection for CalculiX
- make the connection also working for frequency and buckling analysis by directly creating/updating the pipeline where the CalculiX results are loaded
2023-03-16 06:12:14 +01:00
Uwe
c8305549e2 [FEM] [skip ci] fix typos
- spot by the CI
2023-02-23 12:40:32 +01:00
Uwe
21369f227f [FEM] fix annoying material selection bug
- for some materials, just opening the material dialog and pressing OK to close it without any change resulted in a transient material
- for other materials this happened by clicking in the material dialog on a value to edit it, but not changing anything and press OK

The fix is to compare the items item by item and also handle the case that only digits of numbers are different
2023-02-23 03:23:12 +01:00
Uwe
9e380a5bf6 [FEM] fix material initialization
- on creating a new material object, don't pollute the console wit wrong error messages (if no material is yet selected, of course nothing can be found)
- fix that for anew fluid materials the material editor was started with solid materials
2023-02-22 05:43:57 +01:00
Uwe
b31d9d1e34 [FEM] fix material handling of fluids
- the material editor failed for Fluid materials because this info was not passed to it. Instead always solid materials were loaded.

- also fix warning about too long variable name and remove unnecessary debug code
2023-02-19 02:57:12 +01:00
Uwe
de95a22eae [FEM] connect CCX solver to results pipeline
- it was often criticized that our default solver CCX is not connected to the results pipeline system. One had to connect it manually, the create the different filter etc. but as soon as one changed a constraint and re-run the solver the whole work was gone and one had to recreate the pipeline.
This PR solves this by creating a pipeline and by reloading new results to it on a solver re-run.
The CCX results dialog feature is not touched, since the pipeline is hidden when the dialog is active.
2023-02-18 04:05:05 +01:00
Uwe
eecf57ffe9 [FEM] improve messages in mesh generation
- no longer output an error on mesh from a BooleanFragments. There are cases when this fails, but other cases where one must use a BoopleanFragments compound and this works well, see https://forum.freecad.org/viewtopic.php?t=71070. Therefore a warning is sufficient.
- disable log messages not important for the average users.
- avoid code duplication
2023-02-13 16:55:00 +01:00
Uwe
ee4beba619 [FEM] fix bug in potential constraint task panel
- fix logic of a checkbox
2023-02-11 04:41:15 +01:00
Uwe
aca9e15f66 [FEM] extend current density to 3D
- to be used for magnetodynamic 3D equation
2023-02-10 01:30:14 +01:00
Uwe
04f0b66ef7 [FEM] use magnetization constraint for 2D
- uses the constraint for 2D magnetodynamics to perform e.g. Elmer's tutorial non. 15

- modify the Material manager to get rid of magnetization but keep the vectorial functionality because in future there will be support for e.g. birefringence materials etc.
2023-02-09 15:43:42 +01:00
Uwe
04915b694b [FEM] add new constraint for magnetization 2023-02-09 14:41:25 +01:00
Uwe
ddfdce612e [FEM] Elmer: extent potential constraint
- it is now possible to specify a an electric potential vector field
2023-02-08 07:02:35 +01:00
Uwe
82b6e03625 [FEM] add current density constraint
- also add corresponding App::PropertyCurrentDensity

- also fix a typo in test_object.py
2023-02-05 21:10:15 +01:00
Uwe
baf294a5a6 [FEM] initial pressure: bind expression to QuantitySpinBox 2022-08-15 11:54:33 +02:00
Uwe
040f86c4d5 [FEM] fix body heat source constraint
- as the name implies, it must be possible to set the heat to different bodies
- for this a selection dialog is necessary
- check that heat is not zero
2022-08-15 02:47:01 +02:00
Uwe
9b56412856 [FEM] potential constraint: allow to set expression for value 2022-08-15 01:33:35 +02:00
Uwe
27f50ad131 [FEM] add initial pressure constraint (#7364)
* [FEM] add initial pressure constraint

- this is needed for fluids
2022-08-14 20:00:36 +02:00
Uwe
335196a468 [FEM] [skip CI] remove an obsolete comment
- since a while there is no green hook but a QuantitySpinBox
2022-08-14 05:46:17 +02:00
Uwe
dd370b9643 [FEM] Elmer: fix initial flow velocity
- we must allow must be several velocities because there can be several fluid bodies
- don't output flow velocity for solid bodies
2022-08-14 04:39:43 +02:00
Uwe
4b2a486d51 [FEM] fix selection issues with flow velocity constraint
- same fix as commit 7e071623 for flow velocity constraint
- the used selection widget did not highlight the selected faces. This made it very hard to work with when one has an existing document where e.g. 5 faces have a certain velocity and you cannot figure out which ones.
To fix this use another selection widget
2022-08-10 01:17:53 +02:00
Uwe
7e071623d5 [FEM] fix selection issues with electrostatic constraint
- the used selection widget did not highlight the selected faces. This made it very hard to work with when one has an existing document where e.g. 5 faces have a certain voltage and you cannot figure out which ones.
To fix this use another selection widget
2022-08-07 02:33:09 +02:00
Bernd Hahnebach
ffd51eda61 FEM: python code formatting 2022-07-31 23:47:45 +02:00
Uwe
529c48cca4 [FEM] remove unneeded checks for Python 3
since we only support Python >=3, these checks can go
2022-07-31 15:36:54 +02:00
Uwe
a035d650b6 [FEM] remove checks for Python 2 2022-07-27 14:09:23 +02:00
Uwe
adff3da37a [FEM] task_material_common: add a comment 2022-07-23 14:22:48 +02:00
Uwe
1f7374edf1 [FEM] fix material task dialog for fluids
- this fixes a mistake from commit ef088674
- it also consistently use the thermal expansion coefficient
- add code comments

now the material task dialog works with all fluid materials without errors or warnings
2022-07-23 04:59:10 +02:00
Uwe
146e5508aa [FEM] [skip CI] fix wording
Calculix will not be broken, but stopped. After clicking the button your will also get a message that it has been 'stopped'
2022-07-16 19:33:02 +02:00
Uwe
c7aca5b5d2 [FEM] [skip CI] electrostatic: remove unused code 2022-07-13 03:23:19 +02:00
Bernd Hahnebach
bbbd4d07bf FEM: typos, found with:
codespell -q 2 -S *.ts -S *.dyn -S *.svg  -L childs,dof,dum,freez,methode,nd,normaly,programm,som,uint,vertexes,inout  src/Mod/Fem/
2022-07-12 15:04:26 +02:00
Bernd Hahnebach
e49abfb350 FEM: python code formatting 2022-07-12 15:04:26 +02:00
Uwe
ef088674ba [FEM] fix wrong console outputs for fluid materials
- since a while ThermalExpansionCoefficient is used, VolumetricThermalExpansionCoefficient is only used for the material task panel
- as already stated in a code comment, the unit of VolumetricThermalExpansionCoefficient is ThermalExpansionCoefficient, therefore we must check for ThermalExpansionCoefficient
- we must also check if ThermalExpansionCoefficient exists

- Adapt the existing fluid material cards to use the ThermalExpansionCoefficient
2022-07-02 05:36:43 +02:00
Uwe
dd00c46a8c [FEM] fix issue that all plot windows had the same name
- they all had the name "figure 1"
- thus make the name unique and this way also enable to have several plots open displaying different result types (for the line filter)
2022-06-10 00:55:02 +02:00
0penBrain
920e8e0469 [FEM] Implement a better dialog layout management for histogram (#6989)
* [FEM] Implement a better dialog layout management for histogram
2022-06-08 16:51:01 +02:00
Uwe
9156d591c9 [FEM] fix subsequent histogram plot call
fixes #6975
2022-06-06 18:26:18 +02:00
Uwe
b5b5375fe4 [FEM] result dialog: handle max shear stress
- max shear stress is supported but could not use in the Calculate section
- also sort the UI file with our sorting script
2022-06-05 00:12:51 +02:00
Uwe
8567ef1849 [skip CI] [FEM] change strings to be consistent with the dialog 2022-06-04 19:06:14 +02:00
Uwe
704feadc7c [skip CI] [FEM] fix typos 2022-06-04 01:33:34 +02:00
Uwe
e41879c6ea [FEM] don't block FC by histogram plot window
fixes #6959
2022-06-04 01:28:55 +02:00
Chris Hennes
d73f9e3762 FEM: Add translation calls to task_result_mechanical.py 2022-06-03 11:42:52 -05:00
Uwe
134fa8b7ea [FEM] use proper histogram titles
- use for the histogram titles the same as in the CCX dialog and not our internal abbreviations
- in the CCX dialog don't use the term PEEQ but the common wording that also gives the user the info what this is about
2022-06-03 13:09:32 +02:00
Uwe
1c666f7837 [FEM] adapt electrostatic examples to changed unit handling
- also a coding improvement
2022-03-26 04:54:36 +01:00
Uwe
30928c0710 [FEM] Elecrostatic: use App::PropertyElectricPotential 2022-03-26 02:29:19 +01:00
Uwe
ac59dce291 [FEM] fix missing recompute
as reported here: https://forum.freecadweb.org/viewtopic.php?p=582525#p582525

- also fix potential issue that FemGui is used by the script but not loaded
2022-03-25 21:22:15 +01:00
Uwe
0419d2f756 [FEM] Electrostatic: read values with its unit 2022-03-23 16:03:35 +01:00
wmayer
cf7fd5d2ac lgtm: removes unused imports in Python scripts 2022-03-20 23:00:55 +01:00
Uwe
c360c6e5f5 [FEM] electrostatic dialog revision
- use a quantity spinbox and do simple signal/slot handling in the UI file
2022-03-19 05:01:23 +01:00