Russell Johnson
d67f636d9d
Path: Fixes to path generation for certain selections
...
Fixes path generation for selection of two non-parallel edges.
Fixes path generation for selection of single, bottom face of slot with two non-parallel ends.
Fixes path generation for selection of two parallel, bottom bounding edges of slot.
2020-12-18 16:04:07 -06:00
Russell Johnson
3b2d06a481
Path: Add docStrings to some methods
2020-12-18 16:04:07 -06:00
Russell Johnson
4d35905a60
Path: LGTM and spelling correction
2020-12-18 16:04:07 -06:00
sliptonic
b2e993e97a
Merge branch 'master' into bug/4466
2020-12-18 11:11:18 -06:00
Markus Lampert
72b70c52a1
Added provision for gcc peculiarities in unit tests
2020-12-17 23:11:02 -08:00
Markus Lampert
3b69d23571
Reuse existing QuantitySpinBox'es in order to avoid segfault on focus change.
2020-12-17 23:01:55 -08:00
Markus Lampert
c1549ba3a8
Allowing QuantitySpinBox to be reused for different attribute; using properties to get values to work around build differences.
2020-12-17 22:56:42 -08:00
Markus Lampert
d136394376
Rearranged BitTool shape update so dependent ops don't execute with invalid tool.
2020-12-17 20:27:42 -08:00
Markus Lampert
a5e992f700
Make BitShape read/writeable, so the tool can be edited when shared to a different system
2020-12-17 19:59:44 -08:00
Markus Lampert
3da82fa6af
Hide document when loading a ToolBit.
2020-12-17 19:55:59 -08:00
Markus Lampert
7049c09448
Only update the shape if it has changed.
2020-12-17 19:14:44 -08:00
sliptonic
9ea837fd90
fixes 4466
2020-12-17 16:21:31 -06:00
wmayer
fc9be21345
Path: [skip ci] fix TooltablePy::getTools to avoid possible double destruction of a Tool instance
2020-12-16 10:34:24 +01:00
sliptonic
b920bbf73a
Merge pull request #4143 from mlampert/bugfix/vcarve-depth
...
Path: Bugfix/vcarve depth
2020-12-14 17:18:30 -06:00
sliptonic
07e2e8fcf3
Merge pull request #4141 from gauna85/PathToolcontroller
...
Path: Added missing signal-connection causing spindle speed not to be updated using ToolControllerDlg Bug 4479
2020-12-14 12:28:56 -06:00
sliptonic
3a07613137
Merge pull request #4136 from gauna85/PathEngrave
...
[Path] Sort edges before splitting at selected vertex
2020-12-14 12:27:54 -06:00
sliptonic
b6a83cbebf
Merge pull request #4132 from gauna85/Path
...
[Path] Check if startpoint is not lower than bounds in order to work always …
2020-12-14 12:21:20 -06:00
wmayer
9b39c6784e
Path: [skip ci] fix memory leak in TooltablePy::getTools()
...
For some background information see: https://forum.freecadweb.org/viewtopic.php?f=15&t=50583&start=20#p457516
2020-12-14 17:19:52 +01:00
Markus Lampert
ee92a1d2f9
Adding g0 to safety to base op so it's applied to all ops
2020-12-13 15:00:05 -08:00
gauna85
add350c6b4
Merge branch 'master' into PathToolcontroller
2020-12-13 22:17:28 +01:00
Stefan Endres
a7edfcf1cb
Path: Added missing signl-connection causing spindle speed not to be updated using ToolControllerDlg
2020-12-13 22:12:08 +01:00
Markus Lampert
ed7be8674e
meld h and v speeds for v-carve commands depending on incline
2020-12-13 11:31:58 -08:00
Markus Lampert
6176ed3e0e
Fixed tool-bit shapes when diameter == shank diameter.
2020-12-13 11:31:58 -08:00
Markus Lampert
1511fae5fe
Consistent TC naming/labeling, regardless of how created.
2020-12-13 11:31:58 -08:00
Markus Lampert
70364c0277
Fixed thread-milling icon reference.
2020-12-13 11:31:58 -08:00
Markus Lampert
c955bf4a4e
Fixed v-carve depth calculation in the presence of a bottom diameter, added unit tests and cleaned up the v-bit parameter naming.
2020-12-13 11:31:58 -08:00
gauna85
5bafaac609
Merge branch 'master' into Path
2020-12-13 19:35:43 +01:00
Stefan Endres
4ad41c96d0
Path: Check if startpoint is not lower than bounds in order to work always from top to bottom
2020-12-13 19:34:02 +01:00
gauna85
864ea59b95
Merge branch 'master' into PathEngrave
2020-12-13 19:30:40 +01:00
Stefan Endres
e7085cb47e
Path: Sort edges before splitting at selected vertex
2020-12-13 19:27:13 +01:00
wmayer
aec9d5f07a
Py: fix memory leaks by incorrect use of PyList_Append
2020-12-13 16:30:04 +01:00
Markus Lampert
85cd4af06b
More py2 special handling for unit tests
2020-12-03 19:39:33 -08:00
Markus Lampert
9eebafbe4b
Added consistent encoding headers and fixed whitespaces
2020-12-03 18:15:36 -08:00
Markus Lampert
134fe23c8f
Fixed unit test breakage for py2
2020-12-03 18:15:36 -08:00
Markus Lampert
cc0ba34a4c
Added thread milling files to cmake
2020-12-03 18:15:36 -08:00
Markus Lampert
c0bdf89f4c
Added example thread cutter to default library
2020-12-03 18:15:36 -08:00
markus
aa2881e08e
Use new ToolBits (and only those) for thread milling.
2020-12-03 18:15:36 -08:00
markus
d5beaf806d
Filter all TCs for suitability for a given op.
2020-12-03 18:15:36 -08:00
markus
b7a356cceb
Catch exception if shape file does not include a thumbnail.
2020-12-03 18:15:36 -08:00
markus
074ad40338
Fixed merge issue
2020-12-03 18:15:36 -08:00
Markus Lampert
b1c385f909
Cleaned up properties
2020-12-03 18:15:36 -08:00
Markus Lampert
c11aaafc54
Added support for imperial threads to thread milling
2020-12-03 18:15:36 -08:00
Markus Lampert
15141e33dc
Added actual thread milling path generation.
2020-12-03 18:15:36 -08:00
Markus Lampert
0a96a861c3
Added thread milling radii calculation
2020-12-03 18:15:36 -08:00
Markus Lampert
b29d168132
Add basic thread milling op
2020-12-03 18:15:36 -08:00
sliptonic
be190a948a
Merge pull request #4097 from Russ4262/millface_fix
...
Path: Millface fix - Address rounding issue
2020-12-03 13:29:14 -06:00
sliptonic
b935769fe3
Add finaldepth property.
...
Operation now sets start/final depth more reasonably.
Will not violate the finaldepth.
2020-12-02 15:05:08 -06:00
Russell Johnson
53091320c6
Path: Swap list instantiation per senior devs specifications
2020-12-02 11:34:58 -06:00
Russell Johnson
384541eede
Path: Instate obj.removalshape property for debugging purposes
2020-12-02 11:34:58 -06:00
Russell Johnson
f869fbf598
Path: Address problem with rounding issue
...
Translate removal shape down into buffer zone to offset rounding issue.
2020-12-02 11:34:58 -06:00
