Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
Fix MillFace div by zero error reported in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=51415.
Rotational-related variables were exposed to non-rotational code block. They have been moved into correct rotational code block.
This `ns` fix might need further attention after testing. The section to which it pertains deals with optimizing rotations between ops with similar rotational axes.
Existing code to determine if shape volume indeed existed, failed.
Added additional pre-check for existing edges in shape to determine if shape geometry indeed exists.
In forum:
[Ticket #4411 - Can only generate pocket once for this shape, then it fails.](https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49035).
Two new properties, `ExpandProfile` (length) and `ExpandProfileStepOver` (percent) added for new feature.
New feature converts the normal single offset profile into a compound profile containing multiple increasing/decreasing offsets.
The new feature clears a each layer completely before stepping down to the next layer.
Adjust sorting procedure in PathAreaOp due to `ExpandProfile` modifications to open edges code.
Avoid spurious diffs from inadvertent newline changes by letting git
normalize newlines in the path module as well, just as a list of other
modules including Draft already do.
This effectively standardizes all checked-in code to Unix newlines, but
checkouts might use CRLF if that is the user preference.
lazy_loader is copied to Ext now, modified external imports to lazy_load
add a few more imports to be lazy loaded, think the install path is correct now
[TD]"<" symbol embedded in html
revert changes to path modules for testing
use lazyloader in PathAreaOp.py
add back in deferred loading
temp change to print error message in tests
temp change to print error message in tests
add _init__.py to lazy_loader
make install in CMakeLists.txt one line
PathAreaOp: Add SetupProperties() function
PathPocketBase: Modify SetupProperties() function to include return from same in PathAreaOp.
PathPocketShape: remove blank indents
PathProfileBase: Modify SetupProperties() function to include return from same in PathAreaOp.
PathProfileFaces: fix `EnableRotation` issue
Fix rotational orientation of pockets. Need to apply same fix to ProfileFaces.
Fix final depth issue based upon error in rotational orientation fixed here.
Add property, `LimitDepthToFace` to facilitate easier pockets and face profiling on rotational-enabled operations.
Hide rotational support properties when operations do not use rotation.
Remove unnecessary property, `B_AxisErrorOverride`, and delete dead code that used it.
Open edges, exterior or interior, can now be used to generate paths.
The new feature behaves as though the parent face is vertically oriented (standing). It is preferred that the user select upper (top) edges. Selecting bottom edges in some cases may not produce a path.
Path ends calculations might need slight adjustment in the code. Path ends are *near* perpendicular to ends of edge.
Cut direction seems sporadic, but the `Direction` property will switch the direction of cut. The `CW` and `CCW` direction labels might not align with the actual direction. Additional algorithm modification is necessary to enforce fidelity to the labels.
Existing properties, `UseComp` and `OffsetExtra` are observed with open faces. Negative values for `OffsetExtra` have not been tested - only zero and positive.
Manual entries of FinalDepth values are now respected, even if below the calculated bottom of selected geometry.
Affected modules include PathPocketShape, PathPocket, PathCircularHoleBase, and PathAreaOp-based operations.
Fix format syntax issues
apply algorithms to some pockets to eliminate air milling and adapt start and finish heights and paths to top and bottom of certain pockets.
Depth correction & flake8 formatting
use list to track successive cuts so variations of settings are tracked and applied correctly
Apply faceType specific depth calculations
Planar face requires one depth source, non-planar requires a different source.
orientation == 'Z' was failing in some cases due to undefined "axis" variable. "axis" declaration was commented out in an earlier commit. Declaration now restored for all orientations.
Thanks @mlampert and @sliptonic for assisting in tracking down the error via unit test analysis.
FreeCADGui usage has to be behind an 'if FreeCAD.GuiUp:` test
Clean up code, improve comments, improve user feedback.
Improve temp clone management.
Correct depth issue with self.finDep
Add comment descriptions for new methods
Clean up comments and contribution information
Initiate recognition of type()==SurfaceOfExtrusion
Adopt standard PathGeom.isRoughly() and .Tolerance rather than idependent precision settings
Depth correction to obj.FinalDepth.Value in single feature operations
Fix AttemptInverseAngle to be uni-directional
Clean up debug and other user provided feedback
* PathSurface: Add StepDown support
Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.
* Update PageOpSurfaceEdit.ui
* PathSurface: Activate CompletionMode input
Update code to use CompletionMode selection from user.
* PathSurfaceGui: Add Completion Mode selection box
Add Completion Mode selection box for user input.
* PathSurface: Use depth_params() for step control
Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.
* PathSurface: Improve stability - Rev3
Organized code better, improved path optimization algorithm
* PathSurface: Add XY rotational surfacing
Add options to perform 3D surfacing by rotating object around X or Y axis.
* PathSurface: update setup function
Add properties to setup function
* PathSurface: Remove extraneous code
removed commented lines that consume processing time
* PathSurface: Correct nxt.z point assignment
Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z
* PathSurface: Update 4th axis operation
Provided both parallel and perpendicular to axis scans when performing rotational operation.
* PathSurface: Corrected Y-axis rotation to gcode
Inverted Y-axis scan values in gcode to produce correct result
* PathSurface: Adjust gcode feed rates
Adjust feed rates for axial rotations
* PathSurface: Implement waterline alternative
Used OCL dropcutter scan as data base for python algorithm to extract a waterline. Waterline also incorporates step down feature.
* PathSurface: Update to 3m-Usable
stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills
* PathSurface: Update 3m-Usable_r1
change instantiated static class attributes from value None, to 0.0
* PathSurface: Revert to 3i-Usable_r1
Further testing needed for 3m-Usable release
* PathSurface: Update to Rev. 3s Usable
fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb
* PathSurface: Update to Rev. 3t Usable
Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation
* Implement 4th-axis feature
Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii
* Deleted reference to undeclared variable
* Added missing class attributes/variables
* Added missing class variables/attributes
* Relocate class variables to higher class
* Remove references to undeclared variables
relocated class variables here
delete references to undeclared variables
* Correct rotation direction for normal-to-Y faces
* Remove X oriented 180 degree rotation adjustment
Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation
* Update 4th-axis integration
Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature. EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.
* PathSurface: Add StepDown support
Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.
* Update PageOpSurfaceEdit.ui
* PathSurface: Activate CompletionMode input
Update code to use CompletionMode selection from user.
* PathSurfaceGui: Add Completion Mode selection box
Add Completion Mode selection box for user input.
* PathSurface: Use depth_params() for step control
Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.
* PathSurface: Improve stability - Rev3
Organized code better, improved path optimization algorithm
* PathSurface: Add XY rotational surfacing
Add options to perform 3D surfacing by rotating object around X or Y axis.
* PathSurface: update setup function
Add properties to setup function
* PathSurface: Remove extraneous code
removed commented lines that consume processing time
* PathSurface: Correct nxt.z point assignment
Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z
* PathSurface: Update 4th axis operation
Provided both parallel and perpendicular to axis scans when performing rotational operation.
* PathSurface: Corrected Y-axis rotation to gcode
Inverted Y-axis scan values in gcode to produce correct result
* PathSurface: Adjust gcode feed rates
Adjust feed rates for axial rotations
* PathSurface: Implement waterline alternative
Used OCL dropcutter scan as data base for python algorithm to extract a waterline. Waterline also incorporates step down feature.
* PathSurface: Update to 3m-Usable
stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills
* PathSurface: Update 3m-Usable_r1
change instantiated static class attributes from value None, to 0.0
* PathSurface: Revert to 3i-Usable_r1
Further testing needed for 3m-Usable release
* PathSurface: Update to Rev. 3s Usable
fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb
* PathSurface: Update to Rev. 3t Usable
Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation
* Implement 4th-axis feature
Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii
* Deleted reference to undeclared variable
* Added missing class attributes/variables
* Added missing class variables/attributes
* Relocate class variables to higher class
* Remove references to undeclared variables
relocated class variables here
delete references to undeclared variables
* Remove X oriented 180 degree rotation adjustment
Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation
* Correct rotation direction for normal-to-Y faces
* Update 4th-axis integration
Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature. EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.
* Apply XYZ Model translations to paths; Add rotation axis selection property
* Spelling correction
ln 110
* Geometry list box: shrink height
560 to 400 height
* Update 4th-axis integration
Clean up code
Add comments for visionary elements
Apply axis selection to opHeights rotational calculations
* Update 4th-axis integration
Prepare sorting of vertical faces per axis_angle grouping, just as horizontal faces are sorted, for analysis as connected shapes
* Reset to FreeCAD master current
* Reset to current FreeCAD master version
* Update PathPocketBase.py
* Reset to current FreeCAD master
* Corrected __created__ date
* Convert all print() to PathLog.debug()
* Convert print() to PathLog.debug(); Clean up code
Use PathLog.debug over print() for troubleshooting
Clean up large commented sections of code.
* Convert print() to PathLog.debug(); combine duplicate methods
* Update last modified stamp
* Update last mofified timestamp
Also, removed commented-out code
* Typo corrected: "selt." to "self."
Discovered in https://api.travis-ci.org/v3/job/526456071/log.txt
on 30 April 2019 while searching for errors related to failure of PR #2114
* Restore initialization of self.depthparams
PR is failing Travis CI build test. Previous deletion of this code appears to be the reason.
See report at: https://api.travis-ci.org/v3/job/526492709/log.txt
* Convert tuple sizes from other PathWB ops
* B-axis rotation: render correction
* Revert "rebase to FC master 2019-05-02"
* Correct depthparams opOnDocumentRestored() issue
* Relocate "UseRotation" property from PathAreaOp.py
* Improve meshFromShape() calculation per @sliptonic
faster mesh creation
helps smooth jagged lines in path results
* Part: Make 3rd party libraries into PCH
* PartDesign: 3rdParty to PCH
* Sketcher: PCH
* PartDesign: PCH GUI
* Sketcher: GUI PCH
* Travis windows build (#2110)
Travis windows build
* Travis: enable clcache debug
* disable travis clcache debug
* respect user settings for dialog used in merge-document command
* msbuild verbose and logo
* Travis force wait 60 minutes
* Travis: Use & between vars sourcing and msbuild
* Travis: Move building to external batch script (#2131)
* Travis: Move building to external batch script
* Travis: double quotes to escape route
* Travis: use cmd.exe to call batch file
* Crowdin: fix grammatical error + whitespace
https://crowdin.com/translate/freecad/569/en-fi#6498705
* Crowdin: experiment to fix crowdin 'ghost' strings
The following translation strings still perpetuate after updating crowdin translations. This commit experiments with removing their source counterparts in the FC .ts files. I'm not sure why they are not rendered obsolete by the normal operations.
* https://crowdin.com/translate/freecad/6766/en-en#6499472
* https://crowdin.com/translate/freecad/6766/en-en#6573450
* fix for edit tracker draw styles
* deleted commented code
* Travis: filter out
* AddonManager: allow to add custom repositories
* Revert "rebase to FC master 2019-05-02"
* Draft: Fixed Draft text justification
* Arch: Fixed bug in arch windows creation
* Arch: Fixed export of windows colors to IFC
* Draft: Fixed 0.18.1 bug in DXF importer
* Arch: Fixed wrong exported objects in IFC export
* Arch: Fixed export of sites to IFC
* Start: Fixed bad default icon in start page
* Correct depthparams opOnDocumentRestored() issue
* Relocate "UseRotation" property from PathAreaOp.py
* Improve meshFromShape() calculation per @sliptonic
faster mesh creation
helps smooth jagged lines in path results
* Relocate "UseRotation" property in PathAreaOp.py
* Syntax correction
Travis CI python 3.7 build test fails regularly due to syntax error at this point
* Correct rebase issue: PR #2114
* Correct rebase issue: PR #2114
* Correct rebase issue: PR #2114
* Correct rebase issue: PR #2114
* Correct rebase issue: PR #2114
* Correct rebase issue: PR #2114
* path pep8 cleanup
* Multi-face geometry selection repaired
Previous version broke ability to select process multiple faces selected by user in geometry tab in operation task window.
Also performed some syntax cleaning per PEP8 linter
* Update script version info
