kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
33,042 Commits 41 Branches 6 Tags
d7e0100d4b0940708f4e59256036ef4e756c19d5
Commit Graph

3108 Commits

Author SHA1 Message Date
marioalexis
544ba0f56a Draft: Use ordered vertexes to create Draft Wire from Part.Wire 2021-06-12 18:09:45 -03:00
luz paz
0db5d84a7e Fix source comment typos 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ontop,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
 2021-06-10 17:33:40 -04:00
Yorik van Havre
4a9963a03f Merged crowdin translations 2021-06-10 12:24:24 +02:00
Yorik van Havre
5739d6eb7c Updated ts files 2021-06-10 11:48:18 +02:00
Yorik van Havre
c50bbd263d Merge pull request #4833 from carlopav/draft-fix-autogroup 
Draft: fix Autogroup to fix Draft_OrthoArray crash when using active Std_Part.
 2021-06-09 12:44:42 +02:00
Yorik van Havre
524023cab9 Merge pull request #4840 from marioalexis84/draft-wp 
Draft: Improve alignToSelection method on WorkingPlane
 2021-06-09 12:43:58 +02:00
Roy-043
cb07846ca8 Draft: Fix wrong tree icon for Draft_PointArray 2021-06-08 14:29:03 +02:00
marioalexis
a6ef3e656b Draft: Check null shape in geometry.py functions 2021-06-06 21:30:20 -03:00
marioalexis
1c918e9d9e Draft: Improve alignToSelection method on WorkingPlane 2021-06-06 21:30:20 -03:00
carlopav
d115db2cbb Draft: Autogroup, insert guard to prevent cyclic references 
ref. Forum discussion: Draft_OrthoArray: Crash when using active Std_Part. https://forum.freecadweb.org/viewtopic.php?f=23&t=59155&p=508132#p508132

Autogroup try to add new created Draft Objects into the active Part, but if the Part is used as a Base for the new object this could create a cyclic reference. 
This behaviour is prevented by adding a check for " obj in active_part.InListRecursive"
 2021-06-06 11:21:21 +02:00
carlopav
f050f77343 Draft: Autogroup, rename variables to more readable names 2021-06-05 17:07:32 +02:00
Yorik van Havre
fb8b21ec43 Updated ts files 2021-06-04 18:30:30 +02:00
Yorik van Havre
7b58a46ab7 Merge pull request #4827 from Roy-043/Draft_Fix_gui_stretch 
Draft: Fix gui_stretch
 2021-06-04 13:18:05 +02:00
Yorik van Havre
f9c0455385 Merge pull request #4816 from luzpaz/typos 
Fix misc. typos
 2021-06-04 13:16:21 +02:00
Yorik van Havre
3352ebf9a0 Merge pull request #4811 from carlopav/DraftEdit_Improvements 
Draft: Edit improvements to context menu and code organization
 2021-06-04 13:15:18 +02:00
luz paz
097bb0769c Arch: fix typo in translate() 2021-06-03 14:36:21 -04:00
Yorik van Havre
d0d637b2c6 merged crowdin translations 2021-06-03 15:43:34 +02:00
Yorik van Havre
4361893f24 updated ts files 2021-06-03 15:37:33 +02:00
Roy-043
6cbd0cb9b4 Draft: Fix gui_stretch 
If a wire is created to replace a rectangle, the MakeFace property of the wire should match that of the rectangle.
 2021-06-02 14:28:56 +02:00
carlopav
267291567f Draft: Edit, cleanup of new GuiTools.addPoint methods 
In new splitted addPoint methods, getObjectsInfo and the consequent checks have been removed and moved to main DraftEdit module in a new get_specific_object_info method.
This method returns the info for the selected object at a given position and the 3d Vector of the point clicked on the object.
 2021-06-01 23:21:12 +02:00
carlopav
5841b737e1 Draft: Edit, moved resetTrackers for context menu actions to main module 
The wrapper allows to call resetTrackers in the main module after the callback to the GuiTools is executed.

This is the last commit, many thanks to @matthijskooijman for having menthored me :)

I think it's helpful to have @matthijskooijman explanation on this use of the wrapper:

This defines a new wrapper function, that calls the original callback and then calls resetTrackers. Note that this creates a new function for every loop iteration, so each of these wrapper functions captures potentially different callback, self and obj values so things work as expected. Note I did something weird with the callback value there: Since functions like these capture a variable, not its value at the time of function definition, and loop variables like label and callback are a single variable shared between all loop iterations, capturing callback directly ends up with all wrappers calling the last callback (i.e. they all capture the same variable and by the time the wrappers are called, that variable will contain the last of the callbacks). This is commonly solved by using a default value in the function definition, since such a default value uses the value of the (in this case) callback variable, not capturing the variable.
 2021-06-01 23:20:41 +02:00
carlopav
0ea4c5d2fe Draft: Edit, Added reverse wire option to context menu 
Now Draft Edit can reverse the order of the points of a Draft_Wire
 2021-06-01 22:53:24 +02:00
carlopav
28ced10d50 Draft: Edit, rewriting context menu system 
get_edit_point_context_menu(self, edit_command, obj, node_idx)
get_edit_obj_context_menu(self, edit_command, obj, position)
that are called depending if the user is over an editpoint or over another part of the object.
 2021-06-01 22:53:01 +02:00
carlopav
cc87ab4913 Draft: Edit, Split out addPoint in multiple methods in the GuiTools 
Now Draft_Wire, Draft_BSpline, Draft_Bezcurve have their own methods to add points.
 2021-06-01 21:57:38 +02:00
carlopav
bd02136f9d Draft: Edit, change startEditing method to accept (obj, node_idx) 
This enable to start editing also without an user click event, by just calling the method and specifying the object and the edit point index.
It is used for alternative edit mode (alt_edit_mode) by arc context menu
 2021-06-01 21:47:37 +02:00
carlopav
b108f66780 Draft: Edit, Remove all the empty pass functions 
Remove unused functions. Since GuiTools objects inherit from the GuiTools class, they do not need those placeholders.
 2021-06-01 21:47:37 +02:00
Yorik van Havre
f7cdb4cc04 Merge pull request #4822 from marioalexis84/draft-fillet 
Draft: Add shortcut to fillet command
 2021-06-01 17:01:53 +02:00
Yorik van Havre
9332e52d94 Draft: Added ExclusionPoints property to shape2dview object 2021-06-01 11:30:04 +02:00
marioalexis
d363f10edf Draft: Add shortcut to fillet command 2021-05-31 16:18:36 -03:00
Yorik van Havre
43a2e2e640 Merge pull request #4820 from Roy-043/Draft_Fix_make_text 
Draft: make_text fixed 3 small issues
 2021-05-31 19:44:13 +02:00
Roy-043
cd31a4f026 Draft: make_text fixed 3 small issues 
Fixed 3 small issues in make_text that came up while working on make_label (pull request #4801).
 2021-05-30 19:53:02 +02:00
Yorik van Havre
f94f4257cf Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-05-28 14:11:51 +02:00
Yorik van Havre
cc1140489e Merge pull request #4801 from Roy-043/draft_make_label_text_input 
Draft: Fixed make_label to accept list of strings for custom_text
 2021-05-28 13:46:10 +02:00
Yorik van Havre
b1d9a5607f Merged crowdin translations 2021-05-27 14:51:33 +02:00
Yorik van Havre
c6771853ae Updated translation files 2021-05-27 14:44:40 +02:00
Roy-043
c0105690f4 Merge branch 'master' into draft_make_label_text_input 2021-05-26 16:23:22 +02:00
Yorik van Havre
e6af8032e2 Merge pull request #4804 from luzpaz/Crowdin-Draft 
Crowdin: fix Draft mirror code typo
 2021-05-25 15:07:28 +02:00
Yorik van Havre
601d6ca466 Merge pull request #4808 from matthijskooijman/movewithhost-link-exception 
Draft: Do not move children of App::Link objects
 2021-05-25 15:06:55 +02:00
Yorik van Havre
5d57496f25 Merge pull request #4809 from matthijskooijman/draft-arch-simplifications 
Draft & Arch: Python code simplifications
 2021-05-25 15:05:46 +02:00
Roy-043
57de4681ec Update make_label.py 
Brought back name=_name. Added type(custom_text) is list check.
 2021-05-24 18:42:27 +02:00
Matthijs Kooijman
738bcbe357 Draft: Fix "Show groups in layer list drop-down button" preference 
The code that was intended to handle this preference looked inside
Mod/BIM instad of Mod/Draft for the preference. This seems to have been
broken since the preference was first introduced in commit 507c40669d
(Draft: Turned autogroup button into layers selector (added pref option
to restore old groups-based system)).

This also removes a stray "-" that was probably a leftover from a merge
conflict, introduced in commit 68119de02f (Draft: move Draft_AutoGroup to
gui_groups module). Since -True is still true and -False is still false,
this did not actually break the code, though.

See https://forum.freecadweb.org/viewtopic.php?t=42018 for related
discussion.
 2021-05-22 18:33:15 +02:00
Matthijs Kooijman
ecc05545c1 Draft: Simplify code using getattr default value 
This uses the default value that can be passed to getattr to simplify
code that uses it. By choosing an appropriate default value, a separate
call to hasattr can be avoided and in some cases duplicate code can be
avoided.

This applies this trick where possible in wire.py and circle.py.

This commit does not change behavior.
 2021-05-22 17:44:04 +02:00
Matthijs Kooijman
19ada8fd1f Draft: Do not move children of App::Link objects 
This caused the original object to be moved when using the Draft move
tool to move a link object, when the original object has MoveWithHost
set (e.g. a Window). There was already a similar exception for clones,
so it makes sense to extend this for links too.

Note that there seem to be more problems with the "MoveWithHost"
mechanism and fixing them might completely refactor this code, but until
then, this is a simple and targeted fix that at least makes moving
links to windows work as expected.

See https://forum.freecadweb.org/viewtopic.php?f=23&t=57223 for
discussion of this bug, its fix and the additional problems mentioned.
 2021-05-22 16:51:04 +02:00
Roy-043
98e563c3d9 Update make_label.py 
If custom_text is a string there is no need to put it in a list.
 2021-05-22 16:33:12 +02:00
Yorik van Havre
089b2ae478 Draft: Fixed use of double quotes in Draft Texts 2021-05-21 15:35:29 +02:00
luz paz
5394c27683 Crowdin: fix Draft mirror code typo 
ref: https://crowdin.com/translate/freecad/548/en-en?filter=basic&value=2#6587132
 2021-05-20 16:02:34 -04:00
Roy-043
9b2ebec35d Draft: Fixed make_label to accept list of strings for custom_text 
The make_label function should accept a list of strings for custom_text. Compare the make_text function. The new code was mostly taken from there.
 2021-05-18 21:08:02 +02:00
Yorik van Havre
5161d99b48 Merge pull request #4795 from luzpaz/Crowdin-Draft-whitespace 
Crowdin: remove superfluous whitespace from translation
 2021-05-18 16:24:42 +02:00
luz paz
71faff2a0a Crowdin: remove superfluous whitespace from translation 
ref: https://crowdin.com/translate/freecad/548/en-en?filter=basic&value=2#6587168
 2021-05-17 10:51:05 -04:00
luz paz
7f4ac1d4f8 Crowdin: fix mistake in Draft Preferences text [skip ci] 
ref: https://crowdin.com/translate/freecad/548/en-en?filter=basic&value=13#6577122
 2021-05-17 10:28:43 -04:00