Commit Graph

368 Commits

Author SHA1 Message Date
sliptonic
d82ee98d46 Merge pull request #12602 from FlachyJoe/arc-distance
Sketcher : ArcLength Constraint
2024-04-01 10:43:35 -05:00
Roy-043
bc7833cfab Sketcher: Spelling colinear -> collinear
I have not changed the name of the `areColinear` function.
2024-03-26 07:40:14 +01:00
Florian Foinant-Willig
ef35ec195d Sketcher : ArcLength Constraint 2024-03-25 22:32:20 +01:00
PaddleStroke
e6802b049c Sketcher : fix error in className of CmdSketcherCompHorizontalVertical 2024-03-18 13:23:54 -04:00
Josh Coalson
fbd8767242 Part: Rename AttachExtension::Support property to AttachmentSupport, to avoid name conflict with base features. Fixes #7052 2024-03-04 18:22:43 +01:00
Max
2643902b6b add description of colinear function to Sketcher_ConstrainTangent 2024-03-04 18:20:18 +01:00
wmayer
88b2cccc09 Fix compiler warnings:
fix [-Winconsistent-missing-override]
fix [-Wunused-lambda-capture]
fix [-Wunused-variable]
fix [-Wswitch]
2024-02-26 11:01:37 -06:00
LemonBoy
72db315043 Fix icon order in constraint menu
Closes #12264
2024-02-12 11:50:41 -06:00
PaddleStroke
dc942368db Sketcher: CommandConstraint.cpp : modernize for loops and use some auto 2024-02-12 11:14:22 -06:00
PaddleStroke
4f508067ed Sketcher: Parallel: Ignore selected points instead of throwing an error. 2024-02-12 11:14:22 -06:00
Ajinkya Dahale
4de52e5269 [Sketcher] Handle spline selection in Dimension tool 2024-02-08 23:46:17 +05:30
Ajinkya Dahale
cf3e0c1b4a [Sketcher] Expose general tangency with B-splines to Sketcher
The following commits were squashed into this

[Sketcher] Handle some corner cases in AngleViaPoint

[Sketcher] Avoid redundant constraints with B-splines...

When involving tangent, perpendicular and angle constraints.

[Sketcher] Add pre-commit changes

[Sketcher] Do not allow 2-selection tangent with B-spline

Also...

[Sketcher] Report error when using direct tangency with B-splines

[Sketcher] Fix malformed constraint when B-spline is selected second

To clarify, this means the second curve selected. The position of the point in
selection order does not matter in angle-via-point.

[Sketcher] Fix wrong number for B-Spline tangent on redundancy

[Sketcher] Remove existing point-on-object in some redundant cases

Particularly when point constrained on a B-spline is being used for
tangent, perpendicular or angle via point with the same B-spline.

[Sketcher] Fix direction issue with B-spline tangents.

Without these changes the solver might try to "twist" the B-spline to make the
angle between curves be 0 instead of PI (which may be closer to the initial shape).
2024-02-08 20:04:28 +05:30
Max Wilfinger
96d3e26110 sketcher: create contextual right click menu 2024-01-08 12:39:17 -05:00
Paddle
621b4bd5fc Sketcher_dimension : Fixes https://github.com/FreeCAD/FreeCAD/issues/11904 2024-01-07 20:53:22 -06:00
Max Wilfinger
15d8a7aa17 add capabilities to auto-dimension tool to dimension distances between arc-point, arc-circle, arc-arc 2024-01-05 09:25:53 -06:00
Max Wilfinger
5c2da33b1f always show auto HorVer tool command in the toolbar when the tool is present (concise toolbar oprion) 2023-12-31 10:44:08 -06:00
Abdullah Tahiri
a6bbb7f970 Sketcher: Activate new icon for optional unified coincident constraint 2023-12-21 15:36:56 +01:00
Kacper Donat
34c85e26da Gui: Allow ActionGroups to not remember choice
This is fix to issue mentioned in the #11717, on discord and forum that
for smart dimension tool the chosen tool should not be remembered. This
will ensure that the "smart" tool is always visible on the toolbar and
other tools are accessible in case that such explicit choice is needed.
2023-12-18 17:51:48 +01:00
Florian Foinant-Willig
d4e5c7e966 Fix isCircleOrArc usage 2023-12-17 16:01:29 +01:00
Abdullah Tahiri
8d00b00c9b Sketcher: Utils/CommandConstraints/EditModeConstraintCoinManager - refactor duplicated code 2023-12-17 16:01:29 +01:00
Abdullah Tahiri
d28fe43565 Sketcher: Redraft circle/arc to circle/arc constraint command 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
7343bf940b Sketcher: Extend distance constraint to arcs 2023-12-17 16:01:29 +01:00
Florian Foinant-Willig
838802e28d Sketcher: Arc to arc or circle distance constraint 2023-12-17 16:01:29 +01:00
Chris Hennes
bd9a210b65 Merge pull request #11494 from Ondsel-Development/Coincident
[Sketcher] Introduce an optional unified version of coincident and pointOnObject
2023-12-04 10:46:21 -06:00
Paddle
d94fdf795e Introduce CmdSketcherConstrainCoincidentUnified. This is a unified version of coincident + pointOnObject.
This is disabled by default. Nothing changes by default.
2023-11-27 21:14:33 +01:00
wmayer
7157448b37 Sketcher: add security checks to avoid possible undefined behaviour 2023-11-27 10:58:50 +01:00
Paddle
466395194c hor/ver tool, remove unused variables 2023-11-27 10:44:25 +01:00
Paddle
b3fc34d61b Sketcher : Replace toggle icons. 2023-11-25 20:55:50 -03:00
Paddle
4c7ff0a6be Sketcher: remove unused cursor_createcoincident[] and DrawSketchHandlerCoincident. They are not used anymore. 2023-11-22 16:47:51 +01:00
Paddle
a45bb8626f Sketcher: Move Distance command next to DistanceX. ONLY move code, nothing changed. 2023-11-22 16:19:08 +01:00
PaddleStroke
cce89e4fec [Sketcher] Auto horizontal/vertical (#11330)
* Refactor sketcher horizontal / vertical constraints and adds a horizontal/vertical command.

* Sketcher : HorVer : change tool icon.

---------

Co-authored-by: Paddle <PaddleStroke@users.noreply.github.com>
2023-11-20 11:00:22 -06:00
Paddle
ca80f8eee2 Fix ESC key for Sketcher_Dimension 2023-11-15 14:41:43 +01:00
Abdullah Tahiri
f56eebea64 Sketcher: Fix lints 2023-11-08 17:46:34 +01:00
Abdullah Tahiri
dca052bd9d Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Paddle
a7e1cba6b0 Sketcher_Dimension: If radius of arc is not DoF, then offer arc angle first. 2023-11-06 14:02:54 -06:00
Chris Hennes
590fb19f31 Merge pull request #10978 from FlachyJoe/modernize-type-check
Modernize type and derived type checking
2023-11-06 10:44:32 -06:00
Abdullah Tahiri
3eda026ecb Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
533250bc34 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Florian Foinant-Willig
c0e8fa1e75 Sketcher: modernize type checking 2023-10-23 18:09:23 +02:00
Paddle
0f049a6cb0 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
e9586c4206 Sketch: fix several compiler and lint warnings
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
2023-10-20 12:29:59 +02:00
Paddle
019bd50bbc Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
Paddle
2ea27064d5 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
wmayer
b2d255e5fc Sketch: fix a few minor issues:
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
2023-09-19 22:01:19 +02:00
Paddle
f080b39829 Sketcher_Dimension : adds arc-angle mode for arcs. 2023-09-19 08:25:45 +02:00
Paddle
b97a2ef6dc Adds a small convenience function to get arc of circle angle. 2023-09-18 21:33:24 +02:00
howie-j
49bca90219 fixes #10651 2023-09-18 10:56:13 -05:00
Florian Foinant-Willig
e8becf3f15 Sketcher: refactor CommandConstraint.cpp (#10692)
* Sketcher: refactor CommandConstraint.cpp with TypeId helpers

* Sketcher: cosmetic empty lines

* fix pointer misusage
2023-09-18 10:37:03 -05:00
Paddle
cde6afe847 Sketcher_Dimension : enable user to deselect geos by clicking on them again. 2023-09-14 20:57:39 -05:00
wmayer
bc8a5e4704 Sketcher: fix several inconsistencies in Sketcher_CompDimensionTools
* The menu text and tooltip of the Sketcher_ConstrainRadius command shouldn't be different if part of the group command or not.
  The explicit mentioning to change the weight of a B-Spline is pointless and confusing.
* The order of Sketcher_ConstrainRadius and Sketcher_ConstrainDiameter has flippend when used in Sketcher_CompDimensionTools
* The command Sketcher_ConstrainRadiam is completely missing
* The command Sketcher_ConstrainSnellsLaw was wrongly re-added
* CmdSketcherCompConstrainRadDia uses a wrong context
2023-09-14 20:56:14 -05:00