Commit Graph

33 Commits

Author SHA1 Message Date
Benjamin Bræstrup Sayoc
63d9806b86 Remove magic number and hard type enums in Geometry.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-17 12:16:49 -05:00
tritao
65466d580b Gui: Reorganize the selection files into a top Selection folder. 2025-02-03 17:56:57 +01:00
Ladislav Michl
0ee3c9f8e6 Base: Drop QString-std::string conversion functions from Tools
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
2024-12-02 23:30:53 -05:00
WandererFan
b71c2a3278 [TD]Cosmetic function overhaul (#14216)
* [TD]Cosmetic geometry and tools update

- all cosmetics to store geometry in same form
- all cosmetics to survive scaling and rotation
- extension functions to survive scaling and rotation

* [TD]overhaul leader point storage and editing

- add py routine makeLeader(points)

* [TD]add leader conversion utility

* [TD]Set Leader RotateWithView default to true

* [TD]fix intersection vertex position

* [TD]add CosmeticEdge::makeLineFromCanonicalPoints

* [TD]fix 2 Extension tools

- positioning in DrawCosmeticCircle
- mishandling of points in execLineParallelPerpendicular

* [TD]Remove duplicate constexpr

* [TD]fix 2x Cosmetic arc tools

* [TD]refactor LineFormat out of Cosmetic

* [TD]move cosmetic appearance settings to LineFormat

* [TD]remove 2 unused methods

* [TD]apply format to blue line & circle tools

* [TD]fix ballon arrowhead does not rotate with view

* [TD]fix CosmeticCircle3Points

* [TD]allow multiple cosmetic object deletions

* [TD]fix extend/shorten centerline
2024-05-23 09:41:42 -04:00
wandererfan
762e1b53ff [TD]Standard Line Styles - Gui components 2023-12-01 11:27:29 -05:00
wandererfan
9a7163f533 [TD]fix 2 tidy warnings 2023-10-31 09:12:50 -04:00
pavltom
ded89f5e8f [TechDraw] - Line Decoration Improvements 2023-10-26 14:30:36 -04:00
wmayer
2a88c7c7df modernize C++: use bool literals 2023-08-06 01:35:39 +02:00
Benjamin Bræstrup Sayoc
a207822ee8 [TechDraw] Move CenterLine into own file 2023-04-06 13:51:35 -04:00
xtemp09
37d7f7d570 [TechDraw] Minor improvement of TaskLineDecor.cpp 2023-03-12 13:57:45 -04:00
wandererfan
01641433c1 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
wmayer
25a63f8750 TD: move to new style connect() 2023-02-01 01:33:34 +01:00
Uwe
cbd0140dcd [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
Benjamin Bræstrup Sayoc
43f6c17942 [TechDraw] Rename icon filenames for consistency 2022-07-09 14:38:30 -04:00
Chris Hennes
c44ccc0ff2 TD: PR6497 move return statement to new line 2022-03-29 13:26:01 -05:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
e91cc8e329 [TD] avoid memory leaks by using shared_ptr
TD geometry objects are sometimes double deleted.  This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
donovaly
21dc72ed10 [TD] make more pointers to the UI std::unique_ptr
addendum to PR #4293

(as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for remaining TD dialogs that don't already use a unique_ptr.)
2021-02-05 13:24:21 +01:00
donovaly
b5f57ed2f0 [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
wmayer
e9bc970c28 PVS: V522 There might be dereferencing of a potential null pointer 2020-07-18 10:59:27 +02:00
donovaly
d9e65c7780 [TD] use Gui::QuantitySpinBox in dialogs
as recently discussed

- also add lost alignment properties
2020-03-28 08:51:12 -04:00
donovaly
bf4e6b6316 [TD] refurbish LineDecorDlg
- also set a better step size
- also apply the changes in the DLG immediately

see: https://forum.freecadweb.org/viewtopic.php?f=35&t=44362&p=379377#p379377
2020-03-23 09:23:50 -04:00
wandererfan
a04d0f2574 [TD]Py routines for CenterLines 2019-12-16 20:36:10 -05:00
wandererfan
1ad2d35bce [TD]Python routines and extension for line formating 2019-12-16 20:36:10 -05:00
wandererfan
08f23b84f7 [TD]Python routines and extension for Cosmetic Edges 2019-12-16 20:36:10 -05:00
donovaly
15e5b29c22 TD renaming tools, part 2/2
as discussed in https://forum.freecadweb.org/viewtopic.php?p=344899#p344800
we need a more consistent naming for the Wiki
2019-11-17 08:22:09 -05:00
wandererfan
e406b2f3e6 [TD]Remove NoLine option from dialogs 2019-07-18 08:53:38 -04:00
wandererfan
621b66be17 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
b561190d4f [TD]Add restore invisible lines 2019-07-15 12:36:48 -04:00
wandererfan
3d2edd0f7e [TD]Add line appearance editor 2019-07-15 12:36:48 -04:00