Commit Graph

268 Commits

Author SHA1 Message Date
DeepSOIC
db26cbcc4c Sketcher: fix false detection of doubleclick
Double-click detector code was comparing double-click threshold (value =
5) with distance between clicked objects in model space (i.e.
double-click distance threshold was equal to 5 mm in model space
regardless of zoom). The fix changes the comparison to pixels on screen
instead.

This fixes the inability to select sketch entities in quick succession,
when the sketch is small (i.e. less than 40 mm or so).
2017-11-10 18:12:48 +03:00
wmayer
8b2fcf3677 fix several kind of warnings:
+ fix -Wparentheses/-Wlogical-op-parentheses
+ fix -Wunused-variable
+ disable -Wundefined-var-template due to many false-positives (clang)
+ fix -Winconsistent-missing-override
+ fix -Wmaybe-uninitialized
2017-10-15 19:12:07 +02:00
Unknown
772c5b1970 Doxygen Typos
+ doxy whitespace formatting
+ added more misc. typos
+ grammar fixes
[skip ci]
2017-10-15 16:27:42 +02:00
wmayer
1be2d52deb whitespace improvements + some optimizations 2017-10-12 11:22:10 +02:00
wmayer
4c7841c071 don't select circle/ellipse center if not inside selection box 2017-10-12 11:07:27 +02:00
SparkyCola
5696a66850 changed touch-selection so that it doesn't select the center- and end-
points of an object when they're not boxed
2017-10-12 10:42:04 +02:00
SparkyCola
9fba505e84 fixed touch-selection of circle and ellipse centerpoints not working 2017-10-12 10:41:05 +02:00
SparkyCola
b32fce69f1 fixed selection of centerpoints when only selecting them resulted in not
selecting anything at all (in Sketcher touch-selection)
2017-10-12 10:36:13 +02:00
SparkyCola
aaae347dd8 resolves #3204 2017-10-12 10:35:52 +02:00
SparkyCola
0a0a9698db implemented simple selection of b-spline in touch mode, so far it allows
only to select the whole spline if one of the points is selected, a
better implementation requires much more sophisticated algorithms
2017-10-12 10:35:52 +02:00
SparkyCola
893c8e84c6 implemented touch mode for arc of parabola with precision inaccuracity 2017-10-12 10:35:52 +02:00
SparkyCola
646604740c implemented touch mode for arc of hyperbola 2017-10-12 10:35:52 +02:00
SparkyCola
bd2fd1a5f5 implemented arc of ellipses touch mode (precision issue as well) 2017-10-12 10:35:52 +02:00
SparkyCola
1639f37887 Implemented arc of circle in touch mode, same issue with precision as in
circle and ellipse
2017-10-12 10:35:52 +02:00
Mattis
2f18e25278 fixed issue related to polylines in touchmode, also implemented ellipse
touchmode (same issue as circle touching for now)
2017-10-12 10:35:52 +02:00
Mattis
2ec06ca548 touch mode for circle implemented, does work for 90% of the cases, not
yet with relatively big circles and a narrow selectionbox.
2017-10-12 10:35:52 +02:00
Mattis
c9c5ca3010 added selection of end-points to line touch-select 2017-10-12 10:35:52 +02:00
SparkyCola
2781585a66 Added touchMode-detection and partially implemented touchMode for line-
detection (only works when one end-point is selected, yet).
The touchMode refers to a rectangular selection where objects are
selected even if only a part of them is int the box. It's used when the
selection box is drawn from right to left.
2017-10-12 10:35:52 +02:00
wmayer
770c9ce095 fix various coverity issues 2017-09-15 11:48:38 +02:00
Abdullah Tahiri
f974fec2bc Clarify solver situation at the end of of ViewProvider::OnDelete 2017-08-19 17:14:27 +02:00
Abdullah Tahiri
aa43197976 Refactoring solve+recompute and reinstating initial solve+recompute behaviour 2017-08-19 17:14:27 +02:00
wmayer
2004544e57 fixes #0002710: Freecad doesn't show sketch elements added when overconstrained
issue #0002836: Crash in sketcher
2017-08-19 17:14:27 +02:00
wmayer
3d86498a43 when drawing constraint icon handle the case when view provider of sketch is not in sync with geometry 2017-08-19 17:14:27 +02:00
wmayer
1d83d179ca do not hide any drawing elements when entering edit mode of a sketch 2017-07-15 15:47:22 +02:00
wmayer
989fe4028e various fixes:
+ fix typos
+ fix const correctness
+ whitespace improvements
2017-06-19 17:18:16 +02:00
Stefan Tröger
4ecd831bfd GeoFeatureGroup: Make link collection non-DAG save 2017-06-19 15:37:09 +02:00
Stefan Tröger
6b2558d954 Sketcher: Use correct global placements 2017-06-19 15:37:09 +02:00
Alexander Lin
c51d0b4e16 Adds extend feature to Mod/Sketcher
Fixes #1187
2017-06-19 13:07:37 +02:00
wmayer
a8bd3e95e5 fix creation of NaN that invalidates the view frustum 2017-05-12 08:05:12 +02:00
Abdullah Tahiri
7bee2c5412 Sketcher: Visualization of horizontal alignment constraint 2017-05-01 23:35:13 +02:00
wmayer
d679bba659 Revert "Sketcher: Constraint Node restructuring to enable independent hidding of driving/driven constraints"
This reverts commit 5b2e2b3d2f.
2017-05-01 16:17:20 +02:00
wmayer
7628f2bbb6 Revert "Sketcher: Edit Controls' checkboxes to independently hide/show driving/non-driving constraints"
This reverts commit 03a9d58db6.
2017-05-01 16:16:49 +02:00
wmayer
d25d7a2be2 Revert "Sketcher: hidding constraints - fix entry into empty sketch"
This reverts commit e94a86dd70.
2017-05-01 16:16:13 +02:00
Abdullah Tahiri
e94a86dd70 Sketcher: hidding constraints - fix entry into empty sketch 2017-04-30 10:06:15 +02:00
Abdullah Tahiri
03a9d58db6 Sketcher: Edit Controls' checkboxes to independently hide/show driving/non-driving constraints 2017-04-30 10:06:15 +02:00
Abdullah Tahiri
5b2e2b3d2f Sketcher: Constraint Node restructuring to enable independent hidding of driving/driven constraints 2017-04-30 10:06:15 +02:00
Abdullah Tahiri
c57e594ad7 Sketcher: On reference constraint double click, change it to driving and enter edit mode 2017-04-22 18:16:27 +02:00
Peter Lama
a75a98ef27 Use OCCT Handle macro for Handle_ classes
This is the result of running OCCT's upgrade script provided
with OCCT 7.0. See
https://www.opencascade.com/content/freecad-occt710-and-windows-rtti-data-missing#comment-form
and
https://www.forum.freecadweb.org/viewtopic.php?f=4&t=21405&start=120#p169019
for why this is necessary for OCCT >= 7.1
2017-04-20 12:27:34 +02:00
Abdullah Tahiri
ad112ca8ab Sketcher: Remove unused variable 2017-04-17 20:53:12 +02:00
Abdullah Tahiri
937c6179e2 Sketcher: Rendering order widget 2017-04-17 20:53:12 +02:00
wmayer
292fdebe49 fix scan coverity issues: unchecked dynamic_cast 2017-04-11 12:45:02 +02:00
Abdullah Tahiri
3b50a786f3 BSpline: Comb representation factor with hystheresis to avoid continuous comb variations on geometrically independent geometry 2017-04-10 18:55:23 +02:00
Abdullah Tahiri
418beea589 Sketcher: Only Reference constraints allowable on construction points like bspline knots 2017-04-08 12:58:06 +02:00
Abdullah Tahiri
56ab9d8cb9 Sketcher: Curvature comb general representation scale fix 2017-04-08 12:58:06 +02:00
Abdullah Tahiri
9ecb24c94b Sketcher: Bspline knot multiplicity geometry information layer 2017-04-08 12:58:06 +02:00
wwmayer
09510f0014 Merge pull request #583 from triplus/Font-size
Configurable coordinate info font size in Sketcher
2017-03-03 22:25:56 +01:00
triplus
288239c443 Configurable coordinate info font size in Sketcher
Useful on HiDPI displays and occasionally requested feature on the forum.
2017-03-03 19:27:10 +01:00
Kunda
99c99006b8 source typo fixes pt4 (only on py3 merged code) 2017-03-02 13:47:21 +01:00
Abdullah Tahiri
4fe4792f4d Sketcher: Fix zero curvature normal exception 2017-02-21 13:24:10 +01:00
Abdullah Tahiri
90bec55660 Sketcher: Automatic calculation of divisions for comb 2017-02-21 13:24:10 +01:00