Commit Graph

57 Commits

Author SHA1 Message Date
Aapo
dbef970697 [TD] Add under- and overtolerances for Dimension Task layout, fixes for Dimension tolerance refresh and behavior. 2021-01-31 15:17:46 +01:00
Aapo
e6ef62e711 [TD] Fix regression in Dimensions: Setting arbitrary under tolerance was somehow lost. 2021-01-31 15:17:46 +01:00
donovaly
96eaff8e4e [TD] some fixes
- the setting "Standard and Style" only affects new dimensions, thus it must be italic

- fix bug that the Property 'LockPosition' appears for dimensions -> this is an option for views and thus must be hidden for dimensions

- since tolerances are in the vast majority fractions of a millimeter/inch, set its stepsize to 0.1
(I hope I did it right in handleChangedPropertyType.)

- fix inconsistent newlines in TaskBalloon.h

- improve wording for a heading
2021-01-10 00:29:34 +01:00
donovaly
2232b1d48e [TD] handle equal tolerances correctly
the common rule is that if a dimension has equal over- and undertolerance, they are output on the same line as the dimension concatenated using the ± character.

This PR does this.

Note that this is not just cosmetics, it is even standardized in the GD&T norms.

also:
* use one format specifier for tolerances since the norms don't allow a different format for the over- and the undertolerance
* some code optimizations like a self-explaining function name, remove unnecessary/outdated comments
2021-01-08 15:14:37 +01:00
Aapo
2077709329 [TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension. 2020-12-17 17:30:29 +01:00
donovaly
a2b523fb39 [TD] fix unit mismatch bug
- also make global decimal option italic since it only affects new dimensions
- also fix a typo in UnitsApi.h
2020-12-03 15:50:06 +01:00
wmayer
2c599495a9 [TD] use PropertyQuantity for OverTolerance and UnderTolerance and add backward compatibility 2020-12-02 16:42:10 +01:00
aapo-aapo
3935ef8b8f @aapo-aapo @chennes [TD] Suggested minor improvements for DrawViewDimension.cpp and QGIViewDimension.cpp in Pull request review.
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2020-12-02 16:38:21 +01:00
Aapo
40bd4b806f [TD] Add tolerance format specifiers and arbitrary tolerances. 2020-12-02 16:38:21 +01:00
Aapo
e7b4d9ed99 [TD] Refactor DrawViewDimension getFormatedValue() into two functions. 2020-12-02 16:38:21 +01:00
Aapo
5ed116283c Refactor code in DrawViewDimension::getRefType() shorter and simpler. No functional change except subelement sizes > 3 are supported, even though they are not supposed to happen. 2020-11-19 13:40:42 +01:00
wandererfan
96d296adf8 [TD]change Angle Dim tolerance format 2020-08-22 08:56:57 -04:00
wandererfan
0e4d893651 [TD]missing prefix/suffix for compound schema 2020-06-15 13:57:55 -04:00
wandererfan
db97daf0e0 [TD]expose dimension arrow position to Python 2020-03-02 08:37:19 -05:00
wandererfan
d1d7098ad6 [TD]Support Landmark Dim in Section and Detail 2020-02-25 17:21:00 -05:00
wandererfan
cb2a3d529c [TD]Landmark Dims initial impl 2020-02-25 17:21:00 -05:00
wmayer
7f77b1e6c9 TechDraw: [skip ci] fix -Winconsistent-missing-override 2019-12-29 00:02:15 +01:00
WandererFan
eb46f15159 [TD]fix overload warning 2019-12-27 20:27:19 -05:00
wandererfan
ed6adae509 [TD]fix dim text for multi value schemas 2019-12-05 07:10:08 -05:00
wandererfan
e64929de14 [TD]const-ness for dump function parameter 2019-11-10 15:58:45 -05:00
wandererfan
b34eb9de77 [TD]Implement unique tags for Cosmetic Vertex 2019-11-02 14:59:32 -04:00
wandererfan
b1e61bcae7 [TD]Improve tolerance formatting 2019-10-11 09:16:41 -04:00
Tomas Pavlicek
39518f8dff Complete remake of drawing dimensions 2019-09-25 15:20:14 +02:00
wandererfan
9828655f48 [TD]Add Properties for Cosmetic persistence 2019-07-15 12:36:48 -04:00
wandererfan
fbfdb69c20 [TD]Py Cosmetic Vertex, Line, Circle Arc 2019-07-15 12:36:48 -04:00
wandererfan
8f35f4c956 Add 3Point Angle Dimension 2018-10-02 09:42:16 -03:00
wandererfan
9f6b61a2a9 Add over/under Tolerance to Dimensions 2018-10-02 09:42:16 -03:00
wandererfan
87bad86dd1 Coverity Fixes
- 175807
- 175808
- 183598
2018-08-18 21:59:06 +02:00
wandererfan
fdaf316e9e Add #3337 Arbitrary Dimension 2018-04-25 11:09:39 +02:00
wandererfan
9bcc7da599 Fix exterior angle arc and value 2018-04-25 11:09:39 +02:00
wandererfan
e9eeea9318 Remove duplicate code/save Dim line geom 2018-04-25 11:09:39 +02:00
WandererFan
bdba11d965 Dimension Graphic Properties to Gui side 2018-02-14 15:42:26 -05:00
WandererFan
d9b71fb754 LinkScope clean up 2017-12-31 14:54:05 +01:00
luzpaz
f3bf8fe919 Misc. typos
+ some are doxy others are just comment code.  
+ some minor whitespace and grammatical tweaks. 
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
2017-10-04 17:59:11 +02:00
WandererFan
6d032f1bcf Change links to Global scope 2017-10-02 13:48:45 -03:00
WandererFan
c0cddda862 Use system Decimals, alternate or custom for Dimensions
- Also make Dimension arrowhead size adjustable
2017-09-10 15:25:37 +02:00
WandererFan
15be0f285e Include osifont in TechDraw
- also use PropertyFont instead of PropertyString
2017-09-10 15:23:46 +02:00
WandererFan
974032dd91 Improve handling of broken references (changed Edge/Vertex names) 2017-01-29 19:40:34 -05:00
WandererFan
01e992050f Handle corrupted 2D references 2017-01-29 19:40:33 -05:00
wmayer
2d8e70085e rename 2d tool classes to be consistent with 3d classes 2016-11-21 14:29:51 +01:00
WandererFan
53f0649273 Allow True dimensions to reference multiple Parts 2016-11-07 17:20:20 -05:00
WandererFan
72c8f7332f Dimension fixes
Prevent _M_range_check on wrong selection

Allow unlinking of linked Dimension

Allow Horiz/Vert projected Dims
Improve error msg for invalid selction
2016-10-31 11:06:15 -02:00
WandererFan
7e14ca361c Prepare App side for "show units" preference 2016-10-06 11:00:35 -03:00
WandererFan
f20320d2b7 Implement automatic scaling 2016-08-16 14:29:15 +02:00
WandererFan
498e37b39c Fix dimension highlighting problems
Derived all lines from PrimPath
2016-08-16 14:29:15 +02:00
WandererFan
ff12c020e0 Add vertex-edge dimension 2016-08-16 14:29:15 +02:00
WandererFan
c2feeca805 Add LineWidth property for Dimension lines 2016-08-01 19:27:52 -03:00
WandererFan
7f2b54d48e Fix 0002627 wrong value in dimension
Remove obolete dimension properties
2016-07-21 19:50:38 -04:00
WandererFan
27aafada9c Include file cleanup per cppclean analysis 2016-07-14 14:39:06 +02:00
WandererFan
621d570026 Preserve True/Projected state on save/restore 2016-07-11 15:32:16 +02:00