I'm still finding typos in the source code. I propose that you keep this PR open prior ro relaese and then merge so that if I find other typos in the meantime they will be part this release.
using custom QT pen styles, the center and section lines look much
better.
With some math we are also able to control the middle position, thus
the centerlines will always look good, regardless of the size of an
object.
Also getting the section label size from the settings, so the font
size is controllable and not hardcoded.
Bonus: adding blank templates for the common paper sizes (as the
Drawing WB has them)
- if a scale transform with scale = 0 is passed to
BRepBuilderAPI_Transform, it will loop forever.
If Page.keepUpdated is false, and Views have not yet
been executed (ex at load time), Views will have a
0.0 x 0.0 bbox and if Autoscale is true, a scale of
0.0 will be used in fit-to-page.
- the regex for finding editable text fields in
the svg code of Templates was too strict and
missed some fields if the svg had extra characters
between </tspan> & </text>.
Now on property panel there is option 'Coarse View' which allows to set
selected drawing view's Hidden Line Removal to utilize polygonal algorithm.
This should be faster on same cases (complex models).
When this option is set for a view there is known limitation with dimensions not
working on this experimental mode. At least currently this is best utilized on
view with no dimensions.
Also the vertices' 'black dots' are not drawn on this mode view to avoid
cluttering. Face hilite is avoided, to gain speed. All curves are represented
by short linesegments in this mode.
Previously TechDraw always used OCC's exact HLR algorithm to generate views,
which produces good quality and continous shape lines but is sometimes
slower to generate than with polygonal approach.
Additionally now there is bool 'CoarseView' Parameter Editor setting, if anyone
wants to set this as their default.
- if a Dimension has multiple references to a
DrawViewPart (ex vertex-vertex) the Dimension
will appear twice in the DVP's InList. This
commit ensures that the Dimension is only
deleted once when deleting the DVP.
- when restoring DVD/DVA from old files, convert Source from
PropertyLinkGlobal to PropertyLink with Scope = Global. Note
subtle difference from Restore method in DrawView - PropertyLink
vs PropertyLinkList.
- Add ability to control default weight for visible,
hidden and decorative lines from a configuration
file. Diffent sets of defaults can be specified as
a preference.
+ some are doxy others are just comment code.
+ some minor whitespace and grammatical tweaks.
+ app/SCL/* typos have also been submitted upstream (https://github.com/stepcode/stepcode/pull/366). So it's ok to merge them in to master.
