kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
39,961 Commits 41 Branches 6 Tags
dd4c462199ebe6d668c086ab3dcbc86a7219b60c
Commit Graph

3621 Commits

Author SHA1 Message Date
Roy-043
dd4c462199 Draft: DraftGui.py fix updateSnapper and implement display_point_active 
* The updateSnapper function did not work properly.
* Added display_point_active attribute to prevent the displayPoint function from triggering the changeXValue etc. functions. This would lead to a loss of accuracy as the rounded displayed values would be read from the inputboxes.
 2025-01-22 10:03:36 +01:00
Roy-043
840786ac6c Changed one tooltip as requested 2025-01-21 15:17:03 +01:00
Roy-043
49e960364f Draft: DraftGui.py improve some tooltips 
Avoid 'new point' and 'next point' in tooltips as this does not always apply.
 2025-01-20 20:53:25 +01:00
Roy-043
ddd86bd7b3 Draft: DXF export: add handling of text justification 
Fixes #18964.
 2025-01-20 18:24:30 +01:00
Roy-043
d587e6a91a Draft: make move, rotate and scale commands link-aware (#18795) 
* Draft: make move, rotate and scale commands link-aware

Fixes #12836.
Fixes #15681.

These changes are presented as a single ('big') PR because the mentioned commands have several similarities. Working on them seperately would have made less sense.

The commands have been made 'link-aware' meaning they can now handle Links and objects in linked containers.

This required several changes in the following main files. For each command all options are handled by a single function now (the `move`, `rotate` and `scale` functions). This was the only reasonable solution to correctly handle nested placements. As a result there is no longer a need to build very complex 'cmd' strings in the gui_*.py files (which is a good thing IMO).

Main files:

* move.py
* rotate.py
* scale.py
* gui_move.py
* gui_rotate.py
* gui_scale.py
* gui_trackers.py

The following files have also been updated:

* Draft.py: Imports updated.
* DraftGui.py: If `CopyMode` is changed the ghosts have to be updated. The move and rotate commands now also show previews of movable children. But since those are not copied they should be removed from the ghosts if `CopyMode` is changed to `True`.
* utils.py: Some helper functions have been added. An existing helper function (only used internally) has been renamed.
* gui_utils.py: The `select` function has been updated to accept a list of tuples to allow the reselection of nested objects.
* clone.py: A new property `ForceCompound`, necessary for non-uniform scaling, has been added.
* join.py: The `join_wires` function now returns the resultant wire objects.
* task_scale.py: Updated to allow negative scale factors. Support for `SubelementMode` preference added.
* dimension.py: `transform` methods added.
* layer.py: `get_layer` function added.
* svg.py: Updated to use `get_layer`.
* view_text.py: Instead of two added `coin.SoTransform()` nodes the main transform node is used instead. This was done so that ghosts of Draft Texts can be handled properly without requiring dedicated code in gui_trackers.py.

Notes:

* Support for "App::Annotation" is limited. Only their `Position` is handled (by the move and rotate commands).
* Support for "Image::ImagePlane" has been removed from the scale command. The object has its own calibrate feature (see https://wiki.freecad.org/Std_Import).
* Copies and clones are always created in the global space.

* Fix several unit test issues.

* Reset value that was changed while testing

* Rebase and update test_modification.py

* Reintroduce scaling of image planes
 2025-01-20 18:23:36 +01:00
Roy-043
a66da9b3d2 Merge pull request #19089 from Roy-043/Draft-Clone-avoid-B-spline-faces-in-more-cases 
Draft: Clone: avoid B-spline faces in more cases
 2025-01-16 19:57:08 +01:00
Roy-043
b31ada686f Draft: Clone: avoid B-spline faces in more cases 
B-spline faces can be avoided if the absolute values of the scaling factors are the same. The `transformShape` method can handle this if two additional arguments are provided.
 2025-01-16 13:39:11 +01:00
Roy-043
288f3aad09 Draft: Save fillet settings 
Fixes #16248.
 2025-01-14 21:48:16 +01:00
Yorik van Havre
fe60505c17 Translations (#18923) 
* Updated ts files

* Merged crowdin translations

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2025-01-13 21:30:30 -06:00
Tobias Frost
7a5a3d1ffc spelling fixes (#18688) 
* Fixes spelling of "Allow to" to "Allow one to"

and those variants:
Allows to -> Allows one to
allow to -> allow one to
allows to -> allows one to

* Fix "Let's -> Lets"

(and lower case variant.)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/3rdParty/salomesmesh/inc/MED_Wrapper.hxx

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

* Update src/Base/PyObjectBase.cpp
Update src/App/ExtensionContainer.h
Update src/App/PropertyContainer.h

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

* Use gerund in user-facing texts.

* Use gerund for two more user-facing strings.

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

* Update src/Mod/Fem/App/FemMeshShapeNetgenObject.cpp

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

* Update src/Mod/Fem/App/FemMeshShapeNetgenObject.cpp

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

* Update src/Mod/Fem/App/FemMeshShapeNetgenObject.cpp

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>

---------

Co-authored-by: Tobias Frost <tobi@debian.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2025-01-13 11:22:20 -06:00
Roy-043
27ac5c4277 Draft and BIM: Layer manager did not accept zero transparency 2025-01-10 22:29:03 +01:00
Roy-043
558eb19103 Merge pull request #18949 from Roy-043/Draft-and-Pref-Packs-fix-snapcolor 
Draft (and Pref Packs): fix snapcolor
 2025-01-09 11:31:22 +01:00
Roy-043
38ef33e272 Merge pull request #18942 from Roy-043/Draft-fix-selection-for-FacebinderTaskPanel 
Draft: fix selection for FacebinderTaskPanel
 2025-01-09 11:25:46 +01:00
Roy-043
3b258b6178 Draft: fix axis calculation in make_sketch 
Fixes #18713.

The code follows the suggestion by imm/webmite:
https://forum.freecad.org/viewtopic.php?p=799014#p799014

@webmite Thank you.
 2025-01-09 09:40:33 +01:00
Roy-043
f6f11ac429 Draft (and Pref Packs): fix snapcolor 
Fixes #17978.
 2025-01-08 18:11:42 +01:00
Roy-043
89b95fc938 Draft: fix selection for FacebinderTaskPanel 
See:
https://forum.freecad.org/viewtopic.php?t=93682
 2025-01-08 14:36:07 +01:00
Roy-043
6deb424539 Draft: Closed corners for extruded Facebinders (#18901) 
* Draft: props_changed_placement_only should ignore material props

The new material related properties (Density, Volume and Mass) must be ignored by the `props_changed_placement_only` function.

Without this moving a Draft_Point will fail for example.

* Draft: Closed corners for extruded Facebinders

Fixes #13816.

The `makeOffsetShape` method that creates the extruded shape is quite picky. For example, it will work for a pyramidal shell (4 triangles) with a square floorplan, but not if the floorplan is slightly rectangular. To get closed corners the `Sew` property of the Facebinder must be set to `True`. If extruding does not work properly, the code will retry with `Sew` disabled.

There is also some code that tries to convert flat B-spline faces created between the main offset faces into planar faces. In some cases that code will fail (the results of `makeOffsetShape` can already contain errors). If that is the case the original shape created by `makeOffsetShape` is used.

* Rebase to restore base.py
 2025-01-07 10:23:33 +01:00
Roy-043
f773dfad91 Draft: props_changed_placement_only should ignore material props 
The new material related properties (Density, Volume and Mass) must be ignored by the `props_changed_placement_only` function.

Without this moving a Draft_Point will fail for example.
 2025-01-06 17:23:37 +01:00
Roy-043
b359a2c46c Draft: make_sketch.py: Use sketcher methods to add constraints (#18805) 
* Draft: make_sketch.py: Use sketcher methods to add constraints

A sketch object has its own methods to add coincident, horizontal and vertical constraints. Using those methods allows to simplify the make_sketch.py code. The new code applies the mentioned constraints to the whole sketch,  instead of per object. The old code would not add coincident constraints between seperate, but connected, objects. the new code does.

Note that the code for point objects (not changed in this PR) does not work properly.

* Fix 2 issues

* The Sketcher detect functions need a tolerance argument.
* obj.Shape.copy() does not work properly for a Draft_Point. As a workaround a Part Vertex is created instead.
 2025-01-06 14:56:53 +01:00
Roy-043
19b4470ce9 Draft: comment out 3 test files with only dummy tests 
Some Draft test files contain only dummy tests (`aux.fake_function`). Running them will just open a new file and then immediately close it. This can result in issues with code that is called with a delay. See #18679. Disabling these tests by commenting them out avoids this.
 2025-01-04 12:20:33 +01:00
Roy-043
2b35ad2281 Draft: Minor cosmetic changes to test files 2025-01-03 22:11:05 +01:00
Roy-043
28d177a725 Add another missing import 2025-01-03 20:32:17 +01:00
Roy-043
4ba16cebb7 Add missing import 2025-01-03 20:10:47 +01:00
Roy-043
4d37256877 Update CMakeLists.txt 2025-01-03 19:56:20 +01:00
Roy-043
0bc9737ca6 Draft: Introduce base classes for Draft tests 
To avoid code duplication.
 2025-01-03 16:51:42 +01:00
Roy-043
c7630ac065 Draft: Make test_modification tests independent of fillmode 
Fixes #18315.

In the issue discussion the more obvious solution (change the MakeFace property of the Draft_Wires) was missed.
 2025-01-03 11:38:51 +01:00
Roy-043
9b8b962f56 Draft: Remove unnecessary CamelCase names 
The related functions were introduced in V0.19. They should not be also available under CamelCase names.
 2024-12-26 12:06:29 +01:00
JULIEN MASNADA
bcdfcce95c Improved SweetHome 3D importer (#17165) 
* Fixed access to Addon::Metadat::Url attributes

* Fixed invalid vector in distance calculation

* SH3D importer initial version

* Cleaned up and added baseboard

* Make sure notificationWidth is properly enabled/disabled

* Added furnitureGroup, color prefs, light weight mesh object

* Allow to join walls

* Prepare to join wall, improved status feedback

* Removing trailing white space

* SH3D importer initial version

* Cleaned up and added baseboard

* Make sure notificationWidth is properly enabled/disabled

* Added furnitureGroup, color prefs, light weight mesh object

* Allow to join walls

* Prepare to join wall, improved status feedback

* Removing trailing white space

* fixing tipo, 80 charlines, etc

* Adding a basic import test

* Work in local but fails on pipeline. Commenting out.

* Adding testcase and join wall path

* Use ruled surface to fix failed sweep

* Fixed faces order when joining walls

* Fixed missing sample importer file

* Allow to change pref just before import

* Fixed excessive debug output

* Allow to import from string. Test use embedded string

* Fixed tipo in comment

Co-authored-by: João Matos <joao@tritao.eu>

* Improved door import

Also added coloring for wall section's edges when debuging

* Moved debug init script to FreeCAD-Docker repo

---------

Co-authored-by: João Matos <joao@tritao.eu>
Co-authored-by: Yorik van Havre <yorik@uncreated.net>
 2024-12-20 09:46:39 +01:00
Roy-043
db12b31b76 Draft: Fix handling of coin nodes 
Fixes #18523.
 2024-12-16 18:24:36 +01:00
Syres916
74abfd39d9 [Gui] Show Preferences page by name rather than index 2024-12-16 11:43:13 -05:00
Yorik van Havre
af84424a77 BIM: NativeIFC 2D support - section planes 2024-12-11 10:24:43 +01:00
Yorik van Havre
7913280486 BIM: Support for NativeIFC in BimViews 2024-12-11 09:23:59 +01:00
luzpaz
20d64a7f0f Fix various typos 
Found via `codespell -q 3 -L aci,addmin,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,aply,apoints,ba,beginn,behaviour,bloaded,bottome,brushin,bu,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,documentin,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,findn,fle,freez,graphin,hist,iff,incrementin,indexin,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,leadin,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,renderin,rin,ro,rougly,sectionin,seperator,serie,shs,sinc,siz,som,strack,substraction,te,technic,thist,thru,tread,tru,ue,uint,unter,uptodate,vas,vertexes,vew,wallthickness,whitespaces -S "./.git,*.po,*.ts,*.pdf,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDoc,./tools/build/WindowsInstaller/lang,./src/Mod/TechDraw/Templates/locale"`
 2024-12-10 15:09:51 +01:00
wmayer
0607c555d6 Arch/Draft: Fix transparency vs. alpha issues 
Fix #18295
 2024-12-09 11:50:14 +01:00
Roy-043
28749e44dd Merge pull request #17379 from yorikvanhavre/draft-fix-annotation 
Draft: better check for Gui object
 2024-12-06 18:05:41 +01:00
Roy-043
e28286a2ef Draft: allow point for Trimex extrusion to be co-planar with the face 
Fixes #14826.

If the point for the extrusion height is co-planar with the face, the normal of the face is used for the direction of the extrusion. The user can then enter a positive or negative value in the task panel. It is probably not the ideal solution, but better than what we have now I think.
 2024-12-06 13:10:18 +01:00
Roy-043
6858a1c0b4 Draft: make Trimex extrude mode link-aware 
Fixes #14670.
 2024-12-05 15:53:38 +01:00
Roy-043
672819fd6b Merge pull request #18299 from Roy-043/Draft-change-position-of-Scale-multiplier-field-in-UI 
Draft: change position of 'Scale multiplier' field in UI
 2024-12-05 12:17:38 +01:00
Roy-043
e41ac03bcc Merge pull request #18307 from Roy-043/Draft-Fix-make_point-color-regression 
Draft: Fix make_point color regression
 2024-12-05 11:53:24 +01:00
Roy-043
32fa1f7411 Merge pull request #18212 from Roy-043/Draft-Fix-finish-behavior-of-Draft_Edit-on-doc-close 
Draft: Fix finish behavior of commands on doc close
 2024-12-05 11:52:07 +01:00
Roy-043
270d48b42b Draft: Fix make_point color regression 
PR #12226 accidentally removed the handling of the color argument of the make_point function.
 2024-12-05 08:36:34 +01:00
luzpaz
96c838f3b9 Fix various typos 
Found with codespell
 2024-12-04 23:18:00 -05:00
Roy-043
afdf07717d Draft: change position of 'Scale multiplier' field in UI 
Fixes #16501.
 2024-12-04 19:44:35 +01:00
Roy-043
7a7c042ab8 Draft: Legacy DXF importer: fix layer block behavior (#18129) 
Fixes #16550.
Fixes #16552.

* Layer blocks receive a name with the "LayerBlock_" prefix.
* They are put in a layer if the "Use layer" import option is checked.
* If Draft or Sketch objects are created a Part_Compound instead of a Draft_Block is created. This was done because a Draft_Block does not claim its children. I am not sure about this change. Maybe the behavior of the Draft_Block should be changed instead.

@yorikvanhavre: do you know why a Draft_Block does not claim its children?
 2024-12-04 14:45:55 +01:00
Roy-043
7541371779 Pattern name Diamant -> Diamond 2024-12-02 11:40:01 +01:00
Roy-043
fa65fcce0d Draft: Display default file and pattern in hatch task panel 
Fixes #18197.
 2024-12-02 11:40:01 +01:00
Roy-043
0ae35d6bab Include other Draft commands 2024-11-30 16:48:41 +01:00
Roy-043
e40cab88ad Draft: Fix finish behavior of Draft_Edit on doc close 
Forum topic:
https://forum.freecad.org/viewtopic.php?p=794746#p794746
 2024-11-30 11:47:10 +01:00
Roy-043
0cd5768fbd Draft: Draft_Fillet: fix error in #17945 (#18150) 
* Draft: Draft_Fillet: fix error in #17945

In #17945 the delete option of the command results in an error if subobjects are selected.

* Command should not be available if there is no selection

* Update copyright notice
 2024-11-29 20:37:48 +01:00
Roy-043
1e00d8f898 Merge pull request #18142 from Roy-043/Draft-fix-focus-behavior-of-radius-input 
Draft: fix focus behavior of radius input
 2024-11-29 18:08:20 +01:00