Commit Graph

111 Commits

Author SHA1 Message Date
Benjamin Nauck
dd6aa9f3c7 Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
Mark Ganson TheMarkster
c0210c2d3c [Spreadsheet] fix isValidAlias() (#18567) 2024-12-23 14:18:30 -03:00
mwganson
7d378a7cf5 [Spreadsheet] avoid removing user dynamic properties when clearing cells, addresses issue #8655 2024-11-03 23:03:04 +00:00
Kris Wilk
ffa1189634 Prevent using reserved names for properties or aliases (Fix #16846) (#16902)
* Prevent naming properties with reserved words (Fix #16846)

* Prevent using reserved constant names for properties or aliases

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* App: Add unit test for isTokenAConstant

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-10-03 10:03:10 -05:00
pre-commit-ci[bot]
9d949c60aa [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2024-08-25 07:29:42 +00:00
bgbsww
0178e848e4 Toponaming: Clean code, apply remark recommendations and Tweak tests 2024-07-22 12:55:23 -04:00
bgbsww
5afdc19874 Toponaming: Cleanup 2024-07-21 17:40:42 -04:00
Zheng, Lei
c9232b141a Toponaming: Transfer in getLinksTo 2024-07-21 17:36:50 -04:00
mosfet80
97b5fb68c7 [Mod] Removed unnecessary function (#12772)
* Removed unnecessary function

the "renamedDocumentObjet" function does nothing

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-03-11 12:20:32 -05:00
André Caldas
560898907b Avoids using getNameInDocument() to test if DocumentObject is attached to a Document.
This patch substitutes by isAttachedToDocument() (almost) everywhere where
getNameInDocument() is used for this purpose.

The very few places not touched by this patch demand a (just a little) less trivial change.
When we change the returning type of getNameInDocument() to std::string,
those places will be easily found, because they shall generate a compiler error
(converting std::string to bool).

Rationale:
The fact that getNameInDocument() return nullptr to indicate
that the object is not attached to a document is responsible for lots of bugs
where the developer does not check for "nullptr".

The idea is to eliminate all those uses of getNameInDocument() and, in the near future,
make getNameInDocument() return always a valid std::string.
2023-12-11 17:37:58 +01:00
pre-commit-ci[bot]
222a2520b1 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-12 13:02:35 -04:00
wmayer
159525084d Sheet: Apply clang format 2023-09-10 16:01:37 +02:00
wmayer
0b0f039ef9 Sheet: modernize C++: use default member init 2023-08-23 00:55:03 +02:00
wmayer
a49e104993 Sheet: modernize C++: use range-based for loop 2023-08-15 20:21:20 +02:00
wmayer
d150fa7164 modernize C++: avoid bind
In many cases std::bind() is kept because the code is much simpler
2023-08-08 21:10:16 +02:00
wmayer
68d22d864b modernize C++: move from boost::bind to std::bind 2023-08-08 17:36:13 +02:00
wmayer
96aabe113e modernize C++: raw string literal 2023-08-07 19:51:15 -06:00
wmayer
ca84a0662d Sheet: modernize C++: redundant void arg 2023-08-05 16:50:31 +02:00
luzpaz
d8146c1db8 Spreadsheet: fix header uniformity
+ trailing whitespace
2023-01-22 21:46:17 +01:00
Uwe
ee7e19fac0 [Spread] App: enable precompiled headers 2022-12-08 02:10:46 +01:00
Chris Hennes
4adf5836c7 Spreadsheet: Add getUsedRange() and getNonEmptyRange() 2022-11-10 14:36:54 -06:00
Zheng, Lei
5fcc1c3d03 Spreadsheet: fix cell span handling
When undo/redo, copy/paste, and removing row/column
2022-10-20 16:03:20 -05:00
Zheng, Lei
05e0aba701 Spreadsheet: fix cell span synchronization with SheetTableView
Also, allow merge cell with overlaps, by auto split overlapped cells
first
2022-10-20 16:03:20 -05:00
Uwe
2d50fd36df [Spread] remove unused includes
- also sort includes
- also additions to precompiled header
2022-10-09 20:31:31 +02:00
berniev
d66df602ad App: Single arg ctors must be explicit 2022-08-24 07:20:57 +02:00
berniev
b796a0d376 Mod: use empty 2022-08-06 19:30:13 +02:00
berniev
5f82cfb39f Fix column number calc
(cherry picked from commit 0a8b875751c9469a52548730539dfd4b4fc51acc)
2022-07-27 13:45:33 +02:00
Uwe
003757176c Mod: remove some more superfluous Boolean checks 2022-07-19 02:40:59 +02:00
Uwe
88a06f8f10 Mod: remove some unnecessary nullptr checks 2022-07-18 12:58:12 +02:00
Uwe
5d76afe0a5 re-add some nullptr
to be safe since their removal within assert() or bools might have some impact I don't know
2022-07-18 02:32:36 +02:00
Uwe
ce86b03e0a [Spreadsheet] remove superfluous nullptr checks 2022-07-18 01:49:41 +02:00
mosfet80
620c273c4e Boost version <=1.60 is never used in freecad 0.20 (#7038)
* Boost version 1.60 is never used in freecad 0.20
2022-06-24 02:20:26 +02:00
Zheng, Lei
4d19e611f8 Spreadsheet: fix binding of merged cells 2022-06-12 16:11:59 +02:00
Zheng, Lei
47a5a6302e Spreadsheet: replace obsolete href with hiddenref in binding 2022-06-12 16:11:59 +02:00
Zheng, Lei
e6a6d838a6 Spreadsheet: fix range selection 2022-06-12 13:51:09 +02:00
Zheng Lei
5864e17d9d Spreadsheet: improve range binding feature (#6995)
* Spreadsheet: improve range binding feature
2022-06-08 19:19:41 +02:00
Zheng, Lei
6d6af2dd3b Spreadsheet: add new API PropertySheet::getNonEmptyCells()
To exclude cells without any text content. Used when printing (among
other cases) to skip empty cells.
2022-05-06 08:40:11 -05:00
Zheng, Lei
f8ae185c15 Spreadsheet: improve efficiency when pasting many cells 2022-04-22 12:28:56 -05:00
Zheng, Lei
bc1f5498a9 Spreadsheet: do not copy empty cell
Because pasteCells() will clear empty cells in selected range
2022-04-22 12:28:56 -05:00
0penBrain
2a002e3df6 Sheet: Warn user when cell merge is not done because already merge cells in the range
Partially fixes #6744
2022-04-15 12:14:55 -05:00
Chris Hennes
cb21ac7bf8 Spreadsheet: PR6497 move return statement to new line 2022-03-29 13:25:44 -05:00
Zheng, Lei
8d97b2bcb8 Spreadsheet: fix owner property reference in PropertySheet
PropertySheet used to only work when refereceing its own cell either
through cell address or alias. It does not work for reference to other
property of the owner Spreadsheet object.
2022-03-26 10:19:20 -04:00
wmayer
2c229d3bc0 Spreadsheet: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
andrea reale
36d865df04 fix uninitialized variables 2022-03-01 02:03:44 +01:00
Uwe
b4fff07d9e [App] Expression and Extension: remove unused includes 2022-02-25 18:06:57 +01:00
Zheng, Lei
c14e6b318e Spreadsheet: fix dependency calculation on external spreadsheet 2022-01-23 19:43:53 -06:00
Zheng, Lei
35d7b71466 Spreadsheet: code style change 2021-12-21 21:41:02 -07:00
Chris Hennes
82759f6203 Spreadsheet: Compilation fixes for cherry-picked commits 2021-12-21 21:41:02 -07:00
Zheng, Lei
2a3951ca32 Spreadsheet: change alias handling
No longer add dynamic property for alias, simply rely on
get(Dynamic)PropertyByName() to check for aliases.

Add new API PropertyContainer::getPropertyNamedList() so that
ExpressionCompleter can discover properties with aliases.
2021-12-21 21:41:02 -07:00
Chris Hennes
79cda0a1b7 Spreadsheet: Compilation fixes for cherry-picked commits 2021-12-21 21:41:02 -07:00