Commit Graph

17006 Commits

Author SHA1 Message Date
Abdullah Tahiri
736aa11f6e Sketcher: Internal Transaction Support and ensure valid constraint geometry indices
===================================================================================

On changing the geometry property (for example from Python), the constraints geometry indices was not rebuild in order to avoid
redundant and unnecessary rebuilds. However, this might cause crashes, as the status of the sketch (or its properties) may be invalid.

It also refactors into OnChanged common functionality.

This commit does NOT solve that the user may be inserting invalid geometry indices to the First/Second/Third of Constraints (invalid input).
Only makes sure that geometry indices (geometry types) of PropertyConstraintList match the geometry.

Solution:

1. Force the rebuild of the constraint geometry indices upon assignment of new Geometry.
2. Force the rebuild of the constraint geometry indices upon assigment of constraints, if they result in invalid geometry indices.
3. Introduce the concept of internal transaction to avoid those rebuilds, checks and updates in case of an ongoing internal transaction,
thereby preventing them as it was done before introducing 1 and 2 (in the case of SketchObject internal transactions).
2020-07-01 14:04:25 +02:00
Bernd Hahnebach
3c4c3197c9 FEM: meshtools, better comment 2020-06-30 22:27:24 +02:00
Bernd Hahnebach
82ea30f752 FEM: imports, improvements 2020-06-30 22:27:16 +02:00
Bernd Hahnebach
0065d6b76e FEM: mesh tools, compact mesh, use one id for Edges, Faces and Volumes as SMESH does save it 2020-06-30 19:26:04 +02:00
wmayer
41c481cc9b Fem: [skip ci] handle exception in Fem Constraint in case referenced shape element doesn't exist 2020-06-30 11:34:07 +02:00
Bernd Hahnebach
3a97d68e70 FEM: elmer equation flux, better name without word solver 2020-06-29 22:28:26 +02:00
Bernd Hahnebach
6321f1d8f3 FEM: equation head, change back wrong menue text introduced with fa8c4c618ff2 2020-06-29 21:46:43 +02:00
luz.paz
ef37cc3930 Fix typos [skip-ci]
Found via codespell v1.18.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-06-29 20:52:23 +02:00
Bernd Hahnebach
096ec69fb3 FEM: elmer writer, fix unit test 2020-06-29 20:21:56 +02:00
Bernd Hahnebach
6912557ee4 FEM: elmer writer, better messages and code formating 2020-06-29 20:21:51 +02:00
HoWil
520b69bdb7 FEM: elmer writer, add scaling and revert scaling only for m/kg/s unit schema 2020-06-29 20:21:51 +02:00
HoWil
3b9422d52d FEM: elmer writer, export meter based units for scaled m-based simulation 2020-06-29 20:21:49 +02:00
Bernd Hahnebach
1432635013 FEM: constant vacuum permittivity, implement in elmer writer 2020-06-29 17:46:43 +02:00
Bernd Hahnebach
84aba55ea8 FEM: constant vacuum permittivity, add object to overwrite constant 2020-06-29 17:46:43 +02:00
sliptonic
1b643536b9 Merge pull request #3657 from Russ4262/MillFace_fix
[Path] MillFace - Fix calculation of OpFinalDepth default value
2020-06-29 09:54:04 -05:00
sliptonic
2c74dd8e28 Merge pull request #3645 from Russ4262/BaseGeomList_resize
[Path] Resize the Base Geometry list dynamically
2020-06-29 09:53:18 -05:00
sliptonic
73b56a6e25 Merge pull request #3653 from etrombly/opsegfault
[PATH] fix segfault when disabling ops
2020-06-29 09:52:36 -05:00
Bernd Hahnebach
b457adc0ae FEM: examples manager, typo 2020-06-29 08:08:34 +02:00
Bernd Hahnebach
7138420c91 FEM: objects make, add TODO comment 2020-06-29 08:08:25 +02:00
Bernd Hahnebach
5be1bde753 FEM: object add module, small comment fix 2020-06-29 08:08:11 +02:00
Bernd Hahnebach
e602c822ff FEM: elmer equation objects, improve object creation 2020-06-29 08:08:04 +02:00
Eric Trombly
74ef899a75 check if pcLineCoords is empty 2020-06-28 19:52:59 -05:00
Eric Trombly
031a3d0816 fix null reference 2020-06-28 19:52:59 -05:00
wmayer
dc551e1fb0 Spreadsheet: [skip ci] avoid to show scroll buttons in PropertiesDialog when a style sheet is used 2020-06-28 18:24:16 +02:00
wmayer
4fc5655657 Part: [skip ci] fix regression in ruled surface feature by applying placement of source object twice
See: https://forum.freecadweb.org/viewtopic.php?p=411934
2020-06-27 23:17:32 +02:00
Russell Johnson
22bc65b54c Path: Resize the Base Geometry list dynamically
Make the size of the Base Geometry list dynamically adjust to its contents.
2020-06-27 15:05:00 -05:00
Russell Johnson
ebc1a42880 Path: Fix calculation of OpFinalDepth default value
Remove commented lines.
Modify PathLog.Level assignment for easier readability.
2020-06-27 09:36:14 -05:00
Bernd Hahnebach
76c0391bcd FEM: examples manager, delete depreciated code 2020-06-26 11:26:42 +02:00
Sudhanshu Dubey
2dcfdd98d0 FEM: examples manager, add generic method to run examples 2020-06-26 10:57:07 +02:00
Bernd Hahnebach
afdb767302 FEM: constants, typo 2020-06-26 09:11:41 +02:00
Bernd Hahnebach
2ee915a00c FEM: elmer writer, better identifier in a method 2020-06-26 08:51:42 +02:00
Bernd Hahnebach
a68b6d8e58 FEM: flake8 2020-06-26 08:17:30 +02:00
Bernd Hahnebach
4be8bdf7c1 FEM: flake8 2020-06-25 18:08:53 +02:00
Yorik van Havre
5bf1eee0a1 Arch: Small code optimizations to the multicore IFC importer 2020-06-25 15:38:31 +02:00
Kisolre
f3972e6fff Fix for changed Github url links being relative instead of absolute. 2020-06-25 15:07:50 +02:00
Yorik van Havre
ec6ea813c5 Arch: New multicore IFC importer 2020-06-25 14:42:38 +02:00
Bernd Hahnebach
1df612b57c FEM: code foramatting, line length 2020-06-25 11:58:45 +02:00
Bernd Hahnebach
4702efc3ff FEM: elmer, better print and log 2020-06-24 18:02:47 +02:00
vocx-fc
e36986de30 Arch: add missing translate function
The code was moved to a separate module, `ArchWindowPresets.py`,
in 4f203f8757, but the `translate` function was not imported
in this new module.
2020-06-24 11:31:26 +02:00
paul lee
6179f4b45a [ArchWall] Revert comments in getExtrusionData() 2020-06-24 11:29:07 +02:00
paul lee
999c3d8bf4 [ArchWall] ArchWall Offset should now works with Base as Sketch 2020-06-24 11:29:07 +02:00
Bernd Hahnebach
40fccdcbc8 FEM: ccx constraint section print, add unit test 2020-06-24 09:22:09 +02:00
Bernd Hahnebach
3a2485033a FEM: examples, section print, fix to setup on cmd mode 2020-06-24 09:22:01 +02:00
UR-0
fc04645402 FEM: ccx constraint section print, add task panel 2020-06-24 07:52:16 +02:00
UR-0
346faafd6b FEM: ccx constraint section print, add Gui command and icon 2020-06-24 07:52:16 +02:00
Sudhanshu Dubey
128819d9ff FEM: examples, add section print 2020-06-24 07:52:16 +02:00
UR-0
f5b235c47b FEM: ccx constraint section print, implement in ccx writer 2020-06-24 07:52:16 +02:00
UR-0
337c935f20 FEM: ccx constraint section print, add object 2020-06-24 07:52:16 +02:00
wandererfan
94e5f205ee [TD]CosmeticVertex default size 2020-06-23 08:21:13 -04:00
wmayer
312e98d003 OpenSCAD: [skip ci] fix missing treeview icon 2020-06-23 12:34:25 +02:00