Commit Graph

1943 Commits

Author SHA1 Message Date
donovaly
dff561a1b0 [PD] UI file fixes
the rotation angle settings of primitives had a different layout than the other parameters, this things like shown in the image below happened.

- The PR uniforms all layouts to grid and for the PD layout
- it sets for the cylinder page a minimum width
- the PD UI file is now also sorted using David's file sorter
- fix the mess with stdset="0"> I accidentally introduced with the merges from yesterday (I simply forgot to install to Qt designer the FreeCAD widgets and then designer pollutes the file with these tags for all FC-specific widgets since it doesn't know them
2021-04-06 13:17:43 +02:00
donovaly
d26e7500ab [Part] [skip ci] add a word in description
since we have now 3 angles for cylinders, make clear the angle property is for the rotation
2021-04-06 11:39:51 +02:00
donovaly
c0e6debcfa [Part] add direction to cylinder primitive
We already have the possibility to create skewed prisms. I recently stumbled upon that I would need this feature for cylinders too.

This PR takes the existing prism extrude direction feature and use it for cylinders too
2021-04-05 13:59:03 +02:00
wmayer
57d2a2fae0 Part: for Prism feature use PrismExtension 2021-04-05 13:25:19 +02:00
wmayer
84c5d22ccb Part: implement Prism as extension 2021-04-05 13:05:59 +02:00
Chris Hennes
00d9dd965f [Part] Remove deprecated Qt < 5.9 code 2021-04-01 19:36:40 +02:00
donovaly
bedd22a662 [Part] save more icons with uniform resolution
- also save them as plain SVG to get rid of sometimes deprecated Inkscape-only stuff
2021-03-29 16:21:59 +02:00
donovaly
0490e33667 [Part] save icons with uniform resolution
- also save them as plain SVG to get rid of sometimes deprecated Inkscape-only stuff
2021-03-28 16:02:28 +02:00
flachyjoe
80a3aa8eaa format TopoShapeWirePy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
44f6b670a8 format TopoShapeSolidPy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
7111e137a1 format TopoShapeShellPy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
37764982bd format TopoShapeEdgePy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
c09093a079 format TopoShapeCompoundPy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
f9af6e8ea3 format TopoShapeCompSolidPy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
5f01c7559e format TopoShapeFacePy.xml 2021-03-28 15:36:36 +02:00
flachyjoe
88c27d502e fix some missed lines 2021-03-28 15:36:36 +02:00
flachyjoe
f94b3c3f58 Improve Part.Shape methods documentation
Formats UserDocu to follow the template:
 Description
 method(args) -> return
 --
 More infos
2021-03-28 15:36:36 +02:00
luz paz
15c16610c8 fix source comment typos [skip ci]
Found via  codespell v2.1.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu
```
2021-03-28 10:57:24 +02:00
donovaly
b63102fae8 [Part] change icon to math the other Part icon scheme
The other Part icons have red lines indicating wires, only the new make faces ion does not. The PR changes this to use the same for all icons.
2021-03-25 18:11:49 +01:00
donovaly
5db4fb767c [Part] uniform feature sorting
at the moment the sorting is confusing, the sorting in the menu differs from the toolbars and some features even belong in the menu to another category than in the toolbars and one feature has not yet a toolbar entry

This PR implements a uniform sorting for the menu and toolbar and adds the missing toolbar icon
2021-03-25 18:04:35 +01:00
bitacovir
b6e81c1821 [UI] Replace Bitmap icon of Part_PointsFromMesh command 2021-03-25 17:42:26 +01:00
Abdullah Tahiri
2afcbff0d6 Part: Geometry - Add function to trim a B-Spline
================================================

Supports both non-periodic and periodic case
2021-03-21 06:56:23 +01:00
Abdullah Tahiri
595fc118e3 Part: Part2DObject::seekTrimPoints rename parameters
====================================================

This function takes parameters named GeoId, which evoke the Sketcher GeoId and which
indeed are used by the sketcher. However, these indices are just indices of the provided
geometry list. Therefore:
1. The are never negative (no matter if a corresponding Sketcher GeoId is external or not).
2. They do not have reserved indices for axes.
3. Most importantly, not found GeoId1 and GeoId2 are coded as -1, which for the Sketcher has
a well defined meaning (axis), whereas the Sketcher uses Constraint::GeoUndef as undefined or
not present/ not found index, which currently is -2000.

For these reasons, it was judged appropriate to rename the parameters and documentation to
emphasise that this function is unrelated and dettached from any Sketcher knowledge, and that
indices are just normal indices of a vector.
2021-03-21 06:56:23 +01:00
wmayer
4561deb4fa Part: [skip ci] implement makeShellFromWires 2021-03-16 16:01:43 +01:00
tomate44
839b96385c Part: fixes and check input values for spiral and helix primitives 2021-03-10 14:24:01 +01:00
tomate44
97543396c5 Part primitives: add SegmentLength property to helix and spiral 2021-03-10 14:23:16 +01:00
tomate44
6f9856bd46 Part primitives: use makeSpiralHelix in spiral and helix primitives 2021-03-10 14:22:04 +01:00
tomate44
18f36c10da TopoShape: add a common function to build spirals and helixes 2021-03-10 14:18:12 +01:00
Benjamin Nauck
f6c9cc90ee [Base] Remove includes to StdStlTools.h as that's not needed anymore
std::make_unique was introduced in c++14, so no need to use the back
ported version
2021-03-06 21:20:32 +01:00
Benjamin Nauck
afb1d0fbc9 [Path] Switch from boost::tuple to std::tuple
It's better to use the standard lib when possible
2021-03-06 19:31:06 +01:00
wmayer
f85478155b Revert "[PartDesign] Add Material property to Body"
This reverts commit 4fcf8f199c.

There is no need to make this a static property because it can be added at runtime via Python or the GUI
2021-03-04 18:50:57 +01:00
howetuft
4fcf8f199c [PartDesign] Add Material property to Body 2021-03-04 12:19:50 +01:00
wmayer
89b094683f Gui: support to customize the font size of bounding boxes 2021-03-02 16:29:57 +01:00
David Osterberg
43bc30da84 Beautify xml step 1: These changes do not affect the uic output 2021-03-02 16:29:11 +01:00
Chris Hennes
a432480e8d [Part] Fix signature of TempoVis dummy function
If the import of TempoVis fails, TaskAttachmentEditor creates s dummy
function to replace the real TempoVis function. That function's
signature did not match the real TempoVis. Caught by LGTM.
2021-02-27 18:21:05 +01:00
Yorik van Havre
958009c2ca Merged crowdin translations 2021-02-25 13:27:48 +01:00
Yorik van Havre
5ba28fa7ff Merged crowdin translations 2021-02-24 18:07:59 +01:00
wmayer
1d412261d6 Part: [skip ci] Fix coverity warning
Coverity warnings fixed:

CID 316522 (#2 of 2): Uninitialized scalar variable (UNINIT)
5. uninit_use_in_call: Using uninitialized value newSelection. Field newSelection.shapeType is uninitialized when calling push_back
2021-02-21 16:06:59 +01:00
wmayer
d4333072a9 Part: [skip ci] add missing expression bindings to tube dialog 2021-02-21 15:20:12 +01:00
luz paz
110860fa47 Part: Part.CompoundTools.Explode.explodeCompound access a property of...
...a sometimes null object with an error

Python code, file `src/Mod/Part/CompoundTools/Explode.py`
The `explodeCompound` function can be called in a context without assigning the `ViewObject` property, for example from a command line script.

The error that is fixed by this patch. 
```
Traceback (most recent call last):
  ...
  File "/opt/freecad/Mod/Part/CompoundTools/Explode.py", line 23, in explodeCompound
    cf.ViewObject.DontUnhideOnDelete = True
AttributeError: 'NoneType' object has no attribute 'DontUnhideOnDelete']
```

Patch submitted by marioamb.  
Fix #004421  
https://tracker.freecadweb.org/view.php?id=4421
2021-02-21 11:40:20 +01:00
donovaly
9fb381b716 [Part] fix regression in location dialog layout
For some reason the horizontal alignment got broken. This PR replaces the different grids with each on grid per groupbox
2021-02-21 11:36:13 +01:00
wmayer
7405dd0ef9 PD: [skip ci] fixes #0004573: missing bindings to expressions in primitives location dialog 2021-02-20 20:04:37 +01:00
donovaly
dd4874d2b6 [Part] add missing bindings
For FC 0.19 we added bindings to the PD primitives but we forgot the Part primitives
2021-02-20 20:02:09 +01:00
Abdullah Tahiri
324f6d3e26 Part: Geometry - BSpline - fix weight assignment
================================================

If during assignment of weights (during the for loop iteratively setting the poles) all weights
become (temporarily) equal even though weights does not have equal values
OCCT will convert all the weights (the already assigned and those not yet assigned)
to 1.0 (nonrational b-splines have 1.0 weights). This may lead to the assignment of wrong
of weight values.

The work-around is to temporarily set the last weight to be assigned to a value different from
the current value and the to-be-assigned value for the weight at position last-to-be-assign but one.

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=478701#p478702
2021-02-18 17:28:38 +01:00
David Osterberg
dac937ae35 Part: Allow helix primitive with negative Angle 2021-02-14 11:53:34 +01:00
Yorik van Havre
84b8282f48 Updated ts files 2021-02-12 14:47:37 +01:00
wmayer
d7ad20acdd Part: [skip ci] code-refactoring in DlgPrimitives class 2021-02-12 12:41:45 +01:00
Chris Hennes
3ef6e1c6d0 [OTHER] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Chris Hennes
46a899c437 [Part] Coverity: dtors can't throw 2021-02-09 23:58:09 +01:00
Yorik van Havre
bcb5c8786f merged crowdin translations 2021-02-09 16:12:18 +01:00