Commit Graph

191 Commits

Author SHA1 Message Date
wandererfan
569fe3b007 [TD]fix angle dim in detail view 2025-11-05 12:46:35 -06:00
Markus Reitböck
63ab3de853 TechDraw: use CMake to generate precompiled headers on all platforms
"Professional CMake" book suggest the following:

"Targets should build successfully with or without compiler support for precompiled headers. It
 should be considered an optimization, not a requirement. In particular, do not explicitly include a
 precompile header (e.g. stdafx.h) in the source code, let CMake force-include an automatically
 generated precompile header on the compiler command line instead. This is more portable across
 the major compilers and is likely to be easier to maintain. It will also avoid warnings being
 generated from certain code checking tools like iwyu (include what you use)."

Therefore, removed the "#include <PreCompiled.h>" from sources, also
there is no need for the "#ifdef _PreComp_" anymore
2025-09-23 00:50:59 +02:00
WandererFan
009754581e [TD] fix small angle dims (fix #21114) (#21208)
* [TD]fix handling of very small angle dimensions

- also remove test for too small format specifier

* [TD]lint messages

* [TD]apply review comments.
2025-05-26 17:19:19 +02:00
bofdahof
ba2c2ca5ad Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
Kacper Donat
b999ce0336 TechDraw: Use freecad_cast whenever possible 2025-04-26 14:23:25 +02:00
Benjamin Nauck
738bc95fa2 TechDraw: Add #include <limits> where used 2025-03-31 23:53:03 +02:00
Benjamin Nauck
cf94011294 Techdraw: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:39 +01:00
captain0xff
13d31711f3 remove gp_* conversion code from TechDraw workbench 2025-03-11 05:21:58 +05:30
Benjamin Bræstrup Sayoc
e92efb14ac Remove magic number and hard type enums in DrawViewDimension.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc
c53679422b Remove magic numbers and hard type enums in DimensionFormatter.h.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-17 12:16:49 -05:00
Benjamin Bræstrup Sayoc
97b34f9c57 Remove magic number and hard type enums in Geometry.h
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-02-17 12:16:49 -05:00
Benjamin Bræstrup Sayoc
9f8f6b1f56 [TechDraw] Use templates instead of duplicate code: toGp 2025-02-08 22:35:57 +01:00
Chris Hennes
143edf737a Merge pull request #19232 from WandererFan/miscSmallFixes
[TD]minor fixes x3
2025-02-03 17:54:20 +01:00
Benjamin Nauck
6f535f19fb Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
wandererfan
2bc9f2ea1f [TD]allow showing units on individual dimensions 2025-01-24 13:04:00 -05:00
WandererFan
f144a87539 [TD]Long and link dim refs (fix #13375) (#18641)
* [Meas]Changes for TD dimension refs for links

* [TD]App changes for dim refs to links

* [TD]Gui changes for dim refs to links

* [TD]fix 2 lint messages

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-12-23 17:36:22 -05:00
Benjamin Bræstrup Sayoc
e025b1bfe2 [TechDraw] Translations and grammer (#16301)
Co-authored-by: WandererFan <WandererFan@gmail.com>
2024-12-02 12:27:39 -05:00
wandererfan
2ff1a2b6de [TD]fix area calculation 2024-11-25 17:49:21 +01:00
wandererfan
17e9f10ca7 [TD]throttle over aggressive dimension autocorrect 2024-10-14 17:45:53 +02:00
WandererFan
a2c3a1a542 [TD]Fix auto correct msg missing16892 (#16909)
* [TD]fix bad return code on auto-correct fail

* [TD]prevent changing references in property editor

- this is a "shoot yourself in the foot" practice
2024-09-30 18:20:47 +02:00
wandererfan
3d0e22c489 [TD]fix dim text wrong side of dim line (fix #16172) 2024-09-02 18:24:16 +02:00
PaddleStroke
d09fb588f4 Techdraw: area dimension: fix scale issue. 2024-06-10 08:28:36 -04:00
wandererfan
e72c63e98a [TD]fix autocorrect handling of older documents 2024-05-21 14:14:16 -04:00
wandererfan
40befa8708 [TD]fix #13992 - compile warnings 2024-05-17 18:07:25 -04:00
PaddleStroke
41650a78d4 TechDraw: Implement 'Area' dimension. 2024-05-06 18:42:28 +02:00
wandererfan
5c8b216567 [TD]fix dimension autocorrect
- autocorrect was not handling scaled and rotated reference geometry
  properly.
2024-05-05 20:38:14 -04:00
wandererfan
301d928cba [TD]fix BrokenView dimensions 2024-04-15 19:59:22 -04:00
wandererfan
43fc04309a [TD]implement BrokenView 2024-04-06 15:25:23 -04:00
wandererfan
e64af14325 [TD]fix fail on corrupt dimension reference 2024-04-03 08:48:39 -04:00
wmayer
48ff9ad3a1 [TD]Refactor LTNP correction code for Dimensions
- additional geometry types

- add method to handle line like bsplines

- handle deleted ref body feature

- add test for empty savedGeometry

- add switch for matcher/LTNP on/off
2024-03-17 08:56:34 -04:00
wandererfan
c94a419eac [TD]fix over/under tolerance
- left justify tolerances
- use format spec for tolerance == zero
- prevent uncommanded tolerance format changes
- use 'w' format for HoleShaftFit
- allow zero tolerance values for HoleShaftFit
2024-03-14 21:45:16 -04:00
wandererfan
e23b13b8d7 [TD]fix Dimension icons 2024-01-12 09:23:38 -05:00
wandererfan
c40f01ae57 [TD]mute dimension autocorrect warning 2023-12-24 12:27:25 -05:00
wmayer
f0d350f60d TD: fix -Wsign-compare 2023-10-11 15:12:42 +02:00
Florian Foinant-Willig
2d27b84686 TechDraw: fix extension lines of projected dimension 2023-10-02 13:53:01 -04:00
Florian Foinant-Willig
ed87ce0af0 TechDraw: Implements projected Length dimension 2023-10-02 13:53:01 -04:00
wandererfan
2d72806e29 [TD]Fix no dimensions from old document (#10880) 2023-10-02 09:39:27 -04:00
wandererfan
2f069bb94f [TD]fix missing reference geometry 2023-09-28 09:01:39 -04:00
wandererfan
39919200f2 [TD]handle BSpline "lines" in GeometryMatcher 2023-04-22 13:49:10 -04:00
Benjamin Bræstrup Sayoc
5d05acc87e [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
wandererfan
181c7ba5eb [TD]fix bad 3d dimensions
- mapToPage was left in place when converting to using
  projectPoint instead of projectToPlane.
2023-03-25 18:14:26 -04:00
wandererfan
354480e9a4 [TD]Lint/Tidy/Review comments applied 2023-03-22 20:09:35 -04:00
wandererfan
8a11528a7e [TD]corrupt dim reference detect and correct 2023-03-22 20:09:35 -04:00
wandererfan
704fb894a5 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
Uwe
c947055821 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
wandererfan
97b6788464 [TD]fix wrong calculation of 3d two edge angle 2023-01-07 16:32:03 -05:00
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
02386e3150 [TD]move makeAlignedPieces to separate thread
- correct ComplexSection rotation

- fix fail to load CS for some profiles and directions
2022-12-18 09:42:42 -05:00
wmayer
a7dc5c23e4 TD: replace QRegExp with QRegularExpression 2022-10-08 13:33:10 +02:00