Commit Graph

2019 Commits

Author SHA1 Message Date
Chris Hennes
823ebacbf9 [Sketcher] Refactor split code
LGTM complains about using continue statements inside a loop
whose condition is always false. In addition, the C++ core guidelines
recommend against using the do...while construct, and in this case it
was really serving as a goto, just hiding the actual goto keyword.
This commit replaces the loop and continue structure with simple
conditionals.
2021-09-17 23:43:12 +02:00
luz paz
e72da8babd Sketcher: fix mislabeled .ui cstring tag
Closes https://github.com/FreeCAD/FreeCAD-translations/issues/59  
Thanks @jakub-swierk for the patch!
2021-09-08 10:21:43 -04:00
Yorik van Havre
89e1a97d80 Merged crowdin translations 2021-09-07 11:26:48 +02:00
Yorik van Havre
d14167a50d Updated ts files 2021-09-06 15:32:07 +02:00
Yorik van Havre
63d77e003b Merge pull request #4945 from 0penBrain/sk3ptCircle
[Sketcher] 3-pt circle : allow tangent constraint for any click
2021-09-01 16:24:46 +02:00
Dirk Olbrich
3cb9f522a7 Sketcher: display dimensional constraint name
- checkbox in sketcher settings ui to display dimensional constrain name
- option to format dimensional presentation string
2021-09-01 10:27:42 +02:00
Yorik van Havre
49abe81271 Merged crowdin translations 2021-08-26 14:51:36 +02:00
luz paz
eab17ddff5 Fix various typos 2021-07-31 09:46:50 +02:00
0penBrain
cd92f3a8df [Sketcher] 3-pt circle : allow tangent constraint for any click 2021-07-28 14:21:55 +02:00
Yorik van Havre
1cee70cd62 Merged crowdin translations 2021-07-08 16:06:38 +02:00
Yorik van Havre
ed9dca288c Merged crowdin translations 2021-07-01 13:56:25 +02:00
luz paz
39b44b1570 Sketcher: FIx typos in source comments [skip ci] 2021-06-29 20:07:30 +02:00
Yorik van Havre
c8b5d8d762 Merged crowdin translations 2021-06-24 17:22:19 +02:00
Yorik van Havre
aa862254dd Updated ts files 2021-06-24 17:18:01 +02:00
donovaly
438895a3be [Sketch] fix menu entry wording
all other menu entries use lower case letters, thus do so also for the new tool
2021-06-21 13:56:23 +02:00
donovaly
4071a13310 [Sketch] change slot icons
change the slot icons to reflect the new selection/definition behavior
2021-06-21 13:56:03 +02:00
donovaly
471e143d09 [sketch] rework the slot command
In practical work it turned out that the slot command is not as convenient as it should because one cannot snap to a proper endpoint and one is restricted to work perpendicular to the sketch axes

This PR fixes this by setting the second snap point to the center of the second arc and removing the perpendicularity.

Benefits:

    when you want to get the slot at a line, edge or sketch axis, set the two center points accordingly. The line does not have to be parallel to one of the sketch axes
    when you want to define the slot using 2 points in the sketch you can do this now
2021-06-20 19:27:58 +02:00
donovaly
198aa4c564 [Sketch] save new icons as plain SVG 2021-06-20 19:06:43 +02:00
donovaly
3559710da6 [Sketch] fix these issues:
- missing menu entry for centered rectangle
- typo
- uniform word casing
- duplicated accel key
- remove superfluous comment
2021-06-20 19:06:09 +02:00
Abdullah Tahiri
b7f8f249b2 Sketcher: Add centered rectangle to the menu 2021-06-20 08:24:02 +02:00
Abdullah Tahiri
0fb621af28 Sketcher: Update icon resources 2021-06-20 08:23:31 +02:00
Abdullah Tahiri
cead3808aa Sketcher: centered rectangle icons 2021-06-20 08:23:01 +02:00
Abdullah Tahiri
8b4acf11c2 Sketcher: Centered Rectangle Creation 2021-06-20 08:14:18 +02:00
Abdullah Tahiri
7c519689f0 Sketcher: Reorder rounded rectangle code next to normal rectangle code 2021-06-20 07:07:22 +02:00
donovaly
27c72da585 [Sketch] update icons - part 4 of 4
save icons with uniform DPI and as plain SVG
2021-06-20 06:43:25 +02:00
donovaly
4c795098e2 [Sketch] update icons - part 3
save icons with uniform DPI and as plain SVG
2021-06-20 06:42:21 +02:00
donovaly
4d2cd6c205 [Sketch] update icons - part 2
save icons with uniform DPI and as plain SVG
2021-06-20 06:41:20 +02:00
donovaly
e5aab6c124 [Sketch] update icons - part1
save icons with uniform DPi and as plain SVG
2021-06-20 06:40:35 +02:00
Abdullah Tahiri
4727dd0de2 Sketcher: Resources updated manually 2021-06-20 06:33:17 +02:00
Abdullah Tahiri
725d9db95b Sketcher: Remove axes alignment icon 2021-06-20 06:32:51 +02:00
Abdullah Tahiri
9b34d671e0 Sketcher: UI toolbar/menu remove axes alignment 2021-06-20 06:16:33 +02:00
Abdullah Tahiri
be153ae2d9 Sketcher: Python wrappers for new remove axes alignment algorithm 2021-06-20 06:16:21 +02:00
Abdullah Tahiri
3c593a33ce Sketcher: Remove Axes Alignment algorithm 2021-06-20 06:16:11 +02:00
donovaly
01d2f6298f [Sketch] add new sketch object rounded rectangle
while constructing I miss often that one cannot insert directly rounded rectangles. As it is, one needs first to insert a rectangle, then go to fillet mode, then click 4 times, then set equal constraint, then often also replace the vertical/horizontal constraints since a rectangle must not necessarily be parallel to a sketch axis

As solution this PR adds rounded rectangles in one step. This saves a lot of time since this object is e.g. often used for milled rectangular pockets, for 3D-printed pads etc.

As discussed I grouped the rectangle and rounded rectangle.
2021-06-20 06:14:24 +02:00
Abdullah Tahiri
9073517291 Sketcher: Default parameter to meaningful value 2021-06-19 13:56:18 +02:00
0penBrain
70d90584ae [Sketcher] Remove no more used preference 2021-06-19 13:45:53 +02:00
0penBrain
dfc975dd93 [Sketcher] Radiam is default tool for radius/diameter constraining
Default is no more an option but last used tool is remained for next session
2021-06-19 13:45:53 +02:00
0penBrain
eda1e4b1df [Sketcher] Radiam : fix bug in constraint processing 2021-06-19 13:45:53 +02:00
Yorik van Havre
69b084f492 Merged crowdin translations 2021-06-17 16:04:02 +02:00
Yorik van Havre
7c5f8d8737 Updated ts files 2021-06-17 15:49:33 +02:00
wmayer
4de2ad46b2 Sketcher: replace or keyword with || as it's not supported by all compilers 2021-06-13 11:02:27 +02:00
0penBrain
1645cc0c28 [Sketcher] Radiam : add icons 2021-06-12 07:07:28 +02:00
0penBrain
2ef1516121 [Sketcher] Radiam : add specific management for Bspline poles 2021-06-12 07:07:28 +02:00
0penBrain
ea1e6595b5 [Sketcher] Radiam : make the command basically usable into Gui 2021-06-12 07:07:28 +02:00
0penBrain
74cfdb57af [Sketcher] Introduce 'Radiam' command that auto set radius or diameter constraint based on geom type
Radius is applied in arcs and BSpline poles
 Diameter is applied on complete circles that aren't BSpline poles
2021-06-12 07:07:28 +02:00
Yorik van Havre
4a9963a03f Merged crowdin translations 2021-06-10 12:24:24 +02:00
Yorik van Havre
5739d6eb7c Updated ts files 2021-06-10 11:48:18 +02:00
0penBrain
85f37a1dbc [Sketcher] Fix 'Reference' checkbox not working for diameter 2021-06-06 07:12:38 +02:00
Yorik van Havre
fb8b21ec43 Updated ts files 2021-06-04 18:30:30 +02:00
0penBrain
e02902cfa2 [Sketcher] Fix 'Reference' checkbox not working for radius/diameter ; fixes #4627
As a consequence :
Remove message box when several arcs/circles are selected ...
... and enforce creation of equality constraints in this case
Former existing option of adding a dimensional constraint ...
... to each circle encouraged improper constraining
2021-06-04 06:12:51 +02:00