Commit Graph

24398 Commits

Author SHA1 Message Date
Ajinkya Dahale
e25896df37 [Sketcher] Prevent dereferencing nullptr in ConstraintView
Fixes #8104.

As described in that issue, a crash happens under the following
conditions:
1. A `DrawSketchHandler` is active.
2. No constraint is selected.
3. Context menu on the `ConstraintView` is triggered.
2023-01-13 15:06:39 +01:00
wmayer
a24323767f Arch: [skip ci] fix typos 2023-01-13 13:30:59 +01:00
Yorik van Havre
cee14a6dd7 Merge pull request #8122 from Roy-043/Arch-improve-context-menus
Arch: improve context menus
2023-01-13 11:48:57 +01:00
Yorik van Havre
858abcdd25 Merge pull request #8081 from Roy-043/Draft-Fix-inconsistent-properties-of-Draft-annotations
Draft: Fix inconsistent properties of Draft annotations
2023-01-13 11:47:00 +01:00
Yorik van Havre
df4f9b9c59 [Draft] Add Units Selector to Status Bar 2023-01-13 11:41:55 +01:00
Roy-043
5ed8c47cac Arch: improve context menus (rebase 2) 2023-01-12 23:10:43 +01:00
Roy-043
172f6c17a7 Arch: improve context menus (rebase) 2023-01-12 22:54:09 +01:00
Roy-043
494a08f3f8 Arch: ArchSectionPlane should update SVG in execute (#8175) 2023-01-12 20:23:54 +01:00
wmayer
62260a9ad4 Gui: [skip ci] fix some warnings reported by GH actions 2023-01-12 17:51:50 +01:00
0penBrain
2eb8c6cc9f AddonMgr: switch pref entry/path to const string 2023-01-12 09:24:03 -07:00
wmayer
3f615bbe05 Gui: fix possible problems with new style connect
* In UIntSpinBox rename the signal to not overwrite the signal of the base class
* In UIntSpinBox use the (ambiguous) signal 'valueChanged' of the base class QSpinBox
* To avoid that connect() fails use the function pointer of the Qt class where the signal is defined
2023-01-12 17:02:59 +01:00
Roy-043
b5a44e6f73 Draft: housekeeping: indentation gui_snapper.py
As mentioned here: #8172
2023-01-12 16:04:31 +01:00
Roy-043
dfb5f5de4b Draft: Properly remove Snap toolbar when switching workbenches (#8172) 2023-01-12 15:29:21 +01:00
Roy-043
0930544c21 Arch: fix ArchSectionPlane getSceneGraph problem (#8171) 2023-01-12 15:28:00 +01:00
Uwe
5ad737ccdc [Gui] modernize some connect() settings
- addresses #6166
2023-01-12 15:13:16 +01:00
luzpaz
0410dc8f4d Spreadsheet: [skip ci] convert tabs to spaces
Minor housekeeping fix
2023-01-12 14:08:33 +01:00
Roy-043
8a3b45ca73 Draft: improve wires.isReallyClosed (#8167) 2023-01-12 10:25:48 +01:00
Roy-043
0e517b0e19 Draft: improve offsets.offsetWire (#8166) 2023-01-12 10:25:11 +01:00
sliptonic
647943a6f0 Merge pull request #8146 from sliptonic/bug/threadmilling
[Path] fix bug with threadmilling collision
2023-01-10 08:05:42 -06:00
Jakub Świerk
16f85753aa GUI: Removed Std_ArrangeIcons command. 2023-01-10 13:46:33 +01:00
Chris Hennes
a7b4a6deba Addon Manager: Fix bug in ZIP isntallation 2023-01-09 19:35:18 -06:00
sliptonic
5b41bab220 Remove check for internal as well 2023-01-09 10:46:55 -06:00
sliptonic
5196a4c01b Merge pull request #8145 from sliptonic/bug/7600
[Path] use correct widgets in task panel Fix #7600
2023-01-09 10:28:50 -06:00
Abdullah Tahiri
152dda172c Part/Sketcher: Geometry/Geometry facade pass by const-reference instead of by value 2023-01-09 17:13:26 +01:00
Abdullah Tahiri
04a7478afb Sketcher: Do not mark as fully constrained sketches that do not converge
=======================================================================

In uncommon situations, the analysis of QR decomposition leads to full rank, but the result does not converge.

We avoid marking a sketch as fully constrained when no convergence is achieved.
2023-01-09 17:11:14 +01:00
Uwe
1ca527c6ad [skip ci] [TD] fix a typo as reported by the CI 2023-01-09 15:47:40 +01:00
Uwe
c947055821 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
Yorik van Havre
ec6b14bbee Merged crowdin translations 2023-01-09 14:06:28 +01:00
Yorik van Havre
c1160c598a Updated ts files 2023-01-09 13:24:16 +01:00
Uwe
2f2480df7b [TD] final fix of compilation after #8141
- in DimensionValidators.h the declarations must not be with TechDrawExport
- add missing precompiled headers

- also fix too long lines (fixed by clang)
- also some re-sorting
- also remove unused headers
2023-01-09 12:48:15 +01:00
Uwe
864ef31d81 [TD] minor fixes
- typos and code formatting as reported by the CI
- some more re-sorting
2023-01-09 12:02:50 +01:00
wmayer
c80a60d8be TD: fixes #8144: TD crash 2023-01-09 11:43:14 +01:00
Uwe
79ae9b8280 [TD] attempt to fix compilation with PCH after #8141
- also resort includes
2023-01-09 11:26:51 +01:00
wandererfan
6a42d6991c [TD]fix loss of precision in view direction 2023-01-08 17:50:49 -05:00
wandererfan
503b58daee [TD]fix dimension retains light on dark colour 2023-01-08 17:50:49 -05:00
sliptonic
f7d2b4495e fix bug with collision 2023-01-08 14:02:33 -06:00
sliptonic
3b954f95f3 use correct widgets in task panel 2023-01-08 12:05:34 -06:00
wandererfan
97b6788464 [TD]fix wrong calculation of 3d two edge angle 2023-01-07 16:32:03 -05:00
wandererfan
7d5c47c633 [TD]fix exception on empty list during restore 2023-01-07 16:32:03 -05:00
wandererfan
88c7aac0d9 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
208104e9e0 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
9e48f5a158 [Measure]fix angle returns supplementary value 2023-01-07 16:32:03 -05:00
luzpaz
171d09f2ac Crowdin: [skip ci] fix string in Arch/ArchSite.py
Props to david69 https://crowdin.com/translate/freecad/6766/en-fr#6604817
2023-01-07 20:08:28 +01:00
luzpaz
6babde5845 Crowdin: fix string in Arch/ArchStairs.py
Props to david69 in https://crowdin.com/translate/freecad/6766/en-fr#6605247:drl:44875:david69
2023-01-07 20:07:57 +01:00
Abdullah Tahiri
9811d6cbb9 GCS: Improvements to popularity contest and conflicting identification
======================================================================

1. Instead of excluding internal alignment constraints from popularity candidate selection, exclude them from the group altogether. This
ensures no group is non-empty with uneligible candidates, which prevents an infinite loop in uncommon circumnstances (when DoFs collapse).

2. Ensure no internal alignment constraint is identified when conflict ensues.
2023-01-06 13:49:56 -06:00
wmayer
f2908e251c [skip ci] fix typos 2023-01-06 18:16:50 +01:00
sliptonic
c909b753a4 Fix for Partial edge drilling Fixes 8131 2023-01-05 17:35:08 -06:00
wmayer
90b7b461b8 TD: [skip ci] fix -Winconsistent-missing-override 2023-01-05 11:14:30 +01:00
Uwe
0a0902532d [TD] fix compilation with PCH after b18f1e5e
- also add includes to QtAll
2023-01-05 00:50:32 +01:00
Ajinkya Dahale
9aba979b27 [Sketcher] Delete check for OCC >= 6.9.0
The oldest version we plan to support is 7.0.0. See
https://forum.freecadweb.org/viewtopic.php?f=10&p=650487#p650487.
2023-01-05 00:27:01 +01:00