Commit Graph

267 Commits

Author SHA1 Message Date
Hannu Koivisto
57aac275c7 [Draft] Mitigate crash in Draft_Edit (#8749) (#8750)
This mitigates the crash reported in issue #8749.  The crash happens when
using Draft_Edit and using keyboard to enter a coordinate in Edit node
dialog.  This change partially restores behaviour before commit fc14567,
after which FreeCADGui.Control.closeDialog and showDialog calls during
execution of DraftToolBar.editUi are no longer made using the todo.delay
mechanism.  The crash can still be triggered by artificially slowing down key
event processing, so this is not a proper fix, just a mitigation.
2023-03-11 17:44:04 +01:00
Roy-043
ec0182b915 Draft: housekeeping: remove obsolete code (uiMode and DraftGui.py) (#8327) 2023-02-02 23:24:27 +01:00
Roy-043
ee872dbc76 Draft: Escape should not switch off continue mode 2022-10-15 12:14:51 +02:00
Roy-043
fc14567d34 Draft: Improve Draft_Edit context menus 2022-09-26 10:03:50 +02:00
Roy-043
2ca31f5c1d Draft: Improve In-Command-shortcut Undo implementation 2022-08-13 14:10:43 +02:00
Yorik van Havre
5a9201d2c5 Draft: Enabled shortcut for undo segment - fixes #6181
That shortcut had apparently been left out last time the system was recoded..
I used the default shortcut '/' because Ctrl doesn't really work with the
current system, and Z is already taken
2022-08-04 17:40:05 +02:00
luzpaz
1ef31f40f5 Draft: Fix 'testing inequality to None' syntax (#7275)
* Draft: Fix 'testing inequality to None' syntax 

- Substitute `is not None` for `!= None`
- Trim trailing whitespace on touched files
2022-07-30 00:26:56 +02:00
Peter Marquardt
5267658651 Draft: fix spacing of ToolTip text 2022-07-12 02:59:30 +02:00
Roy-043
bc37be0c54 Draft: Fix default fillmode in DraftGui.py 2022-06-28 15:42:28 +02:00
Roy-043
7cf1d7b582 Draft: Fix Angle Lock
Fix problem with self.angle = None.
2022-04-21 12:17:42 +02:00
Roy-043
3844c7296b Draft: Fix Angle Lock for non-XY workingplane 2022-03-10 17:44:38 +01:00
Roy
d5615fc6a6 Draft: Fix several translation issues 2022-01-28 14:01:42 -06:00
Roy
c81ce5dea1 Draft: fix task panel related issues
This PR fixes several task panel related issues for Draft modifier commands.
2022-01-15 18:23:05 +01:00
marioalexis
68439aa831 Draft: Use super() to call base class methods 2022-01-07 22:24:21 +01:00
Roy
3ad8c1680f Draft: Draft_Label fix label type list 2021-12-10 18:40:43 +01:00
Roy-043
81268073df Draft: fix task panel issues (DraftGui.py) 2021-12-04 21:57:31 +01:00
Roy-043
3cb0f20b5a Update DraftGui.py
The Y and Z inputs also require the event filter.
2021-10-22 20:04:06 +02:00
Roy-043
d9d8761722 Draft: Fix snap cycling if length input has focus 2021-10-22 19:47:23 +02:00
Yorik van Havre
f3ccc6d660 Merge pull request #5023 from marioalexis84/gui-encoding
Gui:  Harmonize encoding/decoding between view, property editor and command line.
2021-10-14 12:24:49 +02:00
Roy-043
ad0113ca26 Draft: prevent negative snaprange
Also fixed misspelled related in-command shortcuts.
2021-10-01 20:38:30 +02:00
marioalexis
00e95ba55d Draft: Fix Unicode and UTF-8 encoding character behavior 2021-09-23 21:21:24 -03:00
Roy-043
4946203267 Draft: Draft_Trimex: Fix wrong angle units in taskpanel: tooltip in DraftGui.py
I have changed the tooltip from "Trim distance" to "Offset distance" to match the tooltip in gui_trimex.py
2021-07-02 11:37:31 +02:00
marioalexis
2dcbc694af Draft: Check special characters using focused input field 2021-06-14 01:37:44 -03:00
Yorik van Havre
131cdd1e4e Merge pull request #4557 from luzpaz/crowdin/whitespaces-substituted-into-code
Crowdin: represent whitespace in code instead of in string
2021-05-05 17:18:35 +02:00
Yorik van Havre
dca216e761 Merge branch 'master' into draft-feature_name 2021-04-29 12:40:27 +02:00
Yorik van Havre
0e0f55660e Merge pull request #4710 from marioalexis84/draft-draftgui
Draft: Sync input fields in task panel
2021-04-20 11:50:22 +02:00
luz paz
f2b93a7af3 Crowdin: represent whitespace in code instead of in string [skip ci]
Removing possible whitespace from strings lead to more accurate translations
2021-04-19 06:16:09 -04:00
marioalexis
e4a64af3c9 Draft: Sync input fields in task panel 2021-04-07 18:36:56 -03:00
marioalexis
744846dd4f Draft: Fix tooltip typo and trimex task panel title 2021-03-29 10:51:53 -03:00
Yorik van Havre
8f02f8c8f3 Merge branch 'master' into draft-close_button 2021-03-26 11:19:09 +01:00
Yorik van Havre
c4a49a5575 Merge pull request #4348 from marioalexis84/draft-coordinate_input
[0.20] [Draft] Add global mode to enter points - Fixes #0004108
2021-03-26 11:18:23 +01:00
marioalexis
96d1516abe Draft: Change selectUi and makeDumbTask argument named 'callback' to 'on_close_call'
Suggested by user @carlopav
2021-03-20 17:12:58 -03:00
marioalexis
a57b323e00 Draft: Call finish method if pressed Close button in dumb taskdialog 2021-03-20 17:12:58 -03:00
Chris Hennes
fe7e45a7de [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
marioalexis
589cec2d4a Draft: Add global mode to enter points - fixes #0004108 2021-02-01 01:26:15 -03:00
Yorik van Havre
c25ff3ac16 Draft: Hide undo button from modify operations 2020-12-14 15:21:25 +01:00
luz paz
2a8c1271d5 Draft: fix header uniformity + trailing whitespace
[skip ci]
2020-12-11 13:19:49 +01:00
Yorik van Havre
4af412f1e4 Draft: Fixed regression caused by new setstyle button 2020-11-18 11:41:38 +01:00
Yorik van Havre
88f5fc20b1 Draft: Condensed the Draft toolbar style buttons into one with more options 2020-11-10 14:14:18 +01:00
vocx-fc
bc0cfdfda2 Draft: use new name of the icon Part_3D_object
It is defined in the Part Workbench. Before, it was called `Tree_Part`.
2020-10-22 15:11:45 +02:00
vocx-fc
aaeab8bc5d Draft: move units functions outside DraftGui.py
The functions `getDefaultUnit`, `makeFormatSpec`, `displayExternal`
are used to get the default unit schema for lengths and angles,
and display a string with a particular format.

They aren't used in `DraftGui.py`, but are used by the
viewprovider of the Dimension objects. Therefore, they are moved
into a separate module, so that they can be imported without
using the entire `DraftGui` module.
2020-07-10 12:29:30 +02:00
carlopav
55e537d79d [Draft] Improved Snapper Toolbar Behaviour
Changed snap toolbar behaviour:
- create a list of available snaps (Gui.Snapper.snaps)
- make it consistent with Snap Gui Commands (in gui_snaps module)
- create a list of active snaps (Gui.Snapper.active_snaps)
- refactor the isEnabled() method to allow it to check if the given snap is in Gui.Snapper.active_snaps and not if the snap toolbar button isChecked()
- updated and reordered the new list of gui snap commands in draftutils.init_tools and used it as a base to refactor the creation of draft toolbar
- updated all the draft snap gui tools to make them control the toolbar buttons directly
.


.


.
2020-04-20 12:38:06 +02:00
vocx-fc
6cc5001c08 Draft: Draft_Text split lines by newline characters 2020-04-06 13:01:32 +02:00
vocx-fc
7bc2e3ad48 Draft: move ScaleTaskPanel to a module
We remove it from `DraftGui.py` to reduce the size of this file.
Then we import it and tie it to its command defined
in `DraftTools.py`.
2020-04-02 16:53:49 +02:00
vocx-fc
50faaea5bf Draft: move ShapeStringTaskPanel to a module
We remove it from `DraftGui.py` to reduce the size of this file.
Then we import it and tie it to its command defined
in `DraftTools.py`.
2020-04-01 13:22:04 +02:00
vocx-fc
699624fd26 Draft: move DraftSnap to another module
And do not load the `Snapper` in `DraftGui`.
The Snapper should be initialized by the module
that imports `DraftGui`, most probably `DraftTools`
or even by the `InitGui` of the workbench.
2020-03-20 08:11:04 -03:00
carlopav
e79c1e6c99 [Draft] Uniform length and xyz inputfield behaviour
Single returnPressed to accept point if cursor is parallel to xyz axis for bot setfocus on x and on length inputfields.
[Draft] Edit_updated tooltip


[Draft] DraftGui Further cleanup and bugfix
2020-03-12 09:11:34 -03:00
carlopav
f5f43913e0 [Draft] DraftGui and DraftEdit Cleanup to remove AddPoint & DelPoint
Lines to be deleted in DraftGui in the future, are now commented.
2020-03-12 09:11:34 -03:00
carlopav
6182aea46b [Draft] DraftGui Bugfix on selecting inputfields
https://forum.freecadweb.org/viewtopic.php?f=23&t=43145&p=367517#p367517
2020-03-12 09:11:34 -03:00
Syres916
b5a92b656d [Draft] Bugfix for new users opening Shapestring
See Discussion : https://forum.freecadweb.org/viewtopic.php?f=23&t=42808
2020-02-05 10:51:12 +01:00