Commit Graph

91 Commits

Author SHA1 Message Date
wandererfan
e48fee5acc [TD]Property types and spinboxes for Detail 2025-03-02 09:05:10 -05:00
Benjamin Nauck
6f535f19fb Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's
Regex based changes, manually verified
2025-01-27 16:08:18 +01:00
Eric Price
aba60775f6 Fix boolean operations (#17119)
* add BRepAlgoAPI wrapper files to CMakeList

* introduce wrapper for BRepAlgoAPI_BooleanOperation and derivatives, set sensible default Fuzzyness for boolean operations

* allow default fuzzyness to be set in settings - including off

* backwards compatibility with OCCT 7.3.3 - removed newer paramateres from wrapper

* added missing header

* reverted src/Mod/Part/App/OpenCascadeAll.h to original state

* implement some changes suggested by @wwmayer

* removed unneeded destructor definitions

* moved getDefaultFuzzyValue into its own helper class

* removed unneeded references to base class default constructor

* default to SetRunParallel(Standard_True) as suggested by @FlachyJoe

* fixed license header as requested

* Added new method to autocalculate fuzzyness to BooleanOperation base class and use it for those parts that do not call the obsolete constructor but also do not set precision

* implemented static variable solution as suggested by @wwmayer

* added helix for test case

* Refactoring FCRepAlgoAPI to FCBRepAlgoAPI

* Added Test Case (fuse cylinder with helix with different working and non-working Fuzzy values)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* increased default value of FuzzyBoolean and made tests more robust for compatibility with OCCT 7.3

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixes for FREECAD_USE_PCH - allow testing of FREECAD_USE_PCH on linux with cmake switch (default OFF)

* removed surplus line - wasn't needed after all

* included precompiled as instructed

* set anti-corruption flag in boolean operations, ensures source shape is not damaged in OCCT 7.1 and higher

* fix #17085

* disable subtests that were too specific for now

* fixed all CLI tests - see comments in Pull Request https://github.com/FreeCAD/FreeCAD/pull/17119#issuecomment-2420772452

* Update src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* remove surplus tests from github suggestion interface bug

* hide the BooleanFuzzy variable - can now be only set by manually editing the config file
i
in FCParamGroup "Boolean"
<FCFloat Name="BooleanFuzzy" Value="10.000000000000"/>

* Suggestion by @FlachyJoe - add validity checks to the base and tool shape in any direct boolean op

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>
2024-10-21 18:38:51 +02:00
wandererfan
e5dacc9c9b [TD]fix 3d dimension position on DetailView 2024-04-16 13:20:02 -04:00
wandererfan
df0cf92243 [TD]Revert detail to piecewise algo 2024-01-11 18:24:51 -05:00
wandererfan
90b0c15cbf [TD]add properties for detail highlight and matting 2023-12-17 08:37:19 -05:00
wandererfan
1d3aca0733 [TD]handle loose geometry via HLR 2023-12-03 08:55:59 -05:00
Florian Foinant-Willig
1d8a51b47b TechDraw: modernize type checking 2023-10-23 18:08:59 +02:00
André Caldas
0f27212d57 TechDraw: creates closure for concurrent thread context.
We use a lambda function with a copy of variables
that might be destructed in the original calling thread,
possibly producing dangling references.

See: https://forum.freecad.org/viewtopic.php?t=81260
2023-09-20 09:26:15 -04:00
wandererfan
2f8a8beca8 [TD]fix 10013 detail of sketch 2023-08-20 12:25:12 -04:00
wandererfan
41817c188f [TD]split GeometryObject 2023-08-18 15:18:42 -04:00
wandererfan
77ef529c5a [TD]provide result of detail to other views 2023-08-10 10:17:22 -04:00
Benjamin Bræstrup Sayoc
5d05acc87e [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
wmayer
16e27eecc7 TD: port to Qt6
* in QtConcurrent::run the order of 1st and 2nd argument are swapped
* QtConcurrent::run asserts that the argument of the passed function pointer is not non-const
* Used methods of QFontDatabase are static in Qt5 and Qt6
* QTextStream::setCodec() has been removed in Qt6
* Argument of enterEvent() has changed from QEvent to QEnterEvent
* QTextCharFormat::setFamily() is deprecated
2023-03-16 09:17:39 -04:00
wandererfan
1f3bfe0dd4 [TD]make detail highlight interactive
- drag detail highlight to change detail anchor point
- change detail reference position using HighlightAdjust property
2022-12-28 09:41:44 -05:00
wandererfan
100d4956c8 [TD]detail of rotated ComplexSection 2022-12-18 09:42:42 -05:00
Uwe
44a91217a2 [TD] DrawView*: remove unused includes - part 1
- also sort includes
- also additions to precompiled header
2022-10-07 01:08:38 +02:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
wandererfan
c0d69f7d8e [TD]replace GeometryObject only after all changes are done 2022-08-28 15:52:23 -04:00
wandererfan
67ce559bc5 [TD]clazy warning re 3 parameter QObject::connect 2022-08-28 15:52:23 -04:00
Wanderer Fan
0a58649409 [TD]use Label in waiting for thread message 2022-08-21 21:18:26 -04:00
Wanderer Fan
81949d0817 [TD]use new style QObject::connect 2022-08-21 21:18:26 -04:00
Wanderer Fan
90450e8a4a [TD]code review changes for dvp and dvd 2022-08-18 19:43:04 -04:00
Wanderer Fan
6f646a8d2d [TD]prevent running threads on object delete 2022-08-18 09:34:32 -04:00
Wanderer Fan
e97b95341a [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
Wanderer Fan
2483b1524e [TD]fix detail of section not displayed on restore 2022-08-18 09:34:32 -04:00
Wanderer Fan
80d5e9a0b8 [TD]respect AutoDistribute on load 2022-08-18 09:34:32 -04:00
Wanderer Fan
2c19c29d3c [TD]move section cut and detail common to thread 2022-08-18 09:34:32 -04:00
Wanderer Fan
5a92b30f17 [TD]run hlr and extractFaces in threads 2022-08-18 09:34:32 -04:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
fb99e37727 [TD] remove unnecessary nullptr checks 2022-07-26 00:28:57 +02:00
Benjamin Bræstrup Sayoc
7ee5be032d [TechDraw] Improve readability of DrawViewDetail.cpp
[TechDraw] Improve readability of DrawViewDimension.cpp

[TechDraw] Improve readability of DrawViewDimExtent.cpp

[TechDraw] Improve readability of DrawViewDraft.cpp

[TechDraw] Improve readability of DrawViewImage.cpp

[TechDraw] Improve readability of DrawViewMulti.cpp
2022-07-20 16:44:26 -04:00
Uwe
36add10c86 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
wmayer
1cae0fb41d TD: fixes warning: local variable will be copied despite being returned by name [-Wreturn-std-move] 2022-04-17 17:21:37 +02:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
e98852016f [TD]fix spelling mistake in comment for CI 2022-03-14 20:03:08 -04:00
Wanderer Fan
cd663b9efd [TD]fix DetailView alignment 2022-03-14 20:03:08 -04:00
Wanderer Fan
bb3e637e9e [TD]fix detail highlight on DrawViewDetail 2022-03-14 20:03:08 -04:00
Wanderer Fan
855941d5bb [TD]fix misplaced section line
- BRepBndLib::Add results in wrong bbox center.
- replaced with BRepBndLib::AddOptimal
2022-03-03 09:31:29 -05:00
Wanderer Fan
921ada74d4 [TD]Fix 4486 allow detail view of Base with no solids 2022-02-01 09:15:00 -05:00
wandererfan
e2efc19982 [TD]Detail default scale 2020-06-20 12:36:54 -04:00
donovaly
97e1274b00 Merge branch 'master' of github.com:FreeCAD/FreeCAD into TD-DetailWork 2020-05-09 01:36:49 +02:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
donovaly
c44263a572 Merge branch 'master' of github.com:FreeCAD/FreeCAD into TD-DetailWork 2020-04-20 01:07:35 +02:00
WandererFan
7c1ce37eff [TD]Piecewise Detail Algo 2020-04-19 09:17:28 -04:00
donovaly
c9ca93a429 DrawViewDetail: remove unwanted commit 2020-04-18 14:59:28 +02:00
donovaly
ec58acb7df [TD] some Detail View fixes
see https://forum.freecadweb.org/viewtopic.php?f=35&t=45236&p=388925#p388925 for a description of the changes
2020-04-18 14:56:01 +02:00
wandererfan
2cfb124ac6 [TD]dialog for Detail #4221 2020-04-08 13:23:28 -04:00
wandererfan
13661ddf21 [TD]remove highlight on deletion of detail 2020-03-26 12:36:33 -04:00
donovaly
0e0162664f [TD] Detail view - add missing update
- now changes of the BaseView and to the anchor coordinates are directly shown
2020-03-26 08:08:06 -04:00