Commit Graph

3973 Commits

Author SHA1 Message Date
Uwe
e4d1cb66e9 [FEM] Elmer: use different default linear solver
- BiCGStabl is as robust as BiCGStab but in all tested cases it converges faster
2022-08-04 03:24:03 +02:00
Uwe
5d1b25f130 [FEM] Elmer: use direct solving as default for stresses
- direct solving is sometimes even 10 times faster (as fast as CCX) and as accurate as CCX
2022-08-04 03:22:07 +02:00
Uwe
b4c9b7a638 [FEM] pipeline: minor highlighting fix
- if a pipeline is invisible the highlighting must not be triggered
2022-08-04 03:11:02 +02:00
wmayer
ec75ab64c9 Fem: [skip ci] fix possible crash in PropertyPostDataObject::getMemSize 2022-08-03 10:55:31 +02:00
Uwe
9bb9bb923c [FEM] Elmer: update .sif files
- because of solver default settings change
2022-08-03 04:29:27 +02:00
Uwe
bbc21b336a [FEM] Elmer: fix solver stabilize settings
- according to https://www.nic.funet.fi/index/elmer/doc/ElmerModelsManual.pdf
the stabilization methods are equation-specific and only available for some solvers
This commits changes these settings according to the manual
2022-08-03 02:32:01 +02:00
Uwe
a6288fdabe [FEM] Elmer: Flux: add missing settings
- enable the disabled options. They work and are according to the Elmer manual. The user is free to use them or not and since they are all False by default, existing analyses won't be affected.
- add two missing settings
- for new equations, enable at least one calculation, otherwise nothing will happen when an inexperienced user uses the default
2022-08-03 01:50:12 +02:00
wmayer
7e230725b9 Fem: [skip ci] replace the SoAnnotation with an SoSeparator to fix rendering artifacts for non-convex objects 2022-08-02 19:09:05 +02:00
Uwe
1f9b9e8c17 [FEM] remove some unused includes 2022-08-02 05:15:31 +02:00
Uwe
c61ca0d0a7 [FEM] Elmer: fixes for the point filter
- use correct names and support all possible outputs
2022-08-01 04:33:06 +02:00
Uwe
d2cbf80d3c [FEM] Elmer: update .sif files
- because of solver default settings change
2022-08-01 04:27:38 +02:00
Uwe
ea8e13dfa0 [FEM] Elmer: don't push mesh scaled to Elmer
- the mesh scaling was a hack to work around the fact that FC's mesh is in mm while all input units are in SI. It turned out that this made more problems than it solved because Elmer checks the length unit and makes internal recalculations. So the mesh must not be scaled when send to Elmer (despite the ElmerGrid docs doesn't state this).
forum thread: https://forum.freecadweb.org/viewtopic.php?p=614162#p614162
2022-08-01 03:58:09 +02:00
Uwe
927cecc742 [FEM] Elmer: set sensible defaults for elasticity equation
- for BiCGstabl the minimal degree is 2, but 3 is recommended
- when adding the equation, it should do something, therefore enable the calculation of the principal stresses (as it was, nothing was calculated except of the displacement)
2022-08-01 03:42:57 +02:00
Bernd Hahnebach
5d4b753940 FEM: python code formatting 2022-07-31 23:47:45 +02:00
Uwe
02b994a3fb [FEM] importVTKResults: assure user gets a visible object
- on importing a .vtu/.vtk file the new created should be a visible one. Therefore set its display to surface like we do when a new pipeline is created from within FC by the user
2022-07-31 22:32:04 +02:00
Uwe
62bc30ddf4 [FEM] [skip CI] PropertyPostDataObject: some .clang changes 2022-07-31 22:08:43 +02:00
Uwe
b458ef0208 [FEM] Constraint: BodeHeat: fix regression from commit 4a349525
- a simple indentation mistake
2022-07-31 21:17:52 +02:00
wmayer
a5ccef8146 Fem: use SoAnnotation to highlight result pipeline objects 2022-07-31 17:51:31 +02:00
Uwe
4a030cd949 [FEM] remove unneeded checks for Python 3
since we only support Python >=3, these checks can go
2022-07-31 15:36:54 +02:00
wmayer
9ddbecb864 Fem: implement a selection observer to notify a ViewProviderFemPostObject when its selection status has changed 2022-07-31 14:01:23 +02:00
Uwe
bb667b516f [FEM] Elmer: fix small number property handling
- use an expression as discussed: https://forum.freecadweb.org/viewtopic.php?p=613897#p613897
2022-07-31 05:19:45 +02:00
Uwe
f532fa9a1b [FEM] Elmer: fix eigenmode results for point filter
Elmers' eigenmode results have a different result name
2022-07-31 04:30:31 +02:00
Uwe
5107590917 [FEM] add missing eigenfrequcy calculation for Elmer
- while for CCX we output the eigenfrequency, for Elmer the user had to perform the calculation of a sqrt of the complex result.
This is inconvenient and error-prone and also requires the knowledge where the result is output by Elmer and in what format. (cast me more than an hour to find this out)
Therefore perform the calculation for the user and output the result.
2022-07-31 02:31:26 +02:00
Uwe
cbf3de264f [FEM] utils: remove unused import 2022-07-31 02:08:16 +02:00
Uwe
52b2bc6e38 [FEM] Elmer: add missing direct variant MUMPS
- also use capitalized wording to Umfpack as Elmer does
2022-07-30 14:40:10 +02:00
wmayer
3ef98f002b Fem: use 'using' instead of 'typedef' [modernize-use-using] 2022-07-27 19:11:05 +02:00
Uwe
c25c0888c9 [FEM] fix PostObject hiding issue
- when a PostObject is hidden the FemPostDataAtPointFilter must not be taken into account
2022-07-27 16:56:06 +02:00
Uwe
9a9ac18916 [FEM] save icons as plain SVG - part 2/2 2022-07-27 16:42:46 +02:00
Uwe
4c08e41a88 [FEM] PostDataAtPoint: remove unnecessary style setting
- PostDataAtPoint is a point therefore setting a filling style is not necessary

- also fix a typo in a comment
2022-07-27 16:15:04 +02:00
Uwe
d81fe59c2e [FEM] remove checks for Python 2 2022-07-27 14:09:23 +02:00
Uwe
9c89935297 [FEM] skip CI] update a comment 2022-07-27 03:54:26 +02:00
Uwe
591b0f3e1b [FEM] update ViewProvider selection code
as suggested in
7884cb92d9 (r79459854)
2022-07-27 03:51:46 +02:00
Uwe
1c419864c3 [FEM] save icons as plain SVG - part 1/2 2022-07-27 03:34:04 +02:00
Uwe
2e9788d488 [FEM] BodyHeat constraint: use unique icon
- it was not possible to distinguish the constraint from the heatFlux constraint
2022-07-27 03:09:15 +02:00
Uwe
9c7af25d26 [FEM] BodyHeat constraint: hide unused property
- the constraint does not take a references and when trying to set one as user because one thinks this empty property must be set, one gets a recompute error
2022-07-27 02:55:29 +02:00
Uwe
1cc410cb1e [FEM] update Elmer tests after commit 594b65b3 2022-07-27 02:33:42 +02:00
Uwe
2b6f351880 [FEM] Elmer: a fix for keywords
- according to the Elmer solver manual, check keywords have to be quoted
2022-07-27 01:48:10 +02:00
Uwe
e425ed39a6 [FEM] PostObject: improve color bar refreshing
- for data point filters the color bar must not be updated
2022-07-26 04:00:02 +02:00
Uwe
f0d633eb4b [FEM] Elmer writer: fix errors on missing material properties
- we must in this case raise an error and stop the writer script
2022-07-26 03:37:55 +02:00
Uwe
4325f0386c [FEM] update bodyHeatSource
- to the state of the other constraints

(this constraint is currently completely broken by the way)
2022-07-26 01:47:09 +02:00
wmayer
a9a4cf3d6d Fem: [skip ci] Fix several clazy issues:
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Using copy-ctor but class SbMatrix has a trivial copy-ctor but non trivial assign operator [-Wclazy-rule-of-two-soft]
* Missing emit keyword on signal call FemGui::PointMarker::PointsChanged [-Wclazy-incorrect-emit]
2022-07-25 12:11:47 +02:00
Uwe
ae33ad545f [FEM] Elmer: fix python error when solver failed
we must then stop the execution of the script
2022-07-25 02:54:12 +02:00
Uwe
777aabe46c [FEM] ViewProviderDocumentObject: fix parenthesis mistake
(I don't know how this happened)
2022-07-24 19:25:53 +02:00
Uwe
d012b8d012 [FEM] fix color bar handling on hiding post objects
- fixed the remaining part of #7230: on hiding an object, refresh the color bar of the new visible object (if there is any)
2022-07-24 19:17:24 +02:00
Uwe
a5b50fd114 [FEM] set default selection mode to BoundBox for post objects
- this fixes a long-standing annoyance that popped up also from time to time in the forum:
  the post objects deliver information via its coloring but a selection in the tree changed the shape color

Even experienced users like me did not know about the SelectionStyle property and always had to click into the model to see the real color, not the selection color.
Therefore SelectionStyle set to BoundBox is sensible as default settings for post objects since this assures that the users always see the right coloring.
2022-07-24 16:24:01 +02:00
Uwe
c3074efb29 [FEM] fix regression of missing stress results
- fixes the regression that went in short as "last minute fix": commit c5daa88b82 -> fixes #7242

- also remove a doubled entry in an IF
2022-07-24 05:41:33 +02:00
Uwe
e95a16408c [FEM] TaskBoxes: add missing info about transparency
The user had no info about the current transparency nor the value he will be selecting.
2022-07-23 19:41:18 +02:00
Uwe
5aedc73ef6 [FEM] better fix for missing colorbar update for FemPostObject
- better fix for #7230 because we can call the direct paint method and because the bar is now also updated when the object is shown

- also add a ToDo note
2022-07-23 16:57:16 +02:00
Uwe
82083ab059 [FEM] task_material_common: add a comment 2022-07-23 14:22:48 +02:00
Uwe
68659771f5 [FEM] fix material task dialog for fluids
- this fixes a mistake from commit 821dc915
- it also consistently use the thermal expansion coefficient
- add code comments

now the material task dialog works with all fluid materials without errors or warnings
2022-07-23 04:59:10 +02:00