Commit Graph

100 Commits

Author SHA1 Message Date
Roy-043
0179afbe8a Draft: Fix workingplane auto alignment to Front view 2022-09-01 09:54:09 +02:00
Roy-043
75d6804555 Draft: Improve alignToFace in WorkingPlane.py 2022-07-24 18:52:41 +02:00
marioalexis
e62496b636 Draft: Fix orientWP method used by in Draft_Line command 2022-04-20 14:12:26 -03:00
marioalexis
04fe4ef695 Draft: Fix WorkingPlane setup in automatic mode - fixes #6060 2022-04-10 16:17:16 +02:00
marioalexis
1cd01248e0 Draft: Fix projectPoint method 2022-01-08 23:16:15 -03:00
luzpaz
b488071a55 Add requested revision by @chennes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2021-10-30 15:20:28 -04:00
luzpaz
30a3ccde46 Add requested revision by @chennes
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2021-10-30 15:20:28 -04:00
luz paz
580a52f75c Draft: Fix superfluous whitespace in translations + misc. typos 2021-10-30 15:20:28 -04:00
Roy-043
25c3da4f0b Draft: Fix Draft_SelectPlane ignores nesting 2021-10-20 10:15:12 +02:00
Yorik van Havre
835e326652 Draft: Fixed working plane set on non-coin view 2021-06-22 16:12:59 +02:00
marioalexis
1c918e9d9e Draft: Improve alignToSelection method on WorkingPlane 2021-06-06 21:30:20 -03:00
Yorik van Havre
bff31175cb Draft: better checks for no active document 2020-11-16 13:25:12 +01:00
carlopav
fd79e3e3a9 Draft: possibility to set the working plane to an App::Part placement 2020-07-07 10:13:23 +02:00
Yorik van Havre
fda11ed717 Draft: Added convenience methods to the Draft Working Plane to set top, front and side positions 2020-04-09 16:59:01 +02:00
vocx-fc
033d0091e5 Draft: WorkingPlane.py clean up imports and docstrings
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Cleaned up the class docstring, so it is in only one place
below the class definition. Also small fixes
in the docstrings of the class methods.

The class is now in upper case `Plane` to conform with Python
guidelines. An alias in lowercase `plane` is still provided
for compatibility purposes; this will be deprecated
in the future.
2020-04-07 18:12:06 +02:00
luz.paz
ae7cb9e300 Draft: [skip ci] Fix header uniformity
This PR fixes header uniformity across all Draft files
2019-12-27 00:16:12 +01:00
Yorik van Havre
864619fcec Draft: Moved SelectPlane stuff from DraftGui to its own ui file 2019-09-02 22:15:58 -03:00
luz.paz
050ac16f1c Fix misc. typos
Found via `codespell -q 3 -I ../fc-word-whitelist.txt -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller -L od,orign,orginx,orginy`
2019-08-14 14:36:53 -03:00
vocx-fc
445538c7dd Draft: WorkingPlane, improved Pythonic style, line length < 79 characters; shorter variables
to save space and have line lengths < 79 characters; added whitespace to comments
and used the self.__repr__() method to shorten the impression to the terminal;
broke the line inside parentheses to make the line shorter; inside alignToSelection() test for faces first
to use alignToFace(), which actually works; leave alignToCurve() for later,
as it doesn't actually do anything at the moment; improved docstrings in isOrtho(),
the orthogonality is tested for u, v, and axis, on the global axis +Y only;
removed wrongly placed comment in restore() method;
improved file docstring at the top.
2019-08-14 14:31:56 -03:00
vocx-fc
1769b6d7f3 Draft: WorkingPlane, Pythonic style, improved the docstrings, use a shape of type Part.Face 2019-08-09 16:54:50 -03:00
vocx-fc
bbf22c6a40 Draft: WorkingPlane, Pythonic style, improved the docstrings; moved the description of the points within the parameter section 2019-08-09 16:54:50 -03:00
vocx-fc
12ef13e5f7 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
ee4a067930 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
bbc37d5537 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
e844e7b4b6 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
14c7f43614 Draft: WorkingPlane, Pythonic style, improved the docstrings; added the other getLocalRot() and getGlobalRot() related functions to the 'See also' sections; need to verify their operation as some of these methods seem to just return the original point 2019-08-09 16:54:50 -03:00
vocx-fc
05cb2cb4c1 Draft: WorkingPlane, Pythonic style, improved the docstrings; added a graphic to explain the type of point that the functions return; maybe getLocalCoords() should be named getRelativeCoords(), as the return value is a relative vector referred to the plane. 2019-08-09 16:54:50 -03:00
vocx-fc
023cf12c50 Draft: WorkingPlane, Pythonic style, improved the docstring; why does the projection invert the direction of the component, that is, -x instead of x, if the angle between the vectors x and u is larger than 1 radian? Why specifically 1 radian? 2019-08-09 16:54:50 -03:00
vocx-fc
ad74402d9f Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
ee09fc323a Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
34c2dcb277 Draft: WorkingPlane, Pythonic style, improved the docstring 2019-08-09 16:54:50 -03:00
vocx-fc
53ef53e0c8 Draft: WorkingPlane, Pythonic style, improved the docstring 2019-08-09 16:54:50 -03:00
vocx-fc
2bdf33478b Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
f13529deac Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
cf430bf754 Draft: WorkingPlane, Pythonic style, improved the docstring 2019-08-09 16:54:50 -03:00
vocx-fc
8ac3b21ca9 Draft: WorkingPlane, Pythonic style, improved the docstring; these methods only work when 'FreeCAD.GuiUp' is True; it should print a message to the console indicating that. 2019-08-09 16:54:50 -03:00
vocx-fc
5a4ca2a4f7 Draft: WorkingPlane, Pythonic style, improved the docstring; setup() only works when 'FreeCAD.GuiUp' is True, otherwise it fails silently. This should be change to print a message to the console. 2019-08-09 16:54:50 -03:00
vocx-fc
17f39fc410 Draft: WorkingPlane, Pythonic style, improved the docstrings; alignToSelection() only works when 'FreeCADGui.Selection' is available, that is, when the graphical interface is loaded. 2019-08-09 16:54:50 -03:00
vocx-fc
97a02d8795 Draft: WorkingPlane, Pythonic style, improved the docstrings; alignToSelection() only really works with Faces because it calls alignToFace(); it doesn't work with Edges nor Wires because alignToCurve() isn't fully implemented. 2019-08-09 16:54:50 -03:00
vocx-fc
7b91cbce33 Draft: WorkingPlane, Pythonic style, improved the docstrings 2019-08-09 16:54:50 -03:00
vocx-fc
51e6f91824 Draft: WorkingPlane, Pythonic style, improved the docstring, although alignToCurve is not yet implemented so it doesn't do anything 2019-08-09 16:54:50 -03:00
vocx-fc
1a328e58f4 Draft: WorkingPlane, Pythonic style, improved the docstring. 2019-08-09 16:54:50 -03:00
vocx-fc
04a0c0bbf8 Draft: WorkingPlane, Pythonic style, improved the docstring. 2019-08-09 16:54:50 -03:00
vocx-fc
2d294994a7 Draft: WorkingPlane, Pythonic style, improved the docstrings. 2019-08-09 16:54:50 -03:00
vocx-fc
9b3aba60b0 Draft: WorkingPlane, Pythonic style, improved the docstrings, in particular offsetToPoint(); I have some doubts about the implementation in 3D space as it seems to calculate a projected distance, and not the real distance; I don't think this is very helpful when the direction is different from perpendicular (normal); perpendicular distance is certainly the most common case, so I don't know if there is any problem at all in practice. 2019-08-09 16:54:50 -03:00
vocx-fc
59f66dcf87 Draft: WorkingPlane, Pythonic style, docstring of the initialization of the plane class 2019-08-09 16:54:50 -03:00
vocx-fc
dbbb84b441 Draft: WorkingPlane, Pythonic style, docstring of the plane class 2019-08-09 16:54:50 -03:00
vocx-fc
89b9e64786 Draft: WorkingPlane, Pythonic style, docstring of the plane class 2019-08-09 16:54:50 -03:00
vocx-fc
15b11b8cb9 Draft: WorkingPlane, Pythonic style, added whitespace 2019-08-09 16:54:50 -03:00
vocx-fc
1161cbb9ba Draft: WorkingPlane, moved document docstring to the top 2019-08-09 16:54:50 -03:00