Commit Graph

5549 Commits

Author SHA1 Message Date
Pieter Hijma
01874ca898 Core: Fix a missing Python interpreter lock
ReportView has a missing Python interpreter lock.  It is not breaking
FreeCAD in general but it is deemed a bug nonetheless.  See the issue.
2024-06-27 08:02:15 -05:00
Chris Hennes
5f094a48a9 Gui: Remove unused ref to GL context 2024-06-26 11:53:18 -05:00
PaddleStroke
fd64f38998 Assembly: Insert Component: Fix 'Joint Group' being listed even though it's empty. It's because we were using OutList instead of claimChildren. 2024-06-25 16:37:31 +02:00
PaddleStroke
62cc8fc944 Core: ViewProvider: Add claimChildrenRecursive 2024-06-25 11:34:43 +02:00
Roy-043
308013fb97 Gui: Tree.cpp make some gui texts more consistent
The gui texts for "Show description" and "Show internal name" were inconsistent.

"Show description column" -> "Show description"

"Show an extra tree view column for item description. -> "Show a description column for items."
2024-06-24 11:29:05 -05:00
Kacper Donat
032545924f Gui: Change QStyle only with theme
It fiexes performance issues on applying preferences that happens due to
forcing Qt style which is quite slow operation.
2024-06-24 11:28:13 -05:00
Chris Hennes
d01ce32a1f Update for LibPack3 (#10337)
* cMake: Add base support for LibPack3

Minor changes to FreeCAD source code to support compiling with Qt 6.5 on MSVC,
and changes to cMake setup to support the new Libpack.

* NETGENPlugin: Fix compilation with MSVC and OCCT 7.8

* Material: Switch to Wrapped_ParseTupleAndKeywords for /fpermissive- on MSVC

* Base: Prevent accidental definition of MIN and MAX by MSVC

* cMake: Prevent accidentally finding an old LibPack

* Material: Wrap another ParseTuple call

* OCCT: Modify includes for 7.8.x

* Part: Change TNP code to use Wrapped_ParseTupleAndArgs

* Spreadsheet: Workaround for MSVC macro pollution

* Mesh: Workaround for MSVC macro pollution

* Base: Remove extra MSVC flag (moved to CMake)

* Tests: Fix compiling with /permissive-

* FEM: Fix Qt warnings about duplicate element names

* cMake: Ensure major version numbers are set

* Address review comments.

* cMake: Further tweaks for LibPack3

* cMake: Modify specification of compiler flags for MSVC

* Main: Remove QtQuick testing code

* cmake: Find Boost before SMESH (which uses it)

* Fixes for LibPack2

* cMake: Another try at importinhg VTK cleanly
2024-06-24 18:25:05 +02:00
Chris Hennes
1ba5f02129 Merge pull request #14766 from wwmayer/import_options
Import: Avoid modal dialog inside ImportGui.open()
2024-06-24 11:10:31 -05:00
Patryk Skowroński
fefd3851ac Spaceball settings tabs removal from the Customize panel (#14589)
* Removed Spaceball tabs for NavLib integration

* Added missing CMake variable for MacOS/Linux platform

---------

Co-authored-by: Patryk Skowroński <pskowronski@3dconnexion.com>
2024-06-24 11:06:25 -05:00
Chris Hennes
feafecef98 Merge pull request #14592 from kadet1090/tabbar-fixes
Gui: Workbench TabBar - fix scroll and icon-only paddings
2024-06-24 10:58:57 -05:00
Turan Furkan Topak
bd9d911ca9 [Icons]Core Icon Revision (#14154)
* Core Icon Revision

Update utilities-terminal.svg

Update button_add_all.svg

pixel alignment

Pixel alignment was performed for the specified icons.

* Changes requested by Obelisk

* Return old icons
2024-06-24 10:54:58 -05:00
xtemp09
f53c827f94 Fix the crash when closing a document
Closes #14189. This commit partially reverts
d15c7d0673 and
fb37201299.
2024-06-24 10:49:27 -05:00
Chris Hennes
e60d43fcdc Merge pull request #14386 from maxwxyz/sketcher-draw-style
Sketcher: Changes override draw style when entering sketch edit mode.
2024-06-24 10:48:19 -05:00
PaddleStroke
4e4201f033 Core: Tree: Remove !vp->canDragAndDropObject(obj) that made no sense. And remove the auto switching to 'CopyAction' 2024-06-24 10:42:49 -05:00
bgbsww
4c3fc869fe Toponaming: Check for selection mapped element name 2024-06-22 17:10:54 -05:00
Chris Hennes
f294a5efc5 Gui: Silence unused variable 2024-06-22 08:29:27 +02:00
wmayer
4219aaef99 Core: Support of import options 2024-06-21 12:00:38 -05:00
Kacper Donat
d1535e7827 Gui: Disable changing workbench on tab bar scroll
Fixes: #14164
2024-06-21 10:55:00 -05:00
Kacper Donat
3684dc6560 Gui: Display workbench icon in the middle for icon-only
It ensures that for icon-only style it is displayed in the middle and
empty text is not accounted while calculating tab size hint. Custom
styles may need to target `QTabBar[style="icon-only"]` to apply specific
fixes like disabling padding.

Fixes: #14282
2024-06-21 10:55:00 -05:00
bgbsww
9b547bb90f Only adjust found element names 2024-06-20 16:10:39 -05:00
wmayer
f6e67a009d Fix several compiler warnings
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
wmayer
d1d2b730ef Gui: Move ToolBarAreaWidget to its own files
Since ToolBarAreaWidget is not a private class any more move its declaration and definition to their own source files.
2024-06-18 18:42:18 -05:00
FEA-eng
f5ebafcebb Update DlgPreferences.ui 2024-06-17 11:21:26 -05:00
Chris Hennes
c726198106 Merge branch 'main' into erase-version-4 2024-06-17 11:10:12 -05:00
Chris Hennes
99c30da736 Merge pull request #14388 from Ondsel-Development/core_rootObjects
Core: Add Gui::Document::getTreeRootObjects() Fixes #14373
2024-06-17 11:04:18 -05:00
Chris Hennes
d45cf8507b Merge pull request #13810 from hlorus/replace_measuredistance
Integrate Std_MeasureDistance into unified measurement facility
2024-06-17 10:55:40 -05:00
Chris Hennes
c901a2232f Merge branch 'main' into vp_texture_ext 2024-06-17 10:48:45 -05:00
FEA-eng
f413f5d6d0 Preselection preference text improvement (#14579)
* Update CommandView.cpp

* Update DlgSettingsSelection.ui
2024-06-17 10:40:03 -05:00
Kacper Donat
5328ca828f Gui: Split declaration and definition of ToolBarAreaWidget
In order to support targeting ToolBarAreaWidgets via the QSS we need to
make it a proper QObject using Q_OBJECT macro, which must be placed in
header files.
2024-06-17 10:38:12 -05:00
Chris Hennes
5dad1ef528 Merge pull request #14393 from NomAnor/visibility-icon
Change visibility icon default to enabled and tweak visuals
2024-06-17 10:36:35 -05:00
wmayer
80670094eb Clean-up code and improve formatting 2024-06-17 16:30:25 +02:00
David Carter
417ca72977 Materials: Render Transparency
Under certain conditions an objects transparency would no be updated.

fixes #14568
2024-06-16 22:20:06 -05:00
wmayer
32830c0680 Gui: Fix comparison of argument of clicked() with StandardButton
Fixes #14639: Comparison between integers and StandardButton fails for Python task dialogs with PySide6
2024-06-16 22:18:58 -05:00
wmayer
2b52bed558 Gui: Fix possible crash when using Shiboken::Enum::getValue
Fixes #14156
2024-06-16 22:18:58 -05:00
MisterMakerNL
4bbff00727 fix for lag 2024-06-16 22:18:20 -05:00
MisterMakerNL
78a25c53c8 Update CMakeLists.txt
I used the wrong names, so it didn't work.
I did tested it and it did worked once, not sure what happend.
2024-06-16 22:18:20 -05:00
bgbsww
8e4c96d23b Toponaming: fix secondElementSelection and SelectionView 2024-06-16 22:15:11 -05:00
wmayer
2ad397e18e Core: Remove superfluous + operator 2024-06-16 07:53:50 +02:00
MisterMaker
b205922c42 Default stylesheets revision + clean-up (#13772)
* Added the new QSS file with images

Added the new QSS file with images

* fixed some disabled colors to be the same everywhere.

* update

* big update fixed the scrollbars and lots more.

* small tweaks

* small fixes

* fixed groupbox in qsint

* Added light classic

This light theme is basicallyt exactly no-stylesheet.

* fixed the tabs

* fixed background reportview

* updated overlay stylesheets

* Added preference settings from Opentheme @obelisk79

* tabbar tweaks

* forgot the gradients on dark

* Overlay stylesheets clean-up +move icon to folder.

* removing old stylesheets

removing old stylesheets

* it was icons not icon, fixed it.

* updated cmake and package.xml

* to many spaces

* removing old theme's

* updated default overlay qss

* removed my settings files

* updated cfg files

* Bunch of fixes

I compiled it and didn't see any issues anymore. Could be some discussions about the new startpage thumbnails.

* fixed up double arrows and the correct logo!

* updated the work file for the icons

* Sets no-stylesheet overlay to a stylesheet.

* type in cmakelist

* type in filename

* oeps did set the dark theme

* Update OverlayManager.cpp

I removed a bit to much reverting this line

* fixed text color issue in Qsint on the light theme and dark background

* Update Light Theme + Dark Background.qss

Fine tuning the treeview it now works good for ligth theme and dark brackgrounds.

* removed prodark added back Behave dark overlay

@Syres916 I deleted the overlay qss behave dark by accident.
But you might want to check this PR out since it changes a lot.

I deleted Pro-dark since it was not updated and is outdated and it looks also a lot like the default dark.

* Update Light Theme + Light Background.qss

Fixes

* small fixes

small fixes

* remove ProDark

* Update CMakeLists.txt

* changed the thumbnails

Also removed teh dimensions in the filename since that got annoying real fast :)

* Updated other overlay stylesheets

* missing extension

* cleanup and some fixes to the overlay.

* Update Dark Theme + Light Background.qss

udpated the dark theme overaly with light background for all you maniacs who use this.

* Title bar fix for windows

This makes it so that it uses black title bar in windows if you have dark mode

* updated white background and some colors

* I think I fix merge issue now.

* Some cleanup on the thumbnails

* Create CMakePresets.json

* idk

* trying to fix conflicts

* removing old themes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Some fixes for Qsint sketcher toolbars icons

* fixed merge issue with maingui

* trying to fix merge conflicts

* and removing again.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-13 22:13:05 -05:00
wmayer
9b198c7704 MSVC: Fix warnings and build failure 2024-06-12 10:36:58 -05:00
PaddleStroke
974f57cf94 Core: Add Gui::Document::getTreeRootObjects() 2024-06-12 10:57:24 +02:00
hlorus
bb7aa6ac74 Remove Std_MeasurementSimple 2024-06-11 17:57:01 +02:00
hlorus
b42c3aade0 Remove Std_MeasureDistance 2024-06-11 17:57:01 +02:00
wmayer
b4c5a6d5ba Fix several regressions:
+ improve PropertyMaterialList::readString
+ fix transparency handling in ViewProviderPartExt
+ do not register the private member '_diffuseColor' as property because it would be exposed to the
  public where it can be modified
+ fix ViewProviderPartExt::finishRestoring() to correctly restore old project files
+ fix ViewProviderPartExt::setHighlightedFaces() to correctly show face colours if VBO is enabled
+ fix ViewProviderBoolean::updateData()
  fix ViewProviderMultiFuse::updateData()
  fix ViewProviderMultiCommon::updateData()
  fix ViewProviderCompound::updateData()
  fix ViewProviderFillet::updateData()
  fix ViewProviderChamfer::updateData()
  that all set invalid transparency values
+ Filter ShapeAppearance in ViewProviderBody::unifyVisualProperty
  because body features usually have different number of faces than the body itself
+ manually fix some bad looking auto-formatted code
+ clean up code and remove duplicated code
2024-06-11 11:58:32 +02:00
wmayer
a58eebd903 Gui: Move texture handling to view provider extension
It should be avoided to add all stuff to the base class when it's only needed in one sub-class
2024-06-11 11:55:44 +02:00
Kuzemko Alexsandr
aca353d7c5 Displaying internal names in the tree view (#14237)
* Displaying internal names in the tree view

* Change "Hide extra column" to "Hide Description"

---------

Co-authored-by: Kuzma30 <kuzemkoa@gmail.com>
2024-06-10 11:31:04 -05:00
Florian Foinant-Willig
430594ef81 Fix SubElements selection for PropertyLinkSubList 2024-06-10 11:20:37 -05:00
wmayer
133d13bf7f Fix a couple of language change issues
When changing the language in the preferences dialog without closing it then a few things are not re-translated
2024-06-10 11:19:37 -05:00
Chris Hennes
e79ed3be95 Merge pull request #14507 from Rexbas/gesture-rotation-mode
Gui: Fix Gesture navigation rotation mode
2024-06-10 11:14:18 -05:00
Syres916
245e66ed3a [Gui] Fix BehaveDark StatusBar Flickering Border...
...and sync tooltip colours and size
2024-06-10 11:08:44 -05:00