Commit Graph

2844 Commits

Author SHA1 Message Date
Paddle
e7ed8e295e Rectangle DSH : change names or modes. 2023-11-07 15:36:21 +01:00
Paddle
8f17091b8b Fix focus passing between OnViewParameters with tab. 2023-11-07 15:36:21 +01:00
Paddle
5e8701a2ca Fix bug nParameter is not initialized based on construction methode.
Also fix bug construction methode combobox is not at correct index on tool start if not first methode.
2023-11-07 15:36:21 +01:00
mosfet80
2b2a20d9d9 [planegcs] Removed unused code. (#10684)
* Revert cleanplanegcs: removed unused code, removed redefinition of pi
* Sketcher: Switch pi refs to double and constexpr
* Modify code to use the new pi constant immediately

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2023-11-06 14:35:59 -06:00
Paddle
a7e1cba6b0 Sketcher_Dimension: If radius of arc is not DoF, then offer arc angle first. 2023-11-06 14:02:54 -06:00
Chris Hennes
37a8e348c6 Merge pull request #11231 from DeflateAwning/http-cleanup
Find and replace http://freecad to https://freecad
2023-11-06 11:16:13 -06:00
Chris Hennes
590fb19f31 Merge pull request #10978 from FlachyJoe/modernize-type-check
Modernize type and derived type checking
2023-11-06 10:44:32 -06:00
Adrian Insaurralde Avalos
10b51f92eb Sketcher: fix Line tool settings mode name 2023-11-05 07:36:22 +01:00
Abdullah Tahiri
3eda026ecb Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
533250bc34 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Paddle
8239483c35 Offset fix isActive function. 2023-11-04 08:58:50 +01:00
Paddle
6efe9d1fba Polygon DSH : Small syntax improvements. 2023-11-04 08:58:50 +01:00
Paddle
48c5a413a3 Line DSH : syntax and remove potential issues. For example in width+length mode, if user input 0 and 0, instead of validating it will unset the spinboxes. Preventing creation of null lines. 2023-11-04 08:58:50 +01:00
Paddle
386467e685 Rectangle DSH : Fix a bug where 3p rectangle with radius, radius would not apply. Also fix various edge cases. Improve syntax. 2023-11-04 08:58:50 +01:00
Paddle
2c27a1da3c Offset DSH : Add pointer SVG. Some remove unecessary member initialization 2023-11-04 08:58:50 +01:00
Paddle
692c6a4cd1 DSDWC : typo 2023-11-04 08:58:50 +01:00
Paddle
923a0de70b Prevent passing the focus to a spinbox when it shouldn't.
In some DSH some mode (seekSecond for example) don't have onViewParameter. In this case it would wrongly try to give focus to the previous spinbox with focus.
2023-11-04 08:58:50 +01:00
Paddle
1a8aaa7d2e Redraw on construction method changed. Avoid a small issue where you had to move mouse first before being able to rechange the methode by the M key. 2023-11-04 08:58:50 +01:00
Paddle
1525b3d024 SketcherToolDefaultWidget : Add a blockParameterFocusPassing bool that let us set parameters without passing focus. To fix undue passing of focus when using shortcuts U/J. For example in Polygon. 2023-11-04 08:58:50 +01:00
Paddle
fcc91e0055 DrawSketchController and DrawSketchDefaultWidgetController : fix lint warnings 2023-11-03 14:02:25 +01:00
Paddle
c9859ab2e2 Sketcher: Polygon DSH 2023-11-03 14:02:25 +01:00
Paddle
513e1a46c8 Sketcher: Offset DSH 2023-11-03 14:02:25 +01:00
Paddle
74e8990044 Sketcher: Rectangle DSH 2023-11-03 14:02:25 +01:00
Paddle
29f17f9c6d Sketcher: Line DSH 2023-11-03 14:02:25 +01:00
Paddle
feb14870b6 Sketcher: Point DSH 2023-11-03 14:02:25 +01:00
Paddle
6d1c9b4161 DSDH : add canGoToNextMode() methode in onButtonPressed. So that we can prevent going to the next mode on certain conditions. 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
e67f6aa7ae Sketcher: Make GeometryConstructionMode an enum class
=====================================================

Enforce strong typing to avoid all kinds of abusive implicit conversionsm, the corresponding associated bugs and make code more readable.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
17b5a561d0 Sketcher: New flexible DSH Architecture
=======================================

Rewrite of the architecture to accomodate on-view parameters and to enable code reuse
between the default widget and custom widgets.
2023-11-03 14:02:25 +01:00
Paddle
118418c5eb DSH architecture: On-view spinboxes 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3e05815834 Sketcher: New DSH architecture to support multiple input
========================================================

Architecture to support multiple input from a widget and a mouse.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
049cef023b Sketcher: DrawSketchHandler - refactor functions to draw/clear edit curve and markers 2023-11-03 14:02:25 +01:00
DeflateAwning
1e3179e9bc Find and replace http://freecad.org to https://freecad.org
Find and replace:
http:\/\/(.{0,10})freecad
https://$1freecad
Done in all remaining files (after doing it in SVGs in the last commit)
2023-10-29 22:39:22 -06:00
DeflateAwning
46b3c02647 Change http to https in SVGs
Find and replace:
http:\/\/(.{0,10})freecad
https://$1freecad
Include: *.svg
2023-10-29 22:32:59 -06:00
Chris Hennes
583e27e8af Merge branch 'main' into modernize-type-check 2023-10-25 16:07:28 -05:00
Paddle
2c5d90daea SketcherToolDefaultWidget : add 3 parameter configuration functions.
And remove the units from setParameter.
2023-10-24 19:28:13 +02:00
Paddle
48131bafc2 SketcherToolDefaultWidget : add functions to set combobox item icons and checkboxes icons. 2023-10-23 20:24:20 +02:00
Florian Foinant-Willig
c0e8fa1e75 Sketcher: modernize type checking 2023-10-23 18:09:23 +02:00
Paddle
0f049a6cb0 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
decbcfdd12 Sketch: use new-style connect() in new code 2023-10-20 14:23:21 +02:00
wmayer
e9586c4206 Sketch: fix several compiler and lint warnings
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
2023-10-20 12:29:59 +02:00
wmayer
9578b57e3b Sketch: fix Qt6 build failure
QRegExp has been replaced with QRegularExpression and isn't part of the base of Qt6 any more
2023-10-20 11:57:21 +02:00
Abdullah Tahiri
7034795723 Sketcher: ToolSettings Widget - Tool Management
===============================================

Sets the full interface between the DrawSketchHandler and a tool widget available somewhere in the UI.

Signalling is as follows:
1. On activation of the tool, DrawSketchHandler notifies the tool widget.
2. The tool widget retrieves tool information necessary for representation (type of widget, visibility, ...)
3. When the tool widget has created an appropriate widget, it notifies back a widget change.
4. The tool receives the widget handler and can now configure and interact with the widget.
2023-10-15 15:20:03 +02:00
Paddle
c6f42e1b68 Sketcher: DrawSketchHandler - add getViewer function to drawsketchHandler to simplify code. 2023-10-15 15:20:03 +02:00
Paddle
5ad7548340 ToolWidget-Sketcher: Tool widget basic framework
================================================

Provides a framework to show in the taskbar a taskbox with a tool settings dialog.
2023-10-15 15:20:03 +02:00
Paddle
019bd50bbc Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
wmayer
d305f306df Core: Revert superfluous changes made with PR #9521 2023-10-09 15:06:45 +02:00
Abdullah Tahiri
ead8a9a5d1 Sketcher: Example new type checking template function usage
===========================================================

Just two small refactor examples of how to use the type checking template functions.
2023-10-07 23:12:46 +02:00
Abdullah Tahiri
c7b99b9fbb Sketcher: Fix segfault when activating a tool in a different view
=================================================================

When in Sketcher edit mode, a tool button is activated, while the view has been changing to view of a different type, it segfaults.

This commit checks the pointer of the view to ensure correct type before activation, and refusing to activate if not of the correct type.

fixes #10809
2023-10-07 09:00:06 +02:00
Paddle
2ea27064d5 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
AgCaliva
3ac69993c0 merge master via cli 2023-10-04 13:28:48 -03:00