Yorik van Havre
ead1c43de9
BIM: Make sure we have a default context when exporting to IFC
2025-01-19 14:32:03 -05:00
Chris Hennes
f639705762
Merge pull request #19052 from alfrix/hole_ui_hide
...
feat(PD): Hole UI Taskpanel: hide elements that are not applicable or useful
2025-01-19 11:31:03 -05:00
anselm-baur
e22b226866
Assembly: fix missing space
...
Co-authored-by: Anselm Baur <anselm-baur@live.de >
2025-01-18 14:45:50 -05:00
PaddleStroke
4c25c96d75
PartDesign: replace part design datum commands by the core ones
2025-01-18 11:39:44 +01:00
Chris Hennes
49c77303c7
Merge pull request #18665 from AjinkyaDahale/sk-refactor-stage-2
...
[Sketcher] Round 2 of refactors
2025-01-17 10:41:52 -06:00
Roy-043
a66da9b3d2
Merge pull request #19089 from Roy-043/Draft-Clone-avoid-B-spline-faces-in-more-cases
...
Draft: Clone: avoid B-spline faces in more cases
2025-01-16 19:57:08 +01:00
Roy-043
caca0ac994
Merge pull request #19067 from Roy-043/Draft-Save-fillet-settings
...
Draft: Save fillet settings
2025-01-16 19:52:31 +01:00
Roy-043
b31ada686f
Draft: Clone: avoid B-spline faces in more cases
...
B-spline faces can be avoided if the absolute values of the scaling factors are the same. The `transformShape` method can handle this if two additional arguments are provided.
2025-01-16 13:39:11 +01:00
Roy-043
3385ac8a74
Clean up
...
The recompute and the `try` structure are no longer required.
2025-01-16 11:53:55 +01:00
Roy-043
e7e41bb001
BIM: ArchWall use moveGeometry to move sketch point
...
The movePoint function is no longer available in V1.1.
2025-01-16 11:53:55 +01:00
Ajinkya Dahale
51cf34a596
[Sketcher] Refactor and fix an issue in transferConstraints
2025-01-16 15:56:22 +05:30
Ajinkya Dahale
73253bd2d4
[Sketcher] Fix issues in knot operations
...
For some reason this is not caught in the tests.
2025-01-16 15:56:22 +05:30
Ajinkya Dahale
b2e414c407
[Sketcher] Make replaceGeometries protected
...
This should be a `protected` or `private` operation since it doesn't handle
constraints. However, this is intended to be used by external classes that
modify a `SketchObject` (instead of these modifications like `split`, `trim`,
`join` etc. being methods of `SketchObject`). In that case, it may be best to
use the `friend` keyword.
2025-01-16 15:56:22 +05:30
Ajinkya Dahale
aa1122c774
[Sketcher] Fix "used" B-spline poles being deleted
2025-01-16 15:56:22 +05:30
Ajinkya Dahale
821bc2ecdf
[Sketcher] Incorporate review of #18665 by kadet
...
1. Replace `find_if` with `any_of` when the iterator is not used.
2. Use PascalCase for templated class.
2025-01-16 15:56:19 +05:30
Ajinkya Dahale
c6f5739763
[Sketcher] Refactor SketchObject::split
...
1. Now uses `Part::Geometry::createArc`.
2. Removed type-specific codes. It can be generalized now.
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
e6becd0b61
[Sketcher] Further refactor modifyBSplineKnotMultiplicity
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
12102abd6b
[Sketcher] Incorporate review of #18665
...
...by hyarion on December 29.
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
226d24792d
[Sketcher] Fix some issues in trim
...
Fixes fails at cases where one (or both) of the remaining segments is (are)
degenerate. This existed pre-refactor.
Fixes cases where there are some constraints on internal geometry that do not
get deleted cleanly.
Also fixes a memory leak.
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
e4f906c23b
[Sketcher] Refactor SketchObject::trim
...
Cognitive complexity down to 57.
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
3832db01ff
[Sketcher] Refactor SketchObject::modifyBSplineKnotMultiplicity
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
6ba1b0b7a9
[Sketcher] Refactor SketchObject::insertBSplineKnot()
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
0ded3a4af1
[Sketcher] Refactor SketchObject::trim()
...
1. Use `Part::GeomCurve::createArc()`
2. Refactor constraint logic in `trim`
2025-01-16 15:55:14 +05:30
Ajinkya Dahale
5a01d438f2
[Sketcher] Refactor internal geometry operations
...
* Use range-for and rearrange for understandability.
* Break down into individual functions by geomtype.
* Also refactor `exposeInternalGeometryForType<Part::GeomBSplineCurve>`
* Use `Constraint::involves...()` in delete internal
Suppress clang-tidy/clazy warnings by using `[[maybe_unused]]`.
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org >
2025-01-16 15:54:47 +05:30
Ajinkya Dahale
568f984b0b
[planegcs] Refactor pointer vector freeing
...
Remove the type-checks in `free(std::vector<Constraint*>& constrvec)` as well as
checks for `nullptr` before deleting.
2025-01-16 15:52:03 +05:30
Ajinkya Dahale
2025c009cd
[planegcs] Refactor conditions & loops in GCS.cpp for readability
2025-01-16 15:52:03 +05:30
Ajinkya Dahale
a2521d0798
[planegcs] Refactor identifyConflictingRedundantConstraints()
2025-01-16 15:52:03 +05:30
Ajinkya Dahale
bd522fe189
[planegcs] Refactor GCS::System::initSolution()
2025-01-16 15:52:02 +05:30
Ajinkya Dahale
bc2b35da4e
[Sketcher] Helper functions for deleting geometry
...
Some tests probably needed
2025-01-16 15:52:02 +05:30
Ajinkya Dahale
2249c99b33
[Sketcher] Write SketchObject::replaceGeometries()
2025-01-16 15:52:02 +05:30
Ajinkya Dahale
5c52353480
[Sketcher] Refactor SketchObject::join() (expected trivial)
...
No tests are added since this commit only adjusts if-then statements.
2025-01-16 15:52:02 +05:30
Ajinkya Dahale
5a4072587b
[Sketcher] Some trivial for loop changes in SketchObject
...
No tests added since this should be no more different than existing code.
2025-01-16 15:52:02 +05:30
Ajinkya Dahale
0f3aff0eac
[Sketcher][test] Create test for getConstraintAfterDeletingGeo+
...
[Sketcher] Add null case to constraint change on deletion checks
2025-01-16 15:52:02 +05:30
Tim
201eca4d02
Addon Manager: Improve proxy URL parsing & enhanced the error messaging ( #19078 )
2025-01-15 13:39:04 -06:00
Alfredo Monclus
001ce1b479
refactor(PD): hole taskpanel remove minimumSize
2025-01-15 14:57:49 -03:00
Chris Hennes
115cd050bc
Merge pull request #19019 from hyarion/refactor/countObjectsOfType
...
Refactor countObjectsOfType in selection and document
2025-01-14 16:05:12 -06:00
Roy-043
288f3aad09
Draft: Save fillet settings
...
Fixes #16248 .
2025-01-14 21:48:16 +01:00
wmayer
cb4dd89d55
Fix several compiler warnings
2025-01-14 13:34:18 -06:00
Benjamin Nauck
7b22027b90
Add template based Document::countObjectsOfType
...
Also convert code to use this new method
2025-01-14 14:23:46 +01:00
Yorik van Havre
00c00ed595
BIM: Fixed late global declaration - fixes #19049
2025-01-14 13:32:23 +01:00
tritao
13cc6a8d22
BIM: Only import TechDraw when its actually needed.
...
Allows FreeCAD BIM module to load without TechDraw module compiled.
2025-01-14 11:14:16 +01:00
Alfredo Monclus
4b2fdd4ff4
refactor(PD): hole taskpanel alias/promote QuantitySpinBox from QDoubleSpinBox instead of QWidget to represent it correctly on the designer
2025-01-14 06:04:10 -03:00
Chris Hennes
0b1d7349b0
MSVC: Add missing PreCompiled.h includes
2025-01-14 09:28:47 +01:00
João Matos
6222b935f0
Gui: Scene inspector improvements ( #18781 )
...
* Improve naming for root scene graph switch/separator nodes.
* Improve scene graph inspector.
This commit improves the scene graph inspector by improving the UI
layout and displaying information in a more human-readable way.
Instead of having a main generic string column for all node-specific
data, introduce specific columns for node name, memory address and data.
Better visualization was also added for `SoDrawStyle`, `SoPickStyle`
and `SoCoordinate3` node types.
2025-01-13 21:38:41 -06:00
Yorik van Havre
fe60505c17
Translations ( #18923 )
...
* Updated ts files
* Merged crowdin translations
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-01-13 21:30:30 -06:00
wandererfan
4ba83f0f50
[TD]use transformShape instead of transformGeometry
2025-01-13 21:14:10 -06:00
Alfredo Monclus
4dae03a994
feat(PD): hole taskpanel ui hide thread options if profile is none
2025-01-13 18:24:07 -03:00
Alfredo Monclus
4e5f5c4481
feat(PD): hole taskpanel ui hide hole cut options if not cut
2025-01-13 16:59:28 -03:00
Alfredo Monclus
36682bcee8
refactor(PD): remove the ui file connections, this are handled in the task code
2025-01-13 16:59:28 -03:00
Alfredo Monclus
6077317d12
feat(PD): hole taskpanel ui hide thread group if not threaded hide threadFit if threaded
2025-01-13 16:22:21 -03:00