Commit Graph

5350 Commits

Author SHA1 Message Date
Alexander Golubev
eaeba5686f Suppress a couple more warnings 2016-04-12 18:12:21 +02:00
Alexander Golubev
27667cf5e6 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
DeepSOIC
f143e08fad Fix problems with unlimited external geometry
Caused by recent changes by abdullah, which assumes there is external
geometry only if sketch has support.
http://forum.freecadweb.org/viewtopic.php?f=3&t=12746&p=102087#p102087
2016-04-12 18:12:21 +02:00
Stefan Tröger
1a748c4d51 Simplify the feature pick dialog
less options are easier to grasp for the user
2016-04-12 18:12:21 +02:00
Stefan Tröger
f058ae12e9 fix sketch classification for other body
hasObject does search recursive only in groups, but a body is not a group. Hence for sketches within a body this will always return false. Annother logic must be used to detect sketches in bodies.
2016-04-12 18:12:21 +02:00
Stefan Tröger
571e5d55d2 fix sketch selection in part design
validateSketch was faulty: as every sketch is valid (non is removed) it could happen that the returned number was >0 but the iterator firstValidSketch was NULL nontheless. The routine needed to be udated to make snese and the usage in prepareSketchbased together with it.
2016-04-12 18:12:21 +02:00
Stefan Tröger
ad5785654e add only a single reference copy 2016-04-12 18:12:21 +02:00
Stefan Tröger
fe5d8b957d Fix incorrect ShapeBinder recalculation 2016-04-12 18:12:21 +02:00
Stefan Tröger
932f976dd9 Ensure correct sketch placement calculation
As bodies are movable now they need to be taken into account for calculating the sketch placement.
2016-04-12 18:12:21 +02:00
Stefan Tröger
d878028c60 Fix sketch on face of other body or part
The shapebinder object reduces the number of faces to 1, hence the subshape to select is always Face1 and not the original face name
2016-04-12 18:12:21 +02:00
Stefan Tröger
3b43f2cdc5 fix body booleans 2016-04-12 18:12:20 +02:00
Stefan Tröger
f2ad7bde4b PartDesign/Gui: minor fix sWhatsThis of text 2016-04-12 18:12:20 +02:00
Stefan Tröger
08287504fa Fix crossreference handling 2016-04-12 18:12:20 +02:00
Stefan Tröger
a92746da22 crossreferences only with ctrl button and fix missing return value 2016-04-12 18:12:20 +02:00
DeepSOIC
b21950326c Sketcher: when refusing to link external, print why (in statusbar) 2016-04-12 18:12:20 +02:00
DeepSOIC
61dd847db1 Sketcher: allow referencing everything; add testing for circular references 2016-04-12 18:12:20 +02:00
Stefan Tröger
a8781fdacc handle independent copies more gracefully 2016-04-12 18:12:20 +02:00
Stefan Tröger
afc666e587 change point of reference feedback for datums
On datum creation it is better to ask the user on OK than on tool activation, as he might hit cancel (and then the created references are till there) or even more important, he could add additional external references within the dialog. The disadvantae is that if the user sets "cross reference" ge gets asked again every time he opens and leaves the dialog.
2016-04-12 18:12:20 +02:00
Alexander Golubev
1ac37a44f3 PartDesign/Body: add ability to store facebinders inside a body 2016-04-12 18:12:20 +02:00
Stefan Tröger
4e1a9c05cb ask user if he creates inter part/body references 2016-04-12 18:12:20 +02:00
Stefan Tröger
6f8dc62297 add task for datum shape features 2016-04-12 18:12:19 +02:00
Stefan Tröger
c8d9e76a65 PartDesign/Plane: several enhancements to plane icon 2016-04-12 18:12:19 +02:00
Stefan Tröger
00b230fdf8 Setup ShapeBinder Viewprovider and command 2016-04-12 18:12:19 +02:00
Stefan Tröger
21740ffda1 PartDesign: Reorder datum commands 2016-04-12 18:12:19 +02:00
Stefan Tröger
b610dcc97c fix dependent copy references
to make them work with sketches an additional Part2DObject reference needed to be created
2016-04-12 18:12:19 +02:00
Alexander Golubev
266a36bb94 PartDesign/TaskLoftParameters: Added UpdateView checkbox +cleanup 2016-04-12 18:12:19 +02:00
Alexander Golubev
96ae671a23 PartDesign/Gui: prevent Task*PatternParameters not crash on non sketchBased features 2016-04-12 18:12:19 +02:00
Alexander Golubev
3261fdce14 PartDesign/TaskLoftParameters: removed unused hidden widgets 2016-04-12 18:12:19 +02:00
Alexander Golubev
57c583bb09 Part/Gui: remove ViewProviderPart::onDelete which handled unnecessary body housekeaping
Also do some headers cleanup
2016-04-12 18:12:19 +02:00
Alexander Golubev
3bbbb941d1 PartDesign/ViewProviderBody: reduce number of recalculations in the body 2016-04-12 18:12:19 +02:00
Alexander Golubev
ec47cfce54 PartDesign/Gui: rework of ViewProviderDatumCS 2016-04-12 18:12:19 +02:00
Alexander Golubev
4aaad7811f PartDesign/ViewProviderDatum: minor enhancements
- added defaultSize constant
 - fixed typo in margin{g,}Factor function name
2016-04-12 18:12:19 +02:00
Alexander Golubev
a8fcda3523 GeoFeaturertDesign/Gui: Add recompute sizes and datums to the body vp 2016-04-12 18:12:19 +02:00
Alexander Golubev
ba57e0e4dd PartDesign/Gui: rework ViewProviderDatumPlane 2016-04-12 18:12:19 +02:00
Alexander Golubev
0be77b1884 PartDesign/Gui: make Datums use general material interface
- Make Datums colorable and transparent
 - Change default datums color to yellow and transparency to 60%
 - Rework Lines and Points datum view provider
 - Add ViewProviderDatum::defaultBoundBox()
2016-04-12 18:12:19 +02:00
Alexander Golubev
d62aa38ac4 PartDesign/App: cleanup datum's classes and headers 2016-04-12 18:12:19 +02:00
Alexander Golubev
2c3bca4c9e PartDesign/CommandBody: a minor fix in MoveTip command 2016-04-12 18:12:19 +02:00
Alexander Golubev
68c78de00d PartDesign/Gui: add origin sizing and rework datums sizing 2016-04-12 18:12:18 +02:00
Alexander Golubev
3ed51ac4bd PartDesign: add Origin to the Body and unstrap the module from the Parts 2016-04-12 18:12:18 +02:00
Alexander Golubev
d72a919384 OriginGroup: add new abstraction layer between the Part and the GeoFeatureGroup 2016-04-12 18:12:18 +02:00
Alexander Golubev
1d7a1982aa Part/Attacher: remove a couple of no more valid asserts 2016-04-12 18:12:18 +02:00
Alexander Golubev
305151be34 App/Origin: big refactoring
- Rebase App::Origin on App::DocumentObject
 - Keep all control over the Origin structure inside the Origin and it's
   ViewProvider
 - Add OriginFeature class as common base for App::Plane and App::Line
 - Rebase App::Plane and App::Line on top of newly created class and
   move to the file.
 - Change Origin's ViewProvider API associated with temporary display
 - Lots of associated changes to files
 - Several minor fixes
 - Lots of new bugs
2016-04-12 18:12:18 +02:00
Alexander Golubev
ade1dec103 Revert "part deletion handling"
This reverts commit 6ab2002021ac1df26ebe77f488f5cd94e1df0b26.
2016-04-12 18:12:17 +02:00
Alexander Golubev
78de2a193a Commented out a portion of code cosed a segfault 2016-04-12 18:12:17 +02:00
Alexander Golubev
9db890015c PartDesign/Body: move deletion of subobjects to view provider 2016-04-12 18:12:17 +02:00
Alexander Golubev
067530c168 PartDesign/Gui: Make partDesign's add sketch command Workflow-aware 2016-04-12 18:12:17 +02:00
Alexander Golubev
ddd0ecafa9 PartDesign/Gui: initial migration command implementation 2016-04-12 18:12:17 +02:00
Alexander Golubev
771c2b2fce PartDesign/Gui: rename some fonctions in ReferenceSelection.cpp
e.g. getPythonStr -> buildLinkListPythonStr etc
2016-04-12 18:12:17 +02:00
Alexander Golubev
37aab92bbc PartDesign/Body: remowe Part::Feature from isAllowed() 2016-04-12 18:12:17 +02:00
Alexander Golubev
9e47fea5ab PartDisign/WorkflowManager: initial implementation 2016-04-12 18:12:17 +02:00