Commit Graph

1359 Commits

Author SHA1 Message Date
Benjamin Bræstrup Sayoc
cdb92768fe [TechDraw] Return logic simplification (#16504)
* [TechDraw] AppTechDrawPy.cpp return logic simplification

* [TechDraw] CosmeticExtension.cpp return logic simplification

* [TechDraw] DrawBrokenView.cpp return logic simplification

* [TechDraw] HatchLine.cpp return logic simplification

* [TechDraw] LineGenerator.cpp return logic simplification

* [TechDraw] Preferences.cpp return logic simplification

* [TechDraw] ShapeExtractor.cpp return logic simplification

* [TechDraw] MDIViewPage.cpp return logic simplification

* [TechDraw] QGILeaderLine.cpp return logic simplification

* [TechDraw] QGIRichAnno.cpp return logic simplification

* [TechDraw] QGTracker.cpp return logic simplification
2024-11-18 16:14:47 -03:00
luzpaz
ed40de3e23 Fix various typos
Found via codespell.
2024-11-15 20:18:46 +01:00
PaddleStroke
d9ec45b2f6 Techdraw: Fix assembly exploded view (#17726) 2024-11-11 17:53:34 +01:00
WandererFan
60cb2fb005 [TD]handle short&wide hatch area (#17630)
* [TD]handle short&wide hatch area

* [TD]sync .h and .cpp parameter names
2024-11-04 18:01:33 +01:00
wandererfan
aa2c77faef [TD]handle cut profiles with only a single edge 2024-10-28 09:46:41 -05:00
Eric Price
cf8ad66373 Fix boolean operations (#17119)
* add BRepAlgoAPI wrapper files to CMakeList

* introduce wrapper for BRepAlgoAPI_BooleanOperation and derivatives, set sensible default Fuzzyness for boolean operations

* allow default fuzzyness to be set in settings - including off

* backwards compatibility with OCCT 7.3.3 - removed newer paramateres from wrapper

* added missing header

* reverted src/Mod/Part/App/OpenCascadeAll.h to original state

* implement some changes suggested by @wwmayer

* removed unneeded destructor definitions

* moved getDefaultFuzzyValue into its own helper class

* removed unneeded references to base class default constructor

* default to SetRunParallel(Standard_True) as suggested by @FlachyJoe

* fixed license header as requested

* Added new method to autocalculate fuzzyness to BooleanOperation base class and use it for those parts that do not call the obsolete constructor but also do not set precision

* implemented static variable solution as suggested by @wwmayer

* added helix for test case

* Refactoring FCRepAlgoAPI to FCBRepAlgoAPI

* Added Test Case (fuse cylinder with helix with different working and non-working Fuzzy values)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* increased default value of FuzzyBoolean and made tests more robust for compatibility with OCCT 7.3

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fixes for FREECAD_USE_PCH - allow testing of FREECAD_USE_PCH on linux with cmake switch (default OFF)

* removed surplus line - wasn't needed after all

* included precompiled as instructed

* set anti-corruption flag in boolean operations, ensures source shape is not damaged in OCCT 7.1 and higher

* fix #17085

* disable subtests that were too specific for now

* fixed all CLI tests - see comments in Pull Request https://github.com/FreeCAD/FreeCAD/pull/17119#issuecomment-2420772452

* Update src/Mod/PartDesign/PartDesignTests/TestTopologicalNamingProblem.py

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

suggested updated test by CalligaroV

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* Update tests/src/Mod/Part/App/TopoShapeExpansion.cpp

Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>

* remove surplus tests from github suggestion interface bug

* hide the BooleanFuzzy variable - can now be only set by manually editing the config file
i
in FCParamGroup "Boolean"
<FCFloat Name="BooleanFuzzy" Value="10.000000000000"/>

* Suggestion by @FlachyJoe - add validity checks to the base and tool shape in any direct boolean op

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>
2024-10-21 18:38:51 +02:00
Syres916
0f72c18e64 [TechDraw] Fix error for some compilers 2024-10-15 14:19:05 +02:00
WandererFan
42a61ca889 [TD]Fix bad circles (fix #16980) (#17182)
* [TD]fix spurious messages in GeometryMatcher

* [TD]fix closed circle test (fix #16980)
2024-10-14 17:47:04 +02:00
wandererfan
9f7e50e4ce [TD]throttle over aggressive dimension autocorrect 2024-10-14 17:45:53 +02:00
WandererFan
e8772751e6 [TD]Fix auto correct msg missing16892 (#16909)
* [TD]fix bad return code on auto-correct fail

* [TD]prevent changing references in property editor

- this is a "shoot yourself in the foot" practice
2024-09-30 18:20:47 +02:00
Yorik van Havre
9b23064ebc Merge pull request #16889 from WandererFan/fixProjConvention16788
[TD]Fix proj convention (fix #16788, fix #16785)
2024-09-30 18:00:43 +02:00
Yorik van Havre
e41def8c74 Merge pull request #16639 from WandererFan/balloonDrag15388
[TD]Balloon origin drag modifiers (fix #15388)
2024-09-30 17:40:23 +02:00
wandererfan
9f334539ff [TD]add preference methods for Projection Group 2024-09-28 10:39:18 -04:00
WandererFan
a1ff05f382 [TD] Fix win file spec backslash (fix #16646) (#16689)
* [TD]add method to clean win filespecs

- '\' in strings passed to Python as filespecs is interpreted as
  an escape of the following character.
- replace '\' with '/'

* [TD]remove '\' from filespecs before use
2024-09-23 17:40:05 +02:00
wandererfan
fcdd946261 [TD]fix torus render (fix #16646) 2024-09-23 09:21:00 -05:00
wandererfan
5ecd2a0b7a [TD]add preferences for Balloon drag modifiers 2024-09-17 17:17:15 -04:00
wandererfan
fe698a3fb2 [TD]fix outer torus edge not rendered (fix #16136) 2024-09-02 18:41:58 +02:00
WandererFan
e852052df8 [TD]Fix section snapping (fix #15961) (#15450)
* [TD]Add view snapping preferences

* [TD]fix section snapping algo

- snap sections to section normal line.
- snap views to other views in X&Y

* [TD]fix snapping to ProjectionGroups
2024-09-02 18:41:25 +02:00
wandererfan
93e685bd7a [TD]fix dim text wrong side of dim line (fix #16172) 2024-09-02 18:24:16 +02:00
wandererfan
e88b1b49c9 [TD]fix balloon drag on rotated view (fix #15726) 2024-09-02 17:47:40 +02:00
wandererfan
884cf22c71 [TD]fix false positives in isCircle (fix #15979) 2024-08-26 18:01:00 +02:00
bgbsww
8c08549f5a Update to Toposhape versions and fix shapebinder references with test (#16036)
* Update to Toposhape versions and fix shapebinder references with test

* Update src/Mod/PartDesign/PartDesignTests/TestShapeBinder.py

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-08-26 10:50:18 -05:00
wmayer
c9a586f34a Building: Boost dependency errors
Fixes #15999
2024-08-22 18:50:24 -05:00
wandererfan
131956e201 [TD]fix crash on Cosmetic line > 10m 2024-08-19 12:34:53 -04:00
wandererfan
595fbc9c1b [TD]detect breakObject inside Body 2024-08-19 11:32:21 -05:00
wandererfan
558db30497 [TD]fix asCircle error calculation 2024-08-19 12:01:01 -04:00
wandererfan
325a2834b1 [TD]fix autoscale loop
- checkfit and autoscale were calculating page size differently
2024-07-29 11:08:59 -05:00
wandererfan
16f25ec4a2 [TD]translate line names at time of use 2024-07-16 14:03:48 -04:00
luzpaz
9c6e78b5cb TD: Trim trailing newlines 2024-07-14 09:25:46 +02:00
wandererfan
4d90e1655a [TD]fix display of spreadsheet cells with no horiz alignment 2024-07-06 18:51:59 -04:00
wandererfan
3ddddc375c [TD]fix default for KeepLabel 2024-07-06 12:49:18 -04:00
wandererfan
d98aa70d0e [TD]fix camera/front buttons on Proj Group dialog 2024-07-06 12:49:18 -04:00
wmayer
fdfffbcc9e TD: Fix DrawViewCollection::unsetupObject()
Assigning a null pointer to a std::string causes a failure
2024-07-03 09:07:17 -04:00
wandererfan
bc51b1ac23 [TD]fix handling of company name in template fields 2024-06-30 09:32:20 -04:00
wandererfan
f53fd6d474 [TD]show autofill value in dialog 2024-06-30 09:32:20 -04:00
wandererfan
6fd73487c7 [TD]allow template fields to re-apply autofill 2024-06-23 09:48:25 -04:00
wandererfan
4d6fbac1a5 [TD]allow manual update of autofill fields 2024-06-23 09:48:25 -04:00
wandererfan
5723180e43 [TD]correct source of autofill fields 2024-06-23 09:48:25 -04:00
wandererfan
eff32fbba8 [TD]fix wrong xml namespace in some templates 2024-06-23 09:48:25 -04:00
Chris Hennes
4454275146 TD: Use new Qt6.5 interface for setContent (#14543) 2024-06-17 11:33:15 -05:00
wandererfan
6b84b65841 [TD]fix segfault on confused selection
- failure in DrawDimHelper when both 2d & 3d geom selected
2024-06-16 13:15:19 -04:00
wandererfan
1e847e3c7b [TD]remove spurious error messages 2024-06-13 19:25:29 -04:00
bgbsww
d467236564 Guard all uses of basic_random_generator for thread safety 2024-06-10 11:10:57 -05:00
PaddleStroke
ba0ff0db5e Techdraw: area dimension: fix scale issue. 2024-06-10 08:28:36 -04:00
wandererfan
5ca6eab922 [TD]fix incorrect section lines with expression link 2024-06-07 10:19:13 -04:00
Syres916
f8cb31ba0e [TechDraw] Improve visibility of TD preference icons in combo boxes...
...when using dark style sheets.
2024-06-03 09:03:33 -04:00
wandererfan
7d6e9b19fb [TD]add style options for broken view 2024-05-29 14:12:13 -04:00
wmayer
4185605d5e clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
PaddleStroke
48f43429bb TechDraw: Enable snapping section views to their base views. 2024-05-27 11:44:31 -04:00
obelisk79
b6c214b9e5 Resolves missing include for GCC14 compilers 2024-05-26 10:11:50 -04:00