Commit Graph

1131 Commits

Author SHA1 Message Date
Ajinkya Dahale
ee2d324744 [Sketcher] Fix some issues with trimming splines
1. Transfer point-on-object to the correct resulting curve: Currently the
constraint remains on the "start" curve created after the trim.
2. Expose internal geometries of both resulting B-splines.
2024-06-24 21:56:58 +05:30
Ajinkya Dahale
1a6a7d07c2 [Sketcher] Rearrange directives to appease syntax highlight
Spacemacs doesn't handle the braces flow very well. This commit can be dropped
if necessary.
2024-06-24 21:56:58 +05:30
wmayer
127f935711 Fix several compiler warnings
* -Wmaybe-uninitialized
* -Wunused-parameter
* -Wunused-variable
* -Wnonnull
* -Wstringop-truncation
* -Wstringop-overflow
2024-06-19 21:14:23 -05:00
Chris Hennes
c601438b71 Fem/Sketcher: Fix missing PreCompiled.h files 2024-06-18 08:05:32 -05:00
bgbsww
c5de6ccfc7 Toponaming: Fix crash with invalid external geometry 2024-06-17 11:31:04 -05:00
Mihail Dumitrescu
7eff7ee9d0 Fix importing arcs and elliptical arcs as external geometry.
Fix importing elliptical arcs issue #8700.
Fix importing arcs into sketches in the case where they project as elliptical arcs.
Fix a discontinuity that happens when an external arc projects down to a segment. The segment end points should not jump around if the projection angle changes from 89.9 to 90 degrees.
When handling external geometry compare points for equality in a consistent way and remove some dead code.
2024-06-17 11:04:52 -05:00
bgbsww
42eb4fdda6 Guard all uses of basic_random_generator for thread safety 2024-06-10 11:10:57 -05:00
mosfet80
e31aa5e5e3 [mod] clean (#14378)
* [mod] clean

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-06-10 11:07:14 -05:00
Chris Hennes
6759c72eb6 Merge pull request #14337 from wwmayer/refactor_sketch_analysis
Sketch: Refactor SketchAnalysis
2024-06-03 10:49:30 -05:00
wmayer
560cab6f31 clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
wmayer
2b108b1bb3 Sketch: Refactor SketchAnalysis
Refactor detectMissingPointOnPointConstraints()
2024-05-28 15:28:53 +02:00
wmayer
60574c6507 Sketch: Refactor SketchAnalysis
Refactor detectMissingEqualityConstraints()
2024-05-28 15:10:51 +02:00
wmayer
4b8ef4721a Sketch: Refactor SketchAnalysis
Fix linter warnings
2024-05-28 14:43:46 +02:00
wmayer
645c7acf65 Sketch: Refactor SketchAnalysis
Refactor autoconstraint()
2024-05-28 14:28:07 +02:00
wmayer
ad56548739 Sketch: Refactor SketchAnalysis
Refactor makeMissingEquality()
2024-05-28 14:19:58 +02:00
wmayer
b052470b93 Sketch: Refactor SketchAnalysis
Refactor makeMissingVerticalHorizontal
2024-05-28 14:08:44 +02:00
wmayer
7f00aad6aa Sketch: Refactor SketchAnalysis
Refactor makeMissingPointOnPoint
2024-05-28 13:40:38 +02:00
wmayer
8abbed295e Sketch: Refactor SketchAnalysis
Refactor detectMissingPointOnPointConstraints
2024-05-28 13:24:05 +02:00
wmayer
7a2fa1dce8 Sketch: Refactor SketchAnalysis
Move helper classes to anonymous namespace
2024-05-28 12:26:23 +02:00
wmayer
72fb5782ed Sketch: Add test case for validating constraints 2024-05-27 19:15:18 +02:00
wmayer
1e81b7f393 Sketch: Add test case for degenerated geometry 2024-05-27 19:15:18 +02:00
PaddleStroke
a7c2b9cc6f Sketcher: Fix copy of geo constrained to axis. Fixes #14233 2024-05-27 11:37:33 -05:00
wmayer
0a5a049c87 Sketcher: Fixes #14240 2024-05-27 12:09:35 +02:00
wmayer
9f44b3f9a8 Sketch: Refactor Sketch::updateGeometry() 2024-05-20 11:38:06 -05:00
bgbsww
b82e3c73d4 Toponaming: Fix point crash bug 2024-05-16 09:05:27 -05:00
bgbsww
6fa5dc42c6 Toponaming: bring in missing code fragments in Sketcher 2024-05-13 15:47:44 -05:00
bgbsww
ffba7dcbe6 Fix #13858
Mistaken enabling of known bad code
2024-05-07 10:17:48 -05:00
bgbsww
4022e4151e Ensure we set up a valid sketch even with invalid external references 2024-05-06 17:42:38 +02:00
WandererFan
dd09bd2b53 Merge pull request #9750 from hlorus/gsoc2023_measure
GSoC 2023: Unified Measurement Facility
2024-04-29 12:41:54 -04:00
hlorus
309e1c4155 [Sketcher] Add handlers for unified measurement facility 2024-04-29 09:27:22 -04:00
wmayer
af2bbf674e Sketch: expose several methods to Python
* expose detectDegeneratedGeometries to Python
* expose removeDegeneratedGeometries to Python
* expose delConstraintsToExternal to Python
* expose evaluateConstraints to Python
* expose validateConstraints to Python
2024-04-21 10:41:47 +02:00
bgbsww
459644be31 TopoShape/Part: Bug fixes; pass Hasher parms, OCCT 7.8 compatibility, ElementMaps correct item count 2024-04-14 13:56:07 -04:00
bgbsww
942ebd58f0 Toponaming/Part: Add deprecation comments, clean up code 2024-04-09 21:17:08 -04:00
wmayer
7a7c0081c3 Part: Add overloaded methods of GeomBSplineCurve::approximate 2024-04-03 18:06:00 +02:00
PaddleStroke
956841056e Sketcher: Symmetry fix #13164 2024-04-01 11:20:40 -05:00
PaddleStroke
6f817fa190 Sketcher: Chamfer Fix #13049 2024-04-01 11:04:02 -05:00
sliptonic
d82ee98d46 Merge pull request #12602 from FlachyJoe/arc-distance
Sketcher : ArcLength Constraint
2024-04-01 10:43:35 -05:00
bgbsww
51a311e6fb Toponaming/Part: Bug fix for #13169 while we sort this out 2024-03-27 21:33:57 -05:00
bgbsww
8d5385fcd2 Clean, enable disabled element map code in sketcher, add tests 2024-03-25 21:51:41 -04:00
Zheng, Lei
8dd6863414 Toponaming/Part: Move sketcher override of getElementName over 2024-03-25 21:51:41 -04:00
Florian Foinant-Willig
311137c958 fix undeclared M_PI 2024-03-25 22:32:20 +01:00
Florian Foinant-Willig
ef35ec195d Sketcher : ArcLength Constraint 2024-03-25 22:32:20 +01:00
PaddleStroke
a8adc573f8 Sketcher: Symmetry tool rework. 2024-03-25 17:48:01 +01:00
luzpaz
65cdbe3e89 Fix various typos throughout the codebase (#13029)
* Fix various typos throughout the codebase

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-03-18 16:54:30 -05:00
PaddleStroke
58975135f4 Sketcher: Chamfer tool (and fillet refactor) 2024-03-18 13:23:54 -04:00
Ladislav Michl
d95b56137b Base: Implement TimeElapsed
Some instances of TimeInfo serve the sole purpose of measuring time
duration. Using system time is unfortunate as it returns wall clock,
which is not guaranteed to be monotonic. Replace such a usage with
the new TimeElapsed class based on steady clock.
2024-03-05 12:29:24 +01:00
wmayer
63eb83c8f3 Sketch: fix compiler warning
Fix warning: add explicit braces to avoid dangling else [-Wdangling-else]
2024-03-04 23:15:42 -06:00
Josh Coalson
fbd8767242 Part: Rename AttachExtension::Support property to AttachmentSupport, to avoid name conflict with base features. Fixes #7052 2024-03-04 18:22:43 +01:00
Ajinkya Dahale
9c774710be [Sketcher] Join curves with C1 continuity
If endpoint-to-endpoint tangent constraint exists between the connecting points
of the curves to be joined, also apply C1 continuity (i.e. a knot multiplicity
of degree-1).
2024-02-27 09:57:52 -06:00
Ajinkya Dahale
19b68b9862 [Sketcher] Include endpoint-to-endpoint tangency as coincidence
Coincidence is implied as part of this particular variety of tangent constraint.
2024-02-27 09:57:52 -06:00