Commit Graph

2421 Commits

Author SHA1 Message Date
wmayer
41b1fdcb84 PD: Fixes issue #14598: FreeCAD crashes on Undo 2024-06-17 11:11:12 -05:00
Chris Hennes
c901a2232f Merge branch 'main' into vp_texture_ext 2024-06-17 10:48:45 -05:00
wmayer
8f6798fcc1 PD: Fix Qt warning at runtime
QListWidget::item is not declared as Q_SIGNALS and thus cannot be used as sender in QObject::connect()
2024-06-16 22:21:01 -05:00
wmayer
9b198c7704 MSVC: Fix warnings and build failure 2024-06-12 10:36:58 -05:00
wmayer
b4c5a6d5ba Fix several regressions:
+ improve PropertyMaterialList::readString
+ fix transparency handling in ViewProviderPartExt
+ do not register the private member '_diffuseColor' as property because it would be exposed to the
  public where it can be modified
+ fix ViewProviderPartExt::finishRestoring() to correctly restore old project files
+ fix ViewProviderPartExt::setHighlightedFaces() to correctly show face colours if VBO is enabled
+ fix ViewProviderBoolean::updateData()
  fix ViewProviderMultiFuse::updateData()
  fix ViewProviderMultiCommon::updateData()
  fix ViewProviderCompound::updateData()
  fix ViewProviderFillet::updateData()
  fix ViewProviderChamfer::updateData()
  that all set invalid transparency values
+ Filter ShapeAppearance in ViewProviderBody::unifyVisualProperty
  because body features usually have different number of faces than the body itself
+ manually fix some bad looking auto-formatted code
+ clean up code and remove duplicated code
2024-06-11 11:58:32 +02:00
wmayer
dd816a635c Fix several compiler warnings
* variable 'xAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'yAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'zAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* unused variable 'base' [-Werror,-Wunused-variable]
* unused variable 'extrude' [-Werror,-Wunused-variable]
2024-06-11 11:42:12 +02:00
Kacper Donat
1f35398d5a Gui: Fix use of no longer existing DiffuseColor property 2024-06-10 19:40:48 -05:00
Florian Foinant-Willig
0b4e01047f Fix can't pad a sketch on datum plane (#14397)
* Fix can't pad a sketch on datum plane

* Add a unit test for Pad a sketch on datum plane
2024-06-10 11:21:32 -05:00
Kacper Donat
b68da9d844 GUI: Add UI for Up To Shape feature
Add UI for Up To Shape feature and overall refactor of Pad / Pocket.
2024-06-10 18:05:21 +02:00
Kacper Donat
3f6f8c0172 Gui: Refactor DressUp VP to use setHighlighted*
This refactors DressUp VP a bit so it does no longer store original copy
of original faces colors to properly support selection, but uses
highlight methods provided by the base class. It simplfies code a bit
and ensures coherent behavior.
2024-06-10 18:05:21 +02:00
wmayer
9456df5a4b Fix compiler warnings 2024-06-04 20:23:19 +02:00
Chris Hennes
681e8c9d2f Merge pull request #14485 from bgbsww/bgbsww-toponamingFixDressUpShadowSubs
Toponaming fix dress up shadow subs
2024-06-03 21:01:22 -05:00
bgbsww
96aa878b7e Toponaming: reformat code 2024-06-03 19:29:01 -04:00
Florian Foinant-Willig
309dd6e30d PD Extrude up to multiple faces or shape 2024-06-03 11:26:19 -05:00
Chris Hennes
696196d8f0 Update translations 2024-06-03 11:04:42 -05:00
Chris Hennes
64fbafe30e Merge pull request #12589 from NomAnor/pd-trans-body
Add a new mode to PD patterns that will transform the base feature's shape instead of the tool shapes
2024-06-03 10:46:33 -05:00
Chris Hennes
bb40f9cfc1 Merge pull request #13317 from Ondsel-Development/add-prop-varset
Core: Add properties to variable sets
2024-06-03 10:34:57 -05:00
Zheng, Lei
6474a44c87 Toponaming: update TaskDressUp addAllEdges 2024-06-03 11:22:55 -04:00
bgbsww
669f2da362 Toponaming: fix bug with points in sketches 2024-06-01 22:57:31 -05:00
David Carter
8b5a3b1124 Material: Appearance Updates 2
Improves the use of the ShapeAppearance property for the Part workbench.

    removes DiffuseColor property
        adds Python compatibility using custom attributes
        transitions DiffuseColor to ShapeAppearance on open
    Improved UI elements for setting object appearance, and appearance per face
    Lays the foundation for future texture support
2024-06-01 19:57:16 -05:00
bgbsww
958d83ed06 Toponaming: Restore use of AttachmentSupport 2024-06-01 11:49:58 -05:00
wmayer
ffad1e0c34 Mod: Fix several compiler warnings 2024-05-30 08:55:11 +02:00
wmayer
4185605d5e clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
André Althaus
917cebd66e Fix signal for Qt < 5.15 2024-05-28 13:48:48 +02:00
André Althaus
cae23ddcc8 Replace combobox with radio buttons 2024-05-28 09:34:08 +02:00
Max Wilfinger
9d0320198f Revert UI command change in Sketcher and PartDesign 2024-05-27 11:51:02 -05:00
Max Wilfinger
904d689218 Adjust shaft wizard icon to match other Part Design icons 2024-05-27 11:24:21 -05:00
Chris Hennes
fc0f9ba83a Merge pull request #14202 from bgbsww/bgbsww-toponamingFixSubShapeBinder
Toponaming fix sub shape binder and restore multishape tests
2024-05-27 11:19:31 -05:00
Chris Hennes
3a080fcc6d Merge pull request #13968 from marcuspollio/UI-TaskPanels-cleanup-1
UI : Task panels cleanup - Sketcher and Part Design headers
2024-05-27 10:56:07 -05:00
David Carter
51be8e7b4e Material: Appearance and Material inspectors
Dialogs to view the Appearance and Material properties of an object

These inspectors are intended to be used when debugging Appearance and
Material issues in a model.

The Appearance inspector displays the appearance properties of an
object. This will be more useful once PR 13792 is merged which migrates
parts to use ShapeAppearance instead of DiffuseColor. This shows each
of the appearance properties per face for the object.

The Material inspector shows the material, models, and properties
assigned to a model. It displays useful debugging information such as
the UUID and file paths associated with eacch of the items. This is
useful when finding and resolving model conflicts.

The material inspector now gives the option of copying the information
to the clipboard.
2024-05-27 10:50:35 -05:00
Chris Hennes
d4f780782d Update translations
Arch->BIM is a WIP
2024-05-25 19:11:51 -05:00
Zheng, Lei
b7bbc2ed11 Toponaming: Missing code for shapebinder 2024-05-23 09:47:25 -04:00
André Althaus
359c58f2ef Remove feature selection dialog for transformed features
The dialog is no longer necessary because without a selection the
transformed features default to "Transform body".
2024-05-23 12:40:41 +02:00
André Althaus
9ed12bfb30 Set TransformMode to "Transform body" if no features are selected on creation of transform features 2024-05-23 12:23:32 +02:00
André Althaus
5dca1d3e04 Change MultiTransform child detection to the previous method
isMultiTransformChild() tried to do a better job by checking
for a parent MultiTransform in the dependency list, but this
is unusable during initialization, when these dependencies are
not established.

The method is changed back to the previous one which only checks for
default property values. This will give false results during
initialization but not cause problems.
2024-05-23 12:23:32 +02:00
André Althaus
0b5e993b90 Fix solid feature detection for "Transform Body" mode
Because the Origins property is empty in "Transform Body" mode, the
features are detected as not solid.
This messes with the feature order on insertions and moves.

This is fixed by calling the isMultitransformChild() method of the
Transformed features instead of checking the Origins property in the
Body code.
2024-05-23 12:23:32 +02:00
André Althaus
648faf5d36 Fix ambiguous setValue() call 2024-05-23 12:23:32 +02:00
André Althaus
b4b41a9428 Remove unused function 2024-05-23 12:23:32 +02:00
André Althaus
a93e94dabb Modernize code 2024-05-23 12:23:32 +02:00
André Althaus
067c774292 Format code with clang-format 2024-05-23 12:23:28 +02:00
André Althaus
a6c061e19a Add a combo box to the transform featues UI for the TransformMode 2024-05-23 12:22:26 +02:00
André Althaus
45bb606095 Add a TransformMode property to the pattern features
This property controls wether the selected features tool shapes are
transformed or the whole base feature's shape.
2024-05-23 12:22:26 +02:00
André Althaus
4d9b89e265 Add function to check if a Transformed feature is a sub-feature of MultiTransform
This will check the in-list instead of relying on an empty Originals property.
2024-05-23 12:22:26 +02:00
wmayer
0484592835 Fix accessibility of some group commands
Several group commands are active but require an active document to work. This PR overrides the method isActive() to
disable the commands if no active document exists.

The affected commands are:
* Std_ViewGroup
* Std_LinkActions
* PartDesign_CompDatums
* PartDesign_CompSketches
2024-05-23 10:14:46 +02:00
bgbsww
12619b2c2d TopoNaming: restore defenses against multisolids when enabled 2024-05-21 21:42:05 -04:00
bgbsww
febe5c3d9e Toponaming: fix shapebinder selection error 2024-05-21 21:41:26 -04:00
Pieter Hijma
ec841ed6d4 Core: Add VarSets to Groups
If a Group is selected, add the VarSet to the group.
2024-05-21 09:59:49 +02:00
marcuspollio
5c84ce7317 Resolve conflicts 2024-05-21 10:51:07 +12:00
bgbsww
040502280f Toponaming: Cleanup verified face calls 2024-05-20 17:48:01 -05:00
marcuspollio
1209d769ca Merge remote-tracking branch 'upstream/main' into UI-TaskPanels-cleanup-1 2024-05-21 10:36:10 +12:00