kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
39,809 Commits 41 Branches 6 Tags
f43339ad235e003f9cc0ae47de9fa100a4f73f4b
Commit Graph

3381 Commits

Author SHA1 Message Date
wwmayer
f43339ad23 Fix issues in ellipse creation (#18800) 
* Sketcher: Handle exceptions in onViewValueChanged

Because the method onViewValueChanged is used as a Qt slot it must handle all possibly raised exceptions as otherwise
they will slip through GUIApplication::notify() that usually results into a crash on some platforms like macOS

* Sketch: Handle undefined values in calculateThroughPointMinorAxisParameters

* The argument of acos() must be in the range [-1, +1], otherwise it returns nan (not a number)
* The value of sin(0) = 0. So, it cannot be used in the denominator of a fraction
 2025-01-13 17:42:40 +01:00
wmayer
35700db40e Sketcher: Add an option to always add ext. geometry as reference 2025-01-06 17:48:00 +01:00
Ladislav Michl
4d6ed9d531 Base: UnitsSchema: return std::string 2024-12-23 17:48:42 +01:00
Ladislav Michl
2ea8a633ac Base: Quantity: return std::string 2024-12-23 17:48:42 +01:00
Ladislav Michl
0907c7bfda Base: Units: return std::string 2024-12-23 17:48:42 +01:00
Alfredo Monclus
17283b6290 fix(Test): sketcher external geometry removed test 2024-12-20 07:51:34 -03:00
Jiří Pinkava
973ad7b5c8 Sketcher: clean-up geometry history configuation 
Keep code almost 1:1 with LS3 branch, just ensure the variable is
initialized and code is documented
 2024-12-16 12:07:40 -05:00
Chris Hennes
8d110b3b0b Merge pull request #18354 from CalligaroV/pd-hole-restore-missing-refineShapeIfActive 
[PartDesign] Hole: restore missing call to FeatureAddSub::refineShapeIfActive()
 2024-12-16 11:41:50 -05:00
Vincent Belpois
d4b7d074ee Sketcher: Fix double RMB to quite polyline after closed shape 2024-12-13 12:30:41 -05:00
wmayer
e7e410323e Sketch: Fix possible crash in BSpline::splineValue 
There is an underflow of an unsigned int in the calling instance that sets the parameter 'p' to 2**32-1.
But the size of the passed vector is 0. To fix the crash first check if p is less then the size of the vector.

See: https://forum.freecad.org/viewtopic.php?t=92815
 2024-12-13 12:08:31 -05:00
Chris Hennes
9a7063395a Merge pull request #18346 from wwmayer/fix_sketch 
Fix SketchObjectPy::addExternal
 2024-12-13 11:37:51 -05:00
wmayer
ab5b53e972 Sketcher: Fix warning [-Wmaybe-uninitialized] 2024-12-10 12:32:41 -05:00
luzpaz
20d64a7f0f Fix various typos 
Found via `codespell -q 3 -L aci,addmin,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,aply,apoints,ba,beginn,behaviour,bloaded,bottome,brushin,bu,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,documentin,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,findn,fle,freez,graphin,hist,iff,incrementin,indexin,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,leadin,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,renderin,rin,ro,rougly,sectionin,seperator,serie,shs,sinc,siz,som,strack,substraction,te,technic,thist,thru,tread,tru,ue,uint,unter,uptodate,vas,vertexes,vew,wallthickness,whitespaces -S "./.git,*.po,*.ts,*.pdf,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDoc,./tools/build/WindowsInstaller/lang,./src/Mod/TechDraw/Templates/locale"`
 2024-12-10 15:09:51 +01:00
Syres916
74e7df9676 [Sketcher] [Post 1.0] Allow CarbonCopy to work with SketchObjectPython (#15594) 2024-12-09 11:31:04 -06:00
Chris Hennes
fde778faeb Merge pull request #18273 from Ondsel-Development/sk_group_drag 
Sketcher: Group dragging
 2024-12-09 12:29:49 -05:00
Vincenzo Calligaro
e09e107778 Updated tests affected by the modification 
Signed-off-by: Vincenzo Calligaro <vincenzo.calligaro@gmail.com>
 2024-12-07 20:24:31 +01:00
wmayer
cebcb7f66c Sketch: Fix SketchObjectPy::addExternal 
Use PyArg_ParseTuple's support of optional arguments than doing it with several calls of PyArg_ParseTuple
with different arguments.
This is error-prone, leads to convoluted code logic and may even fail because once the error indicator is set
PyArg_ParseTuple may unexpectedly fail.
 2024-12-07 19:55:49 +01:00
wmayer
f2e57b4eb4 Sketch: Fix Python type hints in addExternal 
The syntax of type hints in Python is 'argument name: argument type'.
For more details see: https://docs.python.org/3/library/typing.html
 2024-12-07 19:28:04 +01:00
Kacper Donat
651cefde4d Gui: Use getObject<T>() helpers in classes 
This commit is generated using regex based find and replace:

```
s/[\w:]+_cast\s*<([^>]+)\*>\s*\(\s*getObject\(\s*\)\)/getObject<$1>/
s/[\w:]+_cast\s*<([^>]+)\*>\s*\(\s*([^)]*)\s*->\s*getObject\(\s*\)\)/$2->getObject<$1>()/
```

To regenerate if needed.
 2024-12-06 18:29:39 +01:00
Chris Hennes
b87bdc1f84 Merge pull request #18126 from Ondsel-Development/core_LCS2 
Core datums : Card2 : Core implementation
 2024-12-06 12:12:04 -05:00
Florian Foinant-Willig
1eb8496aae [Core] Fix for frozen status 
A frozen object prevents the document to be saved
The frozen status propagates into object inheritance
A frozen sketch is no more editable
Transform and Placement can't be changed for a frozen object
The freeze icon is reduced
 2024-12-06 11:56:48 -05:00
Jiří Pinkava
3164ee1849 [PartDesign]: Sort sketches in Attach sketch tool alphabetically 
The order of sketches in sketch attaching tool is now determined
by the order in which they were added to document.
Sorting them alphabetically makes IMHO much easier to find a sketch
by user, compared to current state, especially in large and complex
projects with lot of sketches. Of cuser thix expects the user
use sensible names for the sketches.
 2024-12-06 11:52:59 -05:00
PaddleStroke
b92bda03da Sketcher: Rename movePoint to moveGeometries. 2024-12-06 16:45:47 +01:00
PaddleStroke
760091bc8a Sketcher: Fix first external geo deletion failure. 2024-12-05 15:23:25 +01:00
luzpaz
96c838f3b9 Fix various typos 
Found with codespell
 2024-12-04 23:18:00 -05:00
wmayer
c1a75bbafc Fix compiler warnings 2024-12-04 09:50:09 -05:00
PaddleStroke
70972b3926 Sketcher: Group dragging 2024-12-04 10:58:29 +01:00
Ajinkya Dahale
6c3d2eff64 [Sketcher] Use variable for frequently used static cast in trim 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
b2c806d227 [Sketcher] Remove some commented code from SketchObject::trim() 
...and replace with a TODO
 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
d8a86e4e9d [Sketcher] Remove some unneeded comments 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
0b32db53ed [Sketcher] Use switch-case in getPointForGeometry() 
Minor readability improvement.
 2024-12-04 00:57:41 +05:30
Ajinkya Dahale
5262482bc4 [Sketcher] Refactor SketchObject::trim() 
1. Use `Part::GeomCurve::createArc()`
2. Refactor constraint logic in `trim`
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
1cee07cb26 [Sketcher] Add some utility functions to Sketcher::Constraint 
`involvesGeoId`, `invovesGeoIdAndPosId`, `substituteIndexAndPos`
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
0d27efbc2f [Sketcher] Some trivial for loop changes in SketchObject 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
7d8a8b7cc8 [Sketcher] Attempt to fix toponaming issue on trim refactor 
TNP fix algorithm doesn't seem to like when edge with geoId 0 is deleted/made
construction after new geometry is added. Instead, we just ensure that one of
the newly added geometries becomes geoId 0 instead.

Making a `generateId(const Part::Geometry*)` was part of earlier attempts, but
still appears to remain relevant. This part can be reverted if necessary.
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
263331f6fb [Sketcher] Refactor SketchObject::trim() 
DO NOT MERGE because not complete: not all constraints are not transferred.

Includes:

* Adjust `deriveConstraintsForPieces` for trim
* Make sure new points are constrained on the cutting edges
* Add constraints at trim end(s) dependent on pre-exisiting ones with cutting curve(s). Also change tests to reflect that auto-coincidence can now be applied to non-periodic curves as well.

Known issue(s):
* Some redundant constraints may be added under certain circumstances (e.g. in
presence of perpendicular-via-point)
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
c823a6b270 [Sketcher] Refactor SketchObject::split() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
b991c2fbc2 [Sketcher] Add tests for split and trim 
Includes:
* Tests for splitting and trimming of various types of curves
* Assertions on constraints expected to be added on these curves
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
423fb77e1f [Sketcher] Refactor SketchObject::AutoLockTangencyAndPerpty() 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
4cc21e26e1 [Sketcher] Refactor SketchObject::delGeometry() 
Just dropped cognitive complexity to 25.
 2024-12-04 00:57:40 +05:30
Ajinkya Dahale
5f86d7f5a8 [Sketcher] Refactor SketchObject::getPoint() 
...to reduce cognitive complexity.

Use templates to break longer functions. Also makes it possible to avoid
repetition of type-checking logic.
 2024-12-04 00:57:39 +05:30
Ladislav Michl
0ee3c9f8e6 Base: Drop QString-std::string conversion functions from Tools 
Convenience helpers function Tools::toStdString and Tools::fromStdString
were implemented for Qt4 or older to perform utf8 aware conversion as
QString::toStdString/QString::fromStdString were using toAscii/fromAscii
internally (see https://dreamswork.github.io/qt4/classQString.html).

Since Qt5 QString uses toUtf8/fromUTf8, which makes the helper functions
obsolete (see https://doc.qt.io/qt-5/qstring.html#fromStdString).
 2024-12-02 23:30:53 -05:00
Vincent Belpois
f9d1391588 Sketcher: remove auto-generated 'enum value' comments 2024-12-02 23:27:26 -05:00
wmayer
d010645d23 Fix compiler warnings 2024-11-30 00:46:05 +01:00
Max Wilfinger
f0ba161bdf Update Sketcher external icons and cursors 2024-11-29 20:31:39 +01:00
PaddleStroke
7c15b3d240 Sketcher: OVP were drawn at wrong position when editing a sketch from link (#18060) 
* Sketcher: OVP were drawn at wrong position when editing a sketch from a link.

* Update src/Mod/Sketcher/Gui/DrawSketchController.h

Co-authored-by: Adrián Insaurralde Avalos <36372335+adrianinsaval@users.noreply.github.com>

---------

Co-authored-by: Adrián Insaurralde Avalos <36372335+adrianinsaval@users.noreply.github.com>
 2024-11-29 12:12:48 -05:00
PaddleStroke
e2f998f301 Sketcher: External: Change style to : defining are solid lines. Non-defining dashed. Both use external color. 2024-11-29 11:36:55 -05:00
PaddleStroke
63414bf06b Sketcher: Hide External BSpline overlay informations. 2024-11-29 11:36:55 -05:00
PaddleStroke
ac788df608 Sketcher: Rename External to Projection 2024-11-29 11:36:55 -05:00
PaddleStroke
0e5e071d72 Sketcher: Intersection externals 2024-11-29 11:36:55 -05:00