Commit Graph

25457 Commits

Author SHA1 Message Date
Yorik van Havre
f68c045ff7 Draft: Fixes continuing dimensions - fixes #9507 (#9632) 2023-05-24 20:34:52 +02:00
Abdullah Tahiri
60d99ca570 Sketcher: Obey non-intrusive preferences for modal pop-ups
==========================================================

This commit turns the remaining blocking pop-ups in which the user can only click "ok"
into non-intrusive notifications, depending on the user preferences in settings.
2023-05-24 18:35:41 +02:00
wandererfan
367a0a7277 [TD]prevent object deletion outside dialog 2023-05-24 10:15:45 -04:00
wandererfan
2737e830b1 [TD]fix fail on object deleted during dialog (#9626) 2023-05-24 10:15:45 -04:00
wmayer
12c20003b3 Sketcher: fix crash when creating a parabola or hyperbola or when using Sketcher_Split
Forum: https://forum.freecad.org/viewtopic.php?t=78543
2023-05-23 20:01:41 +02:00
wmayer
812a20b864 MeshPart: Allow to cancel trim by plane 2023-05-23 16:05:49 +02:00
Abdullah Tahiri
0e85b24348 Sketcher: Command constraints error handling adaptation
=======================================================

- Better handling for exceptions originating in Python addConstraint.
- Refactor to reuse code for handling of exceptions
2023-05-23 14:24:45 +02:00
Abdullah Tahiri
2338ae633e Sketcher: Make Command Constraints show the severity of warning for typical user mistakes 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
e3702ac2d8 Console: Extend framework with intended recipient and content type metainformation
==================================================================================

Limitations of the current framework:
- Codes the translated state only for TranslatedNotification as part of the type.
- Does not code the intended recipient (user, developer, ...)

Problems:
- Some errors are intended for developers, some errors may only be intended for users,
if, for example, there is another developer error which already contains all the information.
The current framework may lead to information duplication or to showing to the user developer
information, which is perceived as annoying.
- Logs shall be in English (report view), while every message to the user (UI) shall be translated.
The current framework can only differentiate where to report based on subscription (legacy logs do not
subscribe to notifications), and for notifications, whether it is translated or not depends on the type.
It is not possible to code errors or warnings that are already translated.

Solution:
- To extend the ILogger interface with additional metainformation, indicating the intended recipient
(User, Developer, All), and the content of the message (translated, untranslated, untranslatable). The latter
is useful for dynamic strings that won't find a match in the translation framework.

Bonus:
- This extended version allows to do away with translatednotification, as now any message can be independently
marked as translated or untranslated or untraslatable.
- It is now possible to provide the right icon of severity (error, warning, info), even when it is only user intended
and already translated.
2023-05-23 14:24:45 +02:00
Jonas Bähr
dc07897a29 Sketcher: Add tests for Circle to Line distance constraint
Note that support for secants currently only works for reference
constraints but not for driving ones. If and how this should be done
is still under discussion [1].

[1]: https://github.com/FreeCAD/FreeCAD/pull/9044#issuecomment-1548006842
2023-05-23 14:19:51 +02:00
Yorik van Havre
03450a5684 Merge pull request #9586 from yorikvanhavre/arch-ifc-export-fix
Arch: Minor fix to IFC exporter
2023-05-23 13:53:14 +02:00
Yorik van Havre
1ae23db392 Merge pull request #9585 from yorikvanhavre/arch-svg-fill
Arch: Fixed SVG fill
2023-05-23 13:52:33 +02:00
Chris Hennes
aa3b2f39a6 Merge pull request #9624 from wwmayer/fix_OpenSCAD_cmds
OpenSCAD: Hull/Minkowski also work for a single selected object
2023-05-22 13:45:31 -05:00
Chris Hennes
d45356e2b5 Merge pull request #9627 from chennes/addonManagerMiscBugs
Addon Manager: Minor error handling cleanup
2023-05-21 20:37:54 -05:00
Chris Hennes
20f073e84e Update translations 2023-05-21 19:13:11 -05:00
Chris Hennes
e90ecc27ff Addon Manager: Minor error handling cleanup 2023-05-21 15:50:29 -05:00
wmayer
722087b32c OpenSCAD: Hull/Minkowski also work for a single selected object 2023-05-21 16:42:09 +02:00
Roy-043
52b41fee06 Draft: fix props_changed_placement_only for attached clones and similar (#9623)
For an attached object whose Shape depends on one or more source objects props_changed_placement_only should always return False.
2023-05-21 16:15:55 +02:00
Chris Hennes
864f99bf98 Merge pull request #9614 from chennes/fixPrefPageContext
Gui: Correct translation context of pref pages
2023-05-20 19:53:32 -05:00
MaxiV
4cfd56a80b Delete A4_IRAM4504.svg
It is included in the AR_IRAM folder
2023-05-20 10:31:00 -04:00
sliptonic
490ed09dc3 Merge pull request #9608 from chennes/pathHTMLRemoval
Path: Remove HTML where not needed
2023-05-20 07:51:57 -05:00
Roy-043
c5bf5d117b Draft: remove obsolete gui_array_simple.py (#9616) 2023-05-20 10:37:31 +02:00
Abdullah Tahiri
987b4bda2a Sketcher: App - Clang-format 2023-05-20 07:55:05 +02:00
Abdullah Tahiri
2ae7cc4a94 Sketcher: PlaneGCS C-lang formatting
====================================

As per:
https://forum.freecad.org/viewtopic.php?t=77205

Please use pre-commit as described in:
https://github.com/FreeCAD/DevelopersHandbook/blob/master/gettingstarted/index.md#setting-up-for-development
2023-05-20 07:55:05 +02:00
Chris Hennes
ad8a4376c8 Gui: Move C++ pref pages to QObject context 2023-05-19 20:54:27 -05:00
Chris Hennes
0100e8f843 Gui: Correct translation context of pref pages
Preference page title strings must be in QObject
2023-05-19 20:46:12 -05:00
Chris Hennes
4888a28f7d Merge pull request #9612 from chennes/addonmanagerVersionErrorHandling
Addon Manager: Improve error handling for Version
2023-05-19 18:08:14 -05:00
wandererfan
6a7b04a441 [TD]fix fail on bad selection (#9598) 2023-05-19 19:07:48 -04:00
wandererfan
766a04e26e [TD]cleanup debug messages 2023-05-19 19:07:48 -04:00
Chris Hennes
b0090a7890 Addon Manager: Improve error handling for Version 2023-05-19 17:17:29 -05:00
Chris Hennes
e87555bdfb Merge pull request #9610 from chennes/openscadWordingTweak
OpenSCAD: Minor wording tweak in preferences
2023-05-19 10:25:29 -05:00
Chris Hennes
bd1685d107 OpenSCAD: Minor wording tweak in preferences 2023-05-18 21:58:08 -05:00
Chris Hennes
ca2be49541 Addon Manager: Minor linguistic fixes 2023-05-18 21:49:41 -05:00
Chris Hennes
c78ed2829f Path: Misc. minor string cleanup 2023-05-18 21:33:46 -05:00
Chris Hennes
89214499d5 Path: Remove HTML where not needed 2023-05-18 20:44:00 -05:00
Chris Hennes
0b41c4a8a8 Update translations 2023-05-18 07:49:08 -05:00
Chris Hennes
770b002a1a Addon Manager: Fix typo 2023-05-17 17:01:17 -05:00
Roy-043
a23142881a Draft: Draft_Move continue mode failed with numeric input (#9597) 2023-05-17 18:56:36 +02:00
Roy-043
9a219e03a6 Draft: ShapeString: use FaceMakerBullseye instead of current face algo (#9593) 2023-05-17 18:19:00 +02:00
Abdullah Tahiri
d4d5aaf306 Skecher: Rendering order
========================

Recently the rendering order functionality was temporarely removed, as it interferred with the development of visual layers.

However, the release comes before visual layers are finished and can provide such functionality.

This commit reintroduces the functionality for the release.
2023-05-17 16:29:34 +02:00
Abdullah Tahiri
bb5d09ff9b Sketcher: RenderingOrder resources and icons 2023-05-17 16:29:34 +02:00
Abdullah Tahiri
8b9096ede1 Sketcher: New edit tools toolbar
================================

Move Grid and Snap to edit tools
2023-05-17 16:29:34 +02:00
Chris Hennes
f90aed491e Sketcher: Translate context menu 2 2023-05-17 14:43:57 +02:00
Chris Hennes
ff989512e5 Sketcher: Translate context menu 2023-05-17 14:43:57 +02:00
0penBrain
719339657d Sheet: display an error in console when a cyclic dependency is detected 2023-05-17 10:09:41 +02:00
Roy-043
ea35f0f003 Arch: endpoint after Wall length change was not in local sketch coords (#9592) 2023-05-16 21:24:16 +02:00
Yorik van Havre
b777c12b53 Arch: Minor fix to IFC exporter 2023-05-16 15:25:53 +02:00
Yorik van Havre
22226b31c1 Arch: Fixed SVG fill - fixes #6208 2023-05-16 12:27:59 +02:00
Abdullah Tahiri
2eb7badb1e Fem: Remove Unused variable 2023-05-16 08:29:28 +02:00
wandererfan
8eeb095fcc [TD]fix direction precision error #9572 2023-05-15 10:13:42 -04:00