0penBrain
5bbd24e48d
Display Midplane checkbox with Pocket/ThroughAll
...
Was enabled but not visible.
Hopefully last time I fix it. :)
2022-01-22 10:34:14 +01:00
wmayer
af868ed079
PD: move ReferenceHighlighter to Part module
2022-01-18 18:24:02 +01:00
Ajinkya Dahale
d5ae0777d0
[PD] Correct include guard name
...
Correction in `PartDesignGui::ReferenceHighllighter`
2022-01-18 03:01:20 +01:00
wmayer
2d1c083d9a
PD: fix crash in thickness dialog when clicking 'Add Face' button
2022-01-16 18:59:26 +01:00
wmayer
f147986fa9
App: Bugfix for NULL-Pointer dereference of Property->getName()
2022-01-16 14:30:51 +01:00
Chris Hennes
089b18f868
Part Design: Missing =
2022-01-14 09:38:45 -06:00
Uwe
66864bbe7b
[PD] Pad/Pocket: sort out duplicated code
...
the checkboxes are almost identical and it avoids work to have them in one location
2022-01-14 13:17:25 +01:00
wmayer
a1a8de633c
PD: fix small inconsistence, use forwared declaration
2022-01-14 12:22:16 +01:00
Ajinkya Dahale
b2e6f91c1d
[PD] Use buttonToggled signal in PD pipe
...
Combines other button toggle methods/signals/slots involved.
2022-01-13 22:31:05 -05:00
Ajinkya Dahale
1296e2c417
[PD] Use Gui::ButtonGroup in TaskDlgPipeParameters
2022-01-13 22:31:05 -05:00
Uwe
626425526b
[PD] sort out more Pad/Pocket code
...
as suggested in #5349
2022-01-10 14:33:02 +01:00
Yorik van Havre
e33ef084ff
Merged crowdin translations
2022-01-10 11:23:59 +01:00
Uwe
38cc6f29e0
[PD] Pad /Pocket: remove unused code
2022-01-08 03:24:09 +01:00
Uwe
5aadc54d18
[PD] Pad/Pocket: fix reverse behavior
...
- bring back intended behavior as in FC 0.19:
- if 2 lengths, then midplane is invisible
- if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
2022-01-08 01:15:23 +01:00
Uwe
9a8e055cc6
[PD] Hole: fix angle constraints
...
- all 3 angles cannot be >= 180°
- also add missing minimum in UI for taper angle
2022-01-07 20:38:05 +01:00
Uwe
7c158a3751
[PD] rename a UI file
...
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
2022-01-07 20:36:29 +01:00
Uwe
ccc45659b0
[PD] correct copyright
...
these files were added by Werner in 2020
2022-01-06 21:56:53 +01:00
Uwe
a6b01fa1f0
[PD] Hole: some coding style fixes
...
all done by MSVC
2022-01-06 16:18:25 +01:00
Uwe
8df64b7426
[PD] add missing hole constraint
...
- add missing constraint for hole diameter
- add missing sets of angle constraints in the task dialog
2022-01-06 15:39:13 +01:00
mwganson
977b602469
[PartDesign] Chamfer and Fillet, select all edges for the user when no subobjects have been selected prior to executing command
2022-01-05 01:40:10 +01:00
Jonas Bähr
d70faa1f5e
PD: helix cleanup: remove unused strings from task panel ui
...
Since the tool tips are now set from the property descriptions we don't
need them any more in the .ui file. Removing them prevents garbage in
the translation source files.
2022-01-03 11:40:29 +01:00
Jonas Bähr
88063627d2
PD: Use the helix property docs as tooltip in the task panel
...
By reusing the property docs as tooltip we avoid maintaining the same
information in two places. The propery descriptions have been made
translatable, too, to ensure a fully translatable UI.
The ground work for this was layed by the work on Issue 0002524, long
time ago: https://tracker.freecadweb.org/view.php?id=0002524
2022-01-03 11:40:29 +01:00
wmayer
175ceb2d12
PD: [skip ci] remove obsolete TaskPocketParameters.ui
2022-01-01 11:50:43 +01:00
wmayer
c855a3072e
PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code
2021-12-31 17:03:16 +01:00
wmayer
e1b03bc0eb
[skip ci] fix some typos
2021-12-31 14:03:51 +01:00
mwganson
a930d4ebac
[PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode
2021-12-31 14:01:43 +01:00
Yorik van Havre
6cb3782c03
Merged crowdin translations
2021-12-29 12:20:12 +01:00
Zheng, Lei
d286a54fc1
PartDesign: show error on SubShapeBinder CopyOnChange failure
...
The failure is not obivous as it would have been occurred in a
hidden temporary document.
2021-12-21 21:41:02 -07:00
Zheng, Lei
2bd4404afb
PartDesign: expose SubShapeBinderPython
2021-12-21 21:41:02 -07:00
Zheng, Lei
39c04e4877
PartDesign: support CopyOnChange in SubShapeBinder
2021-12-21 21:41:02 -07:00
Uwe
c5f87d8ea8
[PD] hole dialog improvements
...
- no keyboard tracking
- don't disable labels since we don't do this for the other dialog labels
- avoid a doubled word in subsequent labels
- further UI file changes are by Qt's Designer
2021-12-22 02:46:07 +01:00
Uwe
9770449be7
[PD] fix several hole thread issues
...
- actually use specified thread depth, fixes issue reported here: https://github.com/FreeCAD/FreeCAD/pull/4274#issuecomment-997787744
- fixes 2 UI enabling issues
- the thread depth cannot be longer than the hole depth
- the hole cannot be deeper than the through-all depth
2021-12-22 01:09:06 +01:00
wmayer
6d4d433080
PD: [skip ci] improve readability of argument list
2021-12-19 22:02:08 +01:00
Uwe
3d03f0a468
[PD] style improvements for Helix
...
all done automatically by MSVC
2021-12-19 17:52:33 +01:00
Jonas Bähr
bb3d02298d
PD: Fix assignment of Angle/Growth properties
...
Depending on the input mode, either `Growth` or `Angle` is used to create
a conical or flat spiral. The respective other can easily be calculated
to give consistent view. This is already done for the other properties,
e.g. `Height` is calculated from `Pitch` and `Turns`.
With this patch, the same is done for `Angle` and `Growth`.
2021-12-19 16:21:51 +01:00
luz paz
a5bfba2665
PD: Adjust header uniformity
2021-12-16 23:55:48 +01:00
wmayer
8a2ea97276
PD: support of wires in ReferenceHighlighter
2021-12-15 16:25:06 +01:00
wmayer
5bef110491
PD: do not throw an exception in TaskSketchBasedParameters::make2DLabel as otherwise editing a broken loft/pipe won't be possible
2021-12-15 15:36:36 +01:00
wmayer
94d8a2034a
PD: hide the sections of a loft only if it can be recomputed successfully
2021-12-15 15:13:33 +01:00
wmayer
a87c8dca31
PD: hide the profile of a sketch based feature only if it can be recomputed successfully
2021-12-15 15:13:03 +01:00
wmayer
2d9c403cc0
PD: in ViewProviderLoft::highlightSection follow the same logic as in Loft::execute for selected profiles/sections
2021-12-14 00:30:59 +01:00
wmayer
df76209f58
PD: use class ReferenceHighlighter inside ViewProviderDressUp
2021-12-13 16:56:48 +01:00
wmayer
418ef59625
PD: use class ReferenceHighlighter inside ViewProviderPipe
2021-12-13 15:58:55 +01:00
wmayer
098927fb54
PD: properly reset line colors when un-highlighting loft profile/sections
2021-12-13 15:46:04 +01:00
wmayer
6289ff40d5
PD: highlight current profile and sections of a loft when selecting a new profile/section
2021-12-13 15:01:08 +01:00
wmayer
2b65ef8fcf
PD: make Loft working again when two sketches are pre-selected
2021-12-13 10:32:40 +01:00
luz paz
b6f9f39ffc
Fix various typos and grammatical refinements
2021-12-09 08:57:52 -06:00
wmayer
208237d2e6
PD: 0004582: Mulit-transformation dialog cannot be cancelled
2021-12-09 06:13:25 +01:00
wmayer
ca5c799ce2
Gui: rename methods of SelectionObserver to clarify intention in client code
2021-12-07 14:17:07 +01:00
wmayer
ce88fa2052
PD: enable selection only on request and disable it after selecting an object
2021-12-07 13:06:48 +01:00