kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
27,179 Commits 40 Branches 6 Tags
faac46e9e438061ff8b122e3c0cfb7c614be36a4
Commit Graph

1825 Commits

Author SHA1 Message Date
0penBrain
015b229162 [PartDesign] Allow single (viewport) click for mapping feature selection 
Parameter 'singleClickFeatureSelect' can be used to enable/disable
 2022-01-22 16:14:30 +01:00
0penBrain
68e1fc46b6 Display Midplane checkbox with Pocket/ThroughAll 
Was enabled but not visible.
Hopefully last time I fix it. :)
 2022-01-22 10:34:14 +01:00
wmayer
8db8126dd5 PD: move ReferenceHighlighter to Part module 2022-01-18 18:24:02 +01:00
wmayer
09e14f8488 PD: add PD test modules to __init__.py 2022-01-18 18:02:10 +01:00
Jonas Bähr
75d7feaa33 PD: Add tests for InvoluteGear 
There are some basic tests to cover the gear profile and its parameters
and some integration tests for the interaction with PD Pad and Pocket.

I followed the same pattern as the other PartDesign tests, e.g. not using
PEP8 style method names. Eventually some helper methods could be
extracted and moved to the common base framework in Mod/Test, but that's
another step.
 2022-01-18 17:43:52 +01:00
Ajinkya Dahale
faa6cfa402 [PD] Correct include guard name 
Correction in `PartDesignGui::ReferenceHighllighter`
 2022-01-18 03:01:20 +01:00
wmayer
5ea6961715 PD: [skip ci] make uniform the license text of test modules 2022-01-17 16:38:10 +01:00
wmayer
be020c8d9d PD: fix crash in thickness dialog when clicking 'Add Face' button 2022-01-16 18:59:26 +01:00
wmayer
b35623e680 App: Bugfix for NULL-Pointer dereference of Property->getName() 2022-01-16 14:30:51 +01:00
Chris Hennes
5e87b15782 Part Design: Missing = 2022-01-14 09:38:45 -06:00
Uwe
1e9ddc5302 [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
wmayer
13234d7e63 PD: fix small inconsistence, use forwared declaration 2022-01-14 12:22:16 +01:00
Ajinkya Dahale
9c4c40856f [PD] Use buttonToggled signal in PD pipe 
Combines other button toggle methods/signals/slots involved.
 2022-01-13 22:31:05 -05:00
Ajinkya Dahale
fd0be8bccd [PD] Use Gui::ButtonGroup in TaskDlgPipeParameters 2022-01-13 22:31:05 -05:00
luz paz
6394fed4e6 Fix various typos 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
 2022-01-12 14:50:39 -06:00
Uwe
26a36f6b75 [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Yorik van Havre
c24ca51a44 Merged crowdin translations 2022-01-10 11:23:59 +01:00
luz paz
28ab1bb68f Fix various superfluous whitespace in *.dox files 2022-01-09 21:01:42 -06:00
David Österberg
9c142ccb8b PartDesign: Improve orientation behaviour for conical helices (#5363) 
* PartDesign: Improve orientation behavior for conical helices

As identified in the forum
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136

The Freenet orientation mode does not give expected results for helices with cone angle.
By using an auxiliary helix that is axially offset it is guaranteed that the orientation frame
is always consistent with a cylindrical coordinate system.

Results will be the same as before when cone angle is 0.
 2022-01-09 22:13:15 +01:00
Uwe
0cd329de73 [PD] sort includes 
- to keep the overview
- removed double entries
- will make diff of pending PRs smaller
 2022-01-09 21:36:07 +01:00
wmayer
7a85baa7eb PD: declare signedLengthConstraint in FeatureExtrude as static class member 2022-01-09 10:53:04 +01:00
David Osterberg
3af6bf0880 PartDesign: Silence noisy FeatureTransformed 
Remove several report view messages that are not necessary for everyday use.
By request from the forum (https://forum.freecadweb.org/viewtopic.php?f=3&t=64900&start=20#p558962)
 2022-01-08 15:30:39 +01:00
Uwe
74e36f3e0c [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00
Uwe
c1d3cb5fee [PD] Pad/Pocket: fix reverse behavior 
- bring back intended behavior as in FC 0.19:
 - if 2 lengths, then midplane is invisible
 - if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
 2022-01-08 01:15:23 +01:00
Uwe
21f6602d5b [PD] Pad/Pocket: sort out common code 
- sort out a constraint used by Pad and Pocket
- also unify Length2 parameter naming
 2022-01-08 00:45:19 +01:00
Uwe
891c2fe1a0 [PD] remove double include 2022-01-07 21:58:16 +01:00
Uwe
734bb426bf [PD] Hole: fix angle constraints 
- all 3 angles cannot be >= 180°
- also add missing minimum in UI for taper angle
 2022-01-07 20:38:05 +01:00
Uwe
b40ab916bc [PD] rename a UI file 
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
 2022-01-07 20:36:29 +01:00
wmayer
ad30b7dbc8 PD: [skip ci] remove unused variable 2022-01-07 15:50:09 +01:00
Uwe
5f59b5e37f [PD] correct copyright 
these files were added by Werner in 2020
 2022-01-06 21:56:53 +01:00
Uwe
d660bce346 [PD] Hole: some coding style fixes 
all done by MSVC
 2022-01-06 16:18:25 +01:00
Uwe
76f5fe6a74 [PD] remove wrong comment 
was accidentally introduced by ma previous commit
 2022-01-06 16:15:39 +01:00
Uwe
2783563e11 [PD] Hole: don't call onChanged on restoration 
fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=10&t=65035
 2022-01-06 15:51:03 +01:00
Uwe
55421ce9cb [PD] add missing hole constraint 
- add missing constraint for hole diameter
- add missing sets of angle constraints in the task dialog
 2022-01-06 15:39:13 +01:00
Uwe
4b6c0a6f2d [PD] Hole: coding style fixes 
all by MSVC
 2022-01-06 03:51:13 +01:00
Uwe
460d4ad404 [PD] remove unnecessary Unicode characters 
they cause problems: https://forum.freecadweb.org/viewtopic.php?p=559077#p559077
 2022-01-06 02:57:53 +01:00
wmayer
922582d036 Sketcher: avoid attaching to/detaching from the same parameter group twice 2022-01-05 14:05:05 +01:00
Uwe
6c2178d082 [PD] get rid of a CI compiler warning (#5335) 
* [PD] get rid of a CI compiler warning

The CI compiler outputs this warning:
FeaturePad.cpp:101:20: warning: variable 'obj' set but not used [-Wunused-but-set-variable]

Co-authored-by: 0penBrain <48731257+0penBrain@users.noreply.github.com>
 2022-01-05 12:26:48 +01:00
Uwe
f3f6f08e31 [PD] avoid a single-letter variable 
(single letter variables make it hard to read and understand code quickly and are error-prone for typos)
 2022-01-05 03:16:00 +01:00
David Osterberg
1f84ed1e6e PD: Fix bug in FeatureTransformed 
It is important to not include the original in the pattern because the original might not be at the tip of the feature tree. Including the original
will interfere with changes that occur further down in the feature tree

This fixes the bug identified in
https://forum.freecadweb.org/viewtopic.php?f=3&t=64900
 2022-01-05 02:27:53 +01:00
mwganson
6be358fdfa [PartDesign] Chamfer and Fillet, select all edges for the user when no subobjects have been selected prior to executing command 2022-01-05 01:40:10 +01:00
mwganson
af9857faef [PartDesign::Scripts::Spring.py] update old example script 2022-01-03 11:45:05 +01:00
Jonas Bähr
ccb03cadd5 PD: helix cleanup: remove unused strings from task panel ui 
Since the tool tips are now set from the property descriptions we don't
need them any more in the .ui file. Removing them prevents garbage in
the translation source files.
 2022-01-03 11:40:29 +01:00
Jonas Bähr
5266ecf36f PD: Use the helix property docs as tooltip in the task panel 
By reusing the property docs as tooltip we avoid maintaining the same
information in two places. The propery descriptions have been made
translatable, too, to ensure a fully translatable UI.
The ground work for this was layed by the work on Issue 0002524, long
time ago: https://tracker.freecadweb.org/view.php?id=0002524
 2022-01-03 11:40:29 +01:00
wmayer
7d748d958d PD: [skip ci] remove obsolete TaskPocketParameters.ui 2022-01-01 11:50:43 +01:00
wmayer
1d021345f3 PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code 2021-12-31 17:03:16 +01:00
wmayer
fd8f860223 [skip ci] fix some typos 2021-12-31 14:03:51 +01:00
mwganson
a324b33104 [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
Yorik van Havre
91bfb0fbb6 Merged crowdin translations 2021-12-29 12:20:12 +01:00
Uwe
5022385c4f [PD] refine helix intersection calculation 2021-12-24 01:40:25 +01:00