Commit Graph

1035 Commits

Author SHA1 Message Date
wandererfan
fb9b3a9e9e [TD]fix centering of shape
- centering of shape was not affecting the OCC TShape, so
  we now make a deep copy of the original
2023-03-12 19:21:22 -04:00
wmayer
2a970b3045 clang: fix -Wunused-but-set-variable 2023-03-12 15:05:21 +01:00
Uwe
ab327114c3 [TD] fix compiler warning about code duplication and unused variable 2023-03-10 11:25:16 -05:00
wandererfan
0adc473d53 [TD]fix error from BSpline.asCircle 2023-03-09 13:40:16 -05:00
Abdullah Tahiri
c604d1741d Console/ILogger: Refactor and extension
=======================================

Refactor:
 - Substitute the use of variadic templates with parameter packs.
 - Use recently incorporated external library "fmt" to handle printf like formating.
 - Extensive cleaning of pragmas and unnecessary forward declarations.
 - Parameter packs and libfmt provide a much stronger type checking now, so
   conversions that are by standard implicit as bool to int need an explicit static_cast
   to avoid compilation warnings.

Extension:
 - Include a notifier field, so that the originator of the message can be provided. E.g. Document#DocumentObject
 - Include a new type of message called CriticalMessage, this message is intended to have
   special behaviour in the future. Namely, it will be used to notify forward compatilibity issues.
   It will be used to substitute the current signal/slot mechanism.
 - Include two new types of messages for user notifications (Notification and TranslatedNotification). This messages
   will be use to convey UI notifications intended for the user (such as non-intrusive message about the usage of a tool). There
   are two versions to mark whether the string provided as a message is already translated or not. When using the console system for
   notifications, these notifications may originate from the App or the Gui. In the former, it is generally the case that the strings
   of messages are not (yet) translated (but they can be marked with QT_TRANSLATE_NOOP). In the latter, often the messages to be provided
   are already translated.

Python support for CriticalMessage, Notification and TranslatedNofification, including shortcuts:

    Crt = FreeCAD.Console.PrintCritical
    Ntf = FreeCAD.Console.PrintNotification
    Tnf = FreeCAD.Console.PrintTranslatedNotification
2023-03-07 16:13:23 +01:00
xtemp09
323476a9a4 [TechDraw] Improved readability of DrawViewSpreadsheet.cpp
I was stretching my fingers
2023-03-04 09:59:02 -05:00
wandererfan
01641433c1 [TD]getters and setters for geometry
- make attributes private (or protected) and use
  getters and setters instead of accessing attributes
  directly.
2023-02-28 08:15:06 -05:00
Uwe
c32bf8e99a [TD] fix compiler about a variable redefinition 2023-02-26 10:31:36 +01:00
wandererfan
cd79b8744f [TD]centralize balloon prefs 2023-02-11 13:30:15 -05:00
wandererfan
951520a5c1 [TD]use correct shape for section of section 2023-02-02 05:55:32 -08:00
wandererfan
bd25c86973 [TD]fix handling of perforated section faces 2023-02-02 05:55:32 -08:00
luzpaz
d28d63b87b TechDraw: header uniformity + trailing whitespace 2023-01-21 20:11:08 -05:00
wandererfan
72df799770 [TD]apply tester feedback on DimRepair 2023-01-18 17:48:22 -05:00
Uwe
a9ed294765 [TD] remove unused Console include
- no longer used since #8180
2023-01-14 02:39:43 +01:00
wandererfan
271e3c6b8a [TD]Allow balloons to be attached to non-part views 2023-01-13 12:15:33 -05:00
wandererfan
12db3618df [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
1ddd8b8a92 [skip ci] [TD] fix a typo as reported by the CI 2023-01-09 15:47:40 +01:00
Uwe
f8db7e9187 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
Uwe
ce4a916875 [TD] minor fixes
- typos and code formatting as reported by the CI
- some more re-sorting
2023-01-09 12:02:50 +01:00
wmayer
a963ca5f8c TD: fixes #8144: TD crash 2023-01-09 11:43:14 +01:00
Uwe
e42f46a47b [TD] attempt to fix compilation with PCH after #8141
- also resort includes
2023-01-09 11:26:51 +01:00
wandererfan
664b2560ad [TD]fix wrong calculation of 3d two edge angle 2023-01-07 16:32:03 -05:00
wandererfan
63be8da664 [TD]fix exception on empty list during restore 2023-01-07 16:32:03 -05:00
wandererfan
17554e29f1 [TD]fix issues reported by 3d dimension testers
- correct interpretation of True vs Projected

- handle long subelement names in references

- fix "too small" value condition

- better error messages for bad dimension geometry
2023-01-07 16:32:03 -05:00
wandererfan
1b547dff72 [TD]Refactor Dimensions for 3d upgrade
- separate validation, geometry and reference handling into
  individual files
- improve 3d reference geometry handling
- eliminate duplicate dim creation code

- add Dimension reference repair dialog

- Refactor formatting out of DrawViewDimension

- move dimension repaint control to ViewProvider
2023-01-07 16:32:03 -05:00
wandererfan
d63ac0f7f6 [TD]add light text on dark page mode
- some visually impaired users need white graphics on
  dark page.

- revise Annotation dialog to respect dark style
2023-01-03 17:41:33 -05:00
wandererfan
af3c057f99 [TD]make detail highlight interactive
- drag detail highlight to change detail anchor point
- change detail reference position using HighlightAdjust property
2022-12-28 09:41:44 -05:00
wandererfan
da06fc45a2 [TD]add extensions for drag and drop 2022-12-27 19:43:44 -05:00
wandererfan
14994bd9f7 [TD]remove debug statements 2022-12-26 12:13:34 -05:00
wandererfan
d7a9f44f20 [TD]fix startup exception on empty compound 2022-12-26 12:13:34 -05:00
wandererfan
d91edafa62 [TD]fix expression in Scale fails to propagate 2022-12-20 19:08:36 -05:00
wandererfan
47ef35047b [TD]detail of rotated ComplexSection 2022-12-18 09:42:42 -05:00
wandererfan
23dc64365b [TD]move makeAlignedPieces to separate thread
- correct ComplexSection rotation

- fix fail to load CS for some profiles and directions
2022-12-18 09:42:42 -05:00
wandererfan
5f3c61762c [TD]fix parent page counting
- was returning inflated counts of owning page
2022-12-18 09:42:42 -05:00
wandererfan
50cdc60b08 [TD]remove problematic boost check for planarity
- boost check for planar graph was consuming memory until
  crashing.
- since all our edges have been projected onto a plane, we
  don't require this check
2022-12-17 08:07:05 -05:00
Uwe
e92034a187 [skip ci] [TD] only whitespace and sorting 2022-12-12 02:23:22 +01:00
wandererfan
cb06952a79 [TD]fix wrong error message on load
- also improve temp file name generation
2022-12-11 19:11:28 -05:00
wmayer
3c4375986e TD: [skip ci] fix build failure with boost >= 1.78 on Windows 2022-12-08 22:11:33 +01:00
Uwe
cbd0140dcd [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
wandererfan
276e6c45b9 [TD]allow rotation of hatch directions
- faces can have their svg and bitmap hatches rotated to match
  the view rotation or special situations
- section cut face can have svg hatch rotated
2022-12-03 15:15:25 -05:00
wmayer
88510213d9 TD: [skip ci] fix warnings reported by GH actions 2022-11-27 16:51:15 +01:00
wandererfan
13acca7504 [TD]fix ComplexSection null cut shape 2022-11-27 08:21:40 -05:00
wandererfan
cdda6f2c38 [TD]fix fail on missing base view (#7856) 2022-11-22 20:38:46 -05:00
Aapo
1f6ec0469a [TD] DrawViewPart: Fix Dimension attachment for Coarse Views and faceless Views 2022-11-20 08:08:33 -05:00
Aapo
2e19e5f6fb [TD] DrawViewPart: Fix Dimension attachment on Cosmetic CenterLines upon document restore 2022-11-17 19:25:43 -05:00
wmayer
9e9c784041 TD: fix memory leaks with raw pointers of GeometryObject
Replacing the use of raw pointers of GeometryObject with shared pointers fixes the observed memory leaks when running the unit tests of TechDraw
2022-11-15 16:16:08 -05:00
luz paz
b389f6e602 TechDraw: remove trailing whitespace 2022-11-15 16:17:22 +01:00
wandererfan
0c83a17ce8 [TD]prevent Complex Section with no Base View 2022-11-14 19:41:12 -05:00
wandererfan
26d7fe14e1 [TD]add section line marks for simple section 2022-11-14 19:41:12 -05:00
marioalexis
93133040e8 TechDraw: Improve and clean up code in some Python classes 2022-11-14 16:40:07 -05:00