Commit Graph

29619 Commits

Author SHA1 Message Date
wmayer
fbd9eac848 Mesh: Fix linter warnings 2024-11-21 18:30:22 +01:00
wmayer
463cc08f3f Part: Expose Geometry::isSame() to Python 2024-11-20 23:37:39 +01:00
wmayer
8a80ce2ca4 Start: fixes #17857: Icon-files of the startup screen are not removed from /tmp
It's basically a port of #10951 to the new start page implementation.

Note: Icon files are not removed but re-used instead.

The commit adds some new functions:

* getThumbnailsImage()
  Returns the name of the PNG inside a project file

* getThumbnailsName()
  Returns the directory name containing the image files

* getThumnailsParentDir()
  Returns the parent directory of the directory containing the image files

* getThumbnailsDir()
  Returns the path to the thumbnail directory. There is no need to always create a unique directory
  after each restart because it doesn't harm if the thumbnail directoy contains deprecated files.

* createThumbnailsDir()
  Creates the thumbnail directoy if it doesn't exist yet.

* getSha1Hash
  Helper function to compute a SHA-1 hash of a given path. If the same path is passed
  then the hash value will be the same.
  This way it can be avoided to create a different image file from a project file
  after each restart.

* getUniquePNG
  Computes the path of a PNG image file for a given project file. It's also possible
  to pass an arbitrary string as argument.

* useCachedPNG
  If the PNG image exists and if it's newer than the project file True is returned
  and False otherwise.

For a given project file it is checked if the thumbnail directory already contains
a cached image. If it's newer than the project file it will used, otherwise it will
be re-created.

Fix freecadCanOpen() abd DisplayedFilesModel::addFile() to also check for lower-case
file extensions.
2024-11-20 09:44:35 -05:00
Benjamin Bræstrup Sayoc
52fe0eec53 [TechDraw] Return logic simplification (#16504)
* [TechDraw] AppTechDrawPy.cpp return logic simplification

* [TechDraw] CosmeticExtension.cpp return logic simplification

* [TechDraw] DrawBrokenView.cpp return logic simplification

* [TechDraw] HatchLine.cpp return logic simplification

* [TechDraw] LineGenerator.cpp return logic simplification

* [TechDraw] Preferences.cpp return logic simplification

* [TechDraw] ShapeExtractor.cpp return logic simplification

* [TechDraw] MDIViewPage.cpp return logic simplification

* [TechDraw] QGILeaderLine.cpp return logic simplification

* [TechDraw] QGIRichAnno.cpp return logic simplification

* [TechDraw] QGTracker.cpp return logic simplification
2024-11-18 16:14:47 -03:00
Jiří Pinkava
00acfd5b2a Sketcher: refactor, drop return in void returning functions 2024-11-18 12:21:25 -05:00
mosfet80
a5f6846e7f [Mod] clean FemMesh.cpp
Removed dead code
2024-11-18 18:01:59 +01:00
Jiří Mácha
2eec246e95 Assembly: fixed defect in the migrationScript4 function
The old CAD model created by the development version of FreeCAD
(in which the Assembly workbench was used) contained joints that,
for some reason, had an empty Joint Connector 1 reference (Reference1).

This was causing an exception and a crash of the Python function
called migrationScript4. The FreeCAD Report view contained:

23:28:29  pyException: Traceback (most recent call last):
  File "/FreeCAD/Mod/Assembly/JointObject.py", line 175, in onDocumentRestored
    self.createProperties(joint)
  File "/FreeCAD/Mod/Assembly/JointObject.py", line 181, in createProperties
    self.migrationScript4(joint)
  File "/FreeCAD/Mod/Assembly/JointObject.py", line 514, in migrationScript4
    if hasattr(joint, "Reference1") and joint.Reference1[0] is not None:
                                        ~~~~~~~~~~~~~~~~^^^
<class 'TypeError'>: 'NoneType' object is not subscriptable

This patch attempts to avoid such exceptions by validating the type of
the property variable before accessing it.
2024-11-18 17:46:44 +01:00
PaddleStroke
a174d87fac Assembly: Store DocumentObject instead of mbdPart for the dragged parts. Fixing the bug where doDragStep was 50% of time failing to find the correct DocumentObject due to bundling. 2024-11-18 17:43:53 +01:00
Benjamin Nauck
8ea82a849c Spreadsheet: Double click separator to resize to content
Qt handles resize to content on double clicking the separator in the header, by default.
However this does not work in FreeCAD.

There are no comments on why this was done and is therefore treated as bug instead of feature.

Manual testing has been performed after the change and:

* Scaling by double clicking separator in header works
* Sizes are correctly stored in sheet when resizing to content
2024-11-18 09:12:22 -05:00
hasecilu
e5be24d422 Addon Manager: Show repository URL if it exists on the metadata
Fix: #14777
2024-11-18 08:51:15 -05:00
hasecilu
1657d46241 Addon Manager: Show involved branches' names on branch change operation
Fix #12969
2024-11-18 08:47:52 -05:00
Yorik van Havre
31d9d9d881 BIM: Fixed image loading of the tutorial - fixes #17863 2024-11-18 14:22:44 +01:00
Yorik van Havre
1309208603 BIM: Optimized leader UI (#17310)
* BIM: Optimized leader UI - fixes #17284

* Correct task panel icon for BIM Leader.
* Make BIM Leader task panel title translatable.
* Use a single mode parameter for the Line class.

---------

Co-authored-by: Roy-043 <info@b-k-g.nl>
2024-11-16 18:10:04 +01:00
Roy-043
3f15242ad1 Draft: fix tray construction mode button for Light and Dark themes (#17886)
Fixes #17869.
2024-11-16 18:04:26 +01:00
Gauthier Brière
740f5f18df [Draft] add font path relative (#17819)
* Permit a font file path relative to the FreeCAD file

* Use obj.Document instead of App.ActiveDocument

* use filename = instead of directory =
2024-11-16 18:02:02 +01:00
Yorik van Havre
87779387cc Draft: minor fixes (#17793)
- more tolerance on faultly solids in shape2Dview
- fixed display of dimensions in arch override unit
2024-11-16 17:52:55 +01:00
Roy-043
bb89edc83e Draft: Fix extra_scale error in hatch.py (#17715)
Fixes #17712.
2024-11-16 17:49:35 +01:00
Yorik van Havre
37f50c1b10 Draft: Independence from BIM (#17444)
* Draft: Independence from BIM - follow-up of #17390

* Draft: More info in DXF importer if BIM not present
2024-11-16 17:48:28 +01:00
Chris Mayo
cea8d25c11 Draft: Make startup and tests independent of BIM (#17390) 2024-11-16 17:43:46 +01:00
marioalexis
011ff2e34b Fem: Set mesher task panel log text to read-only 2024-11-16 14:31:48 +01:00
marioalexis
7eed9e317d Fem: Adapt FemPostObject transparency to changes made in #ffa3fa5b5a 2024-11-16 12:49:47 +01:00
Max Wilfinger
fc3996b53f Merge pull request #17637 from furgo16/patch-3
Reword rigid/flexible sub-assemblies tooltip.
2024-11-16 10:03:52 +01:00
Furgo
2577cc9cf0 Re-add the note about right click, with more context 2024-11-16 07:15:05 +01:00
luzpaz
a633be7342 Fix various typos
Found via codespell.
2024-11-15 20:18:46 +01:00
OfficialKris
4d4c4fc708 Modified text of all items on help menu
Used ToolTipText for StatusTip on all menu items
Modified some of the MenuTexts
Modified some of the Pixmaps
2024-11-15 18:57:39 +01:00
Furgo
a5c7fc98ca Reword error log to be more verbose 2024-11-15 18:53:00 +01:00
OfficialKris
5e124f0472 Moved items in the Help menubar 2024-11-15 18:51:14 +01:00
marioalexis
934b535c98 Fem: Minor change to Mesh task panels and renaming Gmsh mesh properties group 2024-11-15 18:46:58 +01:00
Max Wilfinger
665bee5e5a Merge pull request #15957 from hasecilu/fix/capitalization
TechDraw: Fix capitalization of 2D and 3D
2024-11-15 18:37:47 +01:00
Max Wilfinger
e8b7fac134 Merge pull request #16535 from WandererFan/translationFixes317And335
[TD] Translation fixes (fix #317 fix #335)
2024-11-15 18:36:44 +01:00
luzpaz
efd4232112 STEP: Rename generic Import/Export dialog title
Closes #16415
2024-11-15 18:36:09 +01:00
wmayer
3c1bf8e864 Core: Extend Color API
* Fix issues with alpha value <> transparency
* Use type traits to convert between different color classes (fixes #14515)
2024-11-15 12:25:25 -05:00
Syres916
6a6699ac86 [Sketcher] Assist user in finding the sketch with the error 2024-11-15 12:15:59 -05:00
Max Wilfinger
82f268f2b4 Merge pull request #14959 from yorikvanhavre/bim-ifc-icons
BIM: Specific IFC icons
2024-11-15 18:11:00 +01:00
Yorik van Havre
726999c9ec Draft: Implement unhandled svg text rotation 2024-11-15 12:09:53 -05:00
Snow Faerie
1ff4b2020b Add Ctrl+{B,I,U} to Spreadsheet; remap File/Import
Adds hotkeys for Bold, Italic and Underline in Spreadsheet.

Ctrl+I was taken by File/Import... This patch remaps that to Ctrl+Shift+I.
2024-11-15 11:57:18 -05:00
FEA-eng
439b7f620e Update Command.cpp 2024-11-15 11:56:46 -05:00
Roy-043
dae79106f6 FEM: FEM_CreateElementsSet menu text in sentence case 2024-11-15 11:56:32 -05:00
wmayer
dbc9615308 Coverity scan: Uninitialized scalar variable
* CID 350633
* CID 512344
* CID 514343
2024-11-13 18:58:16 -05:00
Kevin Martin
ae235ef3e8 Change C++ DXF import to ignore type 999 (comment) records 2024-11-13 10:09:12 +01:00
Paul Lee
97171b5eec [ArchCurtainWall] Bug-fix Sketch as Base
Found regression when Sketch is used as Base and OverrideEdges is specified.
2024-11-13 10:05:37 +01:00
Roy-043
9a4e198d8e Draft: Fix AnnotationStyleEditor delete last style error (#17758)
* Draft: Fix AnnotationStyleEditor delete last style error

Fixes #17716.

* Fix rename problem as well

The on_rename function should update self.current_style as well. To avoid this scenario:
1. Create style A.
2. Create style B.
3. Rename style B to C.
4. Switch to style A.
5. Press OK.
6. Start the tool again.
7. Result: there are 3 styles A, B and C.
2024-11-13 10:02:20 +01:00
wwmayer
7a0154d1b1 PD: Add test case for #17184 (#17707) 2024-11-11 18:21:15 -03:00
Alfredo Monclus
78d57469af fix(PD): initialization of thread class and fit 2024-11-11 18:18:30 +01:00
PaddleStroke
96c1e86e5d Measure: Fix quickmeasure problem with Part::Line objects 2024-11-11 18:17:36 +01:00
dominik-devops
5e69c41306 Update dxf.cpp with missing new line character 2024-11-11 18:14:39 +01:00
Yorik van Havre
36096754c7 Merge pull request #17778 from marioalexis84/fem-material_editor
Fem: Use new material editor in materials task panels - fixes #16814
2024-11-11 17:58:49 +01:00
Yorik van Havre
04f0e7a330 Merge pull request #17782 from wwmayer/issue_17770
Unhandled std exception dragging Cylindrical joint
2024-11-11 17:56:04 +01:00
PaddleStroke
cd9e155078 Techdraw: Fix assembly exploded view (#17726) 2024-11-11 17:53:34 +01:00
Eric Price
44305ffc89 Part: bugfix #17468 recursively unpack compounds for boolean fuse (#17469)
* fix #17468  recursively unpack compounds for boolean fuse

* fix and into &&, add ctest case for multifuse with compounds and recursive compounds

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove unneeded duplicated code - allow Part::Common to be created with a single object (compound or shape) - will result in Unity and possibly a warning message

* prevent endless loop in case of endless recursive compounds as suggested in chat

* Update src/Mod/Part/App/FeaturePartFuse.cpp

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>

* implemented suggestion by wwmayer

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2024-11-11 17:51:56 +01:00