Joao Matos
26437bb86d
PartDesign: Refactor ViewProviderTransformed::recomputeFeature.
2025-03-03 21:22:22 +00:00
Joao Matos
08523fe1ac
Part/PartDesign/TechDraw: Simplify calls to DocumentObject::recomputeFeature.
2025-03-03 21:22:22 +00:00
Joao Matos
60605cc2db
App: Refactor with early exit in Document::recomputeFeature.
2025-03-03 21:22:22 +00:00
Joao Matos
57d890a590
Gui: Remove unused Command::updateAll.
2025-03-03 21:22:22 +00:00
Joao Matos
842a89c30e
PartDesign: Refactor Command::finishFeature.
2025-03-03 21:22:22 +00:00
Joao Matos
16c035bc38
Gui: Refactor StdCmdRefresh::activated.
2025-03-03 21:22:22 +00:00
Joao Matos
ed27ab85de
CMake: Add GCC/Clang -fdiagnostics=color compiler option.
2025-03-03 18:13:39 +01:00
wandererfan
4f9bf0e72e
[TD]change scaling default for Draft & BIM views
2025-03-03 10:44:03 -06:00
paul
534c32975b
[ArchWindow] Improve SubVolume() HoleDepth deduction algorithm ( #19774 )
...
* [ArchWindow] Improve SubVolume() HoleDepth deduction algorithm
https://github.com/FreeCAD/FreeCAD/issues/19559
https://forum.freecad.org/viewtopic.php?t=92360
https://forum.freecad.org/viewtopic.php?p=812844#p812844
Current HoldeDepth deduction algorithm is too 'agressive' and may punch holes in adjacent wall segment.
With improved algorithm, ArchComponent pass the Window's host information to ArchWindow getSubVolume() to deduce HoleDepth taking into account of Wall's Width /getWidths for Wall Base is ArchSkech
TODO: For future development - More robust approach
With ArchSketch, on which wall segment an ArchObject is attached to is declared by user and saved.
The extrusion of each wall segment could be done per segment, and punch hole in the exact wall segment before fusing them all. No need to care about each wall segement thickness.
* [ArchWindow] Typo Lint reported
* [ArchWindow] Fix getSubFace(self) raise NotImplementedError
Github comment - https://github.com/FreeCAD/FreeCAD/pull/19774#discussion_r1972052310
2025-03-03 17:38:22 +01:00
Chris Hennes
d41114589c
Merge pull request #19411 from benj5378/enums2
...
TechDraw: hard type enums, part 2
2025-03-03 10:37:21 -06:00
Chris Hennes
d9ab6c1645
Merge pull request #19753 from benj5378/tag
...
TechDraw: centralize tag functionality
2025-03-03 10:36:24 -06:00
Aurélien Pascal
15c3b560e2
TechDraw: Fix hatch drawing ( #19458 )
...
* TechDraw: Fix hatch drawing (#16353 )
* TechDraw: Fix hatch drawing in Tech View
2025-03-03 10:35:13 -06:00
WandererFan
da8602c1b0
Broken view no compress19647 ( #19688 )
...
* [TD]fix broken view does not collapse
* [TD]delint and clean up code
* Update src/Mod/TechDraw/App/DrawBrokenView.cpp
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
* Update src/Mod/TechDraw/App/DrawBrokenView.cpp
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
* Update src/Mod/TechDraw/App/DrawBrokenView.h
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
* Update src/Mod/TechDraw/App/DrawBrokenView.h
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
* Update src/Mod/TechDraw/App/DrawBrokenView.cpp
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
* [TD]fix merge errors
---------
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
2025-03-03 10:34:23 -06:00
Chris Hennes
729fffaade
Merge pull request #19930 from marioalexis84/fem-current_density
...
Fem: Improve current density boundary condition
2025-03-03 10:32:35 -06:00
xtemp09
7600f58e23
[Spreadsheet] Fix unset zoom level
2025-03-03 10:27:39 -06:00
tritao
6792d6bfd7
Remove Python-generated bindings comparison against XML-generated version.
2025-03-03 10:22:41 -06:00
PaddleStroke
643830624a
Update PreCompiled.h
2025-03-03 10:21:37 -06:00
Roy-043
bc430234d2
Draft: fix Draft_Trimex boundary subelement selection
...
Fixes #19614
Instead of using the whole object, the hovered subelement should be used for the boundary.
With this PR the handling of the boundary is also 'nesting-aware'. This is however still not the case for the object being extended/trimmed. That object has to be in the global space.
2025-03-03 17:18:25 +01:00
Roy-043
cff2d4f8fb
Draft: fix Draft_Edit isAttachedToDocument issue
...
Fixes #19939
The `isAttachedToDocument` method only works in certain circumstances.
https://forum.freecad.org/viewtopic.php?t=94709
2025-03-03 17:17:55 +01:00
Roy-043
14c88e288e
Draft: fix NaN issue with Draft_Rotate
...
Fixes #19690
The issue was caused by a zero distance between the center and the point picked for the rotation angle.
2025-03-03 17:09:11 +01:00
Roy-043
0b81e6e318
Draft: fix polar coords regression
...
Fixes #19961
Regression caused by #19179 .
2025-03-03 17:07:20 +01:00
Alfredo Monclus
84e6d8b915
refactor: add if braces for linters
2025-03-03 11:30:43 -03:00
Alfredo Monclus
2f504b686e
revert: icon to manually painted one
...
windows icon is very different let's try to keep the look unified
2025-03-03 11:21:44 -03:00
Alfredo Monclus
02b16bc454
revert: review suggestion from constexpr to const
2025-03-03 11:10:51 -03:00
Alfredo Monclus
779cfa0463
taskpanel lineup comments
2025-03-03 10:49:27 -03:00
Alfredo Monclus
a1305d6616
taskpanel group early return
2025-03-03 10:49:26 -03:00
Alfredo Monclus
9392af17f9
Apply suggestions from code review
...
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
2025-03-03 10:45:22 -03:00
Benjamin Nauck
d017242584
Use designated initializers and remove zero-initialized fields
2025-03-03 11:02:19 +01:00
Chris Hennes
8593beb6f1
Gui: Add QOpenGLWidget to QtAll.h
2025-03-02 22:59:30 -06:00
marioalexis
7821b2e611
Fem: Update constraint symbol rotation
2025-03-03 00:02:11 -03:00
marioalexis
d2eb1b7ff3
Fem: Fix Elmer magnetodynamic boundary condition keyword
2025-03-03 00:02:11 -03:00
marioalexis
d4dca9fd93
Fem: Improve current density boundary condition
2025-03-03 00:02:02 -03:00
Chris Hennes
e94adfe164
Merge pull request #19951 from chennes/missingColorFix
...
Misc. compilation fixes
2025-03-02 17:32:51 -06:00
Chris Hennes
0a94747bf6
Spreadsheet: Fix old ref to name in doc
2025-03-02 17:23:26 -06:00
Chris Hennes
15a9efe356
Inventor: Fix old color ref
2025-03-02 17:09:19 -06:00
Chris Hennes
1a2070c36f
Merge pull request #19636 from kadet1090/color-in-base
...
Base: Move App::Color to Base
2025-03-02 16:36:40 -06:00
Joao Matos
f2a8bc92af
CI: Extract apt packages installation into a script.
...
This provides a few benefits, as regular users can just call this script
as well and not need to copy this from the CI files to know which files
to install.
2025-03-02 16:35:30 -06:00
Chris Hennes
1ea26a4a94
Merge pull request #19450 from tritao/base-python-api-model
...
Base: Modernize Python bindings APIs
2025-03-02 16:34:25 -06:00
Chris Hennes
98537f00b1
Merge pull request #19626 from tritao/qt-gl-cleanup
...
Gui: Remove QtOpenGL.h.
2025-03-02 16:22:57 -06:00
Andrew
8605bc1747
Merge pull request #19747 from Shkolik/sketcher_datums_projection
...
fix #18894 Sketcher: Create external projection geometry not working with datum objects
2025-03-02 16:20:45 -06:00
Chris Hennes
50adb86a1f
Merge pull request #19761 from chennes/coverityFixesFeb2025
...
Base: Coverity fixes from February 2025 run (round 1)
2025-03-02 16:15:17 -06:00
mosfet80
54f43eb501
Clean AppPartPy.cpp
...
Python version is always greater than 3.9
2025-03-02 16:13:55 -06:00
Roy-043
cdfa386f87
Draft: fix Draft_Edit issue with Gesture navigation
...
Fixes #19519
2025-03-02 16:13:13 -06:00
João Matos
d93c3233fe
Apply suggestions from code review
...
Co-authored-by: Benjamin Bræstrup Sayoc <benj5378@outlook.com >
2025-03-02 19:47:55 +00:00
Benjamin Bræstrup Sayoc
1078ee8c35
Remove magic number and hard type enums in DrawViewPart.h
...
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc
a1a79f01b2
Remove magic number and hard type enums in DimensionValidator.h
...
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc
e92efb14ac
Remove magic number and hard type enums in DrawViewDimension.h
...
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc
a45e2ae8a4
Remove magic number and hard type enums in BalloonPropEnum.h
...
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
Benjamin Bræstrup Sayoc
351feb132a
Remove magic number and hard type enums in ArrowPropEnum.h
...
- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
2025-03-02 17:14:24 +01:00
wandererfan
e48fee5acc
[TD]Property types and spinboxes for Detail
2025-03-02 09:05:10 -05:00