Commit Graph

2434 Commits

Author SHA1 Message Date
sliptonic
f3d6bd21e3 translation cleanup PathCustom/gui 2022-01-03 10:48:39 -06:00
sliptonic
9b4af0b812 translation cleanup PathComment
transaction PathComment
2022-01-03 10:48:39 -06:00
sliptonic
e022675b7a tranlation cleanup PathCopy
transaction PathCopy
2022-01-03 10:48:39 -06:00
sliptonic
2a22ead350 black reformat
black reformat for PathCommands

Black reform PathCopy

Black reform PathComment

Black reformat PathCustom/gui

Black reformat PathUtil/PathUtils

Black reformat PathHop

Black reformat PathGeom

Black reformat

Black reformat

Black reformat

Black reformat

Black reformat

black reformat

Black reformat

black
2022-01-03 10:48:39 -06:00
sliptonic
e209bc706d Merge pull request #5008 from Russ4262/fix/childless_job
[Path] Fixes #4645
2022-01-03 10:37:27 -06:00
jim
ba4f1b443b allow user to specify a seed value for jitter pseudorandomness so that multiple operations/tools can follow the same sequence 2022-01-02 07:38:56 -08:00
jim
531e9143f4 Correct typo in jitter dimension calculation 2022-01-01 19:59:24 -08:00
sliptonic
a65dbc6f82 Use run() instead of Popen() to avoid need for communicate() call. 2021-12-31 10:04:17 -06:00
sliptonic
ca950cf54a use subprocess.Popen() the right way 2021-12-30 16:58:45 -06:00
sliptonic
f18c730491 fix #4810
use subprocess.Popen() to avoid executing arbitrary code
2021-12-30 16:32:17 -06:00
Russell Johnson
344d1b4dc4 Black formatting only 2021-12-25 00:29:05 -06:00
Russell Johnson
763057a1a2 Path: Fix 'NoneType' argument error in '_stepTransitionCmds()'
The 'p1' argument is passed in as 'None' on occasion.  This fix cancels the efficient transition between the two points.  3D Surface is and experimental op, and therefore this fix needs additional user testing with various complex models.
2021-12-25 00:27:19 -06:00
sliptonic
b23ae963d9 Merge pull request #5271 from sundtek/sundtek-discretize-bug
[PATH] change discretize value to fix issues
2021-12-19 12:35:13 -06:00
sundtek
7172e57e5d Update PathAdaptive.py
the internal unit is mm, only lowering the accuracy should be enough.
2021-12-20 01:15:59 +08:00
sundtek
47fc8dee91 change discretize value to fix issues
Discretize of 0.0001 is okay for inches, but for metric <1microns would be quite small, this fixes some issues when generating paths for curves that look inward.
I found following post in the forum: https://forum.freecadweb.org/viewtopic.php?f=15&t=42755
I have experienced similar issues with other curves in my object.
2021-12-19 19:23:09 +08:00
sliptonic
21765dec9c Modified combobox selection
cleaned up translation method

Profile translation cleanup

Incorporating additional suggestions
2021-12-17 08:35:41 -06:00
Russell Johnson
1eccba10ca Path: Translation Solution POC 2021-12-17 08:35:41 -06:00
sliptonic
3ca86cafeb PathOpGui Black reformat 2021-12-17 08:35:41 -06:00
luz paz
e901e584ac Path: fix file header uniformity 2021-12-10 02:36:56 +01:00
Peter Roß
9f9709c7a3 Merge branch 'FreeCAD:master' into RRF-PP-for-Path 2021-12-06 12:33:23 +01:00
sliptonic
f5d230ed29 Merge pull request #5205 from sliptonic/bug/depthsteps
[PATH]  depthparams handles negative steps and finish step correctly. Unit tests
2021-11-26 20:24:25 -06:00
sliptonic
8e6c5a497b make sure depthparams handles negative steps and finish step correctly
revised test
2021-11-26 13:27:44 -06:00
sliptonic
4c129c7526 face outerwires aren't always the first wire in the Wires list.
Added logic to compare hashCodes()

https://forum.freecadweb.org/viewtopic.php?f=13&t=50567
2021-11-15 18:40:28 -06:00
P-C-R
698fe21c0f Update rrf_post.py 2021-11-15 08:20:06 +01:00
P-C-R
8e27e8010f Bugfix for "Before Tool Change" Commands 2021-11-15 08:15:07 +01:00
luz paz
3da6ced354 Fix header uniformity 2021-11-13 06:20:19 -05:00
P-C-R
6f087718f6 Upload of a PP for RRF (RepRapFirmware)
Modified Marlin PP for RRF.
2021-11-03 15:33:51 +01:00
Russell Johnson
c35e44d5dd Application of Black formatting 2021-10-06 19:56:42 -05:00
Russell Johnson
d59ae608d6 Fix incorrect arguments list
This commit fixes the error reported in the forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=33121&start=50#p537787.

This error was introduced when another user replaced the `extractFaceOffset()` method from the PathSurfaceSupport.py module with an improved `getOffsetArea()` function in the PathUtils.py module.  The two instances of the improved `getOffsetArea()` calls here in this fix did not get corrected when that improvement was originally made.
2021-10-06 19:56:03 -05:00
sliptonic
c21f7ab023 Black reformat 2021-09-29 16:51:00 -05:00
sliptonic
9fbd227456 Job object doesn't exist in this context.
Derive output name in the output section or default if unknown
2021-09-29 16:51:00 -05:00
Russell Johnson
e018707307 Path: Strict application of Black code formatting to module file
This commit ONLY contains application of `Black` code formatting.  No other alterations have been made in this commit.
2021-09-27 20:53:09 -05:00
Russell Johnson
0242ada64e Path: Restore removal shape envelope buffer
This buffer application was removed in PR #4978 with removal of rotational code.

The buffer is required to provided adequate significant digit or rounding  in later processing of envelope in Path.Area().

NOTE:  I suggest separate `removalshape` envelopes  be created without the necessary `buffer` adjustment to allow for usage of the `removalshape` for subsequent REST type operations.
2021-09-27 20:53:09 -05:00
sliptonic
0afe01dc5e Merge pull request #5009 from Russ4262/fix/ramp_dressup
[Path] Fix for inactive ramp dressup base operation
2021-09-27 15:34:43 -05:00
sliptonic
fdfe0291fd Merge pull request #5050 from jimzim111/PathArray_Z
Path: PathArray translate copies along Z axis as it does along X/Y
2021-09-27 15:19:43 -05:00
sliptonic
c062384976 Merge pull request #4975 from Russ4262/cleanup/pathprofile
[Path] LGTM cleanup of PathProfile module
2021-09-27 15:16:20 -05:00
Russell Johnson
c44b7d7b54 Path: Fixes #4645
Fixes bug #4645.
This PR adds a simple `integrityCheck()` method to Job object class.  The method is called on the Gui side before openning the task panel to edit the job.  The same method is also called upon document restoration.
2021-09-24 06:43:16 -05:00
Russell Johnson
2bb8baec06 Path: Delete unnecessary comments 2021-09-24 06:40:53 -05:00
Russell Johnson
dd03e616d0 Path: LGTM cleanup 2021-09-24 06:40:53 -05:00
Russell Johnson
fcd8b8558e Path: Fix Face Region boundary shape usage
This commit removes automatic edge extension for `Face Region` boundary shape.  It applies the `Clear Edges` toggle for `Face Region`.  It applies `Exclude Raised Areas` correctly.  The problem of collision paths for `Clear Edges` with `Exclude Raised Areas` for certain use cases remains and is not fixed with this commit.
2021-09-24 06:39:25 -05:00
Russell Johnson
7ec38a5c3b Path: Remove unused import 2021-09-24 06:39:25 -05:00
Russell Johnson
1fbb7412b7 Path: Add docString and comments for getAllIncludedFaces() method 2021-09-24 06:39:25 -05:00
Russell Johnson
48d10b25b2 Path: LGTM fix
Prompted by LuzPaz in Gitter.im/FreeCAD/Path chatroom
2021-09-24 06:39:25 -05:00
Russell Johnson
61a43a644c Path: Black code formatting only 2021-09-24 06:38:39 -05:00
Russell Johnson
a83871e509 Path: Add Base.Active check early in execute() method
This commit adds a `Base.Active` check to determine if the Base is Active.  If the Base is Inactive, the new code sets the `obj.Path` property to the same inactive message used in PathOp module and the `execution()` method returns immediately, stopping further execution.
2021-09-24 06:38:39 -05:00
jim
6e1784ddba PathArry translate copies along Z axis as it does along X/Y 2021-09-20 21:10:49 -07:00
Chris Hennes
be5971ad8e Path: LGTM - don't catch BaseException 2021-09-19 14:37:11 -05:00
luz paz
6642e28826 Path: Fix PathScripts/PathJobGui.py typo bug 2021-09-08 10:22:26 -04:00
sliptonic
b53ec3bd4e Black reformat 2021-09-01 12:56:00 -05:00
sliptonic
ddc4c69e82 black 2021-09-01 12:26:29 -05:00