Commit Graph

2434 Commits

Author SHA1 Message Date
Russell Johnson
90564ea3fd Path: Set CustomPoint2 and CustomPoint1 defaults equal
Setting these two default values equal will aid in code execution and error detection.  Subsequent fixes will rely on this condition.
2021-04-08 22:43:32 -05:00
Russell Johnson
b1ffa159a2 Path: Fix update of Extensions Default Length GUI spin box
Fix the bug hindering update of the Default Length spin box in the Extensions tab after editing and change of focus. 
With the fix, the spin box updates after change of focus, as do other spin boxes in the Path workbench.
Used method found in PathDrillingGui module.
2021-04-08 22:27:02 -05:00
luz paz
15c16610c8 fix source comment typos [skip ci]
Found via  codespell v2.1.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu
```
2021-03-28 10:57:24 +02:00
Chris Nisbet
67f89ac557 Path: vcarve - Fix depth calculation
Depths were being calculated incorrectly due to MIC distance getting
divided by scaling factor rather than multiplied by it.

The scaling factor is the inverse of the tan of half the cutting tool
angle, so for a 30 degree bit (say), the scaling factor would be
1 / tan(30/2), or 3.7320.

When given an MIC (which is a radius) of 3.175 (say), and cutting to the
same width with a 30 degree bit, the depth should be 3.175 * 3.7320
(11..849), not 3.175 / 3.7320 (0.8509) as it is currently.
2021-03-28 16:56:47 +13:00
sliptonic
182a578c43 Merge pull request #4664 from papaathome/uccnc_postprocessor
Path: Added UC-CNC postprocessor script.
2021-03-26 15:26:05 -05:00
andre
19fa532e2a Aplied Flake8 formatting and removed redundant global declarations.
Line limit used: 100 characters, still 3 lines longer than that.
2021-03-26 17:53:02 +01:00
andre
5abd19f121 Included bugfix as in FreeCAD PR. #4673 'Fix proxy error bug that occurs when postprocessing' (review recommendation) 2021-03-26 09:33:40 +01:00
sliptonic
515c7deb21 Merge pull request #4634 from mlampert/bugfix/issue-2839-dogbone-visualisation
[Path]: Bugfix/issue 2839 dogbone visualisation
2021-03-25 22:17:31 -05:00
sliptonic
837cf18153 Merge pull request #4639 from claasahl/claasahl-patch-1
[Path] post procesing for GRBL with option "--translate_drill" should also suppress G99
2021-03-25 17:43:34 -05:00
andre
232969348a Added UC-CNC postprocessor script. 2021-03-24 17:13:42 +01:00
sliptonic
05b0ff2fd1 Merge pull request #4624 from mlampert/bugfix/dogbone-on-straight-edges-and-noop-moves
[Path]: Bugfix/dogbone on straight edges and noop moves
2021-03-23 12:58:44 -05:00
mlampert
a5c4d19a10 Merge branch 'master' into bugfix/issue-2839-dogbone-visualisation 2021-03-22 22:42:53 -07:00
mlampert
c81a43a256 Merge branch 'master' into bugfix/dogbone-on-straight-edges-and-noop-moves 2021-03-22 14:45:41 -07:00
mlampert
5fccb4fc9b Merge branch 'master' into bugfix/job-setup 2021-03-22 14:44:44 -07:00
sliptonic
7d118f31b7 Merge pull request #4615 from Russ4262/fix_pocketshape_combine_shapes
[Path] Fix connected multi-face clearing bug
2021-03-22 13:53:55 -05:00
Claas Ahlrichs
f0f25af3f5 Update grbl_post.py 2021-03-20 10:27:46 +01:00
Markus Lampert
67555d2cc3 Fixed coin import for py3 class initialisation 2021-03-18 18:00:55 -07:00
Markus Lampert
e510d095c4 Moved coin import under GuiUp clause 2021-03-18 11:44:57 -07:00
Markus Lampert
1704f42fb4 Cleanup marker after deleting them 2021-03-17 20:06:01 -07:00
Markus Lampert
c343533604 Added visualisation for dogbones during editing 2021-03-17 19:46:51 -07:00
Markus Lampert
fb49fb2470 Dogbone resiliency against noop moves 2021-03-15 22:39:27 -07:00
Markus Lampert
ef6d526bc3 Dogbone resiliency against comments between moves 2021-03-15 22:39:18 -07:00
Markus Lampert
35efc4ec4d Don't insert dogbone between two straight segments 2021-03-15 22:39:09 -07:00
Markus Lampert
501524e1dc Disable stock/model linking by default 2021-03-14 19:33:45 -07:00
Markus Lampert
2f2ea4c9d4 Fixed race condition in deleting job when cancelling its task panel 2021-03-14 18:33:22 -07:00
Markus Lampert
2ffa5be3fa Fixed aligning path model along an axis. 2021-03-14 18:23:49 -07:00
sliptonic
4092c97bac Merge pull request #4573 from Russ4262/fix_pocketshape_warning_msg
[Path] PocketShape: Remove 'verify final depth' warning
2021-03-13 11:54:05 -06:00
Russell Johnson
bd6c8324ab Path: Fix connected multi-face clearing bug
Identified by MLampert.  If multiple faces are selected at varying Z-heights, the `combineConnectedShapes()` method fails to connect them due to offset Z-heights.  This fix places all input faces for that method into the same working plane.
2021-03-13 11:34:35 -06:00
sliptonic
c1b471588b [PATH] Fix bug with spindle not restarting
if output is split by operation spindle should restart when next file is loaded
2021-03-12 13:12:09 -06:00
Russell Johnson
c087c18fbe Path: Remove 'verify final depth' warning 2021-03-06 11:44:06 -06:00
sliptonic
a6fd02cb04 Fix whitespace error 2021-02-23 19:14:49 -06:00
sliptonic
fa5dc51491 fix trailing whitespace 2021-02-23 19:12:25 -06:00
sliptonic
315d4a8026 fix bad string formatting 2021-02-23 19:06:08 -06:00
sliptonic
b2283c5430 Make string less ambiguous 2021-02-23 19:03:18 -06:00
sliptonic
85bd1bf639 typo in string 2021-02-23 19:01:29 -06:00
sliptonic
f7c50a4d75 fix string formatting 2021-02-23 18:59:04 -06:00
Patrick F
6974ef8b9e [PATH] offsetWire bugfixes 2021-02-21 02:56:14 +01:00
sliptonic
20d513cd66 Merge pull request #4484 from Russ4262/fix_profile_feature_filter
[Path] Fixes for Profile operation [0.19]
2021-02-20 17:27:00 -06:00
sliptonic
2940953470 Merge pull request #4497 from sliptonic/bug/adaptiveuseoutlineprop
[PATH]  Small fixes to Adaptive op and Heidenhain post processor
2021-02-20 17:15:45 -06:00
Russell Johnson
2b35419e55 Path: LGTM cleanup 2021-02-20 12:32:25 -06:00
Russell Johnson
a961fbee86 Path: Remove unnecessary line return 2021-02-20 12:32:25 -06:00
Russell Johnson
1b3205de20 Path: Add error for incorrect open-edge usage
When profiling open edges, the user must currently select a top edge and then set the Final Depth manually to a value below the selected edge(s).
This fix provides the user with feedback for the empty path generated.
2021-02-20 12:32:25 -06:00
Russell Johnson
215967fe78 Path: Catch error if ofstShape has no Area attribute 2021-02-20 12:32:25 -06:00
Russell Johnson
2b4158addc Path: Fix incorrect empty data type return 2021-02-20 12:32:25 -06:00
Russell Johnson
8e234290ef Path: Catch openEdges error if None 2021-02-20 12:32:25 -06:00
Russell Johnson
b3fc4fcf17 Path: Fix spacing typo 2021-02-20 12:32:25 -06:00
Russell Johnson
d7483f6e85 Path: Fix range() input type per gcc-7 build 2021-02-20 12:32:25 -06:00
Russell Johnson
3a10ed5f27 Path: Fix feature selection and handling
Fix error when working with selections containing edges and faces.  This fix effectively processes edges and only passes faces on to next processing step.  This simplifies the code a bit and changes some `obj.Base` references to `otherBase` to improve readability.
Path: Improve `obj.Base` reading and processing

`obj.Base` is first read in `self._processEdges()`.  All edges are identified and processed there.  Remaining features are saved in `remainingObjBaseFeatures` to be processed in the next section of the Profile code.
Path: Change `if` to `elif`
2021-02-20 12:32:25 -06:00
Russell Johnson
91dd729d4e Path: Fix error for undefined profileshape variable 2021-02-20 12:32:25 -06:00
Russell Johnson
8f4f304635 Path: Fix open-edge profiling for micro bit usage 2021-02-20 12:32:25 -06:00