Commit Graph

26860 Commits

Author SHA1 Message Date
Chris Hennes
e3cdb7f875 Merge pull request #5163 from donovaly/PD-sweep-section-visibility2
[PD] fix sweep visibility bug
2021-11-10 22:43:49 -06:00
Uwe
7353ec0096 [PD] code improvement for FeaturePad
as noted by @chennes in PR #5164, we should follow the C++ style guidelines:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-if
2021-11-11 02:26:42 +01:00
Uwe
aa0f0cd3bb [PD] code improvements for TaskPadParameters
as requested by @chennes in PR #5164, the code can be simplified:

- remove a redundant type cast, a redundant qualifier and an inconsistent and unnecessary check
2021-11-11 02:08:57 +01:00
Uwe
6db3337cd2 [PD] handle changed property for loft and pipe
- this was missing in PR #5155
2021-11-11 01:24:53 +01:00
Ajinkya Dahale
0f7f7136ce [PD] Check if property is named before strcmp 2021-11-11 01:13:17 +01:00
Uwe
7bea9e5bc5 [PD] fix sweep visibility bug
Currently:

    only sweep path is toggled correctly in its visibility, the profile is never shown
    the sections are always shown

This PR fixes this inconsistency reported here: https://forum.freecadweb.org/viewtopic.php?f=19&t=63544
2021-11-11 00:00:58 +01:00
sliptonic
c8508fadab cmake error 2021-11-10 13:33:20 -06:00
wmayer
0b75d53676 App: code cleanup 2021-11-10 18:33:26 +01:00
Ajinkya Dahale
99bafa24e8 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Bernd Hahnebach
aa33cdc186 Arch: export IFC, make compatible with ifcopenshell 0.7 2021-11-10 15:59:30 +01:00
Chris Hennes
990e23bb24 Merge pull request #5152 from Roy-043/Draft-fix-getTeighaConverter
Draft: fix getTeighaConverter
2021-11-09 23:05:03 -06:00
Uwe
e6837f8ef2 [PD] fix a typo
- also some sorting
2021-11-10 03:26:23 +01:00
luz paz
ef37925b08 Gui: expose the 'Link Actions' toolbar icon to translation
Related to https://github.com/FreeCAD/FreeCAD-translations/issues/51 and https://github.com/FreeCAD/FreeCAD-translations/issues/16
2021-11-10 01:12:45 +01:00
luz paz
b56cd8007b TechDraw: Renames submenu command + exposes to translation
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/82  
The dropdown `TechDraw > Extensions: centerlines and threading` (submenu) is too long and superfluous. Renamed to: `Extensions: Centerlines/Threading`. Also exposed to translation.
2021-11-10 01:11:39 +01:00
Ajinkya Dahale
854b547503 [PD] Fixed loft and sweep breaking on section deletion
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
2021-11-09 23:05:29 +01:00
Ajinkya Dahale
9cade40755 [PD] Support adding solid faces for loft and pipe sections
With these changes, one face per solid can be added as either the first
"profile" or subsequent sections in loft and pipe.

This commit depends on `App::PropertyXLinkSubList` preserving the order in which
sections are added.

A minor change this also adds is that when a solid's face is selected that face
is mentioned in the fields instead of the solid (eg `Box:Face1` instead of
`Box`).
2021-11-09 23:05:29 +01:00
wmayer
182a0ed882 PD: [skip ci] fix crash in ReferenceSelection::allow 2021-11-09 18:37:54 +01:00
sliptonic
33460b9332 fixing comment errors 2021-11-09 09:04:01 -06:00
Chris Hennes
5b933b159e Merge pull request #5160 from luzpaz/TD-ToolAttributes-typo-translation
TechDraw: Fix typo in Tool Attributes command + expose to translation
2021-11-09 07:37:57 -06:00
wmayer
68be996d57 App: add a CMake test to check if C runtime provides backtrace symbols 2021-11-09 14:16:12 +01:00
wmayer
c83ada98d6 App: add new config key UserConfigPath to store the path to the config files 2021-11-09 13:46:26 +01:00
luz paz
e884c0b41e TechDraw: Fix typo in Tool Attributes command + expose to translation
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/85
2021-11-09 07:23:11 -05:00
Yorik van Havre
9e18d8dc26 Merge branch 'master' into Crowdin-MeshPart 2021-11-09 11:19:21 +01:00
sliptonic
3c094e3d38 Drill Generator and testing 2021-11-08 18:57:16 -06:00
wmayer
55afa21ba1 App: issue 0002956: implement XDG_CACHE_HOME 2021-11-09 00:20:55 +01:00
Chris Hennes
467062bbb0 Merge pull request #5149 from donovaly/PD-loft-visibility-fix
[PD] fixes loft visibility on creation and modification
2021-11-08 15:57:17 -06:00
Uwe
d3bff65828 [Tux] fix navigation status bar
- the PR adjusts the size of the navigation style status bar so that it is wide enough to contain the text + the space for the combobox button
- also sort the entries since as it is it is confusion and just reflects the order the styles were added in the development
2021-11-08 22:48:41 +01:00
wmayer
a9b7506007 App: further code refactoring in Application::ExtractUserPath() 2021-11-08 22:17:06 +01:00
wmayer
b32b908eae App: keep custom user data path as is if FREECAD_USER_HOME or FREECAD_USER_DATA is set 2021-11-08 18:28:02 +01:00
wmayer
dbd3e8784a App: code refactoring in Application::ExtractUserPath() 2021-11-08 16:17:08 +01:00
Roy-043
f5435cf171 Draft housekeeping: importDXF.py should use make_layer 2021-11-08 15:47:07 +01:00
Roy-043
7afac5f206 Draft: fix getTeighaConverter
The getTeighaConverter function did not work on Windows. We don't deal with the actual TeighaFileConverter anymore so there is no need to check for that file. Although the name of the function and the name of the parameter have been kept.
2021-11-08 15:31:49 +01:00
wmayer
ae0198ea0a App: split Application::ParseOptions into two functions
to simplify handling of options that should be processed before determining user directories
2021-11-08 11:10:13 +01:00
Yorik van Havre
af8604f089 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-11-08 10:51:28 +01:00
Yorik van Havre
e83e6747ad Draft: Fixed DWG import's QCAD config 2021-11-08 10:51:10 +01:00
Chris Hennes
1ef20ed984 OpenSCAD: Minor cleanup of import code 2021-11-07 21:50:48 -06:00
Chris Hennes
81830d850f OpenSCAD: Refactor tests to all use the same code path for tempdir generation 2021-11-07 17:13:51 -06:00
Uwe
fe00d3ab59 [PD] fixes loft visibility on creation and modification
- the PR fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=63252

- (also a MSVC code formatting fix)
2021-11-07 21:57:00 +01:00
Uwe
f1bc66b323 [PD] simplify Loft code
- also two automatic style fixes made by MSVC
2021-11-07 19:04:38 +01:00
wmayer
b37354b28b PD: [skip ci] fix ambiguous shortcut overload in TaskDlgPipeParameters 2021-11-07 08:27:33 +01:00
wmayer
799a1c3d56 Sketcher: fix some memory leaks 2021-11-06 17:48:35 +01:00
wmayer
4746f78422 Main: [skip ci] partially fix issue 0004765: FreeCAD failed to build on MSVC with std:c++latest 2021-11-06 14:31:17 +01:00
luzpaz
a77ccbd007 MeshPart: fix header uniformity + remove superfluous whitespace (#5135)
* MeshPart: fix header uniformity + remove superfluous whitespace
2021-11-06 00:15:00 +01:00
Ajinkya Dahale
a24b94efc8 [PartDesign] Fix typo in method name 2021-11-06 00:03:48 +01:00
wmayer
9af29dbc97 Tux: support of OpenSCAD and TinkerCAD in navigation indicator 2021-11-05 23:49:14 +01:00
wmayer
befd78afd1 Gui: move handling of SoMouseWheelEvent to its own handler function 2021-11-05 21:37:19 +01:00
wmayer
3dcbceda3a C++11: modernize use nullptr (replaces NULL or 0) 2021-11-05 18:16:19 +01:00
wmayer
ef598dd1e3 Gui: add method NavigationStyle::processClickEvent() to reduce code duplication in sub-classes 2021-11-05 14:37:18 +01:00
wmayer
f664c02b92 Gui: [skip ci] in MayaGestureNavigationStyle rename mousedownConsumedEvent to mousedownConsumedEvents 2021-11-05 14:00:09 +01:00
wmayer
fbca4b10f2 Gui: [skip ci] rename handleKeyboardEvent to processKeyboardEvent 2021-11-05 12:58:36 +01:00