Commit Graph

2959 Commits

Author SHA1 Message Date
Paddle
05dde3d3cf Polygon DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
8daccecb52 Offset DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
422d5861d8 Line DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
17f4109358 Add preference for OVP visibility. 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5c2a55ade7 Sketcher: Update DSHs to set value via framework only when they are visible 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
0282d3844a Sketcher: DrawSketchController - Extend framework to support hiding OVPs via preference 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5873403254 Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
c09793e811 Sketcher Gui: DrawSketchController - lints 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
e235a1b795 Sketcher: Handling of right mouse button during handler execution
=================================================================

    Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
    delegates the action to DrawSketchHandler.

    DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

    DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
    in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Abdullah Tahiri
9cb6fa0df7 Sketcher: Handling of ESC keypress during handler execution
===========================================================

Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
delegates the action to DrawSketchHandler.

DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Paddle
fc472601e4 EditableDatumLabel : Fix issue where the spinbox would get in the way of the cursor for angle. For example line angle. 2023-11-07 15:36:21 +01:00
Paddle
029fd10bf1 Offset DSH : various fixes 2023-11-07 15:36:21 +01:00
Paddle
2aa67a0b38 Rectangle DSH : fix a bug when trying to make inward thickness. 2023-11-07 15:36:21 +01:00
Paddle
57524b24ef Rectangle DSH : Fixes #11287. Issue where the spinbox for frame thickness doesn't get focus. 2023-11-07 15:36:21 +01:00
Paddle
d272a55310 Rectangle DSH : Fixes #11285, for frames two parallels constraints were missing. 2023-11-07 15:36:21 +01:00
Paddle
0c9c550703 Rectangle DSH : change names or modes. 2023-11-07 15:36:21 +01:00
Paddle
870c358cee Fix focus passing between OnViewParameters with tab. 2023-11-07 15:36:21 +01:00
Paddle
1b55c56f3a Fix bug nParameter is not initialized based on construction methode.
Also fix bug construction methode combobox is not at correct index on tool start if not first methode.
2023-11-07 15:36:21 +01:00
mosfet80
834b2687b9 [planegcs] Removed unused code. (#10684)
* Revert cleanplanegcs: removed unused code, removed redefinition of pi
* Sketcher: Switch pi refs to double and constexpr
* Modify code to use the new pi constant immediately

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2023-11-06 14:35:59 -06:00
Paddle
a3568333a4 Sketcher_Dimension: If radius of arc is not DoF, then offer arc angle first. 2023-11-06 14:02:54 -06:00
Chris Hennes
aaa0db3867 Merge pull request #11231 from DeflateAwning/http-cleanup
Find and replace http://freecad to https://freecad
2023-11-06 11:16:13 -06:00
Chris Hennes
cf84c171e6 Merge pull request #10978 from FlachyJoe/modernize-type-check
Modernize type and derived type checking
2023-11-06 10:44:32 -06:00
Adrian Insaurralde Avalos
9c093ba041 Sketcher: fix Line tool settings mode name 2023-11-05 07:36:22 +01:00
Abdullah Tahiri
1de8d9f10f Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
882262bfa8 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Paddle
dc2da5aba1 Offset fix isActive function. 2023-11-04 08:58:50 +01:00
Paddle
b4a54abed5 Polygon DSH : Small syntax improvements. 2023-11-04 08:58:50 +01:00
Paddle
785ec817c8 Line DSH : syntax and remove potential issues. For example in width+length mode, if user input 0 and 0, instead of validating it will unset the spinboxes. Preventing creation of null lines. 2023-11-04 08:58:50 +01:00
Paddle
3242144128 Rectangle DSH : Fix a bug where 3p rectangle with radius, radius would not apply. Also fix various edge cases. Improve syntax. 2023-11-04 08:58:50 +01:00
Paddle
b72da63139 Offset DSH : Add pointer SVG. Some remove unecessary member initialization 2023-11-04 08:58:50 +01:00
Paddle
5fc39a5add DSDWC : typo 2023-11-04 08:58:50 +01:00
Paddle
aa4a158e0c Prevent passing the focus to a spinbox when it shouldn't.
In some DSH some mode (seekSecond for example) don't have onViewParameter. In this case it would wrongly try to give focus to the previous spinbox with focus.
2023-11-04 08:58:50 +01:00
Paddle
336691cd5a Redraw on construction method changed. Avoid a small issue where you had to move mouse first before being able to rechange the methode by the M key. 2023-11-04 08:58:50 +01:00
Paddle
8788bcc0f4 SketcherToolDefaultWidget : Add a blockParameterFocusPassing bool that let us set parameters without passing focus. To fix undue passing of focus when using shortcuts U/J. For example in Polygon. 2023-11-04 08:58:50 +01:00
Paddle
aef013473b DrawSketchController and DrawSketchDefaultWidgetController : fix lint warnings 2023-11-03 14:02:25 +01:00
Paddle
a0609b1a28 Sketcher: Polygon DSH 2023-11-03 14:02:25 +01:00
Paddle
b65b1ff8de Sketcher: Offset DSH 2023-11-03 14:02:25 +01:00
Paddle
c9f6639810 Sketcher: Rectangle DSH 2023-11-03 14:02:25 +01:00
Paddle
6769166bf4 Sketcher: Line DSH 2023-11-03 14:02:25 +01:00
Paddle
c5de96fbd6 Sketcher: Point DSH 2023-11-03 14:02:25 +01:00
Paddle
3483090279 DSDH : add canGoToNextMode() methode in onButtonPressed. So that we can prevent going to the next mode on certain conditions. 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3f1f1047b2 Sketcher: Make GeometryConstructionMode an enum class
=====================================================

Enforce strong typing to avoid all kinds of abusive implicit conversionsm, the corresponding associated bugs and make code more readable.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
82fed5bbfc Sketcher: New flexible DSH Architecture
=======================================

Rewrite of the architecture to accomodate on-view parameters and to enable code reuse
between the default widget and custom widgets.
2023-11-03 14:02:25 +01:00
Paddle
a5b5d01c22 DSH architecture: On-view spinboxes 2023-11-03 14:02:25 +01:00
Abdullah Tahiri
677694b0ba Sketcher: New DSH architecture to support multiple input
========================================================

Architecture to support multiple input from a widget and a mouse.
2023-11-03 14:02:25 +01:00
Abdullah Tahiri
3ad624236b Sketcher: DrawSketchHandler - refactor functions to draw/clear edit curve and markers 2023-11-03 14:02:25 +01:00
DeflateAwning
8de6db3e97 Find and replace http://freecad.org to https://freecad.org
Find and replace:
http:\/\/(.{0,10})freecad
https://$1freecad
Done in all remaining files (after doing it in SVGs in the last commit)
2023-10-29 22:39:22 -06:00
DeflateAwning
c847a3d516 Change http to https in SVGs
Find and replace:
http:\/\/(.{0,10})freecad
https://$1freecad
Include: *.svg
2023-10-29 22:32:59 -06:00
Chris Hennes
cbd0ef5975 Merge branch 'main' into modernize-type-check 2023-10-25 16:07:28 -05:00
Paddle
d19a16ddd5 SketcherToolDefaultWidget : add 3 parameter configuration functions.
And remove the units from setParameter.
2023-10-24 19:28:13 +02:00