kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
42,621 Commits 41 Branches 6 Tags
fd6c6545610c024545db1d6bbfdeeeec682da027
Commit Graph

2760 Commits

Author SHA1 Message Date
wmayer
06eeea8cb2 PD: Fix crash in Loft::getSectionShape 
The passed DocumentObject pointer can be null which is nowhere checked.
This fixes issue 19545

Fixes: 256ad7a01a ("PartDesign: Loft Intelligence - Select the whole sketch if the selected shape is ...")
 2025-07-18 09:57:29 -05:00
theo-vt
a933c22dad Allow open wires in Part::getProfileNormal 2025-07-14 17:38:51 +02:00
Andrea
6f18b152ed Remove unused deprecated functions 
Remove unused deprecated functions
 2025-06-30 10:40:10 -05:00
Kacper Donat
46d7d8a8b4 Merge pull request #22169 from 3x380V/fix_19002 
PD: Fix regression about single-solid check
 2025-06-25 21:40:05 +02:00
wmayer
86359a3183 PD: Correctly handle single solid rule for loft with and without base 2025-06-25 00:14:15 +02:00
wmayer
7335c798d1 PD: Use isSingleSolidRuleSatisfied() for pipe feature 
This fixes issue 18977

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
 2025-06-25 00:13:54 +02:00
wmayer
25e73289ae PD: Fix regression about single-solid check 
For several PD features the single-solid check fails. The regression
is caused by PR 13960 and reported as issue 19002. The reason for the
failure is that the first solid of the output shape is retrieved and
then checked for a single solid. This test will always pass, of course.

The single-solid is fixed for these features:
* Pad
* Pocket (never worked there)
* Fillet
* Chamfer
* Groove (never worked there)
* Revolution (never worked there)
* Loft

Fixes: 17ad40b2c9f0 ("PartDesign: Refactor single-solid rule enforcement")
 2025-06-25 00:09:33 +02:00
Bas Ruigrok
7a49335cad PartDesign: Remove use of adjustCameraPosition() 2025-06-23 19:28:56 +02:00
David Tanana
3f7438a686 PartDesign: Added 1 3/16 16 threaded drill hole diameter (#22000) 
* Adding UNf 1 3/16  16 to this list
* Updating type and test params
 2025-06-17 08:59:00 -05:00
wmayer
2c2ebc6ed2 Test: Do not write test files into CWD 
When running the tests make sure to write the test files into the temp directory.

This fixes issue 19112
 2025-06-10 17:11:25 +02:00
wmayer
2a7498c930 Helper function to get preferred delete key depending on platform 2025-06-09 18:10:52 +02:00
Chris Hennes
30aee57880 Merge pull request #21659 from 3x380V/gui_fixes 
Gui: random fixes
 2025-06-03 19:23:21 -05:00
Alfredo Monclus
cece88a20f PD: hole change the task panel threaded and model thread checkboxes into a combo/dropdown (#21664) 
* PD: hole change threaded and modeled to combo in taskpanel

* Gui: Property editor apply review suggestions
 2025-06-03 21:14:52 +02:00
Kacper Donat
df6949dcde Merge pull request #21427 from tritao/async-occt-progress 
Part: Introduce `OCCTProgressIndicator` and port operations to support it.
 2025-06-02 18:04:38 +02:00
Alfredo Monclus
b21cf693f1 feat(PD): ISO tyre valve threads 2025-06-02 10:50:10 -05:00
Yorik van Havre
640642eed2 Translations: Merged crowdin translations 2025-06-02 11:48:26 +02:00
Yorik van Havre
26e16765b0 Translations: updated ts files 2025-06-02 11:07:28 +02:00
James Stanley
7093b0b9f0 PartDesign: Add OCCT progress support to FeatureTransformed. 
Include `<Base/ProgressIndicator.h>` and bail out when
`Base::ProgressIndicator::getInstance().UserBreak()` returns true during
transformation loops and composite operations in
`FeatureTransformed.cpp`.
 2025-05-30 18:25:32 +01:00
wmayer
9497ddf5e1 Gui: Replace calls of FCMD_SET_EDIT with Gui::cmdSetEdit 2025-05-30 18:04:33 +02:00
theo-vt
1a0a68ae69 PartDesign: Fix hole centered on point edge case (#21257) 
* Light refactor of getTopoShape function

* Fix hole edge case

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Refactor simplifyCompound()

* Use Base::Flags<GetShapeOption>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Shorten enum name and move it from class scope to namespace scope

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-05-29 22:37:54 +02:00
Alfredo Monclus
8a4501c900 PD: hole safeguard countersink depth calculation against possible math issues 2025-05-24 02:05:06 -06:00
Alfredo Monclus
432e20c60c PD: hole calculate counterbore and countersink if no standards are available 2025-05-23 20:51:35 -06:00
Alfredo Monclus
91d2b25dfd PD: hole fix head custom values checkbox not appearing 2025-05-23 20:51:28 -06:00
Alfredo Monclus
555dfc6ccb PD: hole: calculate depth of countersink and adjust other parameters accordingly when changed 2025-05-23 17:36:26 -06:00
Alfredo Monclus
808cb6ab21 PD: hole: fix standarized head cuts not working in metric regular sizes 2025-05-23 14:15:44 -06:00
Alfredo Monclus
46ab345a9f PD: move the base profiles types to the top 2025-05-15 23:31:55 +02:00
Chris Hennes
952485dcbb Merge pull request #19907 from benj5378/getAttribute 
Base: make getAttribute template
 2025-05-12 10:39:55 -05:00
Benjamin Bræstrup Sayoc
2b1aec0041 Base: make getAttribute template 2025-05-09 15:54:57 +02:00
theo-vt
777d20b812 PartDesign: Fix no longer possible to make a hole from one selected circle in a sketch (#21030) 
* Search for profile shape subelements without simplifying compounds for hole center detection

* Simpler solution
 2025-05-08 16:47:26 +00:00
Beep6581
f2fa2f1360 PartDesign: Merge pull request #21015 from Beep6581/fix-thread-pitch 
Fixes hole thread pitch
 2025-05-07 21:53:09 +02:00
bofdahof
ba2c2ca5ad Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
Ladislav Michl
9683cf1e4f Base: rename Exception's PascalCase methods to camelCase 2025-05-05 23:50:01 +02:00
Kacper Donat
c05ade50ae PartDesign: Use freecad_cast whenever possible 2025-04-26 14:23:25 +02:00
Florian Foinant-Willig
2729cfa0df PartDesign: Prevent user to remove core properties 2025-04-22 23:52:17 +02:00
theo-vt
f2cc750250 PartDesign: Center holes on sketch points as well as circles and arcs (#20583) 
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-04-21 23:30:57 +02:00
Alfredo Monclus
db40acce72 refactor: add disambiguation to clearance hole names and use names from the standard (#19869) 
* PD: refactor: threadFit use standard naming and add disambiguation

* PD: fix: do not use variables for tr
 2025-04-21 09:54:23 -05:00
Florian Foinant-Willig
09ba446acd PartDesign: Fix #20205 where Placement changes at Suppression 2025-04-16 20:39:58 +02:00
PaddleStroke
75edcba686 PartDesign: TaskFeaturePick : Fix LCS temporary visibility 2025-04-15 21:19:34 +02:00
Benjamin Nauck
21fbf8e539 Use Base::toRadians() instead of manually converting 2025-04-15 07:16:36 +02:00
Kacper Donat
4b0a70b62d Gui: Disable Show Placement for Body Features 2025-04-13 17:54:01 +02:00
Kacper Donat
77e40b9747 Base: Use explicit pointer syntax for freecad_cast (#20694) 
* Base: Use explicit pointer syntax for freecad_cast

This aligns our custom cast with other casts

* All: Use explicit pointer syntax for freecad_cast
 2025-04-11 14:11:33 +00:00
PaddleStroke
5678963c2f PartDesign : New sketch: Fix regression 2025-04-08 14:03:30 +02:00
Syres916
b2fb84fb3a [PartDesign] Fix spelling of auxiliary and curvilinear… 
…but also handle the properties name change from old files
 2025-04-07 11:30:51 -05:00
PaddleStroke
2f479e3c95 PartDesign: Fix use of App::Planes to create sketches (#20453) 2025-04-07 17:34:13 +02:00
Kacper Donat
9d97d1c895 Base: Rename Base::freecad_dynamic_cast into freecad_cast 
This is to make it shorter and easier to use. QT does the same thing
with their qobject_cast.
 2025-04-07 10:32:28 -05:00
Benjamin Nauck
913850ef04 PartDesign: Add #include <limits> where used 2025-03-31 23:52:18 +02:00
Benjamin Nauck
c2e885d774 PartDesign: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:38 +01:00
Joao Matos
bbe9fbccb5 PartDesign: Remove XML binding files. 2025-03-25 06:11:22 +01:00
karliss
c5cbb864d8 PartDesign: Update counterbore min size in reaction to diameter changes (#20217) 
Can't rely purely on `TaskHoleParameters::threadDiameterChanged` to update it since the signal is intentionally blocked while syncing state to GUI.

Closes #19744
 2025-03-24 21:18:40 +00:00
Chris Hennes
4b772aff28 PD: Eliminate unused variable in FeatureHole 2025-03-23 18:25:40 +01:00