Commit Graph

174 Commits

Author SHA1 Message Date
Matthijs Kooijman
f06fc0163e Arch: When inverting hinge position, keep opening direction
Previously, just the hinge position was changed, with the rotation
direction kept unchanged, which would make the door open towards the
other side of the wall. This also inverts the rotation direction, so the
door still opens toward the same side of the wall, which is more
intuitively what you would expect.
2022-03-20 14:46:13 +01:00
Roy-043
5a33bb4d24 Arch: Arch_Window.py: do isdir and isfile check for librarypath 2022-02-11 19:50:11 +01:00
Roy-043
129005d36f Arch: ArchWindow.py fix alignment of library windows
Windows and doors from parts_library were not aligned with or inserted in a wall.
2022-02-02 17:23:12 +01:00
Paul Lee
ea217bc9e9 [ArchWindow] add SketchArch attachment support (2nd attempt)
FreeCAD Forum Discussion :
- on Intuitive Automatic Windows/Doors Placement
- https://forum.freecadweb.org/viewtopic.php?f=23&t=50802
2021-12-10 05:26:21 +08:00
Yorik van Havre
146dcd75a9 Arch: Fixed windows invert hinge option 2021-07-16 12:22:56 +02:00
Łukasz Stelmach
0ae1cda2e9 Arch: Parse window opening modes with more than one digit
Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
2021-04-20 15:02:13 +02:00
Matthijs Kooijman
cc88c21fae Arch: Fix displayed rotation values when adding or editing window components
This ensures the rotation edge and mode GUI elements are cleared when starting
to add or edit a component. Previously, when adding a new component or
editing one without rotation, the GUI elements would retain the value
from the previously edited component, which made it hard to check that
components did not have any rotation, and would make it easy to
accidentally add rotation to components that did not need it (just by
clicking edit and confirming).
2021-03-30 12:40:06 +02:00
Chris Hennes
8228d64ac4 [ARCH] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Yorik van Havre
11c7c4d303 Arch: Windows: Added 'invert opening' and 'invert hinge' context menu items + task panel buttons 2020-11-19 13:13:38 +01:00
luz paz
67381e9579 Arch: Fix header uniformity and remove trailing whitespace 2020-11-16 14:51:53 +01:00
Yorik van Havre
e26a9efae8 Arch: Added Awming window preset 2020-11-10 19:14:06 +01:00
vocx-fc
587475fc8a Arch: use new name of the icon Part_3D_object
It is defined in the Part Workbench. Before, it was called `Tree_Part`.
2020-10-22 15:11:45 +02:00
mikeprice99
a0480dc62c fixed door open plan symbol and make makeWindow use name parameter 2020-07-20 14:26:35 +02:00
Yorik van Havre
be0c8eab25 Arch: Better support for App::Parts in Arch Windows 2020-06-12 14:22:39 +02:00
vocx-fc
94a2226102 Arch: import the os module to find the paths 2020-04-29 11:45:00 +02:00
Yorik van Havre
3eff81df35 Arch: Fixed louvre width/spacing property 2020-04-14 15:49:36 +02:00
Yorik van Havre
bbea2dbb7c Arch: Ability to add windows presets 2020-04-08 18:55:49 +02:00
vocx-fc
58d4596888 Arch: use the new Draft trackers module
Previously it was `DraftTrackers.py`.
Now we import the trackers from `draftguitools/gui_trackers.py`.
2020-03-31 12:09:25 +02:00
paullee0
7a30f0e8ba [ArchWindow] getSubVolume() Bug - When the Window is a Clone, HoleWire in original is ignored
getSubVolume() -

- When Windown is a Clone, HoleWire in Clone is tested
- However, if HoleWire is not set, no further check if HoleWire in Original is set
- The original code direclty check the Base's Wires BoundBox as HoleWire
2020-01-22 10:19:06 +01:00
paullee0
98dfa25def [ArchWindow] getSubVolume() Bug - When HoleDepth is set but the Window is a Clone, no opening is created
getSubVolume() -

- When Windown is a Clone, no base is set
- When HoleDepth is set, no further check if there is a Clone to set its base to Clone's base
- The original code return None when no base is set
2020-01-22 10:19:06 +01:00
paullee0
88405ae71c [ArchWindow] Fix getIcon() problem if base is SketchObjectPython
Similar to ArchWall + SketchObjectPython
in Disscusion : https://forum.freecadweb.org/viewtopic.php?t=26815
2020-01-15 10:08:42 +01:00
luz.paz
8fb5c65736 Arch: [skip ci] fix header uniformity
This PR fixes header uniformity across all Arch files
2019-12-26 18:24:06 +01:00
Zheng, Lei
a3e88a399f Arch: relax Part::Feature type checking
For supporting Link inside Arch.
2019-11-17 13:03:42 -03:00
luz.paz
5c1cae14b9 Arch: use string operator instead of numeric LGTM fix 2019-10-25 10:23:24 -03:00
Yorik van Havre
d6fdaefb68 Arch: Fixed windows symbol position 2019-08-22 18:52:44 -03:00
Zheng, Lei
de66e563e0 Draft/Arch related changes
* Add Draft_LinkArray and Draft_PathLinkArray that uses link for both
  data and visualization, which supports linking external objects

* Add link group support for draft snap

* Fix ArchWindows expression ambiguity
2019-08-17 15:32:47 +02:00
Yorik van Havre
07d3423add Arch: Misc bugfixes 2019-07-05 20:58:44 -03:00
Yorik van Havre
2be258104d Arch: Added door mode to window command 2019-05-15 21:14:00 -03:00
Yorik van Havre
070e4c1252 Arch: Fixed color of windows transparent parts 2019-05-09 12:42:25 -03:00
Yorik van Havre
0493d23d8d Arch: Fixed bug in arch windows creation 2019-05-02 15:43:07 -03:00
Yorik van Havre
d5432fcf2a Arch: fixed error when opening 0.14 files 2019-04-29 12:41:01 -03:00
Yorik van Havre
624e20e9a2 Arch: Renamed property IfcRole to IfcType 2019-04-09 15:53:01 -03:00
Yorik van Havre
7c760259a3 Arch: Wall, structure, window and panel tools now remember and keep last used values 2019-03-28 17:02:54 -03:00
Yorik van Havre
3d52e8a6b9 Arch: Fixed recursion loop in windows 2019-01-08 16:39:11 -02:00
Yorik van Havre
024540dbbe Fixed coverity issues
169009 Bad use of null-like value
169005 Bad use of null-like value
169003 Bad use of null-like value
169000 Bad use of null-like value
168998 Bad use of null-like value
168996 Structurally dead code
2018-11-20 12:37:32 -02:00
Yorik van Havre
fe8f172ce1 Arch: Fixed bug in windows snapping 2018-11-05 20:00:56 -02:00
Yorik van Havre
5f63a7764b Arch: using basic object names for all arch objects 2018-07-07 14:40:10 -03:00
Yorik van Havre
6014fce390 Arch: Fixed bug in windows 2018-07-02 13:02:57 -03:00
Yorik van Havre
1314210a4c Arch: Handle cloning of BuildingParts 2018-06-29 12:12:54 -03:00
Yorik van Havre
5da2280cd6 Arch: Added Frame and Offset properties to windows 2018-06-21 18:53:52 -03:00
Yorik van Havre
def225caa9 Arch: Fixed bug in windows presets 2018-06-02 14:20:44 -03:00
Yorik van Havre
e49a5af3ae Arch: separate properties creation in own methods and check properties at file load 2018-06-01 19:36:35 -03:00
Yorik van Havre
37b9fedaf8 Arch: Fixed bug in preset doors 2018-06-01 11:40:09 -03:00
Yorik van Havre
0b3f02ec5b Arch: Window placement now keeps orientation from last face hovered. Much, much easier to place windows in walls now 2018-05-13 12:45:40 -03:00
Yorik van Havre
30476e951d Arch: Renamed Role property to IfcRole 2018-05-11 12:01:55 -03:00
Yorik van Havre
b5ffabace2 Arch: All Arch objects can now have any IFC type(role) 2018-05-10 10:42:06 -03:00
Yorik van Havre
c360263582 Arch/Draft: Make sure an active doc exists before creating objects 2018-05-08 16:07:55 -03:00
Yorik van Havre
fff7c03287 Arch: Window presets now include windows and doors from Parts Library, if available 2018-04-30 14:34:36 -03:00
Yorik van Havre
aa14ed6ba8 Arch: Added 4-pane window preset 2018-04-25 09:37:01 -03:00
luz.paz
90c6689722 Arch: translation fixes
Adding Arch WB translation string corrections/refinements
2018-04-17 10:16:28 -03:00