Commit Graph

2047 Commits

Author SHA1 Message Date
wmayer
fe7f4c4be7 Gui: remove QT_TR_NOOP from command group names and use "CommandGroup" as context string 2021-09-29 16:31:55 +02:00
wmayer
6f6272f12b Sketcher: [skip ci] remove superfluous QT_TRANSLATE_NOOP from Sketcher commands 2021-09-29 15:46:06 +02:00
Yorik van Havre
77925c428e Updated ts files 2021-09-29 14:32:12 +02:00
Abdullah Tahiri
aa7d8001a2 Sketcher: Improve the performance of showing/hiding constraints
===============================================================

Forum test and comments:
https://forum.freecadweb.org/viewtopic.php?p=536445#p536390

What?

Showing/hidding a large amount of constraints is very time consuming

Why?

Because SketchObject Constraints property was being set for each individual constraint

Solution is to use the new setVirtualSpace overload taking a list or a tuple, so that all the
constraints are set in a single operation.

In a Debug system with the test of the forum the time taken by the operation is reduced
from 7 minutes to around 2-3 seconds.
2021-09-28 20:08:46 +02:00
Abdullah Tahiri
490a6f1961 Sketcher: Python - enable using the setVirtualSpace command individually or by group 2021-09-28 20:07:41 +02:00
Abdullah Tahiri
bc080c1845 Sketcher: Overload setVirtualSpace to allow setting a group of constraints 2021-09-28 20:06:52 +02:00
FreeCAD-Tools
ffd7223d55 Update CommandSketcherVirtualSpace.cpp 2021-09-27 16:09:54 +03:00
FreeCAD-Tools
2186b03fc2 Update CommandSketcherTools.cpp 2021-09-27 15:59:31 +03:00
FreeCAD-Tools
c828948457 Update CommandSketcherBSpline.cpp 2021-09-27 15:57:12 +03:00
FreeCAD-Tools
9229c461bb Update CommandCreateGeo.cpp 2021-09-27 15:55:48 +03:00
FreeCAD-Tools
caeffd21b4 Update CommandConstraints.cpp 2021-09-27 15:47:23 +03:00
FreeCAD-Tools
ff1b29ffe1 Update CommandConstraints.cpp 2021-09-27 15:44:55 +03:00
FreeCAD-Tools
a94888ec3d Update CommandAlterGeometry.cpp 2021-09-27 15:39:17 +03:00
FreeCAD-Tools
65df3b46e2 Update Command.cpp 2021-09-27 15:38:41 +03:00
Abdullah Tahiri
c9eaa2393d Sketcher: Rectangular Array Snap mode
=====================================

Rectangular Array gets a snap mode every 10 degrees when pressing CTRL (for consistency with Multiline arc, which also snaps using CTRL).

Request:
https://forum.freecadweb.org/viewtopic.php?p=535691#p535691
2021-09-25 21:58:14 +02:00
Abdullah Tahiri
c37af5e737 Sketcher: fix warning unreferenced local variable 2021-09-25 21:06:50 +02:00
Abdullah Tahiri
5d4f7e96b4 Sketcher: Hide/show constraints according to filter
===================================================

Updates the visibility to the filter selection on the moment of checking the "track filter selection" checkbox.
2021-09-24 13:33:27 +02:00
Abdullah Tahiri
873e0977ca Sketcher: Minor fixes sketcher radius/diameter presentation
===========================================================

Some minor fixes:

https://forum.freecadweb.org/viewtopic.php?p=535406#p535406

https://forum.freecadweb.org/viewtopic.php?p=535511#p535511
2021-09-24 06:57:59 +02:00
0penBrain
1d98cc08e7 [Sketcher] Add an option to get randomness in radius/diameter display angle 2021-09-24 06:57:09 +02:00
0penBrain
daa52ab7b8 [Sketcher] Display radius/diameter constraints with some angle
So they are easily differentiated from distance constraints
 Default angle can be customized with 'BaseApp/Preferences/Mod/Sketcher/RaDiaAngle'
2021-09-24 06:57:09 +02:00
0penBrain
3553d8ed3a [Sketcher] Code simplification by systematically using 'finishDistance' to determine label distance 2021-09-24 06:57:09 +02:00
Yorik van Havre
b042405933 Merged crowdin translations 2021-09-23 17:14:48 +02:00
Yorik van Havre
15da3f01e5 Updated ts files 2021-09-23 17:04:05 +02:00
Abdullah Tahiri
f3a5217468 Sketcher: Fix hide/show operations on Constraint Widget taking too long
=======================================================================

Fixes delay reported here:
https://forum.freecadweb.org/viewtopic.php?f=17&t=60569#p519685
2021-09-22 18:30:03 +02:00
Abdullah Tahiri
6343836689 Sketcher: Show All and Hide All buttons on Constraint Widget 2021-09-22 18:29:41 +02:00
Abdullah Tahiri
3e644ed2af Sketcher: Constraint hiding/showing not working properly for combined constraint icons
======================================================================================

Hiden constraint icons should not be grouped into combined icons. This may also improve selection of combined (stacked) icons.

fixes #4590
2021-09-22 18:29:21 +02:00
Abdullah Tahiri
ff93cb9295 Sketcher: Tracking of constraint visibility via contraint widget filter
=======================================================================

Add new option so that the 3D view constraint visibility track the constraint widget filter selection.

It maintains internally two mutually exclusive virtual spaces and the ability to select one as visible (the other remaining hiden).
2021-09-22 18:29:10 +02:00
Abdullah Tahiri
4243790627 Sketcher: Constraint Widget extended filter
===========================================

- Remove "Normal" as it did exactly the same as "All".
- Add "Geometric" to filter only Geometric (non datum) constraints
- Add all individual constraint types to filter.

As per request:
https://forum.freecadweb.org/viewtopic.php?p=534176#p534176
2021-09-22 18:28:59 +02:00
Chris Hennes
823ebacbf9 [Sketcher] Refactor split code
LGTM complains about using continue statements inside a loop
whose condition is always false. In addition, the C++ core guidelines
recommend against using the do...while construct, and in this case it
was really serving as a goto, just hiding the actual goto keyword.
This commit replaces the loop and continue structure with simple
conditionals.
2021-09-17 23:43:12 +02:00
luz paz
e72da8babd Sketcher: fix mislabeled .ui cstring tag
Closes https://github.com/FreeCAD/FreeCAD-translations/issues/59  
Thanks @jakub-swierk for the patch!
2021-09-08 10:21:43 -04:00
Yorik van Havre
89e1a97d80 Merged crowdin translations 2021-09-07 11:26:48 +02:00
Yorik van Havre
d14167a50d Updated ts files 2021-09-06 15:32:07 +02:00
Yorik van Havre
63d77e003b Merge pull request #4945 from 0penBrain/sk3ptCircle
[Sketcher] 3-pt circle : allow tangent constraint for any click
2021-09-01 16:24:46 +02:00
Dirk Olbrich
3cb9f522a7 Sketcher: display dimensional constraint name
- checkbox in sketcher settings ui to display dimensional constrain name
- option to format dimensional presentation string
2021-09-01 10:27:42 +02:00
Yorik van Havre
49abe81271 Merged crowdin translations 2021-08-26 14:51:36 +02:00
luz paz
eab17ddff5 Fix various typos 2021-07-31 09:46:50 +02:00
0penBrain
cd92f3a8df [Sketcher] 3-pt circle : allow tangent constraint for any click 2021-07-28 14:21:55 +02:00
Yorik van Havre
1cee70cd62 Merged crowdin translations 2021-07-08 16:06:38 +02:00
Yorik van Havre
ed9dca288c Merged crowdin translations 2021-07-01 13:56:25 +02:00
luz paz
39b44b1570 Sketcher: FIx typos in source comments [skip ci] 2021-06-29 20:07:30 +02:00
Yorik van Havre
c8b5d8d762 Merged crowdin translations 2021-06-24 17:22:19 +02:00
Yorik van Havre
aa862254dd Updated ts files 2021-06-24 17:18:01 +02:00
donovaly
438895a3be [Sketch] fix menu entry wording
all other menu entries use lower case letters, thus do so also for the new tool
2021-06-21 13:56:23 +02:00
donovaly
4071a13310 [Sketch] change slot icons
change the slot icons to reflect the new selection/definition behavior
2021-06-21 13:56:03 +02:00
donovaly
471e143d09 [sketch] rework the slot command
In practical work it turned out that the slot command is not as convenient as it should because one cannot snap to a proper endpoint and one is restricted to work perpendicular to the sketch axes

This PR fixes this by setting the second snap point to the center of the second arc and removing the perpendicularity.

Benefits:

    when you want to get the slot at a line, edge or sketch axis, set the two center points accordingly. The line does not have to be parallel to one of the sketch axes
    when you want to define the slot using 2 points in the sketch you can do this now
2021-06-20 19:27:58 +02:00
donovaly
198aa4c564 [Sketch] save new icons as plain SVG 2021-06-20 19:06:43 +02:00
donovaly
3559710da6 [Sketch] fix these issues:
- missing menu entry for centered rectangle
- typo
- uniform word casing
- duplicated accel key
- remove superfluous comment
2021-06-20 19:06:09 +02:00
Abdullah Tahiri
b7f8f249b2 Sketcher: Add centered rectangle to the menu 2021-06-20 08:24:02 +02:00
Abdullah Tahiri
0fb621af28 Sketcher: Update icon resources 2021-06-20 08:23:31 +02:00
Abdullah Tahiri
cead3808aa Sketcher: centered rectangle icons 2021-06-20 08:23:01 +02:00