Commit Graph

75 Commits

Author SHA1 Message Date
PaddleStroke
60290a2a34 TechDraw: Fix child of linked view. 2024-04-18 12:14:10 -04:00
PaddleStroke
ffb34ebe54 TechDraw: Fix child not moving when drag and dropping a view between pages. 2024-04-18 12:14:10 -04:00
PaddleStroke
4d84efb061 TechDraw: Enable App::Links to work with TechDraw views. 2024-04-18 12:14:10 -04:00
pavltom
ed3a1a6184 [TechDraw] Reimplement Rich Annotation parent linking 2024-02-26 16:22:30 -05:00
André Caldas
89dbab9b0e Avoids using getNameInDocument() to test if DocumentObject is attached to a Document.
This patch substitutes by isAttachedToDocument() (almost) everywhere where
getNameInDocument() is used for this purpose.

The very few places not touched by this patch demand a (just a little) less trivial change.
When we change the returning type of getNameInDocument() to std::string,
those places will be easily found, because they shall generate a compiler error
(converting std::string to bool).

Rationale:
The fact that getNameInDocument() return nullptr to indicate
that the object is not attached to a document is responsible for lots of bugs
where the developer does not check for "nullptr".

The idea is to eliminate all those uses of getNameInDocument() and, in the near future,
make getNameInDocument() return always a valid std::string.
2023-12-11 17:37:58 +01:00
wandererfan
b8bea76481 [TD]spelling in comments 2023-11-26 16:42:06 -05:00
wandererfan
d69551eccb [TD]add label translation for Page and Template 2023-08-17 19:23:29 -04:00
Benjamin Bræstrup Sayoc
5d05acc87e [TechDraw] Simplify retrievement of user preferences
for all TechDraw files
2023-04-10 23:34:05 -04:00
Benjamin Bræstrup Sayoc
8c24b09341 [TechDraw] Improve readability of DrawPage.cpp 2023-04-05 14:35:30 -04:00
wandererfan
bc036abb30 [TD]Allow balloons to be attached to non-part views 2023-01-13 12:15:33 -05:00
wandererfan
437457e996 [TD]remove obsolete log messages 2023-01-13 12:15:33 -05:00
Uwe
1ca527c6ad [skip ci] [TD] fix a typo as reported by the CI 2023-01-09 15:47:40 +01:00
Uwe
c947055821 [TD] remove unused headers (#8155)
* [TD] remove unused headers

- also some sorting
- also improve readability by not using an abbreviation (we consistently don't abbreviate class names)
2023-01-09 14:55:22 +01:00
wandererfan
0e402ae075 [TD]add light text on dark page mode
- some visually impaired users need white graphics on
  dark page.

- revise Annotation dialog to respect dark style
2023-01-03 17:41:33 -05:00
wandererfan
ff1147fbae [TD]add extensions for drag and drop 2022-12-27 19:43:44 -05:00
Uwe
4d73bd5a50 [TD] DrawD* - DrawT*: remove unused includes - part 2/2
- also sort includes
- also additions to precompiled header
2022-10-08 17:21:26 +02:00
wandererfan
3ca81a7916 [TD]fix PrintAll output to printer 2022-09-12 19:20:07 -04:00
wandererfan
aa2b1b8392 [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Wanderer Fan
e97b95341a [TD]code clean ups
- QtConcurrent include and CMake for Win

- include clean up dvp, dvs, dvd

- variable names and nested if clean up

- remove debug code
2022-08-18 09:34:32 -04:00
Wanderer Fan
bfffd53493 [TD]fix redraw does not paint all views 2022-07-28 09:16:03 -04:00
Uwe
5486c9808d [TD] remove some more superfluous nullptr checks 2022-07-20 02:53:48 +02:00
Uwe
36add10c86 [TD] App: remove some superfluous nullptr checks 2022-07-19 02:03:50 +02:00
wmayer
e8f9c8a1d3 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
Wanderer Fan
62a670431a [TD]fix update suppression logic 2022-03-16 09:31:29 -04:00
Wanderer Fan
74dc5344d4 [TD]prevent touched but must be execute on DrawPage 2022-01-02 09:48:38 -05:00
Tomas Pavlicek
b93d049f8e TechDraw - Balloon updates 2021-10-03 13:43:53 +02:00
Aapo
f72bf9d325 [TD] Make DrawViewSpreadSheet respect DrawPage::redrawCommand() update mechanism. 2020-12-05 00:50:20 +02:00
wmayer
983939b32d Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wandererfan
a3029fec74 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
donovaly
39be11c459 [TD] reduce scaling increment
see https://forum.freecadweb.org/viewtopic.php?f=35&t=42780
2020-01-26 19:30:02 -05:00
luz.paz
d1dc813a80 TD: fix header uniformity
This PR fixes header uniformity across all TechDraw WB.
2019-12-21 09:57:45 -05:00
wandererfan
251e16b6f1 [TD]Transition to on demand page updates ph1 2019-10-23 14:19:52 -04:00
wandererfan
b24eea7beb [TD]Allow forced redraw of Page 2019-08-29 21:03:39 -04:00
wandererfan
2c2c851cc3 [TD]Add parameters to control drawing update 2019-08-29 21:03:39 -04:00
Zheng, Lei
e90d09dc40 TechDraw: Link related changes
* Support link and group objects

* Support view sync by implementing view provider API getMDIView()

* Use handleChangedPropertyType() for object migration instead of
  reimplementing Restore() because of a lots of changes in
  PropertyContainer::Restore().

* Various other small fixes.
2019-08-17 15:15:46 +02:00
wandererfan
92d92476ef SVG Refactor - minor cleanups 2019-06-11 15:46:46 -04:00
wandererfan
e759f91d68 Fix Balloon Next Index Persistance
- next sequential number for balloon on Page was
  not being preserved across save/restore
2019-05-25 18:44:35 +02:00
Franck Jullien
79f8d4a7cd [TD] Rewrite balloon placing method
When clicking on balloon command, cursor is changing to balloon cursor.
It means user is ready to place a balloon (anywhere on the page).
Balloon object is not created until user click somewhere.

Balloon command can be aborted pressing escape or when page view lost
focus (in other words, when user clic somewhere else than the page).
2019-05-21 08:37:05 -04:00
wandererfan
c4f63ec976 Fix handling of orphan objects during Page delete 2019-04-26 06:36:56 -04:00
wandererfan
ca24f0a821 Add default parameter for Page Scale 2019-04-05 19:35:26 -04:00
Franck Jullien
c5942d6a78 TechDraw: add Balloons 2019-04-01 23:24:17 +02:00
wandererfan
242717f5e3 Fix out of scope warnings
- Links within TD were not set to Global scope. This caused
  problems when a Page was in a container, but Views were not
  in the container.
2019-01-22 10:15:04 -02:00
wmayer
d7ec2b1368 Replace Base::Exception with appropriate subclass 2018-11-14 19:42:10 +01:00
wmayer
920a4e62b2 add missing newlines 2018-06-09 11:47:12 +02:00
wandererfan
765709ddcf Fix DrawProjGroup Positioning
- DrawPage was not including DPG in list of all
  views, so DPG was not being positioned properly.
2018-05-16 18:58:10 -04:00
wandererfan
8a183a0ba0 Eliminate some redundant executes
- excessive calls to DrawView::execute were
  slowing data entry in PropertyEditor.
2018-05-11 10:32:24 -03:00
wandererfan
dd3cc51818 Add getAllViews() method to DrawPagePy 2018-04-23 07:55:38 +02:00
WandererFan
815d8bed0a Fix crash during multi-object delete 2017-12-31 14:54:05 +01:00
WandererFan
a580f60e1e change isDeleting to isUnsetting
- DocumentObject::isDeleting was changed to isRemoving.
  This commit just prevents future confusion.
2017-10-02 13:48:45 -03:00
WandererFan
ac762c32ea Ensure DrawView picks up DrawPage Scale at creation 2017-09-10 15:25:58 +02:00