Implicit conversion from integer to boolean and vice versa is very
common in FreeCAD due to SbBool (from coin) being defined as int. This
creates a lot of false positives that should not be addressed in code
reviews. We also use such implicit coversions in FreeCAD often in
general so that warning is usually ignored.
While the advice is good, the overwhelming majority of "do-while" warnings that come up in our codebase are macros using a standard pattern using a do-while loop to encapsulate the macro's work.
Don't show an error on unknown NOLINT lines (presuming that someone is using a
newer version, etc.), nor formatting issues (which are handled outside the
linter). Clean up clazy checks to remove non-pod-static check, and to do the
Qt6 checks on main (instead of master)
Currently this check isn't enabled but when pushing a PR then the lint checker warns about non-explicit constructors which is
a bit annoying because the PR must be updated to fix the warning or in most cases it won't be fixed at all.
By enabling this check the developer already sees the warning before pushing a PR.
* Github: Build and Test
Build and Test:
- ccache
- build
- Unittest
- install
- Unittest of install
- report
misc:
- use .clang-tidy file to configure Clang-tidy checks
- use use .pylintrc to configure Pylint checks
- Update changed-files Action
- better regex for file extension filter
- show enabled clang-tidy checks in Step Report
- show enabled Pylint Checks
- cpplint filter documentation
- modified cpplint filters recomended by https://github.com/sider/runners/blob/HEAD/images/cpplint/sider_recommended_CPPLINT.cfg
- fixed Branch filter for Clazy QT6 checks --> has only worked on pull requests
- fail the CI only on Build errors, Unittest errors and misspellings
* Github: remove Codespell action as it is now integrated into the check workflow
