kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix(ui): clean up theme selector and migration for single-theme setup #1

Merged
forbes merged 1 commits from fix/theme-selector-migration into main 2026-02-04 19:27:32 +00:00
Conversation 0 Commits 1 Files Changed 5 -186
forbes commented 2026-02-04 19:27:18 +00:00
Owner
Copy Link

Summary

Cleans up orphaned theme configuration and dead code from the single-theme migration.

Changes

  • StartupProcess.cpp: Remove dead code in migrateOldTheme() that set the Theme parameter for KindredCreate.yaml, which is no longer part of the Stylesheets build
  • CMakeLists.txt: Remove Classic.yaml and KindredCreate.yaml from Parameters_Files
  • Delete: parameters/Classic.yaml and parameters/KindredCreate.yaml (orphaned files)
  • ThemeSelectorWidget.cpp: Remove unused includes (QApplication, QEvent, Gui/Application.h)
## Summary Cleans up orphaned theme configuration and dead code from the single-theme migration. ## Changes - **StartupProcess.cpp**: Remove dead code in `migrateOldTheme()` that set the Theme parameter for `KindredCreate.yaml`, which is no longer part of the Stylesheets build - **CMakeLists.txt**: Remove `Classic.yaml` and `KindredCreate.yaml` from `Parameters_Files` - **Delete**: `parameters/Classic.yaml` and `parameters/KindredCreate.yaml` (orphaned files) - **ThemeSelectorWidget.cpp**: Remove unused includes (`QApplication`, `QEvent`, `Gui/Application.h`)
forbes added 1 commit 2026-02-04 19:27:19 +00:00
fix(ui): clean up theme selector and migration for single-theme setup
Some checks failed
Build and Test / build (pull_request) Failing after 2m30s
Details
434ae797a4 
- Remove dead code in migrateOldTheme() that set Theme parameter for
  KindredCreate.yaml, which no longer exists in the Stylesheets build
- Remove orphaned Classic.yaml and KindredCreate.yaml parameter files
  from Stylesheets CMakeLists and from disk
- Remove unused includes in ThemeSelectorWidget.cpp (QApplication,
  QEvent, Gui/Application.h)
forbes merged commit 2a5a645ace into main 2026-02-04 19:27:32 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
UX
branding
bug
ci/cd
CI/CD workflows and deployment
 defaults
documentation
Developer documentation
 enhancement
high-priority
low-priority
theme
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/create#1
Delete Branch "fix/theme-selector-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?