kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix: Silo_Pull crash — App.Document has no IsModified() attribute #170

Merged
forbes merged 1 commits from fix/pull-is-modified-bug into main 2026-02-10 16:40:06 +00:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
forbes commented 2026-02-10 16:39:38 +00:00
Owner
Copy Link

Bug

Silo_Pull command crashes with:

AttributeError: 'App.Document' object has no attribute 'IsModified'

The error occurs in _check_pull_conflicts() at silo_commands.py:993.

Root Cause

App.Document does not have an IsModified() method. The correct API for checking unsaved changes is FreeCADGui.getDocument(doc.Name).Modified — a boolean property on the GUI document object.

Fix

Replace doc.IsModified() with FreeCADGui.getDocument(doc.Name).Modified, matching the existing pattern used elsewhere in the same file (lines 891, 913, 915).

Submodule Note

The mods/silo submodule points to branch fix/pull-is-modified-bug on silo-mod.

## Bug `Silo_Pull` command crashes with: ``` AttributeError: 'App.Document' object has no attribute 'IsModified' ``` The error occurs in `_check_pull_conflicts()` at `silo_commands.py:993`. ## Root Cause `App.Document` does not have an `IsModified()` method. The correct API for checking unsaved changes is `FreeCADGui.getDocument(doc.Name).Modified` — a boolean property on the GUI document object. ## Fix Replace `doc.IsModified()` with `FreeCADGui.getDocument(doc.Name).Modified`, matching the existing pattern used elsewhere in the same file (lines 891, 913, 915). ## Submodule Note The `mods/silo` submodule points to branch `fix/pull-is-modified-bug` on `silo-mod`.
forbes added 1 commit 2026-02-10 16:39:39 +00:00
fix: Silo_Pull crash — App.Document has no IsModified() attribute
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
99ff7d1a09 
_check_pull_conflicts() called doc.IsModified() which does not exist on
App.Document. Use FreeCADGui.getDocument().Modified instead, matching
the pattern used elsewhere in silo_commands.py.
forbes merged commit 15c11b4026 into main 2026-02-10 16:40:06 +00:00
forbes deleted branch fix/pull-is-modified-bug 2026-02-10 16:40:07 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
UX
branding
bug
ci/cd
CI/CD workflows and deployment
 defaults
documentation
Developer documentation
 enhancement
high-priority
low-priority
theme
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/create#170
Delete Branch "fix/pull-is-modified-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?