kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix: resolve build errors — ToolBarItem incomplete type and ReportException method name #178

Merged
forbes merged 1 commits from fix/build-incomplete-type-and-method-name into main 2026-02-11 22:36:02 +00:00
Conversation 0 Commits 1 Files Changed 2 +3 -3
forbes commented 2026-02-11 22:35:53 +00:00
Owner
Copy Link
  • Workbench.h: replace forward declaration of ToolBarItem with #include <Gui/ToolBarManager.h>
    so that ToolBarItem::DefaultVisibility can be used as a default parameter (line 283)
  • ApplicationPy.cpp: fix ReportException() → reportException() to match
    the method name declared in Base::Interpreter.h

Summary

Changes

Related Issues

Checklist

  • Commit messages follow conventional commits (feat:, fix:, chore:, docs:, art:)
  • Code follows project style (clang-format for C++, black for Python)
  • Changes are tested locally
  • Documentation updated (if applicable)
- Workbench.h: replace forward declaration of ToolBarItem with #include <Gui/ToolBarManager.h> so that ToolBarItem::DefaultVisibility can be used as a default parameter (line 283) - ApplicationPy.cpp: fix ReportException() → reportException() to match the method name declared in Base::Interpreter.h ## Summary <!-- Brief description of what this PR does --> ## Changes <!-- List the key changes made --> ## Related Issues <!-- Link related issues: Closes #123, Fixes #456 --> ## Checklist - [ ] Commit messages follow [conventional commits](https://www.conventionalcommits.org/) (`feat:`, `fix:`, `chore:`, `docs:`, `art:`) - [ ] Code follows project style (clang-format for C++, black for Python) - [ ] Changes are tested locally - [ ] Documentation updated (if applicable)
forbes added 1 commit 2026-02-11 22:35:54 +00:00
fix: resolve build errors — ToolBarItem incomplete type and ReportException method name
Some checks failed
Build and Test / build (pull_request) Has been cancelled
Details
1f49e3fa6d 
- Workbench.h: replace forward declaration of ToolBarItem with #include <Gui/ToolBarManager.h>
  so that ToolBarItem::DefaultVisibility can be used as a default parameter (line 283)
- ApplicationPy.cpp: fix ReportException() → reportException() to match
  the method name declared in Base::Interpreter.h
forbes merged commit a6b99f6f5a into main 2026-02-11 22:36:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
UX
branding
bug
ci/cd
CI/CD workflows and deployment
 defaults
documentation
Developer documentation
 enhancement
high-priority
low-priority
theme
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
forbes
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kindred/create#178
Delete Branch "fix/build-incomplete-type-and-method-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?