ui: Origin dropdown height should match workbench dropdown height #231

New Issue

forbes · 2026-02-15T00:35:28Z

forbes commented

2026-02-15 00:35:28 +00:00

Summary

The Origin selector dropdown (OriginSelectorWidget, a QToolButton) renders at a different visual height than the Workbench selector dropdown (WorkbenchComboBox, a QComboBox) in the toolbar. They should have the same height for visual consistency.

Current State

Both widgets are styled in src/Gui/Stylesheets/KindredCreate.qss with padding: 4px 8px but no explicit height constraint. Because QToolButton and QComboBox have different intrinsic size hints, they render at different heights.

WorkbenchComboBox (lines 1183-1199):

Gui--WorkbenchComboBox {
    background-color: #313244;
    color: #cdd6f4;
    border: 1px solid #45475a;
    border-radius: 4px;
    padding: 4px 8px;
}

OriginSelectorWidget (lines 1202-1210):

Gui--OriginSelectorWidget {
    background-color: #313244;
    color: #cdd6f4;
    border: 1px solid #45475a;
    border-radius: 4px;
    padding: 4px 8px;
    min-width: 70px;
    max-width: 120px;
}

Additionally, OriginSelectorWidget::setupUi() in src/Gui/OriginSelectorWidget.cpp sets setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed) but no explicit height.

Proposed Fix

Add matching min-height / max-height to both widgets in KindredCreate.qss, or set a fixed height in the OriginSelectorWidget::setupUi() to match the WorkbenchComboBox rendered height. The origin widget should follow the workbench dropdown's height.

Affected Files

src/Gui/Stylesheets/KindredCreate.qss — widget styling (lines 1183-1221)
src/Gui/OriginSelectorWidget.cpp — setupUi() size configuration

## Summary The Origin selector dropdown (`OriginSelectorWidget`, a `QToolButton`) renders at a different visual height than the Workbench selector dropdown (`WorkbenchComboBox`, a `QComboBox`) in the toolbar. They should have the same height for visual consistency. ## Current State Both widgets are styled in `src/Gui/Stylesheets/KindredCreate.qss` with `padding: 4px 8px` but no explicit height constraint. Because `QToolButton` and `QComboBox` have different intrinsic size hints, they render at different heights. **WorkbenchComboBox** (lines 1183-1199): ```qss Gui--WorkbenchComboBox { background-color: #313244; color: #cdd6f4; border: 1px solid #45475a; border-radius: 4px; padding: 4px 8px; } ``` **OriginSelectorWidget** (lines 1202-1210): ```qss Gui--OriginSelectorWidget { background-color: #313244; color: #cdd6f4; border: 1px solid #45475a; border-radius: 4px; padding: 4px 8px; min-width: 70px; max-width: 120px; } ``` Additionally, `OriginSelectorWidget::setupUi()` in `src/Gui/OriginSelectorWidget.cpp` sets `setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed)` but no explicit height. ## Proposed Fix Add matching `min-height` / `max-height` to both widgets in `KindredCreate.qss`, or set a fixed height in the `OriginSelectorWidget::setupUi()` to match the `WorkbenchComboBox` rendered height. The origin widget should follow the workbench dropdown's height. ## Affected Files - `src/Gui/Stylesheets/KindredCreate.qss` — widget styling (lines 1183-1221) - `src/Gui/OriginSelectorWidget.cpp` — `setupUi()` size configuration

forbes referenced this issue from a commit

2026-02-15 01:15:56 +00:00

fix(ui): match origin dropdown height to workbench dropdown (#231)

forbes referenced a pull request that will close this issue

2026-02-15 01:16:12 +00:00

fix(ui): match origin dropdown height to workbench dropdown (#231) #233

forbes closed this issue

2026-02-15 01:21:57 +00:00

forbes referenced this issue from a commit

2026-02-15 01:21:58 +00:00

Merge pull request 'fix(ui): match origin dropdown height to workbench dropdown (#231)' (#233) from fix/origin-dropdown-height into main

Sign in to join this conversation.